status-im
/
sourcecred
mirror of https://github.com/status-im/sourcecred.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Simplify legacy “simple”/“advanced” tests in Graph (#302) 

Summary:
Improves the result of the preceding commit to strip out cruft. Paired
with @decentralion.

Test Plan:
```shell
$ ! git grep -Fi -e simple -e advanced src/core/graph*
```
Also review `awk '/(describe|it)\(/' src/core/graph.test.js`.

wchargin-branch: simplify-simple-advanced
This commit is contained in:
William Chargin 2018-05-25 19:25:23 -07:00 committed by GitHub
parent d8fef6bf47
commit 15f65fbff4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/__snapshots__/graph.test.js.snap
View File

@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`graph #Graph JSON functions should serialize a simple graph 1`] = `
exports[`graph #Graph JSON functions should serialize the demo graph 1`] = `
Array [
Object {
"type": "sourcecred/sourcecred/Graph",

51
src/core/graph.test.js
View File

@ -20,11 +20,7 @@ describe("graph", () => {
}
describe("construction", () => {
it("works for a simple graph", () => {
demoData.mealGraph();
});
it("works for an advanced graph", () => {
it("works", () => {
demoData.mealGraph();
});
});
@ -74,45 +70,20 @@ describe("graph", () => {
});
describe("getting nodes and edges", () => {
it("correctly gets nodes in the simple graph", () => {
it("correctly gets nodes in the demo graph", () => {
const g = demoData.mealGraph();
[
demoData.heroNode(),
demoData.bananasNode(),
demoData.crabNode(),
demoData.mealNode(),
demoData.nullPayloadNode(),
].forEach((x) => {
expect(g.node(x.address)).toEqual(x);
});
});
it("correctly gets nodes in the advanced graph", () => {
const g = demoData.mealGraph();
[
demoData.heroNode(),
demoData.bananasNode(),
demoData.crabNode(),
demoData.mealNode(),
].forEach((x) => {
expect(g.node(x.address)).toEqual(x);
});
});
it("correctly gets edges in the simple graph", () => {
const g = demoData.mealGraph();
[
demoData.pickEdge(),
demoData.grabEdge(),
demoData.cookEdge(),
demoData.bananasIngredientEdge(),
demoData.crabIngredientEdge(),
demoData.eatEdge(),
].forEach((x) => {
expect(g.edge(x.address)).toEqual(x);
});
});
it("correctly gets edges in the advanced graph", () => {
it("correctly gets edges in the demo graph", () => {
const g = demoData.mealGraph();
[
demoData.pickEdge(),
@ -269,9 +240,9 @@ describe("graph", () => {
});
it("adding a node redundantly is a no-op", () => {
const simple1 = demoData.mealGraph();
const simple2 = demoData.mealGraph().addNode(demoData.heroNode());
expect(simple1.equals(simple2)).toBe(true);
const g1 = demoData.mealGraph();
const g2 = demoData.mealGraph().addNode(demoData.heroNode());
expect(g1.equals(g2)).toBe(true);
});
it("forbids adding an edge with existing address and different contents", () => {
@ -286,9 +257,9 @@ describe("graph", () => {
});
it("adding an edge redundantly is a no-op", () => {
const simple1 = demoData.mealGraph();
const simple2 = demoData.mealGraph().addEdge(demoData.cookEdge());
expect(simple1.equals(simple2)).toBe(true);
const g1 = demoData.mealGraph();
const g2 = demoData.mealGraph().addEdge(demoData.cookEdge());
expect(g1.equals(g2)).toBe(true);
});
it("allows creating self-loops", () => {
@ -1025,7 +996,7 @@ describe("graph", () => {
});
describe("JSON functions", () => {
it("should serialize a simple graph", () => {
it("should serialize the demo graph", () => {
expect(demoData.mealGraph().toJSON()).toMatchSnapshot();
});
it("should work transparently with JSON.stringify", () => {