Update github example data (#1077)

Updating github example data with support
for 🚀 and 👀 reaction types.

This follows #1068 and @decentralion updating
the archived repo with the new reaction types.

`src/plugins/github/fetchGithubRepoTest.sh -u`
(as @decentralion suggested) updated `example-github.json`

`yarn unit` caught two tests with failing snapshot
tests (`createGraph.test` and `relationalView.test`), so
I updated those with `yarn unit -u`

`yarn test -full` caught a failing snapshot test
at `sharness-full`, resolved by updating the
snapshot in `view.json.gz` with
 `UPDATE_SNAPSHOT=1 yarn test --full`.
Thanks to @wchargin for the [explanation] on how
to resolve that issue.

[explanation]: https://github.com/sourcecred/sourcecred/pull/1077#pullrequestreview-196805017

**Test Plan:**
`yarn test --full` is passing.

Additionally, the commands:
```sh
    filepath="./sharness/__snapshots__/example-github-load/data/sourcecred/example-github/github/view.json.gz" &&
    [ -f "${filepath}" ] &&  # sanity check
    diff -u \
        <(git show "HEAD:${filepath}" | gzip -d | jq .) \
        <(gzip -dc "${filepath}" | jq .) \
        ;
```

yields the following output:

```
--- /dev/fd/63  2019-01-27 08:34:15.020387301 -0500
+++ /dev/fd/62  2019-01-27 08:34:15.021095696 -0500
@@ -654,6 +654,22 @@
               "subtype": "USER",
               "login": "decentralion"
             }
+          },
+          {
+            "content": "ROCKET",
+            "user": {
+              "type": "USERLIKE",
+              "subtype": "USER",
+              "login": "decentralion"
+            }
+          },
+          {
+            "content": "EYES",
+            "user": {
+              "type": "USERLIKE",
+              "subtype": "USER",
+              "login": "decentralion"
+            }
           }
         ]
       }

```

Again, thanks @wchargin's for providing those commands and accompanying
explanation.
This commit is contained in:
Brian Litwin 2019-01-27 13:50:48 -05:00 committed by GitHub
parent c2e722ec9c
commit 0254f54375
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 61 additions and 0 deletions

View File

@ -1787,6 +1787,29 @@ Array [
"dstIndex": 24,
"srcIndex": 43,
},
Object {
"address": Array [
"sourcecred",
"github",
"REACTS",
"ROCKET",
"5",
"sourcecred",
"github",
"USERLIKE",
"USER",
"decentralion",
"6",
"sourcecred",
"github",
"ISSUE",
"sourcecred",
"example-github",
"13",
],
"dstIndex": 29,
"srcIndex": 42,
},
Object {
"address": Array [
"sourcecred",

View File

@ -503,6 +503,22 @@ Object {
"type": "USERLIKE",
},
},
Object {
"content": "ROCKET",
"user": Object {
"login": "decentralion",
"subtype": "USER",
"type": "USERLIKE",
},
},
Object {
"content": "EYES",
"user": Object {
"login": "decentralion",
"subtype": "USER",
"type": "USERLIKE",
},
},
],
"https://github.com/sourcecred/example-github/pull/5#discussion_r171460198": Array [
Object {

View File

@ -659,6 +659,28 @@
"login": "decentralion",
"url": "https://github.com/decentralion"
}
},
{
"__typename": "Reaction",
"content": "ROCKET",
"id": "MDg6UmVhY3Rpb24zNTc5ODQzNQ==",
"user": {
"__typename": "User",
"id": "MDQ6VXNlcjE0MDAwMjM=",
"login": "decentralion",
"url": "https://github.com/decentralion"
}
},
{
"__typename": "Reaction",
"content": "EYES",
"id": "MDg6UmVhY3Rpb24zNTc5ODQ0Mg==",
"user": {
"__typename": "User",
"id": "MDQ6VXNlcjE0MDAwMjM=",
"login": "decentralion",
"url": "https://github.com/decentralion"
}
}
],
"title": "An issue with reactions",