status-im
/
sourcecred
mirror of https://github.com/status-im/sourcecred.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
sourcecred/CHANGELOG.md

20 lines
827 B
Markdown
Raw Normal View History

Add CHANGELOG.md (#670) Also, update CONTRIBUTING.md to guide contributors to update the changelog. Test plan: Unnecessary
2018-08-15 22:20:59 +00:00
# Changelog
## [Unreleased]
Better handling of log weights (#736) This commit isolates all of the log-weight behavior in the weight slider. That slider moves in log space, but the numbers printed and passed around the WeightConfig code are now always in linear-space. This should reduce confusion in the UI and for developers. This commit contains two other improvements: (#588) - Changes the (log space) range on the sliders from ±10 to ±5 - Change the order from slider, weight, name to name, slider, weight, so that there is more visual separation between the name and the weight. Test plan: Changes to the weight slider are tested. Changes to the WeightConfig aren't (#604) so I manually tested the UI.
2018-08-31 02:21:59 +00:00
- Improve weight sliders display (#736)
Separate bots and users in the UI (#720) Fixes #696. Test plan: This is basically a config change, so I manually tested it. I ran SourceCred on gitcoinco/web, which has two bots, and verified that the bots are correctly removed from the list of users. Selecting "Bots" in the dropdown filter shows the two bots. Changing the user weight does not affect the bots' scores, and changing the bot weight does affect the bots' scores.
2018-08-29 22:14:42 +00:00
- Separate bots from users in the UI (#720)
Add a configurable feedback URL to prototype (#715) Summary: We can now set, at build time, a URL to be displayed at the top of the prototype, encouraging users to provide feedback. If the URL is not provided, it defaults to the appropriate topic on the SourceCred Discourse instance. The result looks like this: ![Screenshot of the feedback URL in the prototype][screenshot] [screenshot]: https://user-images.githubusercontent.com/4317806/44814824-a238b380-ab92-11e8-88c8-dfbae27ca496.png Test Plan: Unit tests added to `yarn sharness-full` and `yarn unit`. You can run `yarn start` to see the message with the default URL, or `SOURCECRED_FEEDBACK_URL=http://example.com/ yarn start` to specify a custom URL. wchargin-branch: feedback-url
2018-08-29 22:06:12 +00:00
- Add a feedback link to the prototype (#715)
Allow combining repositories at load time (#711) Summary: As a first pass toward support for analyzing whole organizations, we allow loading multiple repositories with `sourcecred load`, combining them into a single relational view and a single Git graph at load time. Test Plan: Run ``` node bin/sourcecred.js \ load \ sourcecred/example-git \ sourcecred/example-github \ sourcecred/sourcecred \ --output sourcecred/examples \ ; ``` and select `sourcecred/examples` from the web view. Filter “Repository” nodes, and note that there are three. Note that loading a single repository without `--output` still works, that loading a single repository with `--output` still works (respecting the alias name), and loading not exactly one repository without `--output` yields an appropriate error message. Note that `yarn sharness-full` still works. wchargin-branch: load-combined
2018-08-29 21:52:26 +00:00
- Support combining multiple repositories into a single graph (#711)
Users have 1000 cred in aggregate (#709) This commit changes the cred normalization algorithm so that the total cred of all GitHub user nodes always sums to 1000. For rationale on the change, see #705. Fixes #705. Note that this introduces a new way for PageRank to fail: if the graph has no GitHub userlike nodes, then PageRank will throw an error when it attempts to normalize. This will result in a message being displayed to the user, and a more helpful error being printed to console. If we need the cred explorer to display graphs that have no userlike nodes, then we can modify the codepath so that it falls back to normalizing based on all nodes instead of on the GitHub userlike nodes specifically. Test plan: There is an included unit test which verifies that the new argument gets threaded through the state properly. But this is mostly a config change, so it's best tested by actually inspecting the cred explorer. I have done so, and can verify that the behavior is as expected: the sum of users' cred now sums to 1000, and e.g. modifying the weight on the repository node doesn't produce drastic changes to cred scores.
2018-08-29 19:20:57 +00:00
- Normalize scores so that 1000 cred is split amongst users (#709)
Stop persisting users' weight choices (#706) Storing the user's weights in localStore enables a workflow where a user chooses their preferred weights, and brings those weights with them across projects and contexts. However, this is the wrong workflow: actually, a project chooses its weights, and when a user visits a particular project, they want to sync up with the project's choice. Giving the user the ability to modify the weights and recalculate is still important, so that they can propose improvements to the project maintainer. But implicitly keeping their modified weights, and even bringing them to other projects the user inspects, is counter-productive. This commit removes this dubious feature. (It's a feature we were likely to drop anyway, as it conflicts with #703.) As an added bonus, this code is untested, which means the feature is technical debt—so removing it reduces our technical debt! It also removes at least one known bug. Test plan: There are no tests. I manually verified that the frontend still works, and that it no longer persists weights across refresh.
2018-08-29 18:46:48 +00:00
- Stop persisting weights in local store (#706)
Retry GitHub queries with exponential backoff (#699) Summary: This patch adds independent exponential backoff to each individual GitHub GraphQL query. We remove the fixed `GITHUB_DELAY_MS` delay before each query in favor of this solution, which requires no additional configuration (thus resolving a TODO in the process). We use the NPM module `retry` with its default settings: namely, a maximum of 10 retries with factor-2 backoff starting at 1000ms. Empirically, it seems very unlikely that we should require much more than 2 retries for a query. (See Test Plan for more details.) This is both a short-term unblocker and a good kind of thing to have in the long term. Test Plan: Note that `yarn test --full` passes, including `fetchGithubRepoTest.sh`. Consider manual testing as follows. Add `console.info` statements in `retryGithubFetch`, then load a large repository like TensorFlow, and observe the output: ```shell $ node bin/sourcecred.js load --plugin github tensorflow/tensorflow 2>&1 | ts -s '%.s' 0.252566 Fetching repo... 0.258422 Trying... 5.203014 Trying... [snip] 1244.521197 Trying... 1254.848044 Will retry (n=1)... 1260.893334 Trying... 1271.547368 Trying... 1282.094735 Will retry (n=1)... 1283.349192 Will retry (n=2)... 1289.188728 Trying... [snip] 1741.026869 Ensuring no more pages... 1742.139978 Creating view... 1752.023697 Stringifying... 1754.697116 Writing... 1754.697772 Done. ``` This took just under half an hour, with 264 queries total, of which: - 225 queries required 0 retries; - 38 queries required exactly 1 retry; - 1 query required exactly 2 retries; and - 0 queries required 3 or more retries. wchargin-branch: github-backoff
2018-08-22 18:37:29 +00:00
- Execute GraphQL queries with exponential backoff (#699)
Re-introduce a simplified git plugin (#685) This commit re-introduces the git plugin, now that it has been radically simplified as described in [1]. The new git plugin only has nodes for commits and only has commit has-parent edges. As compared to the version that was removed in #628, this plugin is far leaner. It doesn't bloat the graph (for `sourcecred/sourcecred`, the git plugin data is just 164k), and as such doesn't incur much performance penalty. Re-incorporating the git plugin also brings some tangible benefits. We already had git nodes in the graph, as the GitHub plugin attaches them to pull requests. Without any git plugin, these nodes are displayed as "uknown nodes" with ugly descriptions. Also, including a git plugin, even one that is very minimal, communicates to users that git is a source of information to SourceCred, and that they can expect more from it in the future. Note that this commit breaks backcompat for existing repositories that were locally loaded after #628. As such, it is best to `rm -rf $SOURCECRED_DIRECTORY` and start with fresh data. Also, due to a known bug in the WeightConfig, you should reset your browser's local storage. Test plan: After removing the SourceCred directory and the stale localStorage, the cred explorer nicely displays git commits, and connects them via has_parent edges. The NodeType filter allows filtering to commits as expected, and the WeightConfig shows node and edge weights for the Git plugin's nodes and edges. [1]: https://github.com/sourcecred/sourcecred/issues/627#issuecomment-413435447
2018-08-16 20:20:41 +00:00
- Introduce a simplified Git plugin that only tracks commits (#685)
Rename cred explorer table columns (#680) The 'Score' column is renamed to 'Cred' (and its prop is renamed as well). The column which shows how a connection or aggregation contributes to a node's cred, as a percentage, has been rendered nameless. It is pretty self explanatory, and the previous name ("Connection") was meaningless. Test plan: Unit tests, also I inspected the frontend.
2018-08-16 05:22:21 +00:00
- Rename cred explorer table columns (#680)
Reverse the order of CHANGELOG entries (#681) It's more consistent to prepend entries to the [Unreleased] section of the changelog, so that entries are all in reverse-chronological order. Since we've appended the first few entries, we reverse them now. Test plan: Not needed
2018-08-16 18:14:52 +00:00
- Display version string in the app's footer
- Support hosting SourceCred instances at arbitrary gateways, not just
the root of a domain (#643)
- Aggregate over connection types in the cred explorer (#502)
- Start tracking changes in `CHANGELOG.md`
<!-- Please add new entries to the _top_ of this section. -->
Add CHANGELOG.md (#670) Also, update CONTRIBUTING.md to guide contributors to update the changelog. Test plan: Unnecessary
2018-08-15 22:20:59 +00:00