sourcecred/scripts/ensure-flow.sh

#!/bin/bash
set -eu
git grep -Fz --files-without-match -e '@flow' -e '@no-flow' -- '*.js' \
    | grep -zv '^flow-typed/' \
    | tr '\0' '\n' \
    | tee >(cat >&2) \
    | diff -q /dev/null - >/dev/null
Fix `ensure-flow.sh` running under Node (#314) Summary: The use of `tee /dev/stderr` failed when running as a child process under Node for some reason. (I haven’t been able to figure out why—it works fine when run as a standalone script or when run as a child process under Python.) This is also technically Linux-specific, so I’ve changed it to use a process substitution. After looking around for a bit, there doesn’t seem to be a way to do this in a way that is portable, uses only POSIX shell features, and doesn’t create temporary files all at the same time, so the script is now run under `bash`. Test Plan: Run `yarn travis` and note that the `ensure-flow.sh` output no longer contains the line `tee: /dev/stderr: No such device or address`. wchargin-branch: no-tee-devstderr 2018-05-29 19:20:53 +00:00			`#!/bin/bash`
Ensure that flow is used in all js files (#232) This script ensures that either //@flow or //@no-flow is present in every js file. Every existing js file that would fail this check has been given //@no-flow, we should work to remove all of these in the future. Test plan: I verified that `yarn travis` fails before fixing the other js files, and passes afterwards. 2018-05-08 03:02:19 +00:00			`set -eu`
Make `ensure-flow.sh` more precise and accurate (#259) Summary: This fixes two problems in the previous version: - A new JS file not checked into git, but with a `@flow` directive, would cause `ensure-flow` to fail, because one list of files was from `git grep` and the other was from `find`. - Only the hard-coded directories `src config scripts` were searched. Now, we search all JS files checked into Git, except for some hard-coded exceptions, namely `flow-typed`. Test Plan: 1. Add `foo.js`, not checked into Git. Note that `ensure-flow` passes. 2. Add `@flow` to `foo.js`, and note that `ensure-flow` still passes. 3. Remove `@flow` from `.eslintrc.js`, and note that `ensure-flow` fails and nicely prints the filename. (Note: this file is at the repository root.) 4. Create a file `echo stuff >$'naughty\nfilename.js'`, and note that `ensure-flow` has the correct behavior in both positive and negative cases. wchargin-branch: ensure-flow-improvements 2018-05-10 19:38:39 +00:00			`git grep -Fz --files-without-match -e '@flow' -e '@no-flow' -- '*.js' \`
			`\| grep -zv '^flow-typed/' \`
			`\| tr '\0' '\n' \`
Fix `ensure-flow.sh` running under Node (#314) Summary: The use of `tee /dev/stderr` failed when running as a child process under Node for some reason. (I haven’t been able to figure out why—it works fine when run as a standalone script or when run as a child process under Python.) This is also technically Linux-specific, so I’ve changed it to use a process substitution. After looking around for a bit, there doesn’t seem to be a way to do this in a way that is portable, uses only POSIX shell features, and doesn’t create temporary files all at the same time, so the script is now run under `bash`. Test Plan: Run `yarn travis` and note that the `ensure-flow.sh` output no longer contains the line `tee: /dev/stderr: No such device or address`. wchargin-branch: no-tee-devstderr 2018-05-29 19:20:53 +00:00			`\| tee >(cat >&2) \`
Make `ensure-flow.sh` more precise and accurate (#259) Summary: This fixes two problems in the previous version: - A new JS file not checked into git, but with a `@flow` directive, would cause `ensure-flow` to fail, because one list of files was from `git grep` and the other was from `find`. - Only the hard-coded directories `src config scripts` were searched. Now, we search all JS files checked into Git, except for some hard-coded exceptions, namely `flow-typed`. Test Plan: 1. Add `foo.js`, not checked into Git. Note that `ensure-flow` passes. 2. Add `@flow` to `foo.js`, and note that `ensure-flow` still passes. 3. Remove `@flow` from `.eslintrc.js`, and note that `ensure-flow` fails and nicely prints the filename. (Note: this file is at the repository root.) 4. Create a file `echo stuff >$'naughty\nfilename.js'`, and note that `ensure-flow` has the correct behavior in both positive and negative cases. wchargin-branch: ensure-flow-improvements 2018-05-10 19:38:39 +00:00			`\| diff -q /dev/null - >/dev/null`