status-im
/
sourcecred
mirror of https://github.com/status-im/sourcecred.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
sourcecred/scripts/ensure-flow.sh

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

5 lines
122 B
Bash
Raw Normal View History

ensure-flow.sh: simplify, removing dep on GNU grep (#602) Summary: By using Git’s magic pathspecs instead of post-processing stream operations, we reduce the pipeline to a single operation. Git implements its own version of `grep`, so this should be platform-independent. Previously, we had needed the `-z` argument to `grep(1)`, which is a GNU extension. Fixes #594. Test Plan: Ensure that the script passes with no output. Then, ```shell mkdir -p src/flow-typed/ touch src/foo.js src/flow-typed.js src/flow-typed/foo.js git add src/foo.js src/flow-typed.js src/flow-typed/foo.js cd scripts ./ensure-flow.js ``` and ensure that script exits with code 1, empty stdout, and stderr with: ``` ../src/flow-typed.js ../src/flow-typed/foo.js ../src/foo.js ``` This verifies that the pathspec is properly excluding the root directory `flow-typed`, but not files that just happen to have `flow-typed` in their paths. wchargin-branch: simplify-ensure-flow
2018-08-22 18:44:20 +00:00
#!/bin/sh
Ensure that flow is used in all js files (#232) This script ensures that either //@flow or //@no-flow is present in every js file. Every existing js file that would fail this check has been given //@no-flow, we should work to remove all of these in the future. Test plan: I verified that `yarn travis` fails before fixing the other js files, and passes afterwards.
2018-05-08 03:02:19 +00:00
set -eu
ensure-flow.sh: simplify, removing dep on GNU grep (#602) Summary: By using Git’s magic pathspecs instead of post-processing stream operations, we reduce the pipeline to a single operation. Git implements its own version of `grep`, so this should be platform-independent. Previously, we had needed the `-z` argument to `grep(1)`, which is a GNU extension. Fixes #594. Test Plan: Ensure that the script passes with no output. Then, ```shell mkdir -p src/flow-typed/ touch src/foo.js src/flow-typed.js src/flow-typed/foo.js git add src/foo.js src/flow-typed.js src/flow-typed/foo.js cd scripts ./ensure-flow.js ``` and ensure that script exits with code 1, empty stdout, and stderr with: ``` ../src/flow-typed.js ../src/flow-typed/foo.js ../src/foo.js ``` This verifies that the pathspec is properly excluding the root directory `flow-typed`, but not files that just happen to have `flow-typed` in their paths. wchargin-branch: simplify-ensure-flow
2018-08-22 18:44:20 +00:00
! git grep -F --files-without-match -e '@flow' -e '@no-flow' \
-- ':/*.js' ':!/flow-typed/' >&2