prevent notification loops

src/libsnore/notification/notification_p.cpp

@@ -113,3 +113,22 @@ bool NotificationData::isBroadcasted() const
     return m_isBroadcasted;
 }
 
+void NotificationData::setSource(SnorePlugin *soure)
+{
+    m_source = soure;
+}
+
+const SnorePlugin *NotificationData::source() const
+{
+    return m_source;
+}
+
+bool NotificationData::sourceAndTargetAreSimilar(const SnorePlugin *target)
+{
+    if(source() && source()->name() == target->name()) {
+        snoreDebug(SNORE_DEBUG) << "Source" << source() << "and Target" << target << "are the same.";
+        return true;
+    }
+    return false;
+}
+

src/libsnore/notification/notification_p.h

@@ -58,7 +58,7 @@ public:
      * Sets the source SnorePlugin.
      * @see source()
      */
-    void setSource(const SnorePlugin *soure);
+    void setSource(SnorePlugin *soure);
 
 
     /**
@@ -67,6 +67,12 @@ public:
      */
     const SnorePlugin* source() const;
 
+    /**
+     * Returns true if the source->name() and the target->name() are the same.
+     * @todo rename
+     */
+    bool sourceAndTargetAreSimilar(const SnorePlugin *target);
+
 private:
     Q_DISABLE_COPY(NotificationData)
 

src/plugins/backends/freedesktop/freedesktopnotification_backend.cpp

@@ -52,7 +52,7 @@ bool FreedesktopBackend::canUpdateNotification() const
 
 void  FreedesktopBackend::slotNotify(Notification noti)
 {
-    if(noti.data()->source()->name() == name()) {
+    if(noti.data()->sourceAndTargetAreSimilar(this)) {
         return;
     }
 

src/plugins/frontends/freedesktop/freedesktopnotificationfrontend.cpp

@@ -126,6 +126,7 @@ uint FreedesktopFrontend::Notify(const QString &app_name, uint replaces_id,
     }
 
     noti.addActiveIn(this);
+    noti.data()->setSource(this);
     SnoreCore::instance().broadcastNotification(noti);
     return noti.id();
 }

src/plugins/frontends/pushover/pushover_frontend.cpp

@@ -263,6 +263,7 @@ void PushoverFrontend::getMessages()
                 if (notification.value(QLatin1String("html")).toInt() == 1) {
                     n.hints().setValue("use-markup", true) ;
                 }
+                n.data()->setSource(this);
                 SnoreCore::instance().broadcastNotification(n);
             }
             if (latestID != -1) {

src/plugins/secondary_backends/pushover/pushover.cpp

@@ -18,7 +18,8 @@
 #include "pushover.h"
 #include "pushoversettings.h"
 
-#include"libsnore/utils.h"
+#include "libsnore/utils.h"
+#include "libsnore/notification/notification_p.h"
 
 #include <QNetworkReply>
 #include <QNetworkRequest>
@@ -28,7 +29,7 @@ using namespace Snore;
 
 void Pushover::slotNotify(Notification notification)
 {
-    if(notification.data()->source()->name() == name()) {
+    if(notification.data()->sourceAndTargetAreSimilar(this)) {
         return;
     }