1169 lines
345 KiB
HTML
1169 lines
345 KiB
HTML
<html><body><style>
|
|
* {
|
|
font-family:sans-serif;
|
|
}
|
|
body {
|
|
text-align:center;
|
|
padding:1em;
|
|
}
|
|
.messages {
|
|
width:100%;
|
|
max-width:700px;
|
|
text-align:left;
|
|
display:inline-block;
|
|
}
|
|
.messages img {
|
|
background-color:rgb(248,244,240);
|
|
width:36px;
|
|
height:36px;
|
|
border-radius:0.2em;
|
|
display:inline-block;
|
|
vertical-align:top;
|
|
margin-right:0.65em;
|
|
}
|
|
.messages .time {
|
|
display:inline-block;
|
|
color:rgb(200,200,200);
|
|
margin-left:0.5em;
|
|
}
|
|
.messages .username {
|
|
display:inline-block;
|
|
font-weight:600;
|
|
line-height:1;
|
|
}
|
|
.messages .message {
|
|
display:inline-block;
|
|
vertical-align:top;
|
|
line-height:1;
|
|
width:calc(100% - 3em);
|
|
}
|
|
.messages .message .msg {
|
|
line-height:1.5;
|
|
}
|
|
</style><div class="messages"><div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 12:46</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-14 12:46</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-14 12:46</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-14 12:46</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 12:46</div><div class="msg">@yenda set the channel topic: <a href="https://github.com/status-im/ideas/issues/9">https://github.com/status-im/ideas/issues/9</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 12:47</div><div class="msg">@yenda set the channel purpose: <a href="https://github.com/status-im/ideas/issues/9">https://github.com/status-im/ideas/issues/9</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 12:47</div><div class="msg">Hey guys I created this channel for the discussion related to idea 9</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-14 12:47</div><div class="msg">:eyes:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 12:48</div><div class="msg">@janherich @alwx is one of you developping on iOS ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 12:48</div><div class="msg">I still need someone to finish the react-native update</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-14 13:23</div><div class="msg">I think both of us are :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-01-09/125597416918_4b7b095b4e695e7a8be1_72.jpg" /><div class="message"><div class="username">carl</div><div class="time">2017-11-14 13:46</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:47</div><div class="msg">@jeluard the update-react-native branch already works for Android and is using latest react native version. Do you have some time this week to work on your PRs that were waiting for the update (flat-list and checkbox with filters) ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-14 15:47</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-14 15:49</div><div class="msg">sure</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-14 15:49</div><div class="msg">Only FlatList requires it, others can be migrated later</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:51</div><div class="msg">Awesome, you can juste target the update-react-native branch then to build on top of it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:51</div><div class="msg">@janherich can you confirm that you'll be working on getting the iOS part working this week once your done with your current work ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:51</div><div class="msg">Ok :+1::skin-tone-2: flat list is good to get done because it will remove the warning I currently have</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-14 15:52</div><div class="msg">@yenda Sure I can</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:55</div><div class="msg">Can someone take <a href="https://github.com/status-im/status-react/issues/2408">https://github.com/status-im/status-react/issues/2408</a> ? We need to get this solved quickly because the warnings are really annoying and pop up every screen</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:55</div><div class="msg">Flat list, iOS update and setTimeout are the highest priority for this week. I will take setTimeout unless someone already has a good idea how to replace it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:55</div><div class="msg">@alwx you will be working on the refactoring right ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-14 15:57</div><div class="msg">Awesome.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-14 19:36</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-14 20:20</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 06:35</div><div class="msg">@andrey have you seen my comment in github ? A guy started to work on remote profiler</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 07:13</div><div class="msg">@yenda Cool stuff! It might make sense to leverage our forces on this indeed.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 07:23</div><div class="msg">hey @yenda, I was off yesterday</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 07:23</div><div class="msg">but yes, I am working on it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 07:23</div><div class="msg">and will be</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 07:26</div><div class="msg">currently I am refactoring re-frame handlers and subs; and on the same time trying to get rid of timeouts (for instance, now in almost all cases we don't need to call one handler in 100 ms after another)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:27</div><div class="msg">Ok thanks! Regarding timeouts The small timeouts are ok it's the one that last minutes that is bad for performance and correctness in Android</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 07:29</div><div class="msg">Let's make sure we have small PRs that are merged quick! The faster the better.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:31</div><div class="msg">@jeluard btw regarding flat list is the PR ready besides waiting for the update to hit develop ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 07:32</div><div class="msg">Need some more tests, and validate inverted list work.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:32</div><div class="msg">I notice that you rebased on old version of the branch, it would be better if you target the branch instead of develop </div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 07:35</div><div class="msg">It's supposed to be based on the right brnach but I might have screwed up something</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:36</div><div class="msg">I mean in github instead of doing to PR to develop it would be better to do it on update-react-native. It can be changed back later once update-react-native is merged</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:37</div><div class="msg">Does your refactoring include discover ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:38</div><div class="msg">(that's where the bad timeout is <a href="https://github.com/status-im/status-react/issues/2408">https://github.com/status-im/status-react/issues/2408</a>)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 07:38</div><div class="msg">That's the case unless I don't get your point</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 07:38</div><div class="msg">no, it's only for chat.
|
|
|
|
<a href="https://github.com/status-im/status-react/issues/2341">https://github.com/status-im/status-react/issues/2341</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 07:39</div><div class="msg">but there are a lot of handlers there</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:49</div><div class="msg">ok good then I will deal with this setTimeout</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 07:50</div><div class="msg">yes my bad. so I think it just needs a rebase to get rid of oskarth commits that got removed because it was a noop</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 08:40</div><div class="msg">@alwx just heads up, in my branch which I opened yesterday, there are no no hard timeouts in chat handlers/events anymore (except for `:load-more-messages` handler, and we want it there)
|
|
The only thing left to do is to port remaining ?old-style? events in `status-im.chat.handlers.cljs`, it's now only ~200LOC of quite simple code.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 08:44</div><div class="msg">my current changes are here: <a href="https://github.com/status-im/status-react/pull/2433">https://github.com/status-im/status-react/pull/2433</a> it's too early to review them, but to give you some understanding</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 08:45</div><div class="msg">more will be commited later today (including these `status-im.chat.handlers` changes)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 08:46</div><div class="msg">Thanks, I will have a look</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 08:47</div><div class="msg">@yenda this recent change gave me very hard time yesterday :smile: <a href="https://github.com/status-im/status-react/blob/develop/src/status_im/ui/screens/events.cljs#L229-#L234">https://github.com/status-im/status-react/blob/develop/src/status_im/ui/screens/events.cljs#L229-#L234</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 08:48</div><div class="msg">Focus on `db` and `app-db` symbols :))</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 08:49</div><div class="msg">by the way, `status-im.chat.handlers.send-message` should and will also be refactored</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 08:50</div><div class="msg">Yes, that's the last big-messy-old-style namespace in chat module actually and it's very bad, lot of duplication, etc.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 08:50</div><div class="msg">yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 08:52</div><div class="msg">no there is also discover</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 08:52</div><div class="msg">still using old u/side-effect! function</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 08:53</div><div class="msg">as a rule of thumbs we should consider the refactoring part to be done once side-effect! function is not used anymore don't you think ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 08:56</div><div class="msg">but it's easy enough to just get rid of side-effects! everywhere, this particular part of refactoring can be done in like 30 minutes</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-15 08:56</div><div class="msg">just replace register-handler with register-handler-fx everywhere :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 08:57</div><div class="msg">but it is also a good marker for probable need of extra refactoring though</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 09:04</div><div class="msg">But it's absolutely not about just replacing `u/side-effect!` with effects map? What?s harder and I would argue more important is to refactor the process so it doesn?t use dispatches for everything, it uses atomic functions and not distinct events, etc.
|
|
For example contacts events are already ?refactored?, but they still dispatch lot of events left and right instead of atomic functions just changing the db with necessary side effects captured in the effects map.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 11:28</div><div class="msg">@janherich tell me when you start working on iOS react-native-update so I don't force push while you work on it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 11:51</div><div class="msg">@yenda I will tell you, there are still some things which I need to do on my jail-loading PR</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 11:51</div><div class="msg">I will probably really start working on the iOS react-native-update tomorrow</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 11:55</div><div class="msg">@janherich Are those things blocking? As in they would break develop? If not it could be a separate PR.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 11:57</div><div class="msg">@jeluard they really, really depend on the code in PR, so it can't be based on develop</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 11:58</div><div class="msg">You can create a branch off the PR one? Do you think it's ok to merge your PR as is?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 12:02</div><div class="msg">I need to fix one subtle bug which exists in develop as well, so it's not really introduced by my PR (but the solution can't be based off develop code)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 12:02</div><div class="msg">I don't see much value in branching separate PR, I will add necessary changes quite quickly</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 12:03</div><div class="msg">If it's merged in the meantime, no problem I can then open separate PR</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 12:15</div><div class="msg">The goal is to have minimal PR merged quickly so that it's easy to test / review.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 12:25</div><div class="msg">The changes I?m going to incorporate will actually *cut down* actual code lines quite significantly - it's about request objects/logic, which is very messy and super hard to understand now (but most importantly, not working correctly)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 12:27</div><div class="msg">How long do you think you will need?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 12:27</div><div class="msg">3-4 hours</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-15 12:29</div><div class="msg">Seems fine! Would be great to have this merged tomorrow!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 12:36</div><div class="msg">Yes, I totally agree with you - by the way the work I?m doing now (refactoring requests) doesn?t hold merging my PR in any way - without it, no new bugs will be introduced, just some outstanding won't be fixed :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 23:11</div><div class="msg">Hi @yenda I?m about to pick-up react-native update for iOS, can you provide me some info about what needs to be done ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 23:16</div><div class="msg">@janherich I think the main task is to fix the merge conflict in the pbxproj file, but this is tricky because there is no way to tell what is to keep or throw</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-15 23:17</div><div class="msg">check the PR for more precision as well as oskarth feedback <a href="https://github.com/status-im/status-react/pull/2217">https://github.com/status-im/status-react/pull/2217</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-15 23:25</div><div class="msg">Thanks @yenda I will start with that tommorow</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 12:53</div><div class="msg">@janherich how is it going with iOS ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 12:54</div><div class="msg">@yenda Not very good to be honest, I?m still trying to resolve merge conflicts in xcode project file to get it working</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 12:54</div><div class="msg">Needless to say I know (almost) nothing about iOS app development stuff and settings, but I?m learning as I do it :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 13:08</div><div class="msg">For `2. the app can be started in a specific state with a configuration file` I worked out the following requirements:
|
|
- save realm files
|
|
- restore realm files
|
|
- save app-db
|
|
- restore app-db
|
|
- start the app on a specific screen with a specific state</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 13:09</div><div class="msg">Being able to save and restore realm files for instance will be quite usefull to be able to test migrations</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 13:09</div><div class="msg">Saving and restoring app-db will be useful for debugging purposes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 13:12</div><div class="msg">@andrey I think re-frisk is the good vector for that because we can read files on the phone with re-frisk-remote and we can write on disk with sidecar what do you think ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 15:00</div><div class="msg">Hi @yenda I have problems with updating npm packages in the `update-react-native` branch, specifically your forked packages (`react-native-http-bridge` etc.) point to git hashes (in `package-lock.json`) which can't be retrieved from remote.
|
|
Is it possible that those hashes are only in your local repo, eq you didn't push everything into remote ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:03</div><div class="msg">that's wierd the package.json doesn't refer to a specific commit. you should remove the package-lock.json though</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 15:05</div><div class="msg">Yes it does in case of your packages, check it out?
|
|
I don't think removing it is a good option (we have it there for some reason, which is security, so nobody can shove corrupted package through npm to us), but as a quick fix I can do it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 15:05</div><div class="msg">But you should fix it anyway</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-16 15:06</div><div class="msg">btw guys we should try to use latest version of `react-native-mapbox-gl`, it implemented with hacks because it didn't work and @roman made some magic</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:07</div><div class="msg">but the commit exists <a href="https://github.com/yenda/react-native-http-bridge#9443c656b40338156e150369d090f76b09a953be">https://github.com/yenda/react-native-http-bridge#9443c656b40338156e150369d090f76b09a953be</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-16 15:08</div><div class="msg">get rid of <a href="https://github.com/status-im/status-react/blob/develop/ios/Mapbox.framework">https://github.com/status-im/status-react/blob/develop/ios/Mapbox.framework</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:08</div><div class="msg">I tried to use it in the react-native-update but couldn't make it work in a hour, it should be a task in itself once we have the update merged</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 15:10</div><div class="msg">But it's different repository: <a href="https://github.com/yenda/react-native-webview-bridge">https://github.com/yenda/react-native-webview-bridge</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-16 15:11</div><div class="msg">Nevermind</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:16</div><div class="msg">how can you update stuff without deleting the package-lock?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-16 15:17</div><div class="msg">ok thanks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:17</div><div class="msg">We could even make it a bounty :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:17</div><div class="msg">the thing is they made a lot of changes, including in the package name and how it work</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-16 15:17</div><div class="msg">yeah, we could even make issue in their repo with bounty :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-16 15:18</div><div class="msg">that would require them to accept our bot in their repo though</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-16 15:18</div><div class="msg">oh, yes (</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-10-04/251566892466_e37667e6064fe542e7d7_72.jpg" /><div class="message"><div class="username">naghdy</div><div class="time">2017-11-16 21:41</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:51</div><div class="msg">so if we want to use re-frame-trace we need to make forks of re-frame-trace and re-frame itself, how could this work?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:51</div><div class="msg">fork repos in status org, make changes</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:52</div><div class="msg">and? how to use it? deploy on clojars? do we need something like status/ for clojars? status/re-frame ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:53</div><div class="msg">or status.forks/re-frame</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:54</div><div class="msg">so we need account on clojars and gpg key for the team</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:55</div><div class="msg">or <a href="https://github.com/tobyhede/lein-git-deps">https://github.com/tobyhede/lein-git-deps</a> ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:57</div><div class="msg">@here ^</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:57</div><div class="msg">does this mention work?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 11:57</div><div class="msg">looks like no</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-17 12:03</div><div class="msg">Why not PR then merge in original repo?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 12:04</div><div class="msg">because we need working version for us, for our purposes</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-17 12:05</div><div class="msg">we need it fast, PR in original repo is a long way</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-17 12:06</div><div class="msg">For small projects it can be fast especially if working together</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-17 12:07</div><div class="msg">I almost never add issues having PR merged in clojure land</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-17 12:52</div><div class="msg">We could use lein-git-deps until it is released ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-17 12:53</div><div class="msg">Or @andrey since you already use clojar for re-frisk you could fork it until it's merged ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-17 12:53</div><div class="msg">And release your fork</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-17 14:09</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-17 16:18</div><div class="msg">@andrey you already have the tracing working ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-24/216937253685_a3e96178175623afd95d_72.png" /><div class="message"><div class="username">vic</div><div class="time">2017-11-18 08:52</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-18 11:09</div><div class="msg">Gosh, I can't even run the current app on iOS simulator after I upgraded the XCode :rage:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-18 12:25</div><div class="msg">@janherich yeah, don't do that yet :disappointed: can run both simultaneously: <a href="https://github.com/status-im/status-react/issues/1923">https://github.com/status-im/status-react/issues/1923</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-18 12:34</div><div class="msg">@janherich FYI there is discussion about this in #10-ob-bounties - maybe you want to chime in wrt this swarm's prios?</div></div></div><br/>
|
|
<div><img src="" /><div class="message"><div class="username"></div><div class="time">2017-11-20 16:39</div><div class="msg">@yenda commented on @andrey?s file <a href="https://status-im.slack.com/files/U3P874D5M/F832N46TD/image.png">https://status-im.slack.com/files/U3P874D5M/F832N46TD/image.png</a>: awesome !!!!!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-20 16:41</div><div class="msg">but my favorite feature you can see event and data for this event in which error happened</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 16:42</div><div class="msg">That?s killer feature @andrey, I could use that like everytime I debug something :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 16:44</div><div class="msg">yeah it's a nightmare when the error occurs in an event that is never logged :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 16:44</div><div class="msg">oh boy</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 18:45</div><div class="msg">@janherich how are you doing with the osx update ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-20 18:48</div><div class="msg">currently discussing if it should be a bounty issue, Eric</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-20 18:49</div><div class="msg">in fact agreed it should unless it will be solved by the swarm <a href="https://status-im.slack.com/archives/C7ZFPTN9G/p1511008011000074">https://status-im.slack.com/archives/C7ZFPTN9G/p1511008011000074</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:49</div><div class="msg">FYI two issues. One is Xcode 9 and the other is RN iOS upgrade. I confused them too a bunch :stuck_out_tongue:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:49</div><div class="msg">- <a href="https://github.com/status-im/status-react/issues/1690">https://github.com/status-im/status-react/issues/1690</a> iOS side left
|
|
- Xcode 9 <a href="https://github.com/status-im/status-react/issues/1923">https://github.com/status-im/status-react/issues/1923</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 18:50</div><div class="msg">@yenda I?m not working on that at all since friday, fully occupied with fixing urgent develop bugs and making sure that `feature/better-command-loading` is merged</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 18:50</div><div class="msg">@oskarth so realm update didn't fix the issue with Xcode 9 ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:51</div><div class="msg">@yenda I have no idea, but @janherich knows this</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:51</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/1923#issuecomment-345791170">https://github.com/status-im/status-react/issues/1923#issuecomment-345791170</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 18:51</div><div class="msg">@yenda It did at least partially, see my comment</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:51</div><div class="msg">So no it fixed step 1 out of N where N is unclear at this stage</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:51</div><div class="msg">that looks like a simple linker error though, should be fixable by clicking around a bunch in xcode</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:52</div><div class="msg">library not found lPods = that library (new for xcode 9 I guess?) hasn't been linked</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:53</div><div class="msg"><a href="https://stackoverflow.com/questions/9863836/library-not-found-for-lpods">https://stackoverflow.com/questions/9863836/library-not-found-for-lpods</a> and lots of google results, did you try any of this?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 18:55</div><div class="msg">in any event, this whole swarms is meant to deal with issues like this right @yenda? so can you please own it in whatever form that takes? I need to focus on offline inbox swarm and feel l'm constantly pulled into this because people aren't talking about these "ugly" issues. If I find some downtime I can have a look at this later but I'd rather you guys figure it out and/or put bounties on it as appropriate. The issues are well defined</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 18:57</div><div class="msg">@janherich can you focus on this this week ? (once you are done with the command PR)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 18:57</div><div class="msg">Sure, once I?m done with that.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 18:57</div><div class="msg">is there still a lot to do on the PR ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-20 18:57</div><div class="msg">so we do not want to make it as a bounty issue and delegate to the external contributors?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 18:57</div><div class="msg">I would do that</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 18:58</div><div class="msg">tbh it seems like quite a waste of time to focus on that ourselves IMO</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 18:58</div><div class="msg">I was under the impression that this requires quite some understanding of how the app is built and works but I might be wrong</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-20 18:58</div><div class="msg">I can make it a bounty in ~5 mins just need swarm agreement :slightly_smiling_face: Eric ok to delegate?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 18:59</div><div class="msg">It?s not interfering with our work and frankly, there is huge load of issues in develop I would like to solve first</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 18:59</div><div class="msg">are we talking about the xcode issue or the react-native update on osx issue ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 19:00</div><div class="msg">I promised some @cryptowanderer that I will make our currently (partially) broken command API usable again, I also promised @adan that I will make demo-bot working again so it can be used for integration testing</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-20 19:00</div><div class="msg">I was talking about delegating <a href="https://github.com/status-im/status-react/issues/1923">https://github.com/status-im/status-react/issues/1923</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-20 19:01</div><div class="msg">Both Xcode and RN upgrade are stopping us moving forward. This is not a good fit for external contributors IMHO</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-20 19:01</div><div class="msg">@janherich There is a dedicated idea for bot API so we can invest time in this then.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-20 19:02</div><div class="msg">Bot API have been broken for months and are bad anyway. I don't see how it's a blocker</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-20 19:02</div><div class="msg">Also we should be idea driven now.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-20 19:03</div><div class="msg">Fine, I will finish my #2409 and get back to RN iOS upgrade stuff. Just to let you know guys, I had to solve *many* bugs since last Friday, quite a lot of them not even regression bugs to make it possible for test-team to properly test huge #2409 PR</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 19:04</div><div class="msg">we believe you @janherich it's cool :+1::skin-tone-2:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2017-11-20 19:05</div><div class="msg">sorry, will be afk till tomorrow morning - if swarm agrees to make bounty for <a href="https://github.com/status-im/status-react/issues/1923">https://github.com/status-im/status-react/issues/1923</a> -will read this channel and do it in the morning</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-20 19:06</div><div class="msg">@anna I would say not now, first react-native update on OSX and if it doesn't work on xcode 9 after that (but it probably will) we can think about it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-20 19:13</div><div class="msg">thanks guys</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:42</div><div class="msg">Hey guys how are you doing, who is currently working on this idea ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:43</div><div class="msg">I see @andrey is on profiling with re-frisk and @janherich on iOS react-native update</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:43</div><div class="msg">@alwx how are you doing with the chat refactoring ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:44</div><div class="msg">yeah and i think we should get rid of realm immediately</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 10:44</div><div class="msg">Should this be a separate idea?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-22 10:45</div><div class="msg">still working :disappointed: the story seems small but it is becoming crazily big, so maybe I should stop at some point. Also think that I dived too deep into it.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-22 10:45</div><div class="msg">however, want to commit all current changes later today</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:45</div><div class="msg">i think so, i'll create it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:49</div><div class="msg">seriously it take a lot of developers resources to write all this shitty migrations, schemas, save functions etc, but only one thing we need is save our app-db once before app close, and load it once on start, and clj->js stuff is expensive, and realm works not super fast, but we save every message in realm for example each time it sent or received</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 10:50</div><div class="msg">Yes there is definitively a lot of value in simplifying all this. Also make it inspectable for instance.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 10:51</div><div class="msg">We should start from requirements, then pick up the right tool</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:52</div><div class="msg">If you only save once before app closes and the app crashes you lose all the data you collected since startup</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:52</div><div class="msg">ok nice</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:53</div><div class="msg">right so we can store it once a time, for example on something changed but not often than 1min for example</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:53</div><div class="msg">we could use edn for example</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:53</div><div class="msg">I have searched for a replacement and there is none so we would have to develop something add-hoc</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:54</div><div class="msg">we are not using encryption for now but that is something we need for release IMO</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:54</div><div class="msg">yes agree</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 10:54</div><div class="msg">Let's make sure we list all requirements, including future needs</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:55</div><div class="msg">replacing realm by our solution could be doable but I think at this point the first step is to have a cleaner interface in order to be able to compare perfs of an eventual replacement</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:55</div><div class="msg">imagine you're chatting in a group chat</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 10:56</div><div class="msg">I'd like a `re-frisk` training session! I'm sure there's a lot I ignore</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:57</div><div class="msg">this is new feature, not released yet</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:57</div><div class="msg">@andrey is it also possible to trace effects and coeffects ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 10:57</div><div class="msg">or is the granularity events</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:57</div><div class="msg"><a href="https://status-im.slack.com/archives/C803EC3S9/p1511196097000103">https://status-im.slack.com/archives/C803EC3S9/p1511196097000103</a> @jeluard</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 10:58</div><div class="msg">Ah VIP only</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:58</div><div class="msg">i implemented only events, but next step is incorporate re-frame-tracer with all features</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:58</div><div class="msg">right</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:58</div><div class="msg">10000SNT</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 10:59</div><div class="msg">and you are in the club )</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:00</div><div class="msg">that's what I am starting today</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 11:00</div><div class="msg">Free drink included?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:02</div><div class="msg">i think the purpose of "realm like" tools is to operate with one source of truth and use schemas, but we have app-db and spec, so we need just to find a way to save app-db and load it to/from disk, and i think edn is a good condidate</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:02</div><div class="msg">we don't need to save and read from disk each time for sure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:03</div><div class="msg">read only once on startup and save periodicaly</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:03</div><div class="msg">the purpose is also to have a dbms that manages read and writes to disk as well as memory efficiently and with consistency</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:03</div><div class="msg">sure</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:05</div><div class="msg">also for chat for instance we can expect to have a chat with 10s of thousands of messages in it that would be a waste to load everytime so our ad-hoc solution should use multiple files and be able to do incremental loading on those files</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:05</div><div class="msg">I have been thinking about all this over the last days</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:06</div><div class="msg">my conclusion at this point is that things will be clearer once the data-store ns and usage have been cleaned up</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:06</div><div class="msg">I will do a small PR with a proposal for a subset of the codebase</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:08</div><div class="msg">I also had this save/restore feature I told @andrey about for realm but it's stalled at that point I might come back to it later</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 11:11</div><div class="msg">Please make sure you list all future requirements in this PR too</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 11:12</div><div class="msg">And non-functional reqs too (perf, durability, upgrade, ..)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:23</div><div class="msg">also i'm thinking about subscriptions on steroids, for example what if i have subscriptions which updates every 200ms, and it requeres a lot of calculations, and re-render all app view, i want to calculate it for example not often than 1s, something like `(reg-sub :my-syb {:timeout 1s} (fn p[})`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:25</div><div class="msg">do we have such subscriptions ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:26</div><div class="msg">idk</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 11:29</div><div class="msg">We have complicated Level-1 subscriptions (re-calculated every-time *anything* in db changes) and we do have periodic (~1s maybe) updates to db (syncing), so ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:30</div><div class="msg">but that could be fixed by simply re-working the app-db schema a bit</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 11:31</div><div class="msg">+ reworking subscriptions, many of Level-1 subscriptions absolutely don't need to be such</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:31</div><div class="msg">yes my question was more for re-frame non for status app</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 11:35</div><div class="msg">TBH tying implementation detail like refresh interval to subscription, which is reactive building block seems wrong to me. The beauty of the subscription is exactly in that I don't care about when, in which order or how often it fires off and it happens automatically.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:37</div><div class="msg">yes, but my idea only in optimisations, if i have 3 same subscriptions in a row in 1 s i don't want to calculate first 2 and re-render view 2 times, only last one</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:39</div><div class="msg">for example if i have ms counter subscription, i don't want to render every ms, because user doesn't see this for example only every 200ms</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:40</div><div class="msg">yeah it's just i'm thinking loud</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:40</div><div class="msg">I only renders 60 times per sec at most now ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 11:40</div><div class="msg">subscriptions are at most calculated once per tick aren't they @janherich</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 11:42</div><div class="msg">My understanding is that subscriptions are re-calculated every-time we produced `:db` effect and app-db atom (well, `ratom`) is swapped</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:43</div><div class="msg">per tick only events</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 11:43</div><div class="msg">and only event could change app-db so yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 11:44</div><div class="msg">So anything like tying refresh interval to them makes some time-tracking/de-bouncing necessary, something which is not necessary at all in current impl</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 11:47</div><div class="msg">It opens some interesting questions, like what happens when you define subscription with 5s refresh interval, 2 events change data relevant to subscription in succession (let?s say the second event arrives 2s after the first one), and then nothing more.
|
|
Do we fire off the subscription the second time ? If yes, when it will be, 5s after second event arrives, or 3s ?
|
|
In the second case, it requires some non-trivial timekeeping, with state for *every* subscription defined with refresh interval</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-24/216937253685_a3e96178175623afd95d_72.png" /><div class="message"><div class="username">vic</div><div class="time">2017-11-22 19:06</div><div class="msg">hi swarm - I suggest to try Github projects to track the idea progress, similar to this <a href="https://github.com/status-im/status-react/projects/4">https://github.com/status-im/status-react/projects/4</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 19:08</div><div class="msg">@vic Isn't this tied to a specific repo? if so it wouldn't work great with cross-team swarms, which is what we want to encourage</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 19:09</div><div class="msg">Here's how we started doing this for offline inboxing, as I believe this is what Jarrad referred to in organizational doc (open PR with progress to ideas issues). <a href="https://github.com/status-im/ideas/pull/36">https://github.com/status-im/ideas/pull/36</a> - maybe useful for inspration (super primitive right now)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-24/216937253685_a3e96178175623afd95d_72.png" /><div class="message"><div class="username">vic</div><div class="time">2017-11-22 19:15</div><div class="msg"><a href="https://github.com/status-im/status-react/projects/5">https://github.com/status-im/status-react/projects/5</a>
|
|
so the idea related issues/PRs can be associated with the project, easily accessed, and went through the workflow (columns)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-24/216937253685_a3e96178175623afd95d_72.png" /><div class="message"><div class="username">vic</div><div class="time">2017-11-22 19:16</div><div class="msg">@oskarth we can try different approaches</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-24/216937253685_a3e96178175623afd95d_72.png" /><div class="message"><div class="username">vic</div><div class="time">2017-11-22 19:17</div><div class="msg">I?m not sure the PR is the right tool for tracking the idea progress (or I didn't get how it's used)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-24/216937253685_a3e96178175623afd95d_72.png" /><div class="message"><div class="username">vic</div><div class="time">2017-11-22 19:18</div><div class="msg">might be the mix of both would work best, let?s try and see</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 19:21</div><div class="msg">sure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 19:30</div><div class="msg"><a href="https://github.com/status-im/status-react/pull/2502">https://github.com/status-im/status-react/pull/2502</a>
|
|
|
|
<a href="https://github.com/status-im/status-react/pull/2501">https://github.com/status-im/status-react/pull/2501</a>
|
|
|
|
<a href="https://github.com/status-im/status-react/pull/2500">https://github.com/status-im/status-react/pull/2500</a>
|
|
|
|
This guy is making some interesting contributions, does anyone have the bandwidth to further chat with him to coordinate on what may be useful in terms of swarm priorities/ projects? If so I can get a room started in riot for whoever </div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:03</div><div class="msg">-2500: I'll think about this one but I am no
|
|
-2501: I don't recall why we moved away from advanced optimization maybe someone from clojureteam remembers it was in <a href="https://github.com/status-im/status-react/commit/be463e094799e23a9b6e9df32330ed0b5062f84b#diff-0fff143854a4f5c0469a3819b978a483">https://github.com/status-im/status-react/commit/be463e094799e23a9b6e9df32330ed0b5062f84b#diff-0fff143854a4f5c0469a3819b978a483</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:04</div><div class="msg">- 2502 is really nice I wanted to implement generative testing at some point, this guy is taking nice initiative :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:04</div><div class="msg">did he apply ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 20:05</div><div class="msg">#2501 no much gain but much slower compilation during dev</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 20:05</div><div class="msg">He did apply yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:06</div><div class="msg">@jeluard how can it slow down compilation during dev ? it's only for prod build</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:07</div><div class="msg">unless someone (like me) used to run lein prod-build in dev all the time for no reason :sweat:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 20:09</div><div class="msg">Hmm good point :sweat_smile: Don't remember then, I think it was perf related</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-22 20:10</div><div class="msg">Size gain in final artifact was almost insignificant</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:13</div><div class="msg">I think using advanced compilation can cause build not to complete, troublesome for ios debugging</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:13</div><div class="msg">but I don't remember exactly. The size diff is also not big and if we want to optimize for size we got bigger problems</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:13</div><div class="msg">if we want to move to advanced compilation we should create issue and wait until Roman is back to get full trade-offs listed imo</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:14</div><div class="msg">yeah ofc it is mentionned in the PR that is not complete anyway</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:16</div><div class="msg">so if it isn't complete what are we supposed to do with it? @yenda you don't have a problem with a new contributor not saying what problem they are solving and just making changes?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:20</div><div class="msg">no I wouldn't call that `just making changes` I see them more as propositions that are clearly explained in each PR, they might not all solve problems but they do have benefits. And it shows a lot of interest he tried to do something even though the artifactory was down for 24 hours</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:22</div><div class="msg">all I see at that point is that he's potentially productive, knows clojure and certainly is motivated which are already important qualities</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 20:22</div><div class="msg">I think we should work on redirecting his attention to a problem we actually are scoping out for a swarm and don't have any hands on IMO if this isn't a ?for sure? help to any of our immediate needs. </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:23</div><div class="msg">@yenda maybe we can define some bounties for 9-dev-xp for real problems we are having?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:23</div><div class="msg">@hutch sure now that he can build the app since artifactory is back on I'll be glad to propose him something to do for this swarm</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:24</div><div class="msg">@oskarth maybe he doesn't even need bounties :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:24</div><div class="msg">well otherwise we are kind of asking him to work for free right</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:24</div><div class="msg">but sure</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:24</div><div class="msg">yeah you are right better put a bounty</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:25</div><div class="msg">well maybe we can make him update react-native on iOS</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:25</div><div class="msg">how can I contact him ? @hutch</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 20:26</div><div class="msg">Let me know if you need any help getting him aligned, but I'd say commenting through an pr he opened will suffice </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 20:26</div><div class="msg">Otherwise through riot </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 20:26</div><div class="msg">I've already invited and asked him to ping me </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:27</div><div class="msg">> see them more as propositions
|
|
right, in that case I agree the generative testing one is interesting</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:29</div><div class="msg">it's awesome because it gets started, once we have node bindings for statusd we can generate scenarios we wouldn't think off it will be really good at catching unexpected bugs</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:30</div><div class="msg">@janherich are you still on the OSX update ? did you commit everything so far ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:30</div><div class="msg">@hutch can you ping me when he's there I am not often on Riot</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:31</div><div class="msg">here's an idea</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:31</div><div class="msg">ask if he wants to do this one: <a href="https://github.com/status-im/status-react/issues/2456">https://github.com/status-im/status-react/issues/2456</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-22 20:31</div><div class="msg">advanced compilation requeres externs, we don't want to generate externs</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:31</div><div class="msg">he obviously knows spec and this is a real problem, and it has a bounty</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:31</div><div class="msg">you are right, this is probably why</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:32</div><div class="msg">^ @hutch @yenda</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:54</div><div class="msg">this one @yenda</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:55</div><div class="msg">yes we can propose that if @janherich can still work on iOS</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:55</div><div class="msg">I think iOS one is a nightmare for new contributor and maybe not good test of skills, cause a big random component to it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:55</div><div class="msg">unless he wants to of course</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:56</div><div class="msg">what's nice about this one is that it has multiple 'stakeholders' so we can see if he solves it for everyone using tool/skills he has</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:56</div><div class="msg">it's quite well-defined though so doesn't test problem identification skills but better than nothing for 'starter' issue</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-22 20:57</div><div class="msg">my 2c, you decide</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 20:59</div><div class="msg">yeah @hutch if you can reach him tell him to give a shot at this one <a href="https://github.com/status-im/status-react/issues/2456">https://github.com/status-im/status-react/issues/2456</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 21:10</div><div class="msg">@yenda sure thing </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 21:11</div><div class="msg"><a href="https://github.com/status-im/status-react/pull/2502#issuecomment-346473878">https://github.com/status-im/status-react/pull/2502#issuecomment-346473878</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 21:13</div><div class="msg">he's already on riot actually</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 21:15</div><div class="msg">Ok :sweat_smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 21:16</div><div class="msg">I see sorry, am on the road today because of thanksgiving so not fully attentive - thanks for pinging him, I'll send him a msg there as well. </div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 21:17</div><div class="msg">I'm chatting with him atm</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-11-22 21:21</div><div class="msg">I'll leave ya to it ;) thanks!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 21:30</div><div class="msg">@yenda I was little bit sidetracked today (the migration stuff, trying to reproduce the elusive bug which happens only with recovered account), but yeah, I did some additional work on that, I?m going to commit everything. But it's still not working as it should and I?m deep down in rabbit hole full of XCode linker errors, conflict of manually linked and Pods linked dependencies, etc.
|
|
I would really, really appreciate help from somebody who has some actual experience with iOS app development.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 21:32</div><div class="msg">are you on riot ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 21:32</div><div class="msg">the guy is there maybe you could collaborate together</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 21:32</div><div class="msg">and you'll be able to give us more feedback on how it is to work with him</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 21:39</div><div class="msg">Yes, I?m, I will get in touch with him</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 21:40</div><div class="msg">Which room there is relevant ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 21:40</div><div class="msg">#dev-status</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-22 22:10</div><div class="msg">So to sum up progress of this swarm so far:
|
|
- re-frisk now has timing for events and shows which event failed (soon to be merged)
|
|
- chat is being refactors (soon PR)
|
|
- iOS react-native update makes progress
|
|
|
|
I also have a basic mechanism for a dev conf should I make a PR or continue progress on the refactoring to make it better ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-22 22:29</div><div class="msg">Thanks !</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-23 00:07</div><div class="msg">swarm, please fix this: <a href="https://github.com/status-im/status-react/issues/2505">https://github.com/status-im/status-react/issues/2505</a> - easy one for RN upgrade. Those are the only ones that are critical to fork AFAICT.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-23 00:21</div><div class="msg">@yenda can you please change the permissions for <a href="https://github.com/yenda/react-native-http-bridge">https://github.com/yenda/react-native-http-bridge</a> so I can push the import fix directly to upstream master (of your forked repo) ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-23 00:22</div><div class="msg">@oskarth We seem to be in the same situation regarding iOS RN upgrade, all import redefinition conflicts resolved, but still some linker error, am I correct ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-23 00:52</div><div class="msg">I already forked and patched the instabug lib (I don't want to really open PR against the one in `status-im` org before we are finished with this thing, to not accidentally break something), once the `react-native-http-bridge` forked by @yenda is patched as well, those duplicate definitions are resolved</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-23 07:17</div><div class="msg">@janherich You probably know this but found this accidentally and figured it would be worth sharing: <a href="https://github.com/facebook/react-native/blob/master/docs/linking-libraries-ios.md">https://github.com/facebook/react-native/blob/master/docs/linking-libraries-ios.md</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 08:18</div><div class="msg">@janherich don't hesitate to fork my repos in the end we will move them to status repo for PR anyway</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-23 09:04</div><div class="msg">re-frame trace 0.1.13 is out with a new subscriptions panel. <a href="https://github.com/Day8/re-frame-trace/releases/tag/0.1.13">https://github.com/Day8/re-frame-trace/releases/tag/0.1.13</a>. Note that you'll need to update to re-frame 0.10.3-alpha1 to make the best use of the subscriptions panel</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-23 09:04</div><div class="msg">just in time :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 09:04</div><div class="msg">:)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-23 09:15</div><div class="msg">@jeluard Thanks !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 13:38</div><div class="msg">@oskarth and @janherich do you still need me to enable some permissions ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 13:39</div><div class="msg">My plan was to just use our personnal repos for the PR and move everything to status org once working during squash</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-23 13:43</div><div class="msg">@yenda That?s exactly my plan as well, and no everything related permissions is already resolved and I?m not blocked in any way</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 13:45</div><div class="msg">ok thanks for the update</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 16:10</div><div class="msg">@janherich do you have hopes that it will be testable by tomorrow ? That was the deadline for this particular requirement but it's okay to delay it the overall progress is great</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-23 16:30</div><div class="msg">@yenda It?s very unlikely that the iOS RN upgrade will be working today (tomorrow I?m not working, opting to work on Saturday instead).
|
|
I already resolved all conflicts and the project builds just fine in XCode (providing that I disable the version setting git script, will get to that later), but I still have problems with the resulting JS bundle and uploading it to phone, I?m solving that now.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-23 16:32</div><div class="msg">awesome</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-24 14:37</div><div class="msg">Behold, the magnificent Status app running in simulator, with the newest react-native dependency :sunglasses:
|
|
As you can see, there are some visual quirks, like the commands/text boundary not properly aligned, but overall, it seems to be running just fine !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-24 14:37</div><div class="msg">ClojureTeam ^</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-24 15:00</div><div class="msg">command alignment is an existing issue, maybe a good opportunity to fix it! :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-24 16:29</div><div class="msg">nice one @janherich!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-24 16:29</div><div class="msg">good job, you fought the Xcode dragons and won</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-24 16:29</div><div class="msg">what was the missing piece re symbol files?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-24 16:48</div><div class="msg">Good job @janherich that's awesome</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-24 16:49</div><div class="msg">You said you work tomorrow ? I will also work this weekend my wife is travelling so I have plenty of dev time :sweat_smile: we should sync tomorrow if you are ok, fix the repos and prepare the final PR for testing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-25 10:32</div><div class="msg">@yenda Yes, my plan was to work today, but I will have my workday spread between today and tomorrow, as I realised I have some urgent family commitments today :slightly_smiling_face:
|
|
When it's OK for you, I would like to sync-by later today (around 18:00-20:00) to coordinate next steps for the RN update, so we can get to the point when it's ready for testing by QA asap.
|
|
If that doesn?t work for you, tomorrow is fine for me as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-25 12:30</div><div class="msg">Ok for 18-20</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-25 16:44</div><div class="msg">If it's okay for you tomorrow is better because the handy man is still there doing work at my place and I haven't eaten yet</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-25 17:43</div><div class="msg">Sure, let?s do it tomorrow, better for me as well :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-25 18:37</div><div class="msg">I let him try the vive so he stayed even longer :D and then he was interested in crypto</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-27 07:14</div><div class="msg">I finished most of my changes to chat events, need to rebase now. It?s a bit difficult because of a lot of conflicts, but it will be done today.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 07:31</div><div class="msg">great</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-27 07:36</div><div class="msg">hey @alwx have moved all effects and coeffects?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:06</div><div class="msg">@janherich have you made changes to the package.json ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:19</div><div class="msg">sorry I see you did</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 08:19</div><div class="msg">@yenda yes, as I needed to update some packages to new version + patch some forked packages (like the `react-http-bridge` you forked)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:20</div><div class="msg">yeah I saw that. I was wondering because I couldn't see any changes after pulling from github, but I realized it is because somehow it only fetches my commit</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:22</div><div class="msg">I don't feel well I'll afk for a few hours I'll come back to it after</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:24</div><div class="msg">I recloned the repo to make it work btw, maybe my gitfu is lacking a bit</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 08:26</div><div class="msg">That?s quite strange? Nevertheless, take a rest and feel better soon !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:28</div><div class="msg">and also I started a build on CI</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:30</div><div class="msg">```sed: node_modules/react-native/packager/src/JSTransformer/index.js: No such file or directory```</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:30</div><div class="msg">something went wrong</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:30</div><div class="msg"><a href="http://jenkins.status.im:8080/job/status-react/job/parametrized%20build/35/console">http://jenkins.status.im:8080/job/status-react/job/parametrized%20build/35/console</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 08:37</div><div class="msg">@janherich I think it's because we need to rebase</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-27 08:38</div><div class="msg">not all of them :disappointed: but the remaining ones are pretty easy and straightforward, want to finish them today</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 08:48</div><div class="msg">I already did, but what I can do is to squash it into 1 commit, if it somehow helps</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 09:09</div><div class="msg">Ok, so this is super strange, when I want to `git rebase -i develop` on the `update-status-react` branch, but it's absolutely not doing what I want?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 09:10</div><div class="msg">I think this patch commit is the culprit why it's not behaving - <a href="https://github.com/status-im/status-react/pull/2217/commits/5afd554c3066330481efa407cedb70fd4239271b">https://github.com/status-im/status-react/pull/2217/commits/5afd554c3066330481efa407cedb70fd4239271b</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 09:35</div><div class="msg">It should be already fixed, I squashed everything into one commit as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 13:50</div><div class="msg">Ok nice</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 13:50</div><div class="msg">I am back</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 13:50</div><div class="msg">testing android atm</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 14:11</div><div class="msg">Hey @janherich it still builds and all</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 14:12</div><div class="msg">I wanted to test the chat though and when I tried to add a contact with QR code I noticed that I get "@3" at the end of the address for some reason</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-27 14:37</div><div class="msg">@andrey What do I need to do to get `re-frisk` running on real device?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 14:37</div><div class="msg">should work without additional steps</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 14:37</div><div class="msg">have you tried ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-27 14:38</div><div class="msg">`lein re-frisk use-re-natal`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-27 14:38</div><div class="msg">and if android forward 4567 port</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-27 14:39</div><div class="msg">Works great after ` adb reverse tcp:4567 tcp:4567`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 14:41</div><div class="msg">so the chat doesn't work when I am chatting with a contact that is not added yet and send a message to him it messes with realm</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 14:43</div><div class="msg">but it is not related to our branch</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 15:36</div><div class="msg">I tried to build again and still get the same failure than earlier today <a href="http://jenkins.status.im:8080/job/status-react/job/parametrized%20build/36/console">http://jenkins.status.im:8080/job/status-react/job/parametrized%20build/36/console</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 15:45</div><div class="msg">ERROR: Slack notification failed. See Jenkins logs for details.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 15:45</div><div class="msg">Sending the Slack notification (about starting the build) is failing and this unfortunately terminates the process</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 15:46</div><div class="msg">I really don't know how to tackle this, who besides @roman is responsible/knows about jenkins<->slack integration ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 15:48</div><div class="msg">Or actually, I?m wrong, only the notification is failing, build suceeeded</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 15:50</div><div class="msg">```[parametrized build] Running shell script
|
|
+ sed -i '' s/301000/1201000/g node_modules/react-native/packager/src/JSTransformer/index.js
|
|
sed: node_modules/react-native/packager/src/JSTransformer/index.js: No such file or directory```</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 15:50</div><div class="msg">this seems to be the problem</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-27 15:51</div><div class="msg">@yenda ping on this one o<a href="https://github.com/status-im/status-react/pull/2502#issuecomment-346674800">https://github.com/status-im/status-react/pull/2502#issuecomment-346674800</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 15:56</div><div class="msg">it's in the script of the pipeline</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 15:57</div><div class="msg">between re-natal deps and mvn dependency::umpack</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-27 16:00</div><div class="msg">Yes, I see, trying to figure out what?s going on, can't really simulate it on my local dev machine, can you (as you have Linux I guess) ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 16:05</div><div class="msg">I commented the line in the CI to see how it goes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 16:05</div><div class="msg">my guess is that because the react-native version changed, this file that sed was changing is not there anymore</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 16:10</div><div class="msg">it passed so its building android now</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 16:30</div><div class="msg">ok got timeout the sed was for timeout, the file is now in metro-bundler package so I changed the sed line</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-27 16:47</div><div class="msg"><!channel> Please give your feedback on <a href="https://github.com/status-im/status-react/pull/2502">https://github.com/status-im/status-react/pull/2502</a>
|
|
|
|
2 things to discuss:
|
|
- introduction of generative testing
|
|
- having all specs in one place
|
|
|
|
Regarding the generative testing I have been thinking about it but lacked the time to do and this guy seems to know what he's doing. Once we have node bindings and can run more complete tests we can even reuse it to generate user events and check for invariants on app-db, run tests forever and let the runner find bugs for us :slightly_smiling_face:
|
|
|
|
Regarding having all specs in one place it will make it easier to avoid duplicated models for the same things and less require but I am not sure it is a good idea or even necessary for generative testing to work.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 11:05</div><div class="msg">@janherich so regarding the build it seems that metro-bundler which replaces the packager doesn't terminate the way the packager was</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 11:05</div><div class="msg">so that's why the jenkins build timeouts because the metro-bundler never terminates, my build script as the same problem now, when I run it it stops at metro-bundler and doesn't run lein repl because of that</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 11:07</div><div class="msg">and their website omg it's only todos there is no doc :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 11:14</div><div class="msg"><!channel> I think we have a problem with our PR, we have already a few and will have more soon, but we don't have any tester</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-28 11:22</div><div class="msg">Ugh, for widely used library from facebook, I would be expecting little bit more :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-28 11:23</div><div class="msg">What do you mean by that ? Aren?t `9-developer-xp` PRs tested in exactly the same way as any other PRs ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 16:26</div><div class="msg"><a href="https://status-im.slack.com/archives/G6GCQH57X/p1511886243000434">https://status-im.slack.com/archives/G6GCQH57X/p1511886243000434</a> since this relates to dev XP</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 16:26</div><div class="msg">um, Someone who likes shell scripts, please review <a href="https://github.com/status-im/status-react/pull/2525">https://github.com/status-im/status-react/pull/2525</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 16:26</div><div class="msg">I'm not sure about the 10 different files things, dunno what you guys think</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 16:36</div><div class="msg"><a href="https://github.com/status-im/status-react/pull/2525#issuecomment-347582690">https://github.com/status-im/status-react/pull/2525#issuecomment-347582690</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 20:04</div><div class="msg">I approved because I find it quite readable and understandable for bash, it uses recommended tools but fallsback to default ones when they are not here, and it is all in a separate directory so doesn't really impact current state of things.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 20:05</div><div class="msg">Now it's a tricky one to test though</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 20:11</div><div class="msg">doesn't have to be super tested I think</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 20:12</div><div class="msg">just sanity check, does it abort on big error, does it kind of do what it is supposed to od</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 20:19</div><div class="msg">```dbalatero commented 41 minutes ago
|
|
i also wanted to try Lumo, so voting for it
|
|
I'm looking at Lumo, but not seeing great use cases for bootstrapping a bunch of different dependencies via shell commands. Also the setup requirements currently don't seem to require having a Clojure environment, they're just shell commands to be run in sequence.
|
|
|
|
Besides "Lumo looks cool, I want to try it" (which is understandable), can someone articulate why this would be a better choice for shell scripting, which Bash does well (and is fairly portable)?```</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-28 20:19</div><div class="msg">@oskarth don't you like this guy :smile: ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-28 20:20</div><div class="msg">haha yes!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-10-03/448433513781_35b198abdf960e874693_72.png" /><div class="message"><div class="username">jarradhope</div><div class="time">2017-11-29 03:33</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-29 08:40</div><div class="msg">openbounty in action, first contribution for re-frisk, really helpfull functionality</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-29 08:46</div><div class="msg">Awesome! Now I want to add bounty to re-frisk :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-29 08:58</div><div class="msg">and it works for this crazy structure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-29 10:48</div><div class="msg">do you have the same issues with cursive right now?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-29 10:48</div><div class="msg">I've updated it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-29 10:48</div><div class="msg">and seems like it ruins everything</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-29 10:48</div><div class="msg">ruins formatting of all clj and cljs files</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-29 10:51</div><div class="msg">better to switch to emacs then</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 10:52</div><div class="msg">I wanted to suggest that but didn't want to act like a troll :laughing:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-11-29 10:52</div><div class="msg">:slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-29 10:53</div><div class="msg">I have not updated yet.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-11-29 10:53</div><div class="msg">Are you sure you didn't install some emacs plugin by mistake? :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-29 10:54</div><div class="msg">Who is a fan of Emacs here raise your hands (and everything works perfectly always with no configuration changes)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 20:58</div><div class="msg">@janherich My refactoring of discover was a bit incomplete, for instance previously the tags were updated by getting all tags from realm, and the whole tag counts was done in realm namespace. So I started to look at how I could move that to the general discover namespace. But now I realize that we never actually read discoveries except when we receive a discovery request, which could be answered simply by using app db.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-29 21:03</div><div class="msg">@yenda any opportunity to get rid of the realm reads is great ! There are couple of other realm schemas/related ns which we don't use anymore (such as handler-data), I will get rid of them as well.
|
|
One question, will your discover refactoring affect subscriptions as well ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 21:06</div><div class="msg">damn I missed the navigation preload stuff that's were it was loading that explains why when I could still see the discoveries in my tests</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 21:07</div><div class="msg">It won't touch the subs no but tags is a 1st level sub which is bad</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 21:07</div><div class="msg">I can change that. unless you are asking because you want to do it ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-29 21:12</div><div class="msg">Which subscription do you mean now, `:get-popular-tags` ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 21:20</div><div class="msg">sorry my bad was not talking about subscriptions but db :smile: The refactoring was only touching events so there is no subscription changes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-29 23:02</div><div class="msg">Ok, great :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-29 23:08</div><div class="msg">put the current behavior of the discover is really non-sensical for me</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 08:26</div><div class="msg"><a href="https://github.com/status-im/status-react/pull/2525#discussion_r154008572">https://github.com/status-im/status-react/pull/2525#discussion_r154008572</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 08:26</div><div class="msg">btw we could add leiningen aliases, something like
|
|
```
|
|
:aliases {"status-genymotion"
|
|
["do"
|
|
["shell" "./re-natal" "use-android-device" "genymotion"]
|
|
["shell" "./re-natal" "use-figwheel"]
|
|
["re-frisk" "use-re-natal"]]
|
|
```
|
|
and use it
|
|
`lein status-genymotion`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 11:54</div><div class="msg">Congrats for the re-frisk update @andrey it's really awesome you made debugging great again ! :angry_trump:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 13:55</div><div class="msg">what do you mean?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 14:14</div><div class="msg">showing the event that got an error in re-frisk and the timing, it rocks</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 14:28</div><div class="msg">oh ok, tomorrow will be two more interesting features :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 15:03</div><div class="msg">:awwyeah:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 15:31</div><div class="msg">@janherich what do you think of this <a href="https://github.com/status-im/status-react/pull/2483/files">https://github.com/status-im/status-react/pull/2483/files</a>, experimenting with data-store as side effects, this is still wip</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 15:35</div><div class="msg">since according to the discover idea <a href="https://github.com/status-im/ideas/issues/8">https://github.com/status-im/ideas/issues/8</a> there is at most 1000 discovers it is reasonnable to assume we can hold it all in app-db, especially since it was done before anyway, so the datastore only purpose is to be able to save them for retrieval at app-startup</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-30 15:56</div><div class="msg">I think it's great and I like the idea of moving relevant effects into `data-store` namespaces, as it's much easier to *not duplicate* those effects by accident.
|
|
The only thing which I don't like is how `::get-all` effect is coded, there is too much logic in it, effects should be minimal, super thin wrappers around side-effect calls and any logic which could exists as a plain function should be defined as such.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-30 15:57</div><div class="msg">I also think that instead of the implicit name-spacing `::`, we should use explicit namespaces for effects/co-effects keywords, or no namespaces at all, if it's truly global effect</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 15:59</div><div class="msg">you are right I will replace by explicit data-store.discovers</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 15:59</div><div class="msg">even if they are global it gives good info</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 18:48</div><div class="msg">updated to latest idea and cursive, yeah it's super cool navigate to keyword, but it works only for namespaced keywords and we have our register-handler-fx , so nothing interesting for us :disappointed: that's sad</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 20:15</div><div class="msg">Hey swarm, any idea about these event overwrite warnings? Does it seem possible to remove them? Didn't look into code in detail cause not high prio but it'd be nice to make test output less verbose :slightly_smiling_face: <a href="https://gist.github.com/oskarth/9acf7a5d7b80c85f2b01be19eeedb55a#file-gistfile1-txt">https://gist.github.com/oskarth/9acf7a5d7b80c85f2b01be19eeedb55a#file-gistfile1-txt</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-30 20:39</div><div class="msg">That would be quite complicated as it would require forking re-frame and changing the logic there.
|
|
But those warning are symptoms, rather then issues - it means that we have to overwrite certain event handlers because they are not pure (they are directly causing/consuming some side effects) so we have to mock them during tests.
|
|
Once we do it properly and get rid of the imperative code, they will disappear, so let?s leave them as a gentle remainder than we still have some work to do in achieving clean, nice and idiomatic `re-frame`/`clojurescript` code :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 20:41</div><div class="msg">> symptoms, rather then issue
|
|
yeah I know, that's what I'm referring to :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 20:42</div><div class="msg">the root issue I mean</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 20:42</div><div class="msg">we're rewriting fx and cofx , so our code nice and idiomatic :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 20:42</div><div class="msg">those warnings are with fx though, no?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-11-30 20:42</div><div class="msg">and we can see in logs what exactly we override for tests ,so</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-30 20:43</div><div class="msg">My bad, I thought we are overwriting handlers itself? Then @andrey is right, nothing wrong there?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 20:51</div><div class="msg">so what does this mean?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 20:51</div><div class="msg">it'd be nice not to see right? so real errors are more clear in tests</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-11-30 20:54</div><div class="msg">In my opinion it's not worth the effort. You always have test summary at the end of the test run, and you can always `grep` for specific for `error`/`failure` whatever</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-11-30 21:04</div><div class="msg">ok</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-11-30 23:52</div><div class="msg">But I understand Oskarth it is noisy, maybe we could put that as a bounty ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 03:37</div><div class="msg">@janherich btw I changed the subs in discover (I think you asked about that yesterday ?)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-01 05:53</div><div class="msg"><a href="https://github.com/Day8/re-frame/issues/204#issuecomment-250337344">https://github.com/Day8/re-frame/issues/204#issuecomment-250337344</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-01 07:29</div><div class="msg">Morning! Any news about RN migration?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 07:34</div><div class="msg">I wasn't able to build on Jenkins</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-01 07:36</div><div class="msg">Is that a blocker?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 07:37</div><div class="msg">Yes it's the last step before testing but I couldn't figure out what was happening and moved to other things penning to come back to it later</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 07:38</div><div class="msg">I think it is also related to the fact that `react-native run-android` doesn't terminate anymore</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-01 07:38</div><div class="msg">`react-native` ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 07:39</div><div class="msg">Yes sorry</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-01 07:39</div><div class="msg">weird</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 07:40</div><div class="msg">Btw @janherich do you notice that on iOS as well ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-01 07:40</div><div class="msg">It would be great to finally tackle this one. We have a bunch of PR / simplifications waiting</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-01 08:42</div><div class="msg">@oskarth ^</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-01 09:09</div><div class="msg">That?s fine, just one of us will have to rebase his PR, depending on which will get tested sooner :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-01 09:10</div><div class="msg">@yenda I will have to double check, but I?m almost 100% sure, that `react-native run-ios` terminates just as before</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-01 11:37</div><div class="msg"><a href="https://github.com/drapanjanas/re-natal/releases/tag/v0.8.0">https://github.com/drapanjanas/re-natal/releases/tag/v0.8.0</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 11:45</div><div class="msg">let's break all the things :aw_yeah:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-01 11:57</div><div class="msg">clojureteam to use whisper in status desktop i need to refactor `status-im.protocol` to use fx and cofx, just fyi i'm working on this</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 12:01</div><div class="msg">awesome I wanted to work on it for a while, good to know it's in scope :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2017-12-01 15:01</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-01 19:58</div><div class="msg">Swarm, ready for review (weird pipeline on this one, in testing first): <a href="https://github.com/status-im/status-react/pull/2564#issuecomment-348599351">https://github.com/status-im/status-react/pull/2564#issuecomment-348599351</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-01 20:09</div><div class="msg">@andrey I tried the update and it didn't change anything compare to what we had alreday</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-02 05:06</div><div class="msg">@yenda isnt this your forte <a href="https://github.com/status-im/status-react/pull/2574#issuecomment-348666237">https://github.com/status-im/status-react/pull/2574#issuecomment-348666237</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-02 05:07</div><div class="msg">The comment about dockerization </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-02 06:31</div><div class="msg">You guys we should really be nice to this guy Charlesg3 - he seems to have his stuff together with clojure - make him feel at home
|
|
|
|
Strong GH profile - <a href="https://github.com/charlesg3?tab=overview&from=2017-09-01&to=2017-09-30&utf8=?">https://github.com/charlesg3?tab=overview&from=2017-09-01&to=2017-09-30&utf8=?</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-02 06:34</div><div class="msg">he?s thinking about docker for these reasons and needs some guidance
|
|
```I like having docker and then integrating it into CI so that CI can start from scratch much like a new person would and makes sure that all the deps and what not work
|
|
|
|
so basically it tests your install setup so that you don't introduce a bug and then not find out until someone new runs into it (sometime later)
|
|
so once CI is setting up everything in docker from scratch you don't have the "works on my machine" issue ever because CI is the gold standard
|
|
|
|
and you can confidently check out master fresh and spin things up new in a blank environment and know you're starting from the same place as everyone else ```
|
|
|
|
Should we cater to this external dev contributor need or is there a better solution?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-02 06:34</div><div class="msg">@oskarth chill on the coffee before you react to this guy. Drink some of that chamomile. :verynice: </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-02 06:35</div><div class="msg">So just let me know ? he?s @charlesg3:<a href="http://status.im">http://status.im</a> on riot .</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-04 17:14</div><div class="msg">@roman if you have time could you look at the react-native-update branch ? For some reason it doesn't build on Jenkins, the Android build is hanging during bundling</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-05 13:45</div><div class="msg">What do you guys think of the cider guy ? <a href="https://github.com/bbatsov">https://github.com/bbatsov</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-05 13:52</div><div class="msg">Well, he is famous :slightly_smiling_face: Do they use Clojure at Toptal ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-05 13:57</div><div class="msg">No ruby</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-05 13:58</div><div class="msg">He could be interested to work with us</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-05 14:25</div><div class="msg">-1 for emacs</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-05 14:30</div><div class="msg">We have almost emacs / cursive parity, he would definitively break this! :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-05 14:31</div><div class="msg">He could cure you</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-05 14:33</div><div class="msg">I am guilty of vim sin</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-05 17:37</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-05 18:06</div><div class="msg">Hi XP swarm. Is it a good place to report building/compilation error? I can't build status-react for iOS, getting the compilation error. And I'm pretty sure it's not a code problem (it works for others), but something with build process.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-05 18:08</div><div class="msg">I get stuck on the same problem trying to build. (still might be my xcode though)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-05 18:09</div><div class="msg">The same? Did you see my logs from another commit?
|
|
|
|
It's:
|
|
```
|
|
$ react-native run-ios
|
|
...
|
|
status-react/node_modules/react-native-mapbox-gl/ios/RCTMapboxGL/RCTMapboxAnnotation.h:3:9: fatal error: 'Mapbox/Mapbox.h' file not found
|
|
#import <Mapbox/Mapbox.h>
|
|
^~~~~~~~~~~~~~~~~
|
|
|
|
|
|
** BUILD FAILED **
|
|
```</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-05 18:11</div><div class="msg">I was debugging this issue a few month ago, and it was related to the npm module for the status-react mapbox code.
|
|
|
|
I tried pretty much everything and it didn't work (there are some scripts that download archive during install, and some mess with choosing directory, etc, so code with that header ends up in a wrong dir).
|
|
|
|
I have no idea why it works for others though.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-05 18:20</div><div class="msg">Ill let you know if its same build error</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-05 19:42</div><div class="msg">Another docs/usability suggestions for this doc: <a href="https://wiki.status.im/Building_Status">https://wiki.status.im/Building_Status</a>: Make better comments/explanations on what each command does and why it is needed.
|
|
|
|
Examples:
|
|
- `re-natal use-figwheel` - without googling I can't figure out what does "re-natal use-figwheel" mean ? these words have no meaning for non-CLJ devs, so you're just typing cryptic words, hoping that it works.
|
|
- `lein repl` ? "run figwheel REPL" is confusing: why do I need REPL at all? I just want to build and app and start it (two commands, ideally). Apparently, build will fail if REPL is not started (I'm not sure though), so it's better to explain in docs.
|
|
- few commands in a row (like `adb reverse`) better to write without `$` because most likely they'll be used with copy-pasting.
|
|
- I would also split iOS and Android instructions into two separate sections, because now reader should manually pick up lines he/she interested in and that makes experience worse.
|
|
|
|
Also, `Contributing` section is probably a good candidate for its own page ? it's quite large (almost half of the document) and looks like quite separate and important topic from "how to build status app".</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-05 20:09</div><div class="msg">I think @jeluard made a clever proposal with lumo I talked with Antonio Monteiro ans we should make issues with bounties to automate everything with lumo</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-05 20:10</div><div class="msg">We would contribute to make the cljs ecosystem on which we rely heavely better and make our life and the life of contributors easier</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-05 20:11</div><div class="msg">how would using lumo solve any of the individual pain points @divan brought up? sorry it's a serious question, lumo seems ace but I don't see the fit</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-06 08:14</div><div class="msg">By the way, this one is ready:
|
|
<a href="https://github.com/status-im/status-react/pull/2572">https://github.com/status-im/status-react/pull/2572</a>
|
|
|
|
send-message refactoring as also almost ready</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-06 08:14</div><div class="msg">And good morning, guys :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-06 08:16</div><div class="msg">It requires rebase.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-06 08:18</div><div class="msg">I think we can use it as advanced scripting system to reduce the number of commands we have to chain and reduce the potential of inconsistencies.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-06 08:18</div><div class="msg">Ideally we shouldn't use `re-natal` at all and have much less commands to run</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-06 09:09</div><div class="msg">@alwx please don't commit changes which have nothing to do with the PR, your PR is almost 800LOC, ~450 from that is package-lock.json (which we shouldn?t commit at all) and another more then 100LOC just formatting changes in the `send-message` ns.
|
|
PR with 250LOC of actual changes would be kind of nicer to review.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-06 10:06</div><div class="msg">sorry for package-lock, it should be added to .gitignore, of course
|
|
will fix the PR</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-06 11:30</div><div class="msg">Sure. What do you think @divan should do in meanwhile?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-06 11:33</div><div class="msg">There is definitively room for improving the doc</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-06 11:39</div><div class="msg">is this within scope of this swarm or not? I forgot</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-06 11:52</div><div class="msg">Can't add it to gitignore though because in theory it is versionned to avoid unwanted updates of deep deps</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-06 11:54</div><div class="msg">It contributes to improving developer experience but we shouldn't do it ourself thats the kind of stuff that we can use SOB for. Nothing to do with divan comment I was not responding to him</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-06 11:56</div><div class="msg">oh I misunderstood you then, thought it was in response to his problems</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-06 12:04</div><div class="msg">Yes, just pick whatever changes are relevant for the PR and don't commit everything changed in the namespace.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 21:08</div><div class="msg">@roman @janherich the react native update branch is building on jenkins</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 21:09</div><div class="msg">I will rebase and then we can leave it to test team</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-08 21:48</div><div class="msg">Wonderful ! If there are any XCode conflicts (they may be, because of the JSC dependency added recently), I will help with that.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 21:49</div><div class="msg">ok can you check ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 21:49</div><div class="msg">I just pushed the rebase</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-08 21:57</div><div class="msg">I just checked in the github interface, sounds good, nothing suspicious in the XCode project file</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 22:00</div><div class="msg">so much emotion seeing the build all green :cry:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 22:00</div><div class="msg">there was a line in the xcodeproject removing protobuf is that right ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-08 22:01</div><div class="msg">Yes, because now that dependency is handler via Cocoapods</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-08 22:01</div><div class="msg">*handled</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 22:01</div><div class="msg"><a href="https://github.com/status-im/status-react/pull/2217/files#diff-37a5e7e8637d6fd3df5179385f88c2bfL55">https://github.com/status-im/status-react/pull/2217/files#diff-37a5e7e8637d6fd3df5179385f88c2bfL55</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-08 22:01</div><div class="msg">ah ok great</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 11:31</div><div class="msg">@janherich apparently the ios build for react native update is not starting <a href="https://i.diawi.com/W9A8hm">https://i.diawi.com/W9A8hm</a> can you check if it still works ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 11:31</div><div class="msg">maybe I screwed up the rebase ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-11 11:32</div><div class="msg">@yenda that's a bummer, I can't check it right now, as I?m in the middle of something else and really, really don't want to switch branches now, but I will get to that later</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 11:32</div><div class="msg">ok thanks !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 19:47</div><div class="msg">@janherich I fixed the 2 bugs that @nastya found in android, or at least one, for the keyboard I am not sure because it's a bug specific to some real device (but not mines)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 19:47</div><div class="msg">did you have any time to look at iOS ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-11 19:48</div><div class="msg">@yenda Not yet, still fully occupied with message data model refactoring and associated changes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 19:50</div><div class="msg">ok make it pretty :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-11 19:51</div><div class="msg">@alwx how are you doing with the chat refactoring ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-11 23:20</div><div class="msg">the most difficult thing I need to do now is rebasing. after it I will be able to push my changes to `send-message` namespace
|
|
but I have one problem: `npm i` simply hangs on my machine with no reason. I tried to clone the repo and do it again, but same problem happens
|
|
|
|
`npm -v` gives `5.6.0`
|
|
|
|
have you ever faced something like this?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 02:41</div><div class="msg">Message data model refactoring PR ready - <a href="https://github.com/status-im/status-react/pull/2692">https://github.com/status-im/status-react/pull/2692</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 02:42</div><div class="msg">This one is big step towards simpler and more logic free views, among other thing, I remember we talked about that some time ago @yenda</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 04:11</div><div class="msg">I don't have my 2 factor authentication on my phone</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 04:11</div><div class="msg"><a href="https://github.com/status-im/status-react/pull/2692/files#diff-10d1268b133286df73b15989d7e84c3dR183">https://github.com/status-im/status-react/pull/2692/files#diff-10d1268b133286df73b15989d7e84c3dR183</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 04:11</div><div class="msg">Seems like you should return effects here not db</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 04:12</div><div class="msg">There might be other places like this double check please</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-12 06:41</div><div class="msg">have you tried --verbose? i think @goranjovic had similar problem?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 07:15</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 07:17</div><div class="msg">Yeah, I think I solved it by downgrading node to v8.1.4 - It works now but I'm not sure if that's what fixed the issue, though</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 07:43</div><div class="msg">```
|
|
yenda@yenda-desktop:~/status-react$ npm -v
|
|
5.3.0
|
|
yenda@yenda-desktop:~/status-react$ node -v
|
|
v8.5.0
|
|
```</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 07:43</div><div class="msg">now I am afraid of ever upgrading :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 07:44</div><div class="msg">Does the build work for you @yenda ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 07:44</div><div class="msg">ok bugs are fixed please look at the iOS today my mac mini is not ready for battle yet :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 07:44</div><div class="msg">yes sure</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 07:45</div><div class="msg">I am rebuilding from scratch everytime I switch branch</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 09:50</div><div class="msg">Sure !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 09:50</div><div class="msg">And thanks for fixing the bugs</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 09:51</div><div class="msg">thanks for thanking me for doing my job lol :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 09:52</div><div class="msg">Well, technically, we are both working on the PR, so you could just say, please make the iOS work *and* fix those pesky ui bugs while doing so :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 09:56</div><div class="msg">well you are working on more urgent things than me</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 09:56</div><div class="msg">I would do the iOS as well if I could</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 09:56</div><div class="msg">soon I will have the mac mini ready but I need cables</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 14:21</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 14:21</div><div class="msg">I have the same problem....</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 14:24</div><div class="msg">which version of npm ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 14:25</div><div class="msg">I tried checking out project and building from scratch, using old shell commands, and the new setup script, restarting networking daemon (and turning wifi on and off again), downgrading node and clearing node cache. Tried all of that on both mac an linux. Then it started working at some point.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 14:26</div><div class="msg">But it only worked once, yesterday. I'm a bit reluctant to try deleting and building again. @yenda In my case `5.0.3`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 14:27</div><div class="msg"><a href="https://github.com/yenda/dotfiles/blob/master/status/status">https://github.com/yenda/dotfiles/blob/master/status/status</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 14:28</div><div class="msg">this is what I run everytime</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 14:29</div><div class="msg">Yep, that's exactly what my script does as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 14:29</div><div class="msg">The step at `npm install` gets nuked</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 14:32</div><div class="msg">> which version of npm ?
|
|
5.6.0</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 14:45</div><div class="msg">so @goranjovic for you it also doesn't work on linux ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 14:47</div><div class="msg">For me it works on linux now. Not sure about mac, once I got it working on linux, I stopped trying. But it didn't work on both machines.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:11</div><div class="msg">it seems like it is due to node update then</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:11</div><div class="msg">@roman still not working for you ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:11</div><div class="msg">have you tried downgrading node ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 15:12</div><div class="msg">Yes I tried </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 15:12</div><div class="msg">It?s not working </div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:13</div><div class="msg">which version ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 15:17</div><div class="msg">Ok I tried to install it via installer from <a href="https://nodejs.org/en/download/">https://nodejs.org/en/download/</a> and it works now</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:18</div><div class="msg">ok nice which version :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:18</div><div class="msg">it seems like there is some versions not working we should list them</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 15:18</div><div class="msg">Versions are:
|
|
```
|
|
? ~ node -v
|
|
v8.9.3
|
|
? ~ npm -v
|
|
5.5.1
|
|
```</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:19</div><div class="msg">ok so maybe it's 5.6.0 that doesn't work</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-12 15:19</div><div class="msg">Looks like </div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 15:19</div><div class="msg">@goranjovic which one do you have on your mac if it still doesn't work ? 5.6.0 ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/a5f396eba057f6f6ce181fd462ff2b1a.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0025-72.png" /><div class="message"><div class="username">goranjovic</div><div class="time">2017-12-12 15:26</div><div class="msg">@yenda No, it's `5.0.3` same as on linux. I'm giving it another shot. This time I'll delete brew installed node and npm and try with `scripts/setup` to see if it works.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 18:30</div><div class="msg">@yenda I?m testing the react-native update on iOS, everything is going well, except one thing, styling seems little bit off, more specifically the text in the input seems to be higher then it should (top margin should be greater).
|
|
Did you also experienced the same thing on android ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 18:52</div><div class="msg">I wouldn't notice I have the worst eyes for these things :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 18:56</div><div class="msg">@janherich did you try the iOS package btw, not dev ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 18:58</div><div class="msg">@janherich see my screenshot for what I have in android (if I understand correctly)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-12 19:00</div><div class="msg">share yours please so I get a better understanding of the problem</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 19:09</div><div class="msg">Ok, then it's ios only styling issue, I will fix it and branch is ready to be tested again (well after jenkins starts behaving :slightly_smiling_face: )</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 19:10</div><div class="msg">I tried the prod build with XCode, builds fine</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 20:21</div><div class="msg">iOS styling issue fixed, everything seems to be working, *except* that I now noticed that figwheel reloading doesn?t work? I have to find out why</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 21:03</div><div class="msg">Ok, just the main dev namespace for ios was outdated, already fixed, figwheel & re-frisk now work without problems, branch is ready to be tested again :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 21:05</div><div class="msg">@yenda ^</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-12 23:15</div><div class="msg">Yeah, I saw that, the style problem was ios only, on yor screenshot, everything appears to be ok</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 07:02</div><div class="msg">Branch: status-im:update-react-native
|
|
Android: <a href="https://i.diawi.com/NWoJfd">https://i.diawi.com/NWoJfd</a>
|
|
iOS: <a href="https://i.diawi.com/ko1Uim">https://i.diawi.com/ko1Uim</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 07:02</div><div class="msg">Have you tried installing the app on a device ? I think that is what doesn't work</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 07:03</div><div class="msg">@nastya @janherich</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 08:18</div><div class="msg">@yenda @janherich Are we good with latest RN now?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 08:18</div><div class="msg">:slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 08:23</div><div class="msg">on android side yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 08:23</div><div class="msg">not sure about iOS waiting for @nastya update</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:43</div><div class="msg">i cant solve this problem when running `react-native start` after installing deps via `npm@5.5.1`
|
|
```
|
|
error: bundling: UnableToResolveError: Unable to resolve module `react-native-android-sms-listener` from `/Users/romanvolosovskyi/clj/status-react/index.ios.js`: Module does not exist in the module map or in these directories:
|
|
/Users/romanvolosovskyi/clj/status-react/node_modules
|
|
|
|
This might be related to <a href="https://github.com/facebook/react-native/issues/4968">https://github.com/facebook/react-native/issues/4968</a>
|
|
To resolve try the following:
|
|
1. Clear watchman watches: `watchman watch-del-all`.
|
|
2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.
|
|
3. Reset packager cache: `rm -fr $TMPDIR/react-*` or `npm start --reset-cache`.
|
|
at p.catch.error (/Users/romanvolosovskyi/clj/status-react/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:366:19)
|
|
at <anonymous>
|
|
at process._tickCallback (internal/process/next_tick.js:188:7)
|
|
```</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:49</div><div class="msg">`react-native-android-sms-listener` is not installed for no reason</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 08:52</div><div class="msg">in develop ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 08:54</div><div class="msg">all this crap in our toolchain is really worrying me</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:57</div><div class="msg">yes, develop</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:57</div><div class="msg">i?m trying different version of npm at the moment</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:57</div><div class="msg">5.5.1 doesn?t install `react-native-android-sms-listener`, `5.6.0` just hangs :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:58</div><div class="msg">trying `5.3.0`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 08:58</div><div class="msg">5.3.0 works smoothly for me</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 08:58</div><div class="msg">but this is insane</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-13 08:59</div><div class="msg">i have 5.5.1 works fine</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 08:59</div><div class="msg">do you have `node_modules/react-native-android-sms-listener` dir locally?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-13 09:00</div><div class="msg">i have</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:01</div><div class="msg">yeah, but i don't :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:01</div><div class="msg">it just stopped working for no reason</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:05</div><div class="msg">seems that `npm cache clear --force` helps. I tried this yesterday but it didn't help</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:05</div><div class="msg"><a href="https://status-im.slack.com/archives/G6GCQH57X/p1513089752000365?thread_ts=1513087822.000557&cid=G6GCQH57X">https://status-im.slack.com/archives/G6GCQH57X/p1513089752000365?thread_ts=1513087822.000557&cid=G6GCQH57X</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:06</div><div class="msg">probably because clear/clean idk</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:07</div><div class="msg">hm nope, that's the same command?.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 09:08</div><div class="msg">but anyway, it works now with 5.5.1 and i don't want to check 5.6.0</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 09:22</div><div class="msg">@janherich <a href="https://i.diawi.com/pXnVqn">https://i.diawi.com/pXnVqn</a> this is the latest build it doesn't start at all on real device. is there a way to troubleshoot this ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 09:26</div><div class="msg">I didn't troubleshoot such situation yet (build only not working on a real device), let me have a look at the jenkins logs for the build</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 09:27</div><div class="msg"><a href="https://jenkins.status.im/job/status-react/job/parametrized%20build/103/consoleFull">https://jenkins.status.im/job/status-react/job/parametrized%20build/103/consoleFull</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:09</div><div class="msg">i?m trying to fix this now</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:53</div><div class="msg">looks like that branch is broken</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 14:53</div><div class="msg">I just realised that the branch was not rebased onto develop for some time</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:54</div><div class="msg">ok nice :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:54</div><div class="msg">i tested `develop` in parametrized pipeline and it works fine</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 14:54</div><div class="msg">@roman How so, where it fails ? It was working quite well for me yesterday (dev mode on simulator), although I didn't tried it on real device</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:55</div><div class="msg">i?m not sure where exactly it fail, though there are no error, but app can't be started on iOS</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:55</div><div class="msg">as i said the same scenario works for develop</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-13 14:55</div><div class="msg">so this is not related to job itself</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 14:56</div><div class="msg">I will try to rebase and we will see</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 15:19</div><div class="msg">Ok, now after rebase, the app doesn?t start in develop as well, that's better, because it's easier to investigate and fix it :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 16:01</div><div class="msg">can you explain I don't get it ? I rebased just before the build</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 16:01</div><div class="msg">@janherich</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 16:02</div><div class="msg">and you rebased develop on what ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 16:04</div><div class="msg">I didn't rebase after my changes (styling + figwheel). It?s still super strange, because the build *was* working for me in dev mode before rebase, now i did the rebase and it's not</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-13 16:04</div><div class="msg">I?m investigating</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 16:06</div><div class="msg">ah ok you meant dev mode not develop branch I was confused :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 16:06</div><div class="msg">but still I rebased after your changes already</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-13 16:06</div><div class="msg">maybe you just didn't pull or you needed to reset your local repo to have it pulled in the way it is on github ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 17:41</div><div class="msg">What do you think of creating Makefile for `status-react`? I realized that just to build it, I need to go to wiki and copy-paste a bunch of commands, and Makefile is a perfect tool to make life easier in such a case.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 17:42</div><div class="msg">Doc from github wiki leads to <a href="https://wiki.status.im/Contributing/development/building-status/">https://wiki.status.im/Contributing/development/building-status/</a> with `There is currently no text in this page.` content.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 17:44</div><div class="msg">We have scripts, doc is not uptodate. @cryptowanderer is on it I believe</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 17:46</div><div class="msg">What scripts do you mean?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 17:47</div><div class="msg">See `scripts`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 17:50</div><div class="msg">Thanks. Script `scripts/build-android.sh` seems to be very different from what's in `Building Status` doc. What should I use to build Android apk?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 17:52</div><div class="msg">`build-android.sh` is for building a prod apk so it's not for status-react devs that expect their changes to be reflected in real time</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 17:53</div><div class="msg">Ah, okay. So my question about moving building status instructions into Makefile still holds true.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 17:55</div><div class="msg">Not sure which part should be moved to a makefile then. Do you need to have clojure changes picked up at runtime?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 17:55</div><div class="msg">What do you mean by "clojure changes picked up at runtime"?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 17:57</div><div class="msg">You make a change in clojure code, it's deployed in your app. I don't think you want that.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 18:03</div><div class="msg">Let me rephrase my original message.
|
|
|
|
Currently the developer experience for anyone who wants to build `status-react` is following:
|
|
- clone repo
|
|
- read the README
|
|
- find the wiki page with building instructions
|
|
- copy-paste and execute bunch of commands, carefully extracting only needed parts (i.e., only for iOS or Andorid) from it
|
|
|
|
I guess it would be much nicer developer experience if that workflow was:
|
|
- clone repo
|
|
- read the README
|
|
- execute two or three commands:
|
|
- `make deps` (or `make prepare` whatever
|
|
- `make build-android` or `make build-ios`
|
|
|
|
Would much better experience, in my opinion.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-13 18:04</div><div class="msg">There are more options that what you describe but yes we have that. Doc must be updated</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 18:06</div><div class="msg">Of course, there are more options.
|
|
|
|
Where do we have that? How can I prepare workspace and build apk file without copy-pasting from the doc?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-13 22:07</div><div class="msg">Where is this doc @divan? Also going to remove sauce labs / that broken image from status react readme when back to my machine. </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-13 22:09</div><div class="msg">Agreed @divan the developer first time setup is cumbersome and confusing - I actually tried to use the script yesterday unsuccessfully so need to get with @cryptowanderer or Dbalarto (the guy who made it) about understanding the flow and updating the wiki </div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-05-11/181684552369_66f21f8981bdb0f83bdd_72.jpg" /><div class="message"><div class="username">cryptowanderer</div><div class="time">2017-12-13 22:09</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-13 22:58</div><div class="msg">Okay, so that's my attempt to improve the situation: <a href="https://github.com/status-im/status-react/pull/2715">https://github.com/status-im/status-react/pull/2715</a>
|
|
|
|
Actually I think it's a good idea to "switch roles" from time to time and status-react developers to try build/rebuild status-go and for Go devs to build/rebuild status-react. It should be effective to get this "new eyes look" and combat knowledge bias (when you know your topic so well, that you think it's obvious for everyone and it's hard to realize what people might not know or understand).</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 08:37</div><div class="msg">@nastya @janherich let's discuss the update-react-native branch in this thread</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 08:37</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 08:38</div><div class="msg">so @nastya the build still doesn't start on iOS ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 08:38</div><div class="msg">yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 08:38</div><div class="msg">and still no logs ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 08:39</div><div class="msg">how did @roman get the logs last time ? I would like to know if we still get
|
|
|
|
'Dec 13 18:06:22 iPhonerv StatusIm[283] <Notice>: undefined is not an object (evaluating 'i.View.propTypes.style')''</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 08:40</div><div class="msg">x-code?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 08:41</div><div class="msg">I dont have x-code on my machine</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 08:53</div><div class="msg">Just one question @nastya, yesterday, when you got that branch started and reported <a href="https://github.com/status-im/status-react/issues/2709">https://github.com/status-im/status-react/issues/2709</a>, did you use local build provided by @roman, or diawi build ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-14 08:54</div><div class="msg">@hutch it's in Github Wiki page of `status-react`. So you go to the status-react repo, click Wiki on the top, click "Developers` Guide" and the link there points to the nonexistent page in Wiki.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 08:55</div><div class="msg">@janherich it was the build Roman built locally. All others are not lauchable for this current branch</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 08:59</div><div class="msg">Than it's something related to fetching npm dependencies on jenkins?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 09:01</div><div class="msg">yes @janherich can you amend your latest commit ? you need to delete the package.lock, rebuild and commit the new one with new commit hash for this package probably</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 09:03</div><div class="msg">if you are too busy I can do it later I am setting up osx at the moment</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 09:03</div><div class="msg">Oh, I see, i will do the new commit, we need to later squash all the commits in the branch anyway :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 09:13</div><div class="msg">Done, triggering new build?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 09:25</div><div class="msg">guys i usually get logs from prod build on ios using next command:
|
|
`idevicesyslog | grep --line-buffered "StatusIm\["`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 09:26</div><div class="msg">so i start this in console, then run the app</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 09:26</div><div class="msg">i don't remember how i installed this `idevicesyslog`, but i?m sure you can google this</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 09:27</div><div class="msg">and yeah, phone should be connected via usb</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 09:28</div><div class="msg">is app still crashing? which build? i can check logs</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 09:29</div><div class="msg">afk for 20 minutes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 09:37</div><div class="msg">it should be good @roman the problem was probably that the package.lock was not updated</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 09:39</div><div class="msg">Yes, it was 99% that, we should have a new build soon</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 09:39</div><div class="msg">Actually, we already have it @nastya :
|
|
----------------
|
|
Branch: status-im:update-react-native
|
|
Android: <a href="https://i.diawi.com/7ECWJp">https://i.diawi.com/7ECWJp</a>
|
|
iOS: <a href="https://i.diawi.com/ZiWz4t">https://i.diawi.com/ZiWz4t</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 09:52</div><div class="msg">please @nastya tell me it start :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 09:54</div><div class="msg">it does not.. :worried:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 10:00</div><div class="msg">@janherich :morty: it does not working</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:09</div><div class="msg">Ok, I will investigate on a real device</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:13</div><div class="msg">i?m here, can check logs on real device</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:17</div><div class="msg">```
|
|
Dec 14 12:17:25 iPhonerv StatusIm[763] <Notice>: There was an error collecting entropy from the browser:
|
|
Dec 14 12:17:25 iPhonerv StatusIm[763] <Notice>: { [TypeError: undefined is not an object (evaluating 'i.random')]
|
|
Dec 14 12:17:25 iPhonerv StatusIm[763] <Notice>: undefined is not an object (evaluating 'i.View.propTypes.style')
|
|
Dec 14 12:17:25 iPhonerv StatusIm[763] <Notice>: Unhandled JS Exception: undefined is not an object (evaluating 'i.View.propTypes.style')
|
|
```</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:17</div><div class="msg">same</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:18</div><div class="msg">that's parametrized build?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:19</div><div class="msg">Yes - <a href="https://jenkins.status.im/job/status-react/job/parametrized%20build/117/parameters/">https://jenkins.status.im/job/status-react/job/parametrized%20build/117/parameters/</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:20</div><div class="msg">there is still `style: View.propTypes.style,` in that file</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:20</div><div class="msg">`node_modules/react-native-webview-bridge/webview-bridge/index.ios.js`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:23</div><div class="msg">I?m investigating why my change to `package-lock.json` didn't force npm on jenkins to fetch the correct (fixed) version of the `react-native-webview-bridge` module</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:25</div><div class="msg">Ok, so my commit clearly doesn?t update the `react-native-webview-bridge` section in `package-lock.json` even if it was regenerated on my machine and locak version is pointing to the correct commit hash of that module :confused:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:26</div><div class="msg">did you delete package lock ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:26</div><div class="msg">I don't think it updates</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:29</div><div class="msg">I think it does (the were clearly lot of changes in it from my commit), but I will try to delete&generate and see if the correct change is propagated</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:33</div><div class="msg">Deleted & regenerated, correct commit hash on my local version, still no change to that in git commit?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:35</div><div class="msg">My bad about the previous message, the `package-lock.json` in the `update-react-native` branch indeed *does* point to the correct commit:
|
|
`"github:yenda/react-native-webview-bridge#123e9cb804b10e7517a624edbe57ecf690aa2441"`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:35</div><div class="msg">So the problem seems to be, that for some reason, npm cache is not cleared on jenkins</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:35</div><div class="msg">ok i will remove it manually</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:36</div><div class="msg">hm we have this line `sh 'rm -rf node_modules'`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:36</div><div class="msg">anyway, removed</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:36</div><div class="msg">let?s start build again</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:37</div><div class="msg">And then before @nastya is testing, let?s check the code in the module</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:38</div><div class="msg">wait I don't see my change from yesterday on the repo</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:38</div><div class="msg">Build started</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:39</div><div class="msg">You mean `react-native-webview-bridge` @yenda?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:40</div><div class="msg">I see them there, just squashed in the older commit, so last change show as sometime in november</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:41</div><div class="msg">yes @yenda means `react-native-webview-bridge`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:41</div><div class="msg">the last commit there is the one which i merged</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:42</div><div class="msg">oh it's there</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:42</div><div class="msg"><a href="https://github.com/yenda/react-native-webview-bridge/commit/123e9cb804b10e7517a624edbe57ecf690aa2441">https://github.com/yenda/react-native-webview-bridge/commit/123e9cb804b10e7517a624edbe57ecf690aa2441</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:43</div><div class="msg">@janherich it's 27th of october</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:43</div><div class="msg">that's not the fix I made yesterday</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:43</div><div class="msg">�\_(?)_/�</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:44</div><div class="msg">Oh, yes, it's not there</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:45</div><div class="msg"><a href="https://github.com/yenda/react-native-webview-bridge/blob/master/webview-bridge/index.ios.js#L84">https://github.com/yenda/react-native-webview-bridge/blob/master/webview-bridge/index.ios.js#L84</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:48</div><div class="msg">sorry for that</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:48</div><div class="msg">No problem, I should have checked that yesterday as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:48</div><div class="msg">:facepalm:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:49</div><div class="msg"><a href="https://github.com/yenda/react-native-webview-bridge/commit/eeef40368e88d40d04a040d44544ec6905e38742">https://github.com/yenda/react-native-webview-bridge/commit/eeef40368e88d40d04a040d44544ec6905e38742</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:49</div><div class="msg">this should be it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:49</div><div class="msg">so we just rebuild again I guess ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:49</div><div class="msg">or we need to update package.lock as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:50</div><div class="msg">I think we do :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:50</div><div class="msg">That?s the change, just removing the deprecatedPropType lib in ios code ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:52</div><div class="msg">We still have this - <a href="https://github.com/yenda/react-native-webview-bridge/blob/master/webview-bridge/index.ios.js#L180">https://github.com/yenda/react-native-webview-bridge/blob/master/webview-bridge/index.ios.js#L180</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:52</div><div class="msg">I think so because normally prop-type is not a problem it got moved to another lib but this import is probably shadowing it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:53</div><div class="msg">i can build locally and check</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 10:53</div><div class="msg">it probably will be faster</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 10:54</div><div class="msg">Makes sense actually, because the module code is the same for ios/android *except* for that one import and android doesn?t have the problem, thanks @yenda!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:56</div><div class="msg">no the whole var WKWebView is not there in the android version</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:56</div><div class="msg">but I don't know enough of iOS to know wheither or not this is useful</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 10:59</div><div class="msg">funny on upstream a guy made exactly the changes I made <a href="https://github.com/alinz/react-native-webview-bridge/pull/243">https://github.com/alinz/react-native-webview-bridge/pull/243</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 11:04</div><div class="msg">probably won't work to remove the import because line 85 there is deprecatedPropType</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 11:05</div><div class="msg">damn I love lisp this syntax drives me nuts :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 11:08</div><div class="msg">i?ve stuck on npm install again, so let?s just build it on jenkins</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 11:09</div><div class="msg">started</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 11:28</div><div class="msg">```
|
|
Dec 14 13:28:44 iPhonerv StatusIm[847] <Notice>: There was an error collecting entropy from the browser:
|
|
Dec 14 13:28:44 iPhonerv StatusIm[847] <Notice>: { [TypeError: undefined is not an object (evaluating 'i.random')]
|
|
Dec 14 13:28:44 iPhonerv StatusIm[847] <Notice>: Can't find variable: deprecatedPropType
|
|
Dec 14 13:28:44 iPhonerv StatusIm[847] <Notice>: Unhandled JS Exception: Can't find variable: deprecatedPropType
|
|
Dec 14 13:28:44 iPhonerv StatusIm[847] <Notice>: Module AppRegistry is not a registered callable module (calling runApplication)
|
|
```</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 11:29</div><div class="msg">@yenda ^</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 11:38</div><div class="msg">Yeah :(</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-14 11:41</div><div class="msg">@divan Thanks for the effort! This will probably evolve in the longer term due to simplifications we are planning but if it provides value to you and others I am :+1:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-14 11:41</div><div class="msg">Once it's merged do you mind updating the documentation?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2017-12-14 11:43</div><div class="msg">Sure.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 11:47</div><div class="msg">any ideas?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 11:48</div><div class="msg">Seems like this part needs a rewrite</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 11:50</div><div class="msg">let me try something</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 12:54</div><div class="msg">ok, i know how to fix this</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 12:54</div><div class="msg">will send PR in 10 minutes</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 13:32</div><div class="msg">it works <a href="https://status-im.slack.com/archives/G53FWGDCM/p1513258144000276">https://status-im.slack.com/archives/G53FWGDCM/p1513258144000276</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 13:33</div><div class="msg">@yenda are you good with these changes <a href="https://github.com/yenda/react-native-webview-bridge/pull/1/files">https://github.com/yenda/react-native-webview-bridge/pull/1/files</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 13:33</div><div class="msg">?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 13:35</div><div class="msg">yes looks great</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 13:38</div><div class="msg">so we can proceed with testing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 13:40</div><div class="msg">have you tried a build locally ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 13:43</div><div class="msg">nope. it was built on jenkins</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-14 13:44</div><div class="msg"><a href="https://status-im.slack.com/archives/C803EC3S9/p1513258336000046?thread_ts=1513240658.000146&cid=C803EC3S9">https://status-im.slack.com/archives/C803EC3S9/p1513258336000046?thread_ts=1513240658.000146&cid=C803EC3S9</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 13:52</div><div class="msg">it works I am on testing it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 13:52</div><div class="msg">@roman :sparkles::clap::doughnut:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 13:53</div><div class="msg">thank you @roman and @janherich</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:10</div><div class="msg">Hi @yenda, @roman `update-react-native` is tested-ok, I will squash it to one commit and rebase&merge if you don't have anything against :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:34</div><div class="msg">@janherich @nastya said we can merge :joy:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:35</div><div class="msg">so we need to move the repos to status org and squash the commits ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2017-12-14 17:35</div><div class="msg">Confirm!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:35</div><div class="msg">I?m just squashing the commits :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:36</div><div class="msg">Done</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:38</div><div class="msg">Now the repos, do we want to move *all* the repos under status-react org, or only those which we forked while working on the RN update ?
|
|
There is for example `"react-native-android-sms-listener": "github:adrian-tiberius/react-native-android-sms-listener#listener-bugfix"` as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:39</div><div class="msg">I suppose we first do the repos we changed</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:39</div><div class="msg">for the others it can be a bounty</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:44</div><div class="msg">Ok, I will do it for my forked repo (`react-native-http-bridge`), you can for yours :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:45</div><div class="msg">@roman @janherich <a href="https://github.com/status-im/react-native-webview-bridge/pull/9">https://github.com/status-im/react-native-webview-bridge/pull/9</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:46</div><div class="msg">@roman @yenda <a href="https://github.com/status-im/react-native-http-bridge/pull/2">https://github.com/status-im/react-native-http-bridge/pull/2</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:50</div><div class="msg">@janherich did we add the http-bridge repo to status for this PR or was it there already ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 17:55</div><div class="msg">@yenda I?m not sure, I forked that from you (and you forked it from @alwx) :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:55</div><div class="msg"><a href="https://github.com/status-im/nfc-react-native/pull/1">https://github.com/status-im/nfc-react-native/pull/1</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:58</div><div class="msg">@janherich <a href="https://github.com/status-im/status-react/pull/2217/commits/a76727b2cc29c3b3fcc2f5cd154edbd20541e122">https://github.com/status-im/status-react/pull/2217/commits/a76727b2cc29c3b3fcc2f5cd154edbd20541e122</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 17:59</div><div class="msg">@janherich you need to do the instabug-reactnative</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 18:00</div><div class="msg">Btw I was asking for the http-bridge because for existing repo with significant changes that are not retro compatible when previous package.json already refers to repo without pinning to specific branch or commit, we need to use a branch</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 18:01</div><div class="msg">but hopefully that is only the case for the webview</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 18:09</div><div class="msg">feels so good to be almost done with this :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 18:09</div><div class="msg"><a href="https://github.com/status-im/instabug-reactnative/pull/1">https://github.com/status-im/instabug-reactnative/pull/1</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-14 18:10</div><div class="msg">Yes, very good and I?m excited about being able to utilize FlatList with lazy rendering finally :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-14 18:12</div><div class="msg">@roman to recap these are the PRs to review/merge
|
|
|
|
<a href="https://github.com/status-im/instabug-reactnative/pull/1">https://github.com/status-im/instabug-reactnative/pull/1</a>
|
|
<a href="https://github.com/status-im/react-native-http-bridge/pull/2">https://github.com/status-im/react-native-http-bridge/pull/2</a>
|
|
<a href="https://github.com/status-im/react-native-webview-bridge/pull/9">https://github.com/status-im/react-native-webview-bridge/pull/9</a>
|
|
<a href="https://github.com/status-im/nfc-react-native/pull/1">https://github.com/status-im/nfc-react-native/pull/1</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-24/320320314756_fe0f3ce0bb820f1aa8e3_72.jpg" /><div class="message"><div class="username">dmitryn</div><div class="time">2017-12-15 08:33</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-15 14:10</div><div class="msg">@alwx what is the current status on the chat refactoring ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-15 15:07</div><div class="msg">@janherich do you know why my squash removed your face from the commit ? When you did it it was still a commit from both just wondering <a href="https://github.com/status-im/status-react/commit/56c59c741fc6f915135e2d6dec44a21ab296ea99">https://github.com/status-im/status-react/commit/56c59c741fc6f915135e2d6dec44a21ab296ea99</a> ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-15 15:08</div><div class="msg">also I merged with the UI and my verified commit got unverified again..</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-15 16:04</div><div class="msg">GH PR is broken</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-15 16:04</div><div class="msg">they confuse AUTHOR with PR logged in user</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-15 16:04</div><div class="msg">should respect COMMITTER and AUTHOR but PR workflow breaks this for some reason</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-15 16:05</div><div class="msg">you can fix it by doing it manually at CLI but PITA, there's a bounty for this + signed for external contributors</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-15 16:06</div><div class="msg">We won't have a lot of PRs like this one with multiple contributions though</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-15 16:06</div><div class="msg">Your script worked fine for merging though</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-15 16:06</div><div class="msg">for external contributors we will I think</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2017-12-15 16:07</div><div class="msg">because they don't nec verify so core contributor needs to sign it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-16 00:32</div><div class="msg">fixed this @divan thanks for pointing it out</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-18 08:11</div><div class="msg">The same as it was on Thursday. Felt really bad during the weekend, so the task still requires some work. Will start doing it in one hour and really really want to finish today.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-19 11:24</div><div class="msg">@jeluard can you look into this PR <a href="https://github.com/status-im/status-react/pull/2297">https://github.com/status-im/status-react/pull/2297</a> now that the migration is done ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2017-12-19 12:14</div><div class="msg">Sure I will</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-19 12:16</div><div class="msg">thanks !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-19 13:12</div><div class="msg">ClojureTeam <a href="https://github.com/status-im/status-react/pull/2692">https://github.com/status-im/status-react/pull/2692</a> finally merged, I think some outstanding PRs will need to be rebased</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-19 13:13</div><div class="msg">Also @roman the thing you were working on (preloading and performance enhancements for `chat-list` <-> `chat` navigation) should be affected quite a lot (for better)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 13:18</div><div class="msg">thanks, will check</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 13:46</div><div class="msg">i can confirm that navigation from chats to `console` chat is ~2 times faster on my slow Android device</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 13:46</div><div class="msg">it was ~2s, now 1.1s</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 13:48</div><div class="msg">though navigation from `console` chat back to chats is still ~2.1s, without any changes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-19 13:51</div><div class="msg">`console` chat is very, very special, unfortunately</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-19 13:52</div><div class="msg">But in process of reworking the app/console start-up sequence (for console, it's unfortunately not only startup), I will make it better, so we are not treating console as anything special and performance is predictable like in other chats</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 13:54</div><div class="msg">if i open another 1-1 chat with some messages navigation takes approximately same time</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-19 14:08</div><div class="msg">@roman I suspect that the reason why is that in console, you have always quite a lot of command/command-request messages, those were slowing down the app quite significantly.
|
|
I suspect that in 1-1 (or even group/public) chat, where you have many commands/command-requests, the speed-up would be comparable</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 14:10</div><div class="msg">i?m not sure, it most likely related to rendering, will provide numbers soon</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 15:00</div><div class="msg">so if chat screen contains only view with text and touchable-highlight inside navigation form chats to chat take less than 0.25s, it's hard to say more precise when observing with eyes :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 15:00</div><div class="msg">probably it's 0.2s</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2017-12-19 15:01</div><div class="msg">and i suppose that most of this time is used for unmouting of previous screen</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-20 13:01</div><div class="msg"><!channel> I would like to wrap up this swarm if you are still working on something related to it please describe it in this thread and estimate when you will be done. Thanks guys !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-20 15:15</div><div class="msg">@yenda ok, here, description | estimate of hours:
|
|
* Finalise simplified message model by refactoring messages statuses (and potentially pending messages) + merging command request logic into messages itself | 16h
|
|
* Properly refactor protocol handlers | 16h
|
|
* Rewrite app/console startup sequence | 32h (this is big, but I feel very necessary)
|
|
|
|
Further things which I think need to be done to say that our codebase consist of quality code (no estimations there, as I didn't give it too much thought yet):
|
|
* Refactor `send-message` ns
|
|
* Further refactor `input` events chat ns, this can be done only after point before is finished.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-20 16:35</div><div class="msg">@andrey there is still no profiling for subscriptions in re-frisk ? do you think this it something that is doable, maybe as a bounty ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-20 16:41</div><div class="msg">@alwx how are you doing with the chat refactoring ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-20 16:41</div><div class="msg">nope, because it requires re-frame fork and re-frame-trace is not stable yet. and i don't have time for this, so a bounty maybe a good idea</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-20 16:48</div><div class="msg">Ok thanks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-20 17:32</div><div class="msg">ok when do you take your holidays ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-20 17:33</div><div class="msg">we'll base the deadline of the next iteration on your estimation+holidays</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-20 18:44</div><div class="msg">I will take holiday on 25-26th of December and 28-29th of December (four days next week)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-21 02:17</div><div class="msg">oh you take holidays for my birthday good thinking :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-21 07:14</div><div class="msg">I have a lot of time today and tomorrow, so everything will 100% be finished during these two days. Currently I am finishing rebasing. After that I need to make sure that everything still works, and I haven't forgot anything. Also there are 2 or 3 handlers left, so I think 4-5 hours are more than enough for it.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2017-12-23 02:13</div><div class="msg">There was a long discussion in our Riot about a week ago about using docker for making dev setup experience easier for a couple separate devs that expressed interest @oskarth @yenda @cryptowanderer ? should I ask Charlesg to make an issue describing why he was trying to use docker? Or was this already addressed, and we shouldn?t advise alternative setup environments like this? <a href="https://github.com/status-im/status-react/pull/2716">https://github.com/status-im/status-react/pull/2716</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2017-12-23 09:17</div><div class="msg">Hey guys.
|
|
This two devexp tasks are done:
|
|
<a href="https://github.com/status-im/status-react/pull/2572">https://github.com/status-im/status-react/pull/2572</a>
|
|
<a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-24 08:42</div><div class="msg">@janherich could you please help with merging this as fast as possible? because we need this asap for status desktop, @alwx will be unavailable, could you please take these two issues ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-24 11:07</div><div class="msg">@andrey Sure, how critical would that be ? I?m not working tomorrow and day after tomorrow</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2017-12-24 11:45</div><div class="msg">ok i'll take care then, thanks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-27 21:34</div><div class="msg">Hi @janherich what is your progress so far regarding this plan ? Is it going to fix <a href="https://github.com/status-im/status-react/issues/2721">https://github.com/status-im/status-react/issues/2721</a> btw ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2017-12-27 22:20</div><div class="msg">Hi @yenda I got little bit pulled aside as I was helping @andrey with `send-message` refactoring (but made good progress there).
|
|
The #2721 bug is about JSC not working correctly for Android, so till @roman fixes it, I just proposed to turn-off JSC_ENABLED flag (I communicated that to QA as well)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2017-12-28 11:49</div><div class="msg">cool it's done now</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-02 10:03</div><div class="msg">happy new year everyone :slightly_smiling_face:
|
|
|
|
as I know, you?ve created a new PR with some of the things from <a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a> and merged it, but there are some things still left to be done. and this PR should be rebased and some of its parts are still needed, right?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-02 10:04</div><div class="msg">apart from that, what else should be done for this idea?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-02 10:04</div><div class="msg">@yenda?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-02 10:05</div><div class="msg">@janherich ^</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-02 10:14</div><div class="msg">@alwx Please look at the comments in your PR left by @andrey (with which I fully agree), mostly the thing about using `cofx` instead of `fx`.
|
|
In my opinion, what?s left to be done is to port rest of the `send-message` ns from handlers into to events namespace (already existing there) and making sure that there is no duplication in command/regular message handling, so everything which needs to happen for every message sent (setting message-type, updating chat, calling protocols, etc.) will happen in common function/s.
|
|
I think that moving functions into `models` namespace is way less important then that and can be done later.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-01-02 10:14</div><div class="msg">Can we also move chat to `ui` ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-02 10:16</div><div class="msg">Sure we can but I think that's the last least important thing to do</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-01-02 10:17</div><div class="msg">We are doing refactoring so why stop in the middle?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-01-02 10:17</div><div class="msg">It's already been weeks in the making so we can do this extra bit</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-01-02 10:18</div><div class="msg">As an extra PR to be easy to review</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-02 10:19</div><div class="msg">agree with @jeluard let's do it, quick PR, because i always trying to find chat in ui</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-01-02 10:33</div><div class="msg">@alwx <a href="https://github.com/orgs/status-im/teams/status/discussions/6">https://github.com/orgs/status-im/teams/status/discussions/6</a> you can check the update and tell me if you see some things missing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-01-02 10:34</div><div class="msg">I think we should focus on things that can improve or help measure performances as this is the most important thing for mvp atm</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-02 10:56</div><div class="msg">I will update my PR and finish the rest of send-message in a couple of days. Thanks for comments</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-02 10:56</div><div class="msg">@yenda great. Will take a look today and let you know.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-03 13:30</div><div class="msg">@janherich why we still have `status-im.chat.handlers` ? i can see we have `status-im.chat.events`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-03 13:31</div><div class="msg">i'm refactoring `status-im.chat.handlers` because i can't wait two weeks more :slightly_smiling_face: we should get rid of realm in chat and protocol, things like `chats/new-update?` `chats/exists?` `chats/is-active?` shouldn't exists , we should work with app-db</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-03 13:32</div><div class="msg">It?s because not everything is yet ported to the ?new way? with `fx/cofx`, functional style without unnecessary dispatches, etc.
|
|
The ?old code? still lives in the `handlers` namespace (already quite small), while the new one is in `events`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-03 13:32</div><div class="msg">ok thanks</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-03 13:33</div><div class="msg">but i'm doing quick one, in status-desktop branch, and these function will be there still</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-03 13:33</div><div class="msg">I think it serves as a nice mental remainder about what needs to be done (keeping the older handlers namespaces till they are properly refactored).</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-10-04/251566892466_e37667e6064fe542e7d7_72.jpg" /><div class="message"><div class="username">naghdy</div><div class="time">2018-01-03 21:53</div><div class="msg">@naghdy has renamed the channel from "9-developer-xp" to "09-developer-xp"</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-05 09:16</div><div class="msg">This task is finished and can be checked: <a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a>
|
|
`send-message` namespace was restructured, and also `send-message` and `send-command` functions were combined into one function.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-01-05 10:19</div><div class="msg">@alwx have you tested it? is it possible to install from scratch and create new account?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-05-11/363235195815_bbe7d055e1883e756d9b_72.jpg" /><div class="message"><div class="username">maxr</div><div class="time">2018-01-05 10:20</div><div class="msg">has joined #09-developer-xp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-05 10:21</div><div class="msg">@alwx you still didn't addressed last @andrey?s comments about using cofx in place of fx</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-05 10:40</div><div class="msg">yes, it works and it is possible</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-05 11:43</div><div class="msg">fix for cofx => fx has also been submitted</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-08 08:03</div><div class="msg">There are some small things still left to be refactored. In the next two days I am going to focus on:
|
|
1) Refactoring `status-im.commands.handlers.jail`. It?s one of the last namespaces with old-style handlers;
|
|
2) Measuring performance and trying to remove some redundant parts of new send-message process;
|
|
3) Fixing some TODOs I left during the last refactoring phase.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-08 08:03</div><div class="msg">By the way, there were some small issues there: <a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a> I fixed them, so I guess this PR is finally ready to be merged.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-01-08 08:10</div><div class="msg">@alwx btw, did you see bug hunting announcement from Anna in #clojure?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-08 09:09</div><div class="msg">yes. I will also take a look at some bugs from the list then</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2018-01-08 14:32</div><div class="msg">Will anyone be ready to have a voice/screensharing session with me tomorrow to help me finally nail that iOS `status-react` build issue. That's the major hindrance for me for weeks and I really want to finally build it. @oskarth, you offered your hand here once, right? (I can't find a comment).
|
|
That'll probably take an hour or two, as we'll probably will go through "reinstall everything/download npm universe/etc" steps.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-01-08 14:39</div><div class="msg">Hey! So I have committed to a lot this week, so if someone else is able to it would be better. My env for iOS isn't rock solid either tbh. But if no one volunteers I'll make time later this week and we can struggle together, at least. Usually end up getting it to work through a magic combination of incantenations</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-08 14:44</div><div class="msg">I usually work with iOS simulator or iOS real device and experience no dificulties. However, I cloned the project about a month ago, and I pretty sure that if I clone the project on a new machine now, I will have some problems :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-08 14:49</div><div class="msg">I can try to do it later and/or join your struggling session later this week</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/3fbb10b8c7115b8c44459363fb6476cf.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0007-72.png" /><div class="message"><div class="username">divan</div><div class="time">2018-01-08 14:49</div><div class="msg">Great, thanks! It's not necessarily should be tomorrow, anytime this week works.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-09 13:07</div><div class="msg">awesome
|
|
now I am also unable to run the iOS project :slightly_smiling_face: it simply stucks while loading</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-09 13:08</div><div class="msg">investigating</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-01-09 13:59</div><div class="msg">:morty:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-01-13 06:13</div><div class="msg">Can we archive this channel if swarm is done @yenda?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-01-13 07:14</div><div class="msg">we can close the channel though I think I would consider the swarm done when the last remaining related PRs are merged <a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a> <a href="https://github.com/status-im/status-react/pull/2483">https://github.com/status-im/status-react/pull/2483</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-01-13 07:17</div><div class="msg">That's fine, in offline inboxing we closed swarm with some minor PRs outstanding</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-01-13 07:17</div><div class="msg">but we can wait if you want</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-05-11/181684552369_66f21f8981bdb0f83bdd_72.jpg" /><div class="message"><div class="username">cryptowanderer</div><div class="time">2018-01-17 09:11</div><div class="msg">@alwx hi! Sorry you were feeling sick yesterday and glad to hear it has improved a bit. What are you working on specifically today and next week? Also, did we add XHR support in the last round of work on the API?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-17 09:13</div><div class="msg">hey
|
|
<a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a>
|
|
it's almost done, I am just trying to restructure some parts of it. but more likely today I will finish, and will be free after that</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-17 09:14</div><div class="msg">I haven't heard anything about XHR support and haven't added it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-17 09:14</div><div class="msg">but maybe somebody else knows more</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-05-11/181684552369_66f21f8981bdb0f83bdd_72.jpg" /><div class="message"><div class="username">cryptowanderer</div><div class="time">2018-01-17 09:15</div><div class="msg">perfect! We need to start work especially on:
|
|
1) Ensuring we have the correct medi permissions to scan QRs from DApps (<a href="https://github.com/status-im/status-react/issues/3003">https://github.com/status-im/status-react/issues/3003</a>)
|
|
2) Hopefully getting `eth_signTransaction` to work correctly (as this will also help with cryptokitties integration etc)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-05-11/181684552369_66f21f8981bdb0f83bdd_72.jpg" /><div class="message"><div class="username">cryptowanderer</div><div class="time">2018-01-17 09:16</div><div class="msg">I think we are the people who know the most about the API mate, not sure who else to ask. If you don't remember and didn't add it, my assumption is that it is still TODO</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-01-17 09:24</div><div class="msg">@roman Do I remember correctly you did some work related to bot XHR support?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-01-17 11:24</div><div class="msg">hm, i?m not sure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-01-17 11:25</div><div class="msg">it was done in otto vm for sure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-01-17 11:25</div><div class="msg">you can switch to otto locally and check</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-01-17 11:29</div><div class="msg">Hmm right otto is not the default anymore</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-10-03/448433513781_35b198abdf960e874693_72.png" /><div class="message"><div class="username">jarradhope</div><div class="time">2018-01-19 08:32</div><div class="msg">i think it was fetch not xhr</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-01-19 08:34</div><div class="msg">yep sure, fetch api</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-01-19 08:36</div><div class="msg">it can be implemented with JSC as well, but i skipped this as we were not using fetch at that moment</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-19 09:49</div><div class="msg">@janherich updated <a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a> according to your comments</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-19 09:49</div><div class="msg">thanks!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-19 09:49</div><div class="msg">however, I have more changes like comments and some small restructuring in my local branch</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-19 09:50</div><div class="msg">but I decided to keep them separately and not increase the size of this PR</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-19 09:50</div><div class="msg">and to make reviewing easier</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-19 09:50</div><div class="msg">Great, thanks @alwx!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-05-11/181684552369_66f21f8981bdb0f83bdd_72.jpg" /><div class="message"><div class="username">cryptowanderer</div><div class="time">2018-01-19 13:36</div><div class="msg">@nastya @janherich apologies for the delayed response on how to test Jan's fix for `status.response`. Though the steps to test it are available in the link provided in that issue, they are quite intense. Essentially, you need to have
|
|
1. A build of Jan's branch running on your device/emulator (something it is not currently trivial for me to set up, otherwise I would just test myself and report).
|
|
2. Clone the repo in the link I provided in the issue to get the DApp to be tested.
|
|
3. Follow the steps given to get the DApp running locally and connected to the build of Jan's branch (i.e. `npm install`, figure out the IP of your device emulator using `status-dev-cli scan` and then `IP=<device_ip> npm run start` and then navigate to the DApp that gets added by virtue of that start script.
|
|
4. Click `/start` to get the bot going and test that the full interaction works, rather than getting stuck on when you try to confirm that the offered price is ok (currently sending `yes` to the `status.response` question just results in that message hanging with `Sending...` displayed below it and no response from the bot).</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-01-19 13:37</div><div class="msg">Thanks!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-01-22 17:36</div><div class="msg">Hey @alwx - the refactoring scope made in <a href="https://github.com/status-im/status-react/pull/2795">https://github.com/status-im/status-react/pull/2795</a>, is there any particular instances (apart of app messaging, - so all chats) you suggest need to be covered by test team?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-22 17:38</div><div class="msg">Hey @sergii!
|
|
I think it's only about messages and chats, so the answer is no :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-01-22 17:41</div><div class="msg">@andrey is it Ok from you side to merge this PR after it gets the ?Tested-OK? status? (it's just in ?Merging is blocked? at the moment - but I assume it may related to when you requested changes ~1 month ago which fixed by already merged <a href="https://github.com/status-im/status-react/pull/2829)">https://github.com/status-im/status-react/pull/2829)</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-01-22 17:42</div><div class="msg">Cool! Got it, thanks!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-01-22 17:45</div><div class="msg">^^ Asked in ?core? as Andrey appears to be not in this channel</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-28 22:10</div><div class="msg">`(not (or public? (get-in contacts [chat-id] :dapp?)))` (status-im.chat.events:222) should be `(not (or public? (get-in contacts [chat-id :dapp?])))`. haven't checked who introduced this bug, but it was really hard to find the exact reason why status messages don't work. it was the case when one bracket on a wrong place costs you 2 hours of time ;?(</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-28 22:11</div><div class="msg">it also exists in `develop`, but the fix is coming</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-01-28 22:41</div><div class="msg">That was most certainly me during the message data model overhaul, stupid typo. Please indicate in the PR that such functionality should he covered by e2e tests by attaching `to be automated` label to the bugfix PR.
|
|
It was super easy to miss (small UI element), QA didn't notice anything during PR testing either and we (mostly @roman) figured something was wrong only much later.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-29 07:46</div><div class="msg">don't worry, this thing can happen to anyone, because it's so ?invisible? :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-11/344678860515_64490607960ebf85ac4a_72.jpg" /><div class="message"><div class="username">alwx</div><div class="time">2018-01-29 07:46</div><div class="msg">ok, sure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-02-14 07:06</div><div class="msg">@yenda can we close this channel? :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-02-14 07:12</div><div class="msg">Yes do it please</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-02-14 07:15</div><div class="msg">@oskarth archived the channel</div></div></div><br/>
|
|
</div></body></html> |