869 lines
243 KiB
HTML
869 lines
243 KiB
HTML
<html><body><style>
|
|
* {
|
|
font-family:sans-serif;
|
|
}
|
|
body {
|
|
text-align:center;
|
|
padding:1em;
|
|
}
|
|
.messages {
|
|
width:100%;
|
|
max-width:700px;
|
|
text-align:left;
|
|
display:inline-block;
|
|
}
|
|
.messages img {
|
|
background-color:rgb(248,244,240);
|
|
width:36px;
|
|
height:36px;
|
|
border-radius:0.2em;
|
|
display:inline-block;
|
|
vertical-align:top;
|
|
margin-right:0.65em;
|
|
}
|
|
.messages .time {
|
|
display:inline-block;
|
|
color:rgb(200,200,200);
|
|
margin-left:0.5em;
|
|
}
|
|
.messages .username {
|
|
display:inline-block;
|
|
font-weight:600;
|
|
line-height:1;
|
|
}
|
|
.messages .message {
|
|
display:inline-block;
|
|
vertical-align:top;
|
|
line-height:1;
|
|
width:calc(100% - 3em);
|
|
}
|
|
.messages .message .msg {
|
|
line-height:1.5;
|
|
}
|
|
</style><div class="messages"><div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-12 11:04</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-03-12 11:04</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-03-12 11:04</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-24/320320314756_fe0f3ce0bb820f1aa8e3_72.jpg" /><div class="message"><div class="username">dmitryn</div><div class="time">2018-03-12 14:18</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2018-03-13 03:50</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-03-13 11:04</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-03-13 11:09</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-23/319521513136_d6db8eeb85a03cb7d705_72.png" /><div class="message"><div class="username">andreaf</div><div class="time">2018-03-15 13:49</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-10-04/251566892466_e37667e6064fe542e7d7_72.jpg" /><div class="message"><div class="username">naghdy</div><div class="time">2018-03-16 07:05</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-03-16 08:48</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-03-16 08:49</div><div class="msg">@janherich @yenda will it be ?autofixed? by new protocol? <a href="https://github.com/status-im/status-react/issues/3560">https://github.com/status-im/status-react/issues/3560</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-03-16 08:56</div><div class="msg">@anna Yes, it will be fixed by design of the new protocol and clock implementation there</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-19 09:07</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-19 18:30</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-20 11:26</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-01-12/298981446807_2ce374952c07670e437e_72.jpg" /><div class="message"><div class="username">levgeniia</div><div class="time">2018-03-21 10:28</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-03-22 23:21</div><div class="msg">New protocol is finally feature complete, with full feature parity to develop (actually more then just parity, things like group chat administration not working in develop are working there :slightly_smiling_face: )
|
|
We will do little bit of more dev testing, perf profiling and then squash the commits in branch and ask QA for one massive regression testing :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2018-03-22 23:37</div><div class="msg">@hutch set the channel topic: <a href="https://github.com/status-im/ideas/issues/87">https://github.com/status-im/ideas/issues/87</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 12:58</div><div class="msg">@nastya let's continue here</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 12:59</div><div class="msg">So I am testing as well I propose we create bugs with the 87-new-protocol tag when we find something</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 12:59</div><div class="msg">sure</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 12:59</div><div class="msg">greay</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 12:59</div><div class="msg">t</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 12:59</div><div class="msg">i will bring us one more tester)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 12:59</div><div class="msg">and we list them in the PR and decide which ones are critical and which one can be merged</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 12:59</div><div class="msg">@sergii please join</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:00</div><div class="msg">thread about testing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:00</div><div class="msg">@nastya @sergii</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:00</div><div class="msg">thread about review</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:00</div><div class="msg">@dmitryn do you mind starting to review the PR ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:01</div><div class="msg">Since it is very big I was thinking we could do it as a dialog, you ask whatever you want and I'll answer and take notes of your question for documentation and guidelines</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-24/320320314756_fe0f3ce0bb820f1aa8e3_72.jpg" /><div class="message"><div class="username">dmitryn</div><div class="time">2018-03-26 13:01</div><div class="msg">yes, i could start, but in 30 mins (having lunch right now)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:02</div><div class="msg">perfect thanks !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:06</div><div class="msg">I'll publish the correct android and iOS build later today</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:06</div><div class="msg">finishing squashing one last bug</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:20</div><div class="msg">@levgeniia ^</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:23</div><div class="msg">@sergii @levgeniia ^ :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:28</div><div class="msg">:heart: these names when someone adds me!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:34</div><div class="msg">@yenda so this is not a final build?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:38</div><div class="msg">no because I added contact-updates this morning to have feature-parity with develop but there is a bug I need to fix when sending message multiple times</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:38</div><div class="msg">so right now group-chat wont work properly</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:38</div><div class="msg">but I 1to1 and public should be fine</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:39</div><div class="msg">and i dont see the admin option to remove add users :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:39</div><div class="msg">can we turn it on in next build?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:41</div><div class="msg"><!channel> write your concerns about new protocol in this thread (potential trade offs)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-03-26 13:48</div><div class="msg">Concerns only, since in general it seems like there's a lot of good stuff in this whole thing!
|
|
|
|
1. PR too big, very likely to cause regressions and hard to revert/toggle specific behaviors introduced/changed
|
|
2. No clear understanding/description of semantic differences (this mean it is hard to reason about trade-offs and potential negative side effects, e.g:
|
|
(a) consequences of removing ack messages
|
|
(b) consequences/complexity of batching messages for reliability/traceability (every system I worked on with this change had issues with it at one point or another)
|
|
(c) consequences of changing message format/packing for 3rd party app dev (maybe it is better now but can't tell)
|
|
(d) consequences of removing info from payload that current exists (providing less in Rich Hickey speak)
|
|
(e) probably more
|
|
3. No clear understanding of which changes provide which types of benefits (i.e. maybe many topics is solely responsible for traffic gains, and maybe battery is only about async realm, but impossible to know with a complete rewrite) - better insight here would make it easier to gradually improve/introduce new behavior as desired. Related: lack of specific GHI(s) PR is targeting.
|
|
4. No clear design/spec stage for new protocol (should come before any code has been written IMO/IME); appears to mix refactoring/protocol design/perf tweaking into same activity
|
|
5. Lack of backwards compatibility which breaks what we all agreed on just a month ago as well as user expectations, this seems to be ignored
|
|
6. General process problem: ignoring agreed upon trunk based development model in favor of a 2 month long living PR and PR acting as gatekeeper for other work which should be coordination-free
|
|
|
|
cc @roman</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:49</div><div class="msg">I tried but it needs a bit more work so I think it should be made in a separate PR</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:49</div><div class="msg">we should aim at feature parity with develop that's already big enough at that point :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-26 13:49</div><div class="msg">sure ! just asking :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:49</div><div class="msg">but I'll do it after promise :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 13:50</div><div class="msg">the code in the new protocol is already there anyway</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-03-26 14:09</div><div class="msg">Trade-offs, largely guessing since I lack intimate knowledge of what this new protocol changes in terms of provisions/capabilities:
|
|
|
|
i. Removing ack messages improves traffic by constant factor but at expense of reliability and UX (UX should be involved cc @chad)
|
|
ii. Batching messages improves traffic at expense of retriability/debuggability/flexibility of message handling/inspectability
|
|
iii. format packing improves size by small constant factor at expense of 3rd party integration simplicity / text-representation for debugging/inspection/serialization bugs (probably weak)
|
|
iv. removing info from payload reduces traffic by constant factor vs unforeseen things breaking/providing less things that might be useful for certain things in future (hard to know without specifics, but generally things are in payload for a reason)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-03-26 14:10</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 14:16</div><div class="msg">i. the way current ack messages work is completely useless it just keep resending the same message to an offline peer until it gives up, and then the offline peers receives many time the same message when back online with offline inboxing, or nothing without it. We didn't supress the idea of having acks, but for now we have bulked seen message that really tell you if the recipient has seen your message and are send at once when you open the chat.
|
|
ii. there is no batching of messages, only bulk-like messages are seen messages, and they contain the ids of all the seen messages, not hard to inspect
|
|
iii. it makes integration easier as transit is actually a format meant to be used by other languages as well unlike edn
|
|
iv. that's a lot of things :smile: but I disagree that things are in payload for a reason, sometimes they are just there and they don't need to. And since we have versionning built-in with tags there is no problem adding new fields in the future</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-03-26 14:23</div><div class="msg">i. To me this isn't trivial to reason about, maybe it is obvious to everyone else but I feel like there are a lot of edge cases here and it relies heavily on offline inboxing. It isn't clear to me to what extent this is wise or necessary. Maybe it is fine but I can't tell, so it'd be nice if this type of change was encapsulated so it is easy to toggle while learn about how it behaves in the real world.
|
|
ii. Ok that's good to know, I was under impression it was a bulk messages, not a list of only one message type. This type of documentation and clarity is vital IMO.
|
|
iii. Generally agree.
|
|
iv. I didn't say always there for a reason, but generally - comes down to specifics.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 14:51</div><div class="msg">i. the question here is how heavy we are going to rely on offline inboxing. Because this feature will be optional afaiu</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 14:53</div><div class="msg">it's still not a problem, what you need in that case is nacks and not acks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 14:54</div><div class="msg">because without offline inboxing the only moment peers can exchange messages is when they are both connected, when one is disconnected the message is just sent for nothing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 14:56</div><div class="msg">so for that you would rely on online messages, when both are online they can exchange their clocks and nack missing messages</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 14:57</div><div class="msg">we can implement that later, (almost) nobody will use a messenger without offline inboxing anyway</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:08</div><div class="msg">we have kind of 606 changed lines in test/cljs/status_im/test/contacts/events.cljs</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:08</div><div class="msg">probably better to add `#_` without rearranging of the whole file?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:11</div><div class="msg">same for status-im.test.accounts.events</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 15:41</div><div class="msg">good point</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:42</div><div class="msg">comment regarding 80 chars is general for PR, i can't read without horizontal scrolling at the moment</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:42</div><div class="msg">i know that's my problem, though? :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 15:43</div><div class="msg">test accounts is commented with #_ actually</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:43</div><div class="msg">yes it is, i mean that you need only to change this exact line</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 15:43</div><div class="msg">without rearranging</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 16:54</div><div class="msg">as well too many places where maps are not aligned, idk we either should decide that we don't align them or to fix everywhere</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 17:10</div><div class="msg">in general, it's too hard to reason about code?s correctness and to reason about the flow when change-set is that big;
|
|
I would be happy to see some unit tests for utility functions and for new handlers;
|
|
also some functional tests for the whole ?messaging? layer, so that we can start local `status-go` node and simulate messaging between device in nodejs env; the code in `status-im.transport` is coupled with other namespaces under `status-im` and also `re-frame.*` which will complicate extraction of the separate lib in future</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-26 17:11</div><div class="msg">though it's definitely better than previous version, i have an impression that for a newcomer it will be not much less harder to figure what?s happening there. Probably some more high level tests and good docs will improve the situation</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-03-26 19:14</div><div class="msg">I totally agree about documentation and tests @roman, we will have to provide those things.
|
|
I disagree about readability for newcomer though, it's just so much less code that it has to be easier to comprehend for anyone.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 20:26</div><div class="msg">I would love to be able to simulate messaging between two devices do you have any idea how to pull that off ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-26 20:40</div><div class="msg"><a href="https://status-im.slack.com/archives/C9PABAAFR/p1522083290000128?thread_ts=1522069221.000050&cid=C9PABAAFR">https://status-im.slack.com/archives/C9PABAAFR/p1522083290000128?thread_ts=1522069221.000050&cid=C9PABAAFR</a> I'm on it, trying to clean up as much as possible, but yeah I don't like these kind of aesthetic rules oppose to the standard lisp single space</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 00:51</div><div class="msg">@nastya @sergii @levgeniia I fixed all the bugs I could find
|
|
- android: <a href="https://i.diawi.com/3iFUza">https://i.diawi.com/3iFUza</a>
|
|
- iOS: <a href="https://i.diawi.com/Qyr7wQ">https://i.diawi.com/Qyr7wQ</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 01:08</div><div class="msg">quick test with devices only bug I found is when you leave/delete group chat, so don't do it for now :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-27 05:20</div><div class="msg">We will focus on this today as well</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 06:25</div><div class="msg">@yenda i don't mind if it would be a single space or any other convention, imo it's important to follow this convention everywhere. You can rise this question again and we will have a poll or something. Same for 80 symbols, if we need 160 and team is fine with this i?ll stop whining. But imo it's hard to read</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 06:44</div><div class="msg">@janherich i?m not speaking about readability, rather comprehensibility and it's usually on the similar level of difficulty, regardless you are reading 4k loc or 5k loc. Just because it's beyond the threshold of something that can be read in 5-10 minutes and quickly understood. That?s very subjective and also i?m not arguing about improvements anyway.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 06:48</div><div class="msg">@yenda there was an attempt to do this under this ns <a href="https://github.com/status-im/status-react/tree/develop/test/cljs/status_im/test/protocol">https://github.com/status-im/status-react/tree/develop/test/cljs/status_im/test/protocol</a>
|
|
so literally starting status-go node from nodejs env (probably we need to start two nodes because of messages caching or something), then init two instances of ?protocol? and test messaging. It wasn't possible at least because protocol was stateful</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 06:48</div><div class="msg">like it was possible, but would require a lot of refactoring as well</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 06:55</div><div class="msg">this also intersects with <a href="https://github.com/status-im/ideas/issues/91">https://github.com/status-im/ideas/issues/91</a> , because @igor680 and @andreap were going to implement something similar, though objective of testing is a bit different than API correctness</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-03-27 07:47</div><div class="msg">@roman Maybe I misunderstood, if you are talking about the fact that even the new protocol code is complex piece of work which absolutely needs good documentation to be properly understood, then I agree.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 07:48</div><div class="msg">yes, that's what i meant</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 08:02</div><div class="msg">The fix for groups</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 08:02</div><div class="msg">Android <a href="https://i.diawi.com/kvNXFo">https://i.diawi.com/kvNXFo</a>
|
|
Ios <a href="https://i.diawi.com/fTapf8">https://i.diawi.com/fTapf8</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-27 13:25</div><div class="msg">> So I am testing as well I propose we create bugs with the 87-new-protocol tag when we find something
|
|
> and we list them in the PR and decide which ones are critical and which one can be merged
|
|
:+1:
|
|
I?m about to address the bugs found for new-protocol latest builds.
|
|
As I understand the way we go is: Create separate issue in git hub with the 87-new-protocol label (need to create the label first), right?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 14:04</div><div class="msg">oh no you found bugs already :smile: ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-27 14:22</div><div class="msg">Yep :disappointed:
|
|
So the first one is combination of two: no list of contacts received by group-chat member upon invitation in group-chat. I.e.
|
|
1) non-admin members doesn?t see any contact on Group Info screen.
|
|
2) /receive and /send has an empty list of contacts in group chat on non-admin side</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 14:44</div><div class="msg">cool that's a minor thing :smile: I'll have a look at it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-16/316437191861_849cef1f2e8411a22126_72.png" /><div class="message"><div class="username">lukasz949</div><div class="time">2018-03-27 14:50</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-27 15:03</div><div class="msg">Is it expected new protocol can't interract with older version (I remember some talks at the top of my head it was main consequences or i?m wrong:) ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-01-24/304281668629_99d09ae86c8e0a04b52d_72.png" /><div class="message"><div class="username">growbot</div><div class="time">2018-03-27 15:20</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-03-27 15:20</div><div class="msg">/kudos @sergii for testing new protocol!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-27 15:41</div><div class="msg">For ?no contact on Group Info? - <a href="https://github.com/status-im/status-react/issues/3701">https://github.com/status-im/status-react/issues/3701</a>
|
|
one more issue with mystique ?system? message <a href="https://github.com/status-im/status-react/issues/3702">https://github.com/status-im/status-react/issues/3702</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 15:43</div><div class="msg">yeah they are not compatible</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 15:43</div><div class="msg">these group chats :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-27 17:04</div><div class="msg">new conflicts in branch</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 17:06</div><div class="msg">Classic :smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-27 17:06</div><div class="msg">I'll rebase in a couple hours I want to make some progress in the documentation first</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-28 00:30</div><div class="msg">I updated the new protocol document, I did 1to1 chat for now and a brief code description, tell me if it goes in the right direction and what you'd like to see in it as well <a href="https://docs.google.com/document/d/1Qh2h07T_qepzEJ7IytmxwIdQAOsGHrvhXwZxuZtbwgc/edit?usp=sharing">https://docs.google.com/document/d/1Qh2h07T_qepzEJ7IytmxwIdQAOsGHrvhXwZxuZtbwgc/edit?usp=sharing</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-28 02:24</div><div class="msg">rebase done btw</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-28 02:25</div><div class="msg">tomorrow I'm looking into the bugs</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-03-28 05:58</div><div class="msg">nice, thank you</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-28 09:05</div><div class="msg">Hello! List of issues found so far for new protocol: <a href="https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3A87-new-protocol">https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3A87-new-protocol</a>
|
|
|
|
Have no exact steps so far for the last one yet (Error ?null is not an object (evaluating ?t.cljs$core$IFn$_invoke$arity$1?)) - just logs? Hope to get steps later (apparently related to contact delete/leave chat)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-28 16:41</div><div class="msg">- Cleared message history reappears in Group and Public chats with all received messages ( <a href="https://github.com/status-im/status-react/issues/3719">https://github.com/status-im/status-react/issues/3719</a>)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-29 06:25</div><div class="msg">Thanks @sergii! I'll try to have all this fixed by Monday. I'll be off till Saturday it's holiday in Germany today but I'll work on it this weekend</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-03-29 08:50</div><div class="msg">@sergii can I put you as tester/evaluator in this swarm ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-03-29 08:53</div><div class="msg">Hey <!here> I?m updating our OKR doc with swarms that are addressing specific KR?s. What KR?s is this swarm targeting? (I see a mention of bandwidth, but thought this is more?) <a href="https://docs.google.com/spreadsheets/d/1BhWKyjkpxhavkqtk9VYB3EHNDIzQtUlkwlg7_lQNAws/edit#gid=0">https://docs.google.com/spreadsheets/d/1BhWKyjkpxhavkqtk9VYB3EHNDIzQtUlkwlg7_lQNAws/edit#gid=0</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-03-29 09:36</div><div class="msg">Done.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-03-29 10:43</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-10-04/251566892466_e37667e6064fe542e7d7_72.jpg" /><div class="message"><div class="username">naghdy</div><div class="time">2018-04-03 08:43</div><div class="msg">@naghdy has renamed the channel from "87-new-protocol" to "087-new-protocol"</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-03 13:39</div><div class="msg">New update to the new protocol documentation: more or less finished, waiting for comments to make it evolve <a href="https://docs.google.com/document/d/1Qh2h07T_qepzEJ7IytmxwIdQAOsGHrvhXwZxuZtbwgc/edit#">https://docs.google.com/document/d/1Qh2h07T_qepzEJ7IytmxwIdQAOsGHrvhXwZxuZtbwgc/edit#</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-03 16:58</div><div class="msg">Testteam will you be able to test the new protocol branch again without group chats tomorrow ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-03 17:05</div><div class="msg">Yes! I?m in.
|
|
To clarify: new protocol branch OR new protocol branch merged in develop?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-03 17:08</div><div class="msg">new-protocol branch, I'll make a build in the night that will be basically the same as if we had merged into develop</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-03 17:10</div><div class="msg">I'll post the build in the chat</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-03 18:08</div><div class="msg">Yep i will do it as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 05:20</div><div class="msg">Branch: PR-3273
|
|
Android: <a href="https://i.diawi.com/LZQntd">https://i.diawi.com/LZQntd</a>
|
|
iOS: <a href="https://i.diawi.com/U4heBD">https://i.diawi.com/U4heBD</a>
|
|
testeam</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 08:08</div><div class="msg">@sergii ^</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 08:25</div><div class="msg">Hey @yenda. In above builds: in 1-1 chat - the /send and /request commands fires up the `Error: Doesn't support name` once the request sent.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 08:26</div><div class="msg">I can have a look</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 08:27</div><div class="msg">Thanks a lot @andreap ! Yes, it almost block us from testing.
|
|
Let me describe this in separate issue too meanwhile</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 08:28</div><div class="msg">i believe we need to rebase this branch - this error was in develop last week and now fixed @andreap @yenda</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 08:28</div><div class="msg">will it work?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 08:29</div><div class="msg">we fixed it in this branch as well ( I believe the fix is already in), so might be something else, but will have a look</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 08:30</div><div class="msg">let us know!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 08:47</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3755">https://github.com/status-im/status-react/issues/3755</a>
|
|
|
|
Just in case: apparently it's something with the appropriate message for /send /request?. Since the transaction succeeded (and visible in tx history)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 08:48</div><div class="msg">thanks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-04 09:12</div><div class="msg">It seems impossible to switch network to Mainnet and then to another one.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 09:15</div><div class="msg">just tried that - confirm , can't switch between networks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 09:17</div><div class="msg">I will fix that :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 09:17</div><div class="msg">thank you Jan! do you need a ticket for this?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 09:18</div><div class="msg">Doesn?t really matter, I guess I have all the necessary info :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 09:18</div><div class="msg">:+1:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 09:20</div><div class="msg">I can switch fine to Mainnet and back to Ropsten with upstream RPC on both iPhoneX and Android 7.0</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 09:20</div><div class="msg">Ah I see?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 09:20</div><div class="msg">No I can't</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 09:21</div><div class="msg">i've selected Mainnet and then to Ropsten with Upstrea,</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 09:21</div><div class="msg">and i am still on mainnet</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 09:22</div><div class="msg">right right. Mainnet persist to stay after network switch</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 09:55</div><div class="msg">@sergii that's fixed, it's building now <a href="https://github.com/status-im/status-react/pull/3273">https://github.com/status-im/status-react/pull/3273</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 09:56</div><div class="msg">Brilliant! Waiting for a new build</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 10:16</div><div class="msg">@nastya @sergii Just to clarify I have the same situation as you:
|
|
1. Switch from default (Ropsten + RPC) to main-net works fine (with app not quitting, just re-logging necessary)
|
|
2. When switching from main-net to Ropsten + RPS, the app quits and when started, it's still on main-net
|
|
|
|
Point 2. shouldn?t happen, it should be just re-login like at point 1., correct ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 10:30</div><div class="msg">it is how it behaves in develop as well</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 10:30</div><div class="msg">a point for investigating</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-04-04 10:33</div><div class="msg">@nastya does it work properly in develop?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 10:33</div><div class="msg"><a href="https://status-im.slack.com/archives/C9PABAAFR/p1522837826000152?thread_ts=1522833143.000580&cid=C9PABAAFR">https://status-im.slack.com/archives/C9PABAAFR/p1522837826000152?thread_ts=1522833143.000580&cid=C9PABAAFR</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 10:33</div><div class="msg">Point 2 - i?d say it should alert user before app close. With the message ?This app will stop and close. When you reopen it, the selected network will be used?.
|
|
Not sure about tech detail why app should restart before switch from Mainnet to test network ?with upstream RPC? - but yes, it is the case now in Develop.
|
|
If alert is not shown - that's the issue. But for me it's shown (just checked)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-04-04 10:34</div><div class="msg">@nastya that would require parsing of the whole context of the thread, as `the same` can mean anything. So yes or no? :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 10:34</div><div class="msg">sorry for it @roman. it is `No`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-04-04 10:34</div><div class="msg">thank you!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-04-04 10:35</div><div class="msg">then let?s skip fixing of this bug now?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 10:36</div><div class="msg">Ok, so to just fix the issue and not introduce any behaviour different from develop, the app should just use the previously selected network after it's started again (point 2.), correct @sergii, @nastya, @roman?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 10:37</div><div class="msg">yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 10:38</div><div class="msg">Thanks</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 10:55</div><div class="msg">The /send and /request works good now, @andreap - thank you a lot! :+1:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 10:55</div><div class="msg">thank you</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 11:06</div><div class="msg">How are you doing on this @janherich? I think it might have to do with the :logout event ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 11:08</div><div class="msg">@yenda Working on it. The problem is ::save-network event, or at least it's red in re-frisk :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 11:09</div><div class="msg">`:logout` is not even performed, only `:close-application` effect is produced</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 11:11</div><div class="msg">And that effect is indeed problematic</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 11:26</div><div class="msg">The next issue:
|
|
?Contact who has been added (shared public key or QR) - won't see account updates (username/avatar) afterwards from those who sent ?Add me in your contacts? request?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 11:27</div><div class="msg">Ok, I think I know the reason, it's because all our writes are async now and app is closed before realm db write can be performed :slightly_smiling_face:
|
|
Easy to fix</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 11:27</div><div class="msg">To clarify the short scenario is:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 11:28</div><div class="msg">1) ContactA adds ContactB (via QR code scan or public key paste).
|
|
2) ContactB sees ContactA?s real name -> cool!
|
|
3) However, whenever ContactA updates his name or avatar - is not updated on ContactB side.
|
|
4) Vice versa - works fine though: if ContactB updates account data - it's right away reflected on ContactA side</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 11:35</div><div class="msg">@sergii thanks for reporting, will be looking into this, do you think this is a blocker for the merge or we can address it once merged?( we are quite keen to get this merged as this is a large PR and rebases are quite expensive)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 11:36</div><div class="msg">Not a blocker for merge at all!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-04 11:37</div><div class="msg">sweet, we will be looking into this, let us know if you find any other issue or when you are ok with us merging!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 11:54</div><div class="msg">Fixed, pushing the fix now</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 12:00</div><div class="msg">Ok, it's fixed @sergii @nastya, I will notify you once new build is ready</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 12:01</div><div class="msg">great!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 12:22</div><div class="msg">Branch: PR-3273
|
|
Android: <a href="https://i.diawi.com/2kHees">https://i.diawi.com/2kHees</a>
|
|
iOS: <a href="https://i.diawi.com/Cy6RFB">https://i.diawi.com/Cy6RFB</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 12:26</div><div class="msg">Offline inboxing is a bit buggy for me:
|
|
if the messages were sent to contact who is offline -> when he backs in online messages are not received *until* the message sender sends one more message? After that - the number of all offline messages appears in one scope as ?Waiting for message to arrive?? and keep staying in that state (waited 3+ minutes). However, re-login ?reveals? all the message content.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 12:27</div><div class="msg">Investigating?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 12:27</div><div class="msg">Just to clarify, this happens in 1-1 chat, correct ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 12:29</div><div class="msg">In 1-1 chat, yes</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 13:42</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3599">https://github.com/status-im/status-react/issues/3599</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 13:42</div><div class="msg">can be related?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 13:44</div><div class="msg">@sergii I was not able to simulate the bug - granted, sometimes offline inboxing takes longer to kick in, but it does, and sending another message is not trigger for it.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 13:46</div><div class="msg">I just tested the scenario you described, nothing happened for quite a long time and then all messages (previously sent while offline + new one) were received after ~ 2 minutes.
|
|
When I tried it again, everything worked fine</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 13:46</div><div class="msg">My suspicion is that our connection to offline inbox servers is not 100% reliable and fast all the time</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 14:07</div><div class="msg">hm? The outcome for me still the same. Scenario is:
|
|
1) Contact1 and Contact2 are in contact list of each other.
|
|
2) Contact2 - goes offline.
|
|
3) Contact1 sends 10 text messages in 1-1 chat.
|
|
4) Contact2 appears online - stays 5+ minutes. Nothing received.
|
|
5) Contact1 sends text message. Result - this last message sent while both online ?picks up? those what has been sent while Contact2 was offline.
|
|
6) Staying more than 5 minutes: those 10 messages all are ?Waiting for message?? + the last one.
|
|
|
|
Contact2 re-login - everything is OK (those offline messages appeared not right away, but pretty fast in 1-1 chat)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 14:22</div><div class="msg">@nastya issues/3599 looks very similar but i think the nature of this issue is different:
|
|
|
|
In my case for Offline - IF contact who was offline sends a message - no any offline-sent messages appear for him (*until* the other side sends the message once again). Messages picked up from offline inbox.
|
|
While in /issues/3599 history re-appears for me in any case - doesn?t matter who sent the message. Messages already in app.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 14:27</div><div class="msg">I?m testing with 2 iOS simulators and just can't simulate it :slightly_smiling_face:
|
|
What devices do you use for testing @sergii, android - ios pair ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 14:38</div><div class="msg">Yes. Android - iOS real devices. On both devices it's the same for me.
|
|
One note: push notification is received though. So I receive PN right away when appear online - navigate to 1-1 chat - nothing there. Once online-sender send one more message - everything appears (offline keep in ?Waiting for message??</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 15:08</div><div class="msg">Very strange, I will try with real devices</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 15:13</div><div class="msg">One more issue :disappointed: - very similar to what you @janherich fixed for ?Clear chat history? in <a href="https://github.com/status-im/status-react/issues/3719">https://github.com/status-im/status-react/issues/3719</a>
|
|
Public chat with received message exist -> ?Delete? or ?Leave? public chat -> relogin -> public chat reappears with all received messages.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 15:18</div><div class="msg">We can do it together if it helps: i can send you messages while you offline to contact on iOS simulator for debug.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 15:27</div><div class="msg">I will fix that, though I?m quite sure it will be present in develop as well :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 15:35</div><div class="msg">it is</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 15:35</div><div class="msg">we hope new protocol will fix it!
|
|
:smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 15:37</div><div class="msg">looking too</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 15:44</div><div class="msg">@janherich could it be for slow rendering UI or something? i can repro it as @sergii described</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 15:45</div><div class="msg">and my app closed itself on Android 7</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 15:45</div><div class="msg">:smile:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 15:46</div><div class="msg">I think it's something else, I?m fixing the reappearing deleted chat bug and will focus on it again after that.
|
|
UI is very fast in new protocol and it doesn?t happen at all when two iOS devices (simulators) are communicating, I will try with ios <-> android pair</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 15:49</div><div class="msg">Was anything done recently related to offline inboxing?
|
|
I've suddenly started to got app crashes (iOS and Android) last 30 minutes. Even with single 1-1 chat in contact occurred.
|
|
iOS fired an error once ?Out of memmory?
|
|
and TF logs continuously respond:
|
|
```02:59 D/ReactNativeJS: DEBUG [status-im.utils.handlers:35] - Handling re-frame event: :status-im.transport.inbox/fetch-peers
|
|
02:59 D/ReactNativeJS: DEBUG [status-im.utils.handlers:35] - Handling re-frame event: :status-im.transport.inbox/check-peer-added
|
|
02:59 I/ReactNativeJS: INFO [status-im.transport.inbox:145] - offline inbox: fetch-peers response [{:id "03f3661686d30509d621dbe5ee2e3082923f25e94fd41a2dd8dd34bb12a0c4e8fbde52247c6c55e86dc209a8e7c4a5ae56058c65f7b01734d3ab73818b44e2a3", :name "StatusIM/v0.9.9-unstable/linux-amd64/go1.9.3", :caps ["les/1" "les/2" "shh/6"], :network {:localAddress "192.168.2.63:55380", :remoteAddress "188.166.33.47:30303", :inbound false, :trusted false, :static true}, :protocols {:shh "unknown"}} {:id "dffef3874011709b12d1e540d83ddb19a9db8614ad9151d05bcf813585e45cbebba5aaea223fe315786c401d8cecb1ad2de9f179680c536ea30311fb21fa934b", :name "StatusIM/v0.9.9-unstable/linux-amd64/go1.9.3", :caps ["les/1" "les/2" "shh/6"], :network {:localAddress "192.168.2.63:56890", :remoteAddress "188.166.100.178:30303", :inbound false, :trusted false, :static true}, :protocols {:shh "unknown"}}]
|
|
02:59 I/ReactNativeJS: INFO [status-im.transport.inbox:151] - Peer <enode://fa63a6cc730468c5456eab365b2a7a68a166845423c8c9acc363e5f8c4699ff6d954e7ec58f13ae49568600cff9899561b54f6fc2b9923136cd7104911f31cce@163.172.168.202:30303> is not registered. Retrying fetch peers.
|
|
```</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 15:51</div><div class="msg">App crash is the out of memory issue? Last 6 hours it was all fine and I had numbers of chats.
|
|
Last 30 minutes suddenly app started struggle from ?out of memory? even with 1 chat?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 15:55</div><div class="msg">This is the classic log when the app fails to connect to the mailbox server</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 16:00</div><div class="msg">It shouldn?t crash with OOM though</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-04 16:02</div><div class="msg">android is not fast at all - very slow (android 7)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 16:10</div><div class="msg">Got it. Well that's the last what TF logs showing before session end (when app just closed)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 16:22</div><div class="msg">I just fixed it and pushed, once the new build is ready, you can re-test @sergii</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 16:23</div><div class="msg">I?m now experiencing similar issues as well, something is very wrong with offline inboxing, investigating</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 16:47</div><div class="msg">the big question is: is it also happening in develop ? because it's that the case it's better to merge and fix these issues in smaller PRs</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-04 17:33</div><div class="msg">Works perfectly now, @janherich! Thanks mega much! :+1:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 17:34</div><div class="msg">Exactly, I think that our offline inboxing is just unreliable overall - on develop is not so evident, because:
|
|
1. There are no placeholder messages, so it's easier to oversee that we are waiting for some messages to arrive
|
|
2. There is a (very expensive) re-delivery mechanism, so even when offline inboxing is not working and sender is online all the time, recipient waking from offline state will still receive the messages (because the sender tries to re-transmit them till ack is received)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 17:36</div><div class="msg">The question is now @yenda - for feature parity, do we want to implement delivery acking for `experiment/new-protocol-app` branch ?
|
|
I know it's expensive, but with unreliable offline inboxing, it's better then nothing.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 18:17</div><div class="msg">No we can do it later , because the redelivery only works when user is online all the time</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 18:18</div><div class="msg">so I think we should merge asap, then tackle issues one by one in small PRs that can actually be reviewed</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 18:19</div><div class="msg">we really need to ship this code to stop rebasing and see diffs clearly, we can't fix everybug that was already there in a new commit that will be squashed we need more tracability</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 18:30</div><div class="msg">I fully agree, I?m just trying to please QA so they will give us green light :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-04 19:28</div><div class="msg">I think mailservers might be overloaded currently because of the release ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-04 20:51</div><div class="msg">Sounds plausible</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-05 05:15</div><div class="msg">The average traffic per hour in idle state: 600k (i've measuring this for 12h).</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 05:58</div><div class="msg">it should be fixed now</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 06:12</div><div class="msg">For me the problem is mostly that you don't see the warning that there is a connection problem, it probably was removed because it's confusing. UI should tell you when it's still trying to connect to mailserver. The behavior you are describing as well as the logs from testfairy shows that you really just don't connect to mailserver</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 06:14</div><div class="msg">you see the "Waiting for message..." only after sending an additionnal message because up until then you just didn't receive any update of the contact clock so you don't know you missed 10 messages</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 06:15</div><div class="msg">@nastya regarding slow rendering and app closing itself do you have logs for that ? I blame develop btw :smile: it wasn't there before rebase afaikt and we didn't make changes that could cause that IMO</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 06:18</div><div class="msg">@sergii the logs you are showing should happen after troughly below 8 min of unsucceful connections (100 tries)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 06:22</div><div class="msg">@sergii @nastya Branch: PR-3273
|
|
Android: <a href="https://i.diawi.com/GZxCuh">https://i.diawi.com/GZxCuh</a>
|
|
iOS: <a href="https://i.diawi.com/7C6zwL">https://i.diawi.com/7C6zwL</a>
|
|
|
|
Build fixing the contact name update and including the reappearing messages fix</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 06:22</div><div class="msg">Could you close the bugs that have been already taken care off ? What is your call at that point how much testing is still needed ? Can we consider the offline inbox hiccups a separate concern ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 06:36</div><div class="msg">i will double check in develop for sure, logs in TF are not showing anything helpful :confused:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 08:42</div><div class="msg">Will review the bugs opened for new-protocol whether they are in develop already.
|
|
Not much testing is left (~2h i can finish it).
|
|
Lets aim on whether we can go for merge by the lunch time today, OK?
|
|
|
|
About offline inbox issues - how much time approximately it may take to fix it?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-05 09:17</div><div class="msg">@sergii @nastya let?s test last build of 3273 together in ?mini-dogfooding? session :slightly_smiling_face: <a href="https://meet.google.com/tdi-tbay-scb">https://meet.google.com/tdi-tbay-scb</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 09:18</div><div class="msg"><a href="http://prntscr.com/j15mqw">http://prntscr.com/j15mqw</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 09:18</div><div class="msg"><a href="http://prntscr.com/j15mxw">http://prntscr.com/j15mxw</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 09:41</div><div class="msg">There is an issue with message ordering:
|
|
Briefly it looks like as: three users join the same public chat -> first user sends more than 16 messages -> second user sends 17th message -> third user sees this 17th message somewhere above (or in between) those 16 messages..</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 09:43</div><div class="msg">Will log it as separate issue</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-05 09:43</div><div class="msg">Yes, the ordering is working correctly all the time only in 1-1 chat.
|
|
But this is the same in develop as well (will be solved by the consistent ordering implementation by @andreap later), very easy to simulate out of order messages with offline inboxing as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-05 09:43</div><div class="msg">public chat message ordering has not been improved, it's the same as develop I think</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 10:06</div><div class="msg">that would be great</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-05 10:17</div><div class="msg">oom <a href="https://app.testfairy.com/projects/4803590-status/builds/8047552/sessions/18/?accessToken=z5fA32H/RO3nD3YFwuo8B4YjTU0">https://app.testfairy.com/projects/4803590-status/builds/8047552/sessions/18/?accessToken=z5fA32H/RO3nD3YFwuo8B4YjTU0</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 11:35</div><div class="msg">@sergii @nastya <a href="https://jenkins.status.im/blue/organizations/jenkins/status-react%2Fpull%20requests/detail/PR-3273/207/pipeline">https://jenkins.status.im/blue/organizations/jenkins/status-react%2Fpull%20requests/detail/PR-3273/207/pipeline</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 11:37</div><div class="msg">@yenda @janherich i also logged some random crash that is happening in the new protocol branch <a href="https://github.com/status-im/status-react/issues/3774">https://github.com/status-im/status-react/issues/3774</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 11:38</div><div class="msg">why do I only see the crash report in test fairy session and not the logs and stuff as usual ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 11:38</div><div class="msg">nothing else was recorderd</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 11:39</div><div class="msg">but the app was just running in home tab</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 11:40</div><div class="msg">ok then I blame develop :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-05 11:52</div><div class="msg">hm</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-05 12:18</div><div class="msg">@nastya @sergii build is ready
|
|
Branch: PR-3273
|
|
Android: <a href="https://i.diawi.com/KFu4Pv">https://i.diawi.com/KFu4Pv</a>
|
|
iOS: <a href="https://i.diawi.com/KsZoB2">https://i.diawi.com/KsZoB2</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 12:22</div><div class="msg">Brilliant! Looking now!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 13:35</div><div class="msg">So the last build are fine and no OOM, app is responsive all the time for me whether it stays in idle state for 5+ minutes or I use the chats.
|
|
Issues we have:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 13:47</div><div class="msg">1) Message ordering in public chat: <a href="https://github.com/status-im/status-react/pull/3658">https://github.com/status-im/status-react/pull/3658</a> in develop already and awaiting new-protocol
|
|
2) Offline inboxing in 1-1 /public chat: no offline messages arrive when contact appears online until the offline-message-sender sends 1 more message.
|
|
3) I have contact on 0.9.16 with chats -> Upgrade to new-protocol -> Login and try to send a message in 1-1 / public chat. Message stuck in ?Sending?? state. Re-login / app-re-opening doesn?t help. Like: after upgrade - no ability to Send the message to previous accounts even they upgraded the app too.
|
|
4) Swipe to delete -> does not remove the chat (1-1/public). Only browsing items(Dapps/sites)
|
|
|
|
2nd and 4th - agree to fix after merge.
|
|
For the 3rd item - we?ll anyway have to have new accounts with the recent Wallet changes so the idea to merge new-procol+new Wallet</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 13:48</div><div class="msg">Am I right with the 3rd item, @yenda @janherich @andreap?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 13:52</div><div class="msg">One sec? I thought there was cut off branch made for next release 0.9.17 - but now I don't see it.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-05 13:54</div><div class="msg">Yes, we won't support migrations for release with new protocol (+ I guess wallet changes will be clumped into release with new protocol as well)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-05 13:54</div><div class="msg">Yes, does that mean we are ready to merge @sergii ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 14:15</div><div class="msg">Not this minute.. We need to align then with wallet changes.
|
|
I thought release/0.9.17 branch was cut off already, but it's gone (branch gone but Jenkins job left)
|
|
|
|
For the new-protocol we need wallet too? <a href="https://github.com/status-im/status-react/pull/3730">https://github.com/status-im/status-react/pull/3730</a> is not merged yet - and I?m thinking about so we not end up for both items in separate releases.
|
|
|
|
So, if have release/0.9.17 cut off made - we are good to merge. Let me check with core-release?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 14:34</div><div class="msg">@yenda @andreap @janherich - let?s merge new-protocol in develop!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-05 14:41</div><div class="msg">merged now, thanks for testing it @sergii</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 14:47</div><div class="msg">Thank you too @andreap I've pushed new build for develop.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-05 15:32</div><div class="msg">Branch: status-im:develop
|
|
Android: <a href="https://i.diawi.com/RorSNi">https://i.diawi.com/RorSNi</a>
|
|
iOS: <a href="https://i.diawi.com/Q52SJu">https://i.diawi.com/Q52SJu</a>
|
|
^^ The new develop builds with new-protocol ^^
|
|
|
|
Our next steps should be focused to polish it.
|
|
1) For Group Chat related issues i guess we need to enable back the Group Chat from ?Create new chat? list first.
|
|
2) List of Group chat related issues <a href="https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3Agroup-chat">https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3Agroup-chat</a>
|
|
3) Offline inboxing. I?m on the way to recheck it in above builds and submit the issues. With TF sessions.
|
|
4) Message ordering: <a href="https://github.com/status-im/status-react/pull/3658">https://github.com/status-im/status-react/pull/3658</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 07:00</div><div class="msg">@sergii can you sanity check this before merge ? <a href="https://github.com/status-im/status-react/pull/3779#pullrequestreview-109960351">https://github.com/status-im/status-react/pull/3779#pullrequestreview-109960351</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-06 07:23</div><div class="msg">On it now.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 07:47</div><div class="msg"><!channel> I've finished testing new communication protocol and here is some results.
|
|
|
|
The app had been tested for 12 hours in 3/4G internet.
|
|
Build:
|
|
Android: <a href="https://i.diawi.com/RorSNi">https://i.diawi.com/RorSNi</a>
|
|
iOS: <a href="https://i.diawi.com/Q52SJu">https://i.diawi.com/Q52SJu</a>
|
|
|
|
Inboard messages = 300 (12-13 messages per hour)
|
|
Outboard messages = 100 (4-5 messages per hour)
|
|
Message text size = *96B*
|
|
Traffic per message = *2.75K*
|
|
|
|
Total idle traffic per hour: *610K*
|
|
Non-ethereum traffic per hour: *56K*
|
|
Message traffic per hour: *183K*
|
|
Traffic per hour without testify and surveys API (instabug): *737K*
|
|
|
|
Daily traffic with testify and instabug: *18.59M*
|
|
Daily traffic without testify and instabug: *17.27M*
|
|
|
|
So, as expected, we've reached *17M* per day.
|
|
|
|
In total we have:
|
|
decentralized solution (@dmitry.shulyak is working on mailserver decentralization in separate issues)
|
|
dark routing and all messages are in darkness
|
|
17M per day traffic with average chat activity
|
|
|
|
Maybe its enough for us? Do we need yet another solution (and have more complicated application and infrastructure) to reach 10M per day, but have more compromises with darkness?
|
|
For me, its a fair deal to have +7M traffic overhead above 10M per day but in exchange for darkness.
|
|
Guys, I need your opinions and thoughts about further steps of the #071-low-traffic swarm.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-06 07:49</div><div class="msg">Wow crazy stuff! Also did you disable mixpanel ? (share data option)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 07:49</div><div class="msg">Yes, I did.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 07:55</div><div class="msg">@jeka Now when our data (and battery) consumption is drastically down, maybe we can start to think about carefully adding niceties like acking/nacking to see that message was delivered (`delivered` status), online/offline status sharing, `typing` hints for certain chats (`user is typing...` message), etc., while carefully monitoring traffic increase of course.
|
|
The question is what is acceptable traffic consumption for us ?
|
|
Also, we should probably try to simulate much higher (realistic) load on the network, with 10-100k of users, 20-30% of them actively chatting all the time, wdyt ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 07:59</div><div class="msg">Yeah! Maybe we should somehow simulate the average conditions (100 Out/ 300 In messages per day, size 89B) and have the test on it.
|
|
Then we can add new nice features.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:02</div><div class="msg">And yes, the one of the main questions for me is "while we were thinking about OKRs we'd write 10Mb/day number, but now we have a good solution with darkness feature with 17Mb/day. May be its enough for now?"</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:04</div><div class="msg">Yes. the thing is, with p2p networks, it's different if the network has 10 vs 1000 participants, even if the average number of messages for each participants is the same (eq in both cases, participants exchange messages with 2-3 others, similar amount of them), in latter case, much more traffic is forwarded through intermediate nodes because the network is potentially ?deeper? (connection between A and B goes through more hops).
|
|
I would be just careful to make sure we are counting with that</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-04-06 08:05</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:05</div><div class="msg">It's not difficult to test with additional traffic in 1000 more topics. I can do it today.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:06</div><div class="msg">Awesome !</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:13</div><div class="msg">How do you think is it enough to test with 1000 topics more with in total 100 messages per second?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-04-06 08:15</div><div class="msg">Inclined to agree. Based on <a href="https://github.com/status-im/status-react/issues/2931">https://github.com/status-im/status-react/issues/2931</a> this would appear to be in same ballpark as Telegram, which I think is Good Enough. I think it makes more sense to work on message reliability (OKR p0!) (and decentralization/robustness) right now. If someone has a great idea for how to make massive gains again then we can always create another swarm.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:16</div><div class="msg">Not sure to be honest, hard to predict network topography with bigger network.
|
|
Actually the new protocol uses only one fixed (discovery) topic + then one topic per each chat.
|
|
I?m not sure how whisper nodes work on low level, do they only relay messages matching their own topics ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:16</div><div class="msg">Or all messages ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-04-06 08:17</div><div class="msg">Also great job, remember how much BW was used just a few months ago! Huge kudos to everyone who made it happen in #071-low-traffic and #087-new-protocol :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:18</div><div class="msg">Yeah! Message reliability and scaling (now we have can scale only with cluster growth) much more important now.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:20</div><div class="msg">"Actually the new protocol uses only one fixed (discovery) topic" - is it because the issue of non sending messages without a subscription?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:21</div><div class="msg">I'm going to add traffic to random topics to see does it effects our numbers. If not we trust them,.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:27</div><div class="msg">@jeka Multiple reasons for that, it makes it easier to model group chat moderation as well (change participants -> new symmetric key needs to be broadcasted to all new participants, etc.) but yes, one of the reason was also that</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:31</div><div class="msg">I just worried that it was not the only reason. especially since it has already been solved.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-09-06/237954395223_d3ed19865c8990049e2b_72.jpg" /><div class="message"><div class="username">b00ris</div><div class="time">2018-04-06 08:32</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:40</div><div class="msg">No, no, there were other reasons as well :slightly_smiling_face:
|
|
What about the message relying, how does it work on whisper level, only messages matching node topic/s are relayed further, or all valid (ttl not expired) messages ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-06 08:43</div><div class="msg">@yenda looks not very good? Message exchange in this build really poor.
|
|
I checked current Develop and it's fine there.
|
|
|
|
So what happens is that Contact loses connection (not device!) too often. And all messages sent to him kept in offline inbox.
|
|
I couldn?t send 20 messages one by one and receive them on another side.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:45</div><div class="msg">A user receives messages in topics he subscribes + some topics he didn't subscribes to keep darkness.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:48</div><div class="msg">So the bloom filters not only work as a mean to ensure better privacy (not all traffic received/relayed by the node is destined for the node) but also as a mean to increase network reliability - as more traffic is relayed further by each node, correct ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:48</div><div class="msg">Yeah!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:49</div><div class="msg">Great, thanks for the explanation :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 08:52</div><div class="msg">Last question - the routing works purely based on topics, and encryption (asymmetric or symmetric) determines only if the node is actually able to decrypt and receive the message (listener fires off), but the messages are relayed further to other nodes regardless on the fact (able or not able to decrypt), correct ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 08:59</div><div class="msg">We have 2 node types: full and light.
|
|
Any full node must receive all traffic from all topics from its peers.
|
|
Any light node receives only messages matched to Bloom's filter filled by topics.
|
|
Any node must relay messages to its peers according to its types.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 09:01</div><div class="msg">@sergii have you been able to reproduce it ? because I'm a bit skeptical that it can be caused by this build, it only removes stuff that is not used anymore</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-06 09:08</div><div class="msg">Yes, reproducing all the time. Android - iOS pair -> can't exchange with 20 messages without one of the contacts connection drop off.
|
|
Looking Android(real)-Android(emulator) pair now..</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-06 09:41</div><div class="msg">The same on Android(real)-Android(emulator) pair? Fresh installs used.
|
|
There is a new develop build in process now - i?ll check there too. I was checking yesterday develop when I told ?works fine on develop?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 10:07</div><div class="msg">I've done retested the same scenario with 1000 messages per second in ethereum network. The results are the same. I dont see any changes in idle or chat mode.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 10:07</div><div class="msg">Awesome, thank you very much !</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-04-06 10:14</div><div class="msg">@jeka what about 1kk sending their contact with avatar image :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/9a90059210aaacfa5550a12d39020469.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0022-72.png" /><div class="message"><div class="username">jeka</div><div class="time">2018-04-06 10:24</div><div class="msg">It's easy, when it'll be a problem, we should update the communication protocol to solve it.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 10:27</div><div class="msg">I can't reproduce myself on ios/android pair</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 10:28</div><div class="msg">The problem must exist on develop there is no way this PR affect this, I would expect that the only thing that can go wrong is that it doesn't build but it does</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-09-06/237954395223_d3ed19865c8990049e2b_72.jpg" /><div class="message"><div class="username">b00ris</div><div class="time">2018-04-06 10:30</div><div class="msg">@andrey You don't receive any messages except reurning true in bloom?s filter) do we send images using one topic for all users?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 10:31</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3780">https://github.com/status-im/status-react/issues/3780</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 10:33</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3781">https://github.com/status-im/status-react/issues/3781</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 10:36</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3782">https://github.com/status-im/status-react/issues/3782</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 10:39</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3783">https://github.com/status-im/status-react/issues/3783</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-06 10:43</div><div class="msg">@b00ris Yes, we use fixed discovery topic for that (sending all user updates, including photo)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 11:23</div><div class="msg">@sergii I think we can merge my PR because @andrey seem to have that problem on nightly as well</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 11:24</div><div class="msg">I think it is something about the network</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 11:29</div><div class="msg">@sergii so can I merge ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-06 11:29</div><div class="msg">Lets merge, yes. I've marked PR appropriately</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 11:30</div><div class="msg">ok thanks next step is to remove migrations</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 11:31</div><div class="msg">we should include it in release because they are useless with breaking release</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-06 19:58</div><div class="msg">Regarding #3782 GHI Realm now supports primitive data types arrays <a href="https://github.com/realm/realm-js/pull/1345">https://github.com/realm/realm-js/pull/1345</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-09 06:44</div><div class="msg">@sergii This one just needs a sanity check <a href="https://github.com/status-im/status-react/pull/3791">https://github.com/status-im/status-react/pull/3791</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-09 07:20</div><div class="msg">On it now.
|
|
Please note today I?m off most of the day - just have a couple of hours to work for now.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-09 07:24</div><div class="msg">ok!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-09 07:40</div><div class="msg">Looks good!
|
|
Upgrade obviously failed, - well that expected due to removed migration :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-09 09:18</div><div class="msg">is it planned to enable group chats in nightlies ? @yenda</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-09 09:20</div><div class="msg">I?m currently working on that, should be finished today</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-09 09:22</div><div class="msg">great ! thanks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-09 15:10</div><div class="msg">Basic versionning support done <a href="https://github.com/status-im/status-react/pull/3812">https://github.com/status-im/status-react/pull/3812</a>
|
|
@janherich how are you doing with group-chats ?
|
|
@andreap any progress on clocks ?
|
|
that would be the left goals for iteration 1
|
|
I think the goals for iteration 2 are also pretty much done, I will start working on the `benchmark for bandwith consumption in advanced features allows testers to verify performance claims with real conditions`. we have to check that `traces of transport layer concerns have all been removed from the application code and database schemas`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-09 15:10</div><div class="msg">we should have a sync call today or tomorrow if you are ok</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-09 15:11</div><div class="msg">clocks is good to go, but test team is waiting for group chats to test it I believe <a href="https://status-im.slack.com/archives/C88MZP11P/p1523270625000358">https://status-im.slack.com/archives/C88MZP11P/p1523270625000358</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-09 16:18</div><div class="msg">I didn't want to smash everything (group chat bugfixing + contacts/groups refactoring) into one PR, but if it will speed things up, I will immediately start with bugfixing work in my refactoring PR</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-09 16:18</div><div class="msg">Which is ready and waiting for one more approval</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-10 05:22</div><div class="msg">I would like to implement this today wdyt ? <a href="https://github.com/status-im/status-react/issues/3815">https://github.com/status-im/status-react/issues/3815</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-10 13:03</div><div class="msg">@yenda in the <a href="https://github.com/status-im/status-react/pull/3812">https://github.com/status-im/status-react/pull/3812</a> - where exactly should the error appear for user for outdated type of message?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-10 13:03</div><div class="msg">I've intalled two builds from: 3811(outdated one) and 3812. When 3811 sends a message -> 3812 receives it fine. When 3812 send to 3811 -> nothing received + but see in the logs a `ERROR [status-im.transport.handlers:26] - Your version of Status is outdated and was not able to process a message you received`</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-10 13:35</div><div class="msg">It should be a popup</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-10 13:36</div><div class="msg">Yeah that's the error I thought they would popup</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-10 13:37</div><div class="msg">Doesn't it make a popup ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-10 13:42</div><div class="msg">nope, no popup. It?s `+ (log/error "Your version of Status is outdated and was not able to process a message you received")`
|
|
- apparently it's only in log, not a popup.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-10 13:49</div><div class="msg">I also think how it will deal with bunch of messages? Lets assume user with old app version received 100 offline inboxed messages after login. How will it behave - 100 popups overlapped ony by another?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-10 17:25</div><div class="msg">testteam it would be awesome if we could test & merge this soon - <a href="https://github.com/status-im/status-react/pull/3810/files">https://github.com/status-im/status-react/pull/3810/files</a> - it's growing big + it mostly fixes groups chats (they are already working except for couple of edge cases like adding new members, will be solved very soon)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-10 17:45</div><div class="msg">yeah update or die lol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-16/316437191861_849cef1f2e8411a22126_72.png" /><div class="message"><div class="username">lukasz949</div><div class="time">2018-04-11 07:06</div><div class="msg">@nastya @sergii do you need help with testing?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 07:07</div><div class="msg">i did not start yet, assume neither sergey. Feel free to take over</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 07:56</div><div class="msg">okay i will take it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-16/316437191861_849cef1f2e8411a22126_72.png" /><div class="message"><div class="username">lukasz949</div><div class="time">2018-04-11 08:04</div><div class="msg">looks like a big task. I can help you if you want. I can take one platfrom like iOS</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:04</div><div class="msg">i will take it, no worries</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:29</div><div class="msg">@janherich I am missing `faucet` in console for this PR, i am going to check in develop, but could you please check in your code too? /send and /request are shown in Console, but not /faucet</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 08:29</div><div class="msg">Ok, that's definitely wrong, `/send` and `/request` should not be shown there and `/faucet` should :slightly_smiling_face: Checking</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:31</div><div class="msg">i know the reason - mainnet is defaulted @janherich</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:32</div><div class="msg">:okay:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 08:34</div><div class="msg">Ok, so missing `/faucet` is not a problem then, but `/send` and `/request` in console are, does that happen in develop as well ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:34</div><div class="msg">looking now</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:37</div><div class="msg">in last nightly i dont see /faucet at all , only /debug under Mainnet - expected, so looks good, no send and request</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 08:37</div><div class="msg">Got it, something is wrong in my PR, fixing :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:38</div><div class="msg">thank you!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 08:46</div><div class="msg">Ok, commands fixed, new build will be ready soon</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 08:47</div><div class="msg">wow that was fast! :rocket:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 09:12</div><div class="msg">Build ready @nastya :
|
|
Branch: PR-3810
|
|
Android: <a href="https://i.diawi.com/KAi9rQ">https://i.diawi.com/KAi9rQ</a>
|
|
iOS: <a href="https://i.diawi.com/ZpCA2Y">https://i.diawi.com/ZpCA2Y</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 10:17</div><div class="msg">if we use this new post method what about third parties ? if they use the standard web3 they will have a much lower delivery rate</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 11:43</div><div class="msg">@janherich <a href="http://prntscr.com/j3rrzu">http://prntscr.com/j3rrzu</a> when re-adding user to group chat</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 11:44</div><div class="msg">+ we dont want to add dapps to group chats (as far as i remember)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 11:47</div><div class="msg">+ what is that message from system ? expected? <a href="http://prntscr.com/j3ru6g">http://prntscr.com/j3ru6g</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 12:16</div><div class="msg">@nastya yes, there are couple of glitches still, important is that nothing except re-introduced group chats is affected</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 12:17</div><div class="msg">I will take care of all those petty group-chat bugs in follow-up PRs :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 12:19</div><div class="msg">ah okay i see - then lets merge it as is</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 12:22</div><div class="msg">Great, thanks !</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-11 12:53</div><div class="msg">There is an issue with the contact status in 1-1 chat.
|
|
<a href="https://github.com/status-im/status-react/issues/3346">https://github.com/status-im/status-react/issues/3346</a>
|
|
|
|
In the past it was partially buggy for Android only. With the recent changes - the `Unknown` contact status is always present.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-11 12:54</div><div class="msg">Last release correctly behaves indicating `Online` or `1 minute ago` or `5 minutes ago`.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 12:56</div><div class="msg">there is no more online messages so there is nothing to put there</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 13:12</div><div class="msg">@janherich group chats will be disabled in develop right? :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 13:15</div><div class="msg">No they are enabled, if we don't fix all those issues in time, we can disable them for release</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-11 13:21</div><div class="msg">Well, then we need to include online messages to be sent to the contacts from user ?Contacts list?.
|
|
If not in contact list - no online messages for those.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 13:43</div><div class="msg">just asking - as this PR ^ after merge will produce issues i described above and they are not in GH yet</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 13:44</div><div class="msg">Most of them already is in GH, I even think all of them</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 13:50</div><div class="msg">my bad )</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 14:42</div><div class="msg">Quick protocol question: can a user update a message previously sent?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-11 14:45</div><div class="msg">no don't think so, I think we need to have a word with ux if we want to allow users to edit messages</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 14:45</div><div class="msg">this is not really a new protocol concern</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 14:46</div><div class="msg">if there was UX for it it would be feasible to implement it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 14:46</div><div class="msg">we could have a message-update type</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 14:48</div><div class="msg">but you can''t even do that with whatsapp</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 14:49</div><div class="msg">I think it needs to be tought trough at the UX level first it has a lot of implications</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 14:50</div><div class="msg">this feature is present in skype i believe, neither watsap nor viber</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 14:50</div><div class="msg">and nobody uses skype unless they are forced too :smile:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-11 14:51</div><div class="msg">exactly!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 15:42</div><div class="msg">You can in slack :)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 15:43</div><div class="msg">Ok but could be done if needed some day</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 15:48</div><div class="msg">Related: can a message payload be something more complex than a string? Like a map?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 15:50</div><div class="msg">RTFM :smile: <a href="https://docs.google.com/document/d/1Qh2h07T_qepzEJ7IytmxwIdQAOsGHrvhXwZxuZtbwgc/edit">https://docs.google.com/document/d/1Qh2h07T_qepzEJ7IytmxwIdQAOsGHrvhXwZxuZtbwgc/edit</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 15:51</div><div class="msg">but yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 15:54</div><div class="msg">@jeluard you mean chat message `:content`, or whisper message `:payload` ?
|
|
The answer to first question is yes (it's already the case for command messages), to second, on lower level it's just bytes, representing serialised (transit) clojure record, could be really anything</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 16:09</div><div class="msg">do you have a use case in mind to clarify @jeluard?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 16:19</div><div class="msg">I'd like to have special kind of messages (sent by external process) have custom display (could be handled by an extension)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-11 16:24</div><div class="msg">I would suggest to introduce a new `:content-type` or `:message-type` then ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 16:29</div><div class="msg">Cool! Will take a look.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-11 16:52</div><div class="msg">We should discuss the API when you have some time I've looked at what expo is doing and it's quite complex, we can use our jsc with react native web to mimic that, but it will be suboptimal. It's hard to let devs use a full programming language without security risks</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/2674ec9e762bcd011c9542c1b787ce13.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0019-72.png" /><div class="message"><div class="username">jeluard</div><div class="time">2018-04-11 16:58</div><div class="msg">Sure. I will share a document soon so that we can discuss.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-04-12 01:46</div><div class="msg">is there a plan to update the wiki with new protocol docs? would be useful to make sure people can find it and we can easily refer to it in the future</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-12 14:57</div><div class="msg">@janherich <a href="https://github.com/status-im/status-react/issues/3851">https://github.com/status-im/status-react/issues/3851</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-12 15:09</div><div class="msg">Sure, I will take care of that</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 11:16</div><div class="msg">Hey @janherich. For the issues: <a href="https://github.com/status-im/status-react/issues/3705">https://github.com/status-im/status-react/issues/3705</a> and <a href="https://github.com/status-im/status-react/issues/3701">https://github.com/status-im/status-react/issues/3701</a> - i?m going to update the description.
|
|
|
|
At the moment, in latest nightly, what happens is that there is NOT `no contact at all on non-admin group chat..` - but ?Non-admin member doesn?t see Admin in the lists of group chat people?
|
|
|
|
So currently issues and reproduction is valid, but it might be helpful to know scenario with 3 contacts?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-13 11:19</div><div class="msg">Thanks @sergii, I'm working on that :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 15:53</div><div class="msg">Hey @yenda @janherich - we?ve encountered one major issue with current develop?
|
|
There are current develop build and 0.9.17 release candidate build exist.
|
|
When contact using Develop build sends a message (doesn?t matter - 1-1/public chat) to contact who is on 0.9.17 - app crashes on 0.9.17 side.
|
|
|
|
I'll create issue quick - we?ll check another nightlies to find out when it was introduced?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 15:57</div><div class="msg">From the first view it may look a rare case? But in fact we can't release 0.9.17 until it's fixed: imagine 10k users instal 0.9.17 after release. And one user install latest develop.
|
|
Everyone are using status public channel. This one user sends a message and it brakes 10k of 0.9.17 apps?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:26</div><div class="msg">what's the exact error message?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 16:41</div><div class="msg">No error messages - app just freeze and stops.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:41</div><div class="msg">ah ok, thanks</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 16:42</div><div class="msg">I've just found when it was introduced..</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:42</div><div class="msg">can you send the commit?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 16:43</div><div class="msg">334th Jenkins nightly build -> sends a message to 333rd Jenkins nightly -> 33rd crashed.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 16:43</div><div class="msg">Looking the list of commits now first, yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:45</div><div class="msg">I have it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-13 16:48</div><div class="msg">@andreap can you share the commit ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:49</div><div class="msg">I don't have the commit, I have a bunch of commits, but it's 99% the stuff I worked on, the clock commit, I don't think is backward compatible, but should be easy to extend</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:50</div><div class="msg">Can we just cherry pick it in the release branch?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-13 16:57</div><div class="msg">That would be probably the best solution indeed, can you handle that @andrey?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 16:57</div><div class="msg">I can do that, I have already the commit picked locally</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 17:01</div><div class="msg">@sergii <a href="https://jenkins.status.im/job/status-react/job/release/job/release%252F0.9.17/11/">https://jenkins.status.im/job/status-react/job/release/job/release%252F0.9.17/11/</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 17:01</div><div class="msg">Described the issue in <a href="https://github.com/status-im/status-react/issues/3870">https://github.com/status-im/status-react/issues/3870</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 17:02</div><div class="msg">:hushed: Do you mean that build release%252F0.9.17/11/ should fixes the issue, @andreap? That?s pretty fast!!</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 17:03</div><div class="msg">maybe, haven't tested it, but I did nothing :slightly_smiling_face: I just cherry picked a commit from dev</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 17:05</div><div class="msg">The ?the clock commit? - is it the one fixing message ordering in chats?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-13 17:09</div><div class="msg">yes</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-13 17:14</div><div class="msg">Heh, cool! We thought during dogfooding meeting to cherry pick that one in release, so awesome!
|
|
Waiting the build?!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-10-03/448433513781_35b198abdf960e874693_72.png" /><div class="message"><div class="username">jarradhope</div><div class="time">2018-04-13 21:17</div><div class="msg">will the new protocol handle multiple device synchronization?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-14 06:21</div><div class="msg">If we solve the account data synchronisation (dumbest solution would be to do it over whisper as well) it is much easier now because with symmetric keys we also receive our own messages</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-14 13:48</div><div class="msg">@sergii regarding <a href="https://github.com/status-im/status-react/pull/3812">https://github.com/status-im/status-react/pull/3812</a> maybe we could show a warning in the chat similar to connexion lost to indicate the user that the contact uses an incompatible version instead of popups ? We could ask designteam about this</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-14 14:42</div><div class="msg">Hmm, yeah! Makes more sense for me! And we won't even care with how many times it appear or disappear.
|
|
Just hang a label 'You are using older version...." on Home screen once first message received.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-14 15:48</div><div class="msg">Ok will do</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-14 17:24</div><div class="msg">Probably not ok to have alerts overlap like this with the first element of chat list, any suggestion ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-14 17:30</div><div class="msg">Perhaps add some copy that helps the user? eg add ?Please upgrade.?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-14 17:33</div><div class="msg">Sure I'll add that</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-14 17:33</div><div class="msg">but also need to settle on color of the alert, overlap or not overlap, etc...</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-14 17:36</div><div class="msg">@nikitalukyanov ^^^^</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-16 09:41</div><div class="msg">@nikitalukyanov is there already some designs for these kind of warnings you could point me to ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 06:26</div><div class="msg">@janherich morning :slightly_smiling_face: I see several bugs for group chats but not sure in what state group chats are now. Like the removed member can still see the group chat, write there and other members will see that messages. Also it's not possible to add a member `nth is not supported on this type` is shown after Add. If leave group chat and relaunch the app -> empty left chat is shown and new messages there also are shown.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 06:27</div><div class="msg">I can add all these as new issues in case group chats are considered done</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 06:33</div><div class="msg">Yes, please do that, I was not aware of those bugs, I will try to fix them all today :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:13</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3891">https://github.com/status-im/status-react/issues/3891</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 07:14</div><div class="msg">Thanks @anna, on it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:15</div><div class="msg">@hester @denis-sharypin @nikitalukyanov @andmironov when user is removed from the group chat should this user see the chat in the Home tab and be able to read history of the chat before it was removed? I would say yes as I might need some info from the history and I was proven member so have rights to see it. Agree?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-04-17 07:20</div><div class="msg">user was removed or left by herself?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:20</div><div class="msg">removed</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-04-17 07:23</div><div class="msg">Okay, I agree. User should see as the last message in this chat something like this: You was removed by `username`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:26</div><div class="msg">and previous messages too, so when user relaunches the app then this group chat should be still visible with the previous messages and last one ?You was removed? right?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:26</div><div class="msg">@janherich another one <a href="https://github.com/status-im/status-react/issues/3892">https://github.com/status-im/status-react/issues/3892</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:48</div><div class="msg">@denis-sharypin now similar question but for the case when user left the chat :slightly_smiling_face: Should we show it in Home tab? I think yes, because it's kind of ?do not spam me anymore? rather then remove the conversation</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-04-17 07:50</div><div class="msg">we can keep until user delete it by herself</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-04-17 07:52</div><div class="msg">I?m trying to put all chat behavior in the one table <a href="https://docs.google.com/spreadsheets/d/1zld4jT8DupiwLwWePZ6lg-O4cs-Iwq6WKtky31y72Ac/edit#gid=0">https://docs.google.com/spreadsheets/d/1zld4jT8DupiwLwWePZ6lg-O4cs-Iwq6WKtky31y72Ac/edit#gid=0</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 07:52</div><div class="msg">But deleting the chat (either by swiping or by `options` -> `delete`) actually only hides the chat from home tab (this is consistent among all types of chat), while leave (available only for public & group chats) does the same + makes sure that the chat never pops up again (not listening to new messages anymore)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 07:53</div><div class="msg">I think it would be confusing if the `leave chat` option would leave the chat on home tab, despite being more ?hard? delete then the `delete chat` which hides the chat from home tab</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 07:53</div><div class="msg">We should probably revisit our vocabulary, eq `hide chat` instead of the `delete chat`, etc.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 07:55</div><div class="msg">and the last one: <a href="https://github.com/status-im/status-react/issues/3893">https://github.com/status-im/status-react/issues/3893</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-04-17 07:55</div><div class="msg">@janherich I was thinking about it as well. But only I want to rename ` delete chat` to `archive chat`</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 08:10</div><div class="msg">@janherich not sure but it also might be a side-effect of new protocol <a href="https://github.com/status-im/status-react/issues/3894">https://github.com/status-im/status-react/issues/3894</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 08:15</div><div class="msg">Yes, it is, we can upgrade new protocol to support such functionality</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-17 09:07</div><div class="msg">but it makes it easy to spoof someone identity</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 09:08</div><div class="msg">it was a call from @chad in <a href="https://github.com/status-im/status-react/issues/3894">https://github.com/status-im/status-react/issues/3894</a> so maybe he can comment on spoof someone identity</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 09:09</div><div class="msg">Display name isn't an identity</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 09:09</div><div class="msg">sorry wrong link, here is correct one <a href="https://github.com/status-im/status-react/issues/2892">https://github.com/status-im/status-react/issues/2892</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 09:09</div><div class="msg">#145-identity and #151-ens-usernames will work to solve identity and real usernames</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-17 09:10</div><div class="msg">@chad correct, I rather meant that with current UI it's easy to pretend to be someone else</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 09:10</div><div class="msg">Which part of the UI?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-17 09:18</div><div class="msg">The public chat UI</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 09:19</div><div class="msg">Yes, at the moment those 3 random words are the only way to tell if I am talking to the same person, provided they are generated on my device from the pk of the author of the message</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:16</div><div class="msg">@sergii if you are still on the nightly and ropsten then can you check what happens when new user joins existing public chat, please? I?m on mainnet with rpc and nightly build and have some unexpected behaviour: user joins existing public chat and see only new messages than user relaunches the app and public chat gets all messages, so history before user joined is shown to him. I don't think it's expected</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-17 12:18</div><div class="msg">Checking what happens on Ropsten now.
|
|
Then on Mainnet.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:19</div><div class="msg">on mainnet there is no need - I can confirm it happens there</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:19</div><div class="msg">need to know if it's unique or happens also for ropsten</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-17 12:23</div><div class="msg">yes. So i?m Ropsten with upstream -> joined status channel -> empty chat list -> re-login -> yesterday messages arrived.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:26</div><div class="msg">ok so it looks like common issue in nightly</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:27</div><div class="msg">@anna I have noticed that before, is it not an existing issue? ( I always had to logout/login again to receive old messages for a public chat)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-17 12:28</div><div class="msg">For Mainnet RPC - there are even more messages (those which I sent earlier from Mainnet + those which come for user who joins being on Ropsten.
|
|
|
|
Yep, it's not expected to pull the history for public channels.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:29</div><div class="msg">@sergii you mean we should never pull old messages from a public chat ? ( it always did, but you had to logout/login)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-17 12:31</div><div class="msg">@andreap issue is that we pull the history from public channels even. So, *very new account* created -> joins @status (basically existing channel) -> relogins -> yesterday history appears for this new account.
|
|
|
|
That what is not expected.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:32</div><div class="msg">ok, thanks for clarifying, I didn't know that we should not pull history from public chats</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:33</div><div class="msg">actually, it's a good moment to think if we want to. Same for user who will join group chat later - do we want user to see previous messages?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:33</div><div class="msg">I'd say yes, but I might not want to receive push notifications for those :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:33</div><div class="msg">I would expect that I can see only messages since the moment I've joined</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:34</div><div class="msg">we can also check with UX as always :slightly_smiling_face: @denis-sharypin @hester @nikitalukyanov @andmironov should user who joins public or group chat see all messages sent before user joined?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:35</div><div class="msg">and @chad ^</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:36</div><div class="msg">maybe we can even have 2 options (with past history or without) that user can select when joining chat.. if technically possible :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:38</div><div class="msg">One option is probably easier, less code & less to test :slightly_smiling_face: Personally I see no harm in showing old messages, other then the push notifications, but either ways seems reasonable to me</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 12:39</div><div class="msg">On a busy channel I don't care about older messages as there are lots of new ones. On a quiet channel I like to see last X messages for context</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:42</div><div class="msg">at that point though I would always show the last x messages, it's more predictable for the user (we would have to make a decision ourselves of what a busy channel is), also makes the system slightly easier</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 12:43</div><div class="msg">Is it easy to show Last 10?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:43</div><div class="msg">no :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:43</div><div class="msg">I don't think we can show the last x , I don't think we can guaranteed the number</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:43</div><div class="msg">it depends on what the mailserver holds</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:44</div><div class="msg">so if it's really busy, it will start evicting messages</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 12:44</div><div class="msg">I think it is also fine for beta to show none</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:45</div><div class="msg">yes, I agree both are fine, UXR any opinion/preference?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-17 12:47</div><div class="msg">Heuristic: get the basics working solidly for beta. post beta we can improve based on research and user input and other signals</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:55</div><div class="msg">I would show none because we have no idea how much data will be shown and if it's a lot of data then it might slow down the UI when user does not expect it at all</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:56</div><div class="msg">just out of curiosity, for 1to1 and group chat what we do?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:56</div><div class="msg">(or what we should be doing, as it seems there's some differences on what the code does and what we expect it to do)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:57</div><div class="msg">for group chats can tell now have other bug that I can't add new member to existing group chat.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:57</div><div class="msg">ok, do we know what is the expected behaviour though?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 12:58</div><div class="msg">as I remember we had no past history when new user was added to the group chat</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 12:59</div><div class="msg">yes, that's true, there's no way to fetch past history for new users</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 13:00</div><div class="msg">so it's only public chat that differs, sounds reasonable not to show any old messages then</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-17 13:01</div><div class="msg">i?m on the way to describe public chat issue now?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 13:02</div><div class="msg">But it's not particularly easy to do (show no message history for public chats older then time of joining + support offline inboxing), because we (currently) don't have the ability to issue time based query to offline inboxing, it's either all or nothing.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 13:04</div><div class="msg">So if it's not super bothering (my opinion would be it's not), I would very much like to wait with the proper implementation till we get that from goteam (time constrained queries for offline inboxing), because otherwise, we would have to support it with complicated (and perf sensitive) hacks, like filtering out all ?old? messages on the device after requesting all of them.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 13:12</div><div class="msg">@janherich just to understand, you are saying not to use offline inbox at all for public chats?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 13:17</div><div class="msg">@andreap No, not at all, that would make them (nearly) useless. What I want to say is to leave the behaviour as it (sure create an ticket/specify design, but not work on it immediately) and start fixing it once we get time-based queries for offline inboxing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 13:19</div><div class="msg">Ok, I think performance should not be impacted by filtering out messages that have been posted after you joined, but that's probably a discussions for pms :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-17 13:28</div><div class="msg">Yes, it won't be impacted compared to current impl (we receive all of them anyway), it will be compared to ideal (and much leaner code wise) impl with time based queries :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-17 13:29</div><div class="msg">cool, that's what I was confused about, thanks for clarifying</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-17 13:29</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3898">https://github.com/status-im/status-react/issues/3898</a> - this is for public chat issue.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-17 13:36</div><div class="msg">kudos @andreap and @janherich for clarifying expectations for the current and future implementations of the past history in the group chats and digging for it as deep as needed to get it clear :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-18 08:25</div><div class="msg">@sergii will you add the current expectations to the test cases?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-18 08:35</div><div class="msg">Yes, sure, will update appropriate existing test cases.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-18 09:57</div><div class="msg">@jeka regarding `Dealing with offline inboxing: there is deduplication for messages sent by peer nodes but there is no deduplication of the messages sent by the offline inbox with direct p2p.` do you think something can be done about this ? cc @janherich</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-18 13:07</div><div class="msg">/kudos @janherich for dealing with the last bugs in the protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-17/348134203537_1bc2a6f28471cf6ec828_72.png" /><div class="message"><div class="username">hutch</div><div class="time">2018-04-18 13:40</div><div class="msg">Would you say 3 months is an accurate timeframe for R&D for this new protocol? (just for announcements purposes)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-18 13:43</div><div class="msg">2 or 3months, whatever sounds better :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-19 10:45</div><div class="msg">Hey @janherich could you please rebase <a href="https://github.com/status-im/status-react/pull/3904">https://github.com/status-im/status-react/pull/3904</a> off of develop please?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-19 10:52</div><div class="msg">Sure, rebasing</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-19 10:54</div><div class="msg">Done, new build should be ready soon</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-23 07:52</div><div class="msg">@janherich when user recovers account then messages sent to him from users who were in his contacts are not received. Is it same issue as with default Jarrad?s contact? Would you mind if I'll add it to GH?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-23 07:54</div><div class="msg">Yes, it's essentially the same issue, and yes, please add it to GH, thanks :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-03-08/150717543185_46c3b78ed6fd88d4b338_72.jpg" /><div class="message"><div class="username">anna</div><div class="time">2018-04-23 10:38</div><div class="msg"><a href="https://github.com/status-im/status-react/issues/3963">https://github.com/status-im/status-react/issues/3963</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-26 12:43</div><div class="msg"><!here> @janherich @andreap we should have a call to evaluate the state of this swarm and eventually close it and agree and what documentation to leave behind, is tommorow ok for you ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-26 12:45</div><div class="msg">Yes, fine for me</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-04-26 12:58</div><div class="msg">same here</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-26 14:20</div><div class="msg">@yenda could you look please at <a href="https://github.com/status-im/status-react/pull/3872">https://github.com/status-im/status-react/pull/3872</a>
|
|
@janherich could look please at <a href="https://github.com/status-im/status-react/pull/3904">https://github.com/status-im/status-react/pull/3904</a>
|
|
Also, can we check if ?contact online? issue <a href="https://github.com/status-im/status-react/issues/3346">https://github.com/status-im/status-react/issues/3346</a> can be fixed too (need to add online messages)?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-26 14:22</div><div class="msg">Add me please to the invitation list :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 08:36</div><div class="msg">@yenda set the channel topic: <a href="https://ideas.status.im/ideas/87-new-protocol">https://ideas.status.im/ideas/87-new-protocol</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:25</div><div class="msg">@sergii don't forget to add the label to the group-chat issues you want to be solved in that swarm</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-27 11:28</div><div class="msg">@yenda we have 18 issues already for group chats and 3 for new protocol (labeled as such) . Could it be a scope for this swarm? <a href="https://github.com/status-im/status-react/issues?q=is%3Aissue+is%3Aopen+label%3Agroup-chat">https://github.com/status-im/status-react/issues?q=is%3Aissue+is%3Aopen+label%3Agroup-chat</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:37</div><div class="msg">ask @janherich but I would say the rule of thumb is that the issue that are labeled as new protocol should be stuff that need to be fixed and not features</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:37</div><div class="msg">I made a PR to update our swarm after our sync call <a href="https://github.com/status-im/ideas/pull/224">https://github.com/status-im/ideas/pull/224</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-27 11:38</div><div class="msg">it is difficult now understand what is related to new protocol and what is not , i am just worrying that we have a lot of group chat issues and not sure which swarm i should address them to</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:41</div><div class="msg">kudos @janherich for all the work on fixing the issues of this swarm over the past weeks (and those to come :wink: )</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:42</div><div class="msg">kudos @sergii for cleaning up our issue tracker and helping me sort it all out</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:43</div><div class="msg">if it's an issue (something doesn't work) I think you can reasonnably put it in this swarm</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-27 11:43</div><div class="msg">yes i believe 90 % of the bugs are bugs and not features</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:44</div><div class="msg">please add them then because otherwise they won't have any visibility</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-27 11:44</div><div class="msg">Yes, I?m about to put a `new-protocol` label on issues from that list.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-27 11:44</div><div class="msg">do we have a board? )</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:44</div><div class="msg">No we don't atm</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-27 11:44</div><div class="msg">lets put them all on board - and then review -retest - kill</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:46</div><div class="msg">I don't think we need one there is already the QA pipeline that should be enough</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 11:46</div><div class="msg">one just has to filter by label to get the 87-new-protocol labels only</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-27 11:46</div><div class="msg">I think label is enough</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-04-27 11:46</div><div class="msg">okay</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-28/338213459126_9a2080e57364819a4d87_72.jpg" /><div class="message"><div class="username">andrey</div><div class="time">2018-04-27 12:32</div><div class="msg">are we ready to refactor names and move chat ns into ui ? :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-27 12:41</div><div class="msg">I would say yes</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 14:51</div><div class="msg">@sergii @nastya after discussing with @chad it seems like the consensus for this swarm is to exclude group chats completely <a href="https://github.com/status-im/ideas/pull/224#discussion_r184694789">https://github.com/status-im/ideas/pull/224#discussion_r184694789</a> (cc @janherich don't focus on these issues then)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-04-27 14:58</div><div class="msg">I?m not, I will open PR hiding the group chats behind flag set to false by default (so we can easily re-enable them in dev mode for testing)</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-04-27 15:53</div><div class="msg">Okay.
|
|
Then not so much left for this swarm:
|
|
- already existing PRs - <a href="https://github.com/status-im/status-react/pulls?q=is%3Aopen+is%3Apr+label%3A87-new-protocol">https://github.com/status-im/status-react/pulls?q=is%3Aopen+is%3Apr+label%3A87-new-protocol</a> (GroupChat related PR 3904 -> not a blocker for end of swarm)
|
|
- and this bug `'Unknown' contact status in 1-1chat while this contact is online`( <a href="https://github.com/status-im/status-react/issues/3346">https://github.com/status-im/status-react/issues/3346</a> ) - the user online/offline presence indication really got dropped after new protocol (so always Unknown is displayed).</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 16:03</div><div class="msg">@chad what is the status of <a href="https://github.com/status-im/status-react/issues/3787">https://github.com/status-im/status-react/issues/3787</a> regarding design ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-27 16:07</div><div class="msg"><a href="https://status-im.slack.com/archives/C9B1T4B9B/p1524830674000065">https://status-im.slack.com/archives/C9B1T4B9B/p1524830674000065</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-04-27 16:07</div><div class="msg">Lost a designer but getting some help</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-04-27 16:15</div><div class="msg">nice thanks for the update!</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-12/285383092772_62dfbe80e57ef8940bb7_72.jpg" /><div class="message"><div class="username">sergii</div><div class="time">2018-05-02 08:01</div><div class="msg">@chad since we dropping group chats from scope of this swarm, - which swarm is the best to include them then?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-07-31/220671542518_0d49983291e646e395f0_72.jpg" /><div class="message"><div class="username">nastya</div><div class="time">2018-05-02 08:41</div><div class="msg">we have a lot of issues for group chats and public chats seems to be working incorrectly\</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-10-03/448433513781_35b198abdf960e874693_72.png" /><div class="message"><div class="username">jarradhope</div><div class="time">2018-05-02 09:31</div><div class="msg">btw we need to incorporate forward secrecy into our messaging protcol at some point <a href="https://github.com/status-im/doubleratchet">https://github.com/status-im/doubleratchet</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-05-02 09:32</div><div class="msg">99 can take a look at it. but first lets get 1-1 and public chats working 100%</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 09:58</div><div class="msg">on that topic, I think at some point there needs to be a deeper discussion and some conclusion about this - there is very little clarity on the tradeoffs that we're willing to make, or even understanding what consequences of certain choices are... for example, direct p2p keeps coming up as an idea in various shapes and forms (latency reduction, vid/aud calls) which breaks a premise of whisper, as well as other "optimizations" that give up features of whisper (topic routing, etc). I've been looking a little at various other clients to come up with something more meaty as a base for discussion, but it'll take a little longer to research. forward secrecy in the left hand will not help if the right hand leaks the message some other way.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 09:59</div><div class="msg">the only thing I've heard so far is "dump the choice on the user" but even then, we should know what security properties we're shooting for, and why.. ie in a binary choice, how secure is option a and option b?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 10:01</div><div class="msg">here's an example: <a href="https://briarproject.org/how-it-works.html">https://briarproject.org/how-it-works.html</a> (thanks @yenda!)
|
|
> ```Briar is designed to resist surveillance and censorship by an adversary with the following capabilities:
|
|
|
|
All long-range communication channels (internet, phone network, etc) are comprehensively monitored by the adversary.
|
|
...
|
|
```</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 10:01</div><div class="msg">once you know that, you can make protocol and ux choices based on that list, or reject features that do not fit</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-10-03/448433513781_35b198abdf960e874693_72.png" /><div class="message"><div class="username">jarradhope</div><div class="time">2018-05-02 10:06</div><div class="msg">looking forward to seeing the mapping that comes out of that @arnetheduck.slack</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-05-02 10:21</div><div class="msg">+1 for clarity around tradeoffs we are willing to make, and more generally a more considerate protocol design/research pov on this problem</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 11:05</div><div class="msg">I agree in this particular instance though, FS is a nice feature in general, and if it happens to get implemented without any bad consequences, it's a step forwards :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 11:06</div><div class="msg">so what I want to say is, let's not hold back small improvements while waiting for something that doesn't exist</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-02 11:10</div><div class="msg">I've read signal doubleratchet paper a few time and it feels like a really heavy protocol with lots of conditions for FS to be working.</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-05-02 11:58</div><div class="msg">@yenda what's the state of this swarm? do you think we can wrap it up soon? there's some overlap with this and 99 - maybe we can make sure all reliability regressions are dealt with in context of that swarm? this is by far the most important thing for core.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-02 12:02</div><div class="msg">we'll discuss that during sync call but I think it's pretty done. I'll submit a PR soon for mailserver and we can move the issue @andreap is working on to #099-confidence</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-06/310412231971_aab33885aa55d16e4740_72.jpg" /><div class="message"><div class="username">arnetheduck.slack</div><div class="time">2018-05-02 12:07</div><div class="msg">heavy as in.. having properties preventing us from using it, or just hard to understand?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-05-02 12:10</div><div class="msg">ok cool</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-05-02 12:11</div><div class="msg">it seems to me like a bunch of the reliability regressions come about as part of new protocol change. What do you think about you and Jan being part of 99 and making sure those things are fixed? whatever this means. Because reliability is the #1 prio still, I think @roman might have some thoughts on what this means in practice (acks or whatever)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-02 12:55</div><div class="msg">heavy as in lots of overhead</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 07:09</div><div class="msg">it does have quite a lot of overhead, but I'd say the advantages are not only on security, but also in PR (decentralized p2p app with dark routing using the signal protocol). The best outcome would be to be able to re-use libsignal (there's a version for both android & ios). It is tricky though to implement over whisper, just by thinking it a bit roughly we'd definitely would have to use header encryption, at that point it can be sent unencrypted over whisper but then we are not really using much of whisper features (I remember someone saying that unencrytped messages would not be supported). We can also use whisper and encrypt the whole message with header encryption (so part of the message would be encrypted twice).</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:30</div><div class="msg">@andreap @janherich I think we should have a test suite before implementing big changes like this <a href="https://docs.google.com/document/d/1e4-lRuA8n6_btE1W8Y33RreiWYDE_L81g3OV3_6_4Bo/edit">https://docs.google.com/document/d/1e4-lRuA8n6_btE1W8Y33RreiWYDE_L81g3OV3_6_4Bo/edit</a>
|
|
Right now the biggest issue for me is the lost of contact request and I don't understand how that proposal solves it, there is already a ack for the contact request, the problem is that: contact requests are not indempotent/somehow they are lost, even to the mailserver/we don't do anything in case of no ack. With wallet recovery you lose all your contacts anyway, if this is solved topics recovery will probably be solved as well.</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:31</div><div class="msg">@andreap @janherich also I think the reason contact requests are lost is pretty simple, afaict we don't requestMessages for the discovery-channel</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:32</div><div class="msg">maybe the fix is just doing that for now (along with allowing to resend a contact request)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-05-03 07:32</div><div class="msg">I added one comment to the document, I think we should have a call and discuss it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-05-03 07:34</div><div class="msg">But I mostly agree, we already have ack for exchanging symkey (request/response), so just using shared-topic/pubKey and trying to establish specific-topic/symKey as early as possible (and rely on that *only* after confirmation) would be good compromise I think</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 07:37</div><div class="msg">we can do, I think though that if we want to keep exchange out-of-band it needs to be justified, in-band (with the message) at this point makes much more sense</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:40</div><div class="msg">exchange is in band already, the message is the contact request wrapped with key exchange</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:40</div><div class="msg">same thing can be done in later messages or maybe I misunderstand you</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 07:40</div><div class="msg">when i say in-band I mean with a chat message</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:40</div><div class="msg">ready for call we can do the sync call today instead of tomorrow</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:41</div><div class="msg">contact-request is a special kind of chat message</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-05-03 07:41</div><div class="msg">I think that key exchange should be message type agnostic (it's kind of is already because of the wrapping)</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-05-03 07:41</div><div class="msg">I?m ready for call in 1 hour</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:42</div><div class="msg">ok meanwhile I will check my claim that we don't request messages for the discovery channel</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 07:43</div><div class="msg">I am good anytime. @yenda to be reliable you need a SYN-SYN-ACK-ACK type of exchange, that problem has been solved many times. You can't rely on the transport layer to be reliable</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 07:46</div><div class="msg">I don't think it applies here</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 07:46</div><div class="msg">why?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-12-19/289021559940_764a5c704a5a99098d7a_72.jpg" /><div class="message"><div class="username">oskarth</div><div class="time">2018-05-03 08:00</div><div class="msg">Can this effort be synced up with 99 swarm and @roman? Seems useful to make sure everyone is on the same page and working towards same goal</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 08:05</div><div class="msg">what do you mean ? inviting them to this call ?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 08:06</div><div class="msg">@oskarth sure, also I have added the iterations to the docs if you want to have a look</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-08-27/423671855091_1b4f90cfbdd6a3ee2b6f_72.jpg" /><div class="message"><div class="username">roman</div><div class="time">2018-05-03 08:08</div><div class="msg">i?m on train, can't attend until ~ 3:30 PM CEST</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 08:09</div><div class="msg">mmh, I don't think a call with many participants is the best place to discuss the inner details of the protocol :slightly_smiling_face:</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 08:10</div><div class="msg">at that point asynchronous seems to be better, we could have a call to understand the direction</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 08:11</div><div class="msg">we'll just have a call with Jan in a moment and report, it's more about exchanging our pov quickly at that point because we seem to have different ideas</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 08:16</div><div class="msg">I'm making a PR to fix the discovery channel offline inbox, I wouldn't be surprise if the reliability goes up as proably quite a few lost messages are due to the fact that if the contact request is not received further messages are not either</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/8f5d17c2210ba9813f6612330fc0fc66.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0014-72.png" /><div class="message"><div class="username">janherich</div><div class="time">2018-05-03 08:29</div><div class="msg">I?m ready for call whenever you are</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 08:32</div><div class="msg"><a href="https://meet.google.com/ajv-ajip-syc">https://meet.google.com/ajv-ajip-syc</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 11:23</div><div class="msg">@andreap as a most urgent concern could you make <a href="https://github.com/status-im/status-react/issues/4034">https://github.com/status-im/status-react/issues/4034</a> ? I think the mvp is really just making it possible to resend a contact request</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-03 11:23</div><div class="msg">@andreap @janherich tiny review <a href="https://github.com/status-im/status-react/pull/4094">https://github.com/status-im/status-react/pull/4094</a></div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/4f643ff2e520e1b103a3c81fe6d4267c.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F3654%2Fimg%2Favatars%2Fava_0023-72.png" /><div class="message"><div class="username">andreap</div><div class="time">2018-05-03 11:25</div><div class="msg">looks good @yenda but afk so can't approve it for at least 1 hr, feel free to move it to testing on my side</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-04 01:35</div><div class="msg">design-team could we have a design for pending contact request response, that invites the user to resend a contact request ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-05-04 06:45</div><div class="msg">^^ @hester @patrick771 can you take a look at this with @denis-sharypin? Take a look at <a href="https://github.com/status-im/status-react/issues/4034">https://github.com/status-im/status-react/issues/4034</a> for some context</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-05-04 09:00</div><div class="msg">on the UI level why a message from the sender can't be treated as a contact request?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-04 09:04</div><div class="msg">So you mean every message is a contact request until the user accepts the contact ?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-05-04 09:08</div><div class="msg">something like that. And also why recipient should accept request to see messages from the sender?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-04 09:11</div><div class="msg">He doesn't have to accept it</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-04 09:11</div><div class="msg">But he has to receive it</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-05-04 09:16</div><div class="msg">ah so idea is to remind a `sender` that he needs to send a contact request to recipient one more time?</div></div></div><br/>
|
|
<div><img src="https://secure.gravatar.com/avatar/fcc4675bd0ade27de9baefb82098e500.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2F66f9%2Fimg%2Favatars%2Fava_0002-72.png" /><div class="message"><div class="username">yenda</div><div class="time">2018-05-04 09:19</div><div class="msg">To suggest him to do it if the contact didn't accept after some time and he suspects the message was lost</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-06/324554464353_18f48763243f656a4978_72.jpg" /><div class="message"><div class="username">patrick771</div><div class="time">2018-05-04 10:14</div><div class="msg">So from what I understand from the issue and above, sounds like what @yenda and @denis-sharypin have proposed is reasonable</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-06/324554464353_18f48763243f656a4978_72.jpg" /><div class="message"><div class="username">patrick771</div><div class="time">2018-05-04 10:17</div><div class="msg">that a message from `sender` to `receiver` who are not previously contacts triggers a contact request. and if `receiver` doesn?t accept or message is lost we trigger a `resend` notification in-line</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-06/324554464353_18f48763243f656a4978_72.jpg" /><div class="message"><div class="username">patrick771</div><div class="time">2018-05-04 10:18</div><div class="msg">which I believe Nikhita had proposals for in this PR: <a href="https://github.com/status-im/status-react/pull/3964">https://github.com/status-im/status-react/pull/3964</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-02-26/320279260448_ec6cae0dd4f9145858b4_72.jpg" /><div class="message"><div class="username">chad</div><div class="time">2018-05-04 10:21</div><div class="msg">@yenda can you clarify how you imagined it working?</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-04-16/346978770624_9e34aabb0e7c70909e09_72.jpg" /><div class="message"><div class="username">denis-sharypin</div><div class="time">2018-05-07 13:23</div><div class="msg">@maria245 :point_up_2:</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2018-03-12/327737946193_ab02044e1a399d76784a_72.jpg" /><div class="message"><div class="username">maria245</div><div class="time">2018-05-07 13:23</div><div class="msg">has joined #087-new-protocol</div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-04-24/173180126768_7f6060168aa29f44babc_72.png" /><div class="message"><div class="username">noman</div><div class="time">2018-05-08 18:13</div><div class="msg">@noman set the channel topic: <a href="https://ideas.status.im/ideas/087-new-protocol">https://ideas.status.im/ideas/087-new-protocol</a></div></div></div><br/>
|
|
<div><img src="https://avatars.slack-edge.com/2017-10-04/251566892466_e37667e6064fe542e7d7_72.jpg" /><div class="message"><div class="username">naghdy</div><div class="time">2018-10-05 05:50</div><div class="msg">@naghdy archived the channel</div></div></div><br/>
|
|
</div></body></html> |