status-im/secp256k1
2
0
Fork 0
mirror of https://github.com/status-im/secp256k1.git synced 2025-02-24 03:38:12 +00:00
Code Issues Projects Releases Wiki Activity

Merge bitcoin-core/secp256k1#1025: build: replace backtick command substitution with $()

Browse Source 
2b7c7497ef66eae3a178b666fe17af40495322a6 build: replace backtick command substitution with $() (fanquake)

Pull request description:

  This is only needed for the very oldest of non-POSIX-compatible shells.
  Note that this code will also only be executed on macOS, where it'd be
  very unlikely to run into such a shell anyways.

  Followup to https://github.com/bitcoin-core/secp256k1/pull/1019#pullrequestreview-815300521. I had thought there were more usages of this
  syntax, but seems like it's just the one.

  See:
  https://github.com/koalaman/shellcheck/wiki/SC2006

  Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

ACKs for top commit:
  real-or-random:
    ACK 2b7c7497ef66eae3a178b666fe17af40495322a6
  hebasto:
    ACK 2b7c7497ef66eae3a178b666fe17af40495322a6, verified that this is the only case.

Tree-SHA512: 6192f5efe437ff428ce7843ac595049a1aa7969a9e696f649cfd4820b28fc96ad0fabd6eec0ec1ca404763f02e64af6a99e57666a00d8749c6212a0646211991
This commit is contained in:
Tim Ruffing 2021-12-03 14:53:58 +01:00
commit 4900227451
No known key found for this signature in database
GPG Key ID: 8C461CCD293F6011
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configure.ac
View File

@ -44,7 +44,7 @@ case $host_os in
# in expected paths because they may conflict with system files. Ask # in expected paths because they may conflict with system files. Ask
# Homebrew where each one is located, then adjust paths accordingly. # Homebrew where each one is located, then adjust paths accordingly.
if $BREW list --versions valgrind >/dev/null; then if $BREW list --versions valgrind >/dev/null; then
valgrind_prefix=`$BREW --prefix valgrind 2>/dev/null` valgrind_prefix=$($BREW --prefix valgrind 2>/dev/null)
VALGRIND_CPPFLAGS="-I$valgrind_prefix/include" VALGRIND_CPPFLAGS="-I$valgrind_prefix/include"
fi fi
else else