status-im
/
samyoul-notes
mirror of https://github.com/status-im/samyoul-notes.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
My notes on the work I do at Status.
311 Commits 1 Branch 0 Tags 17 MiB
HTML 99.8%
Go 0.2%
Go to file
Samuel Hawksby-Robinson fabc0b6af5 Updated 2024-05-23 2024-05-24 20:20:43 +01:00
analysis/wallet/Router Added suggested restructure for filterRoutes 2024-05-15 15:45:06 +01:00
archive Archived current log 2024-05-13 12:07:11 +01:00
attachments Updated filter test results 2024-05-17 20:27:12 +01:00
priorities Updated priorities 2022-01-05 13:34:36 +00:00
tags Updated 2024-05-13 2024-05-13 21:42:30 +01:00
README.md Updated 2024-05-23 2024-05-24 20:20:43 +01:00

README.md

2024-05-23

Pulls

  • Router Filter Modularisation #5177
    • Resolved a boat load of test scenario issues
      • I'm super seriously very nearly finished now.
      • However, I do need reviewers to pay super close attention to the test cases and check that the intent of the functions is matched by the cases.
    • The full list of changes is available in the PR commits.

Schedule

2024-05-22

Pulls

  • Router Filter Modularisation #5177
    • Resolved a boat load of test scenario issues
      • I'm very nearly finished now. However, I do need reviewers to pay super close attention to the test cases and check that the intent of the functions is matched by the cases.
    • The full list of changes is available in the PR commit.

Scoping

Ad Hoc

  • Confirming details about my EthCC presentation

2024-05-21

Pulls

Schedule

  • SendModal designs review : 10:00 – 12:00
    • https://meet.google.com/qdq-wrzq-mha
    • Meeting notes
    • Attendees:
      • Sale (Facilitator)
      • Alisher
      • Ben
      • Magnus
      • Michal C
      • Myself
    • A very in depth meeting reviewing the send flows of desktop.
    • Key Decisions:
      • Reduce the scope of the Send, Bridge and Swap UI designs for 2.30
      • UI and design to work together
        • Desktop UI should detail what is feasible for the 2.30 release
        • Alisher and Ben are supportive of facilitating a highly iterative framework.
        • Alisher and Ben will adapt sending flows as required
      • Michal and Sale would discuss the best process for improving the UI while at the same time being able to deliver something. Include Noelia
      • Identified distinctions between the concepts of backend Router and UI Router
        • Backend Router is a logic model for sending blockchain tokens. This model contains functionality that manages:
          • Calculating the best path for any given transaction requirements:
            • From address(es)
            • To address(es)
            • From network(s)
            • To network(s)
            • From token type(s)
            • To token type(s)
          • The Router is capable of using multiple input tokens and addresses to plan a route to multiple output addresses and tokens.
            • The Router determines which swaps and bridges may be required to achieve the goal
        • Backend Router can be called by multiple UI components:
          • Bridging
          • Sending
          • Swapping
        • Backend Router handles all of these transaction types internally.
        • UI Router is a complex high level UI component that allows a user to plan with great detail which tokens, addresses and networks they wish for a transaction (or series of transactions to take).
        • UI Router is part of the UI bridging functionality.
  • mobile-core retro : 13:00 – 14:00

2024-05-20

Pulls

Schedule

  • 13:00 – 13:45 : bi-weekly status-go call
    • https://meet.google.com/gbq-tyqe-vju
    • Stand-ups
    • Discussion about changes required for Wallet Router to accommodate swap functionality.
    • Discussion about the stability work done on Wallet Router.

2024-05-17

Pulls

2024-05-16

Issues

Reviews

  • https://github.com/status-im/status-go/pull/5159 approved, feedback
    • A re-review after Sale made some changes in response to all of the feedback given.
    • I've suggested one opinion based change based on function signature complexity, aside from that I've approved the PR.

Schedule

2024-05-15

Coding

  • filterRoutes is a very complex function, and it is very difficult to read. I've split it apart and named the levels of filter after what they do rather when they happen.

Reviews

Scoping

2024-05-14

Scoping

Schedule

  • I raised an axe to the crew meetings, swung hard and true. Toppled and prostrate they settled motionless. Tonight we revel in the light of their embers!

2024-05-13

Scoping

  • Wallet Router
    • I began work on reading and building context of the Route status-go logic.
    • This work is tricky to track, but I have begun making notes of the logic. I plan to continue to build out a description or documentation detailing the analysis.
  • Torrent dependencies in mobile build

Schedule

  • 10:30 – 11:30 : Discussion and sync with Sale about planning and scoping of Wallet Router work.
  • 12:00 – 12:30 : Wallet Router Sync
    • https://meet.google.com/amj-krdp-dta
    • Attendees:
      • Alisher
      • Andrea
      • Emil
      • Ivan
      • Jamie
      • Sale
      • Myself
    • Notes
      • Discussed what should be priorities
      • Decided the following:
        • Scope the Wallet Router to understand the logic
        • Tests should be writen to validate any changes the Router code, but we do not build tests out without introducing changes.
          • Tests can be written in the context of demonstrating / exploring how code works.
        • Alisher was meant to present the product expectations, but we ran out of time.
  • 14:30 – 15:00 : team update