status-im
/
samyoul-notes
mirror of https://github.com/status-im/samyoul-notes.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
My notes on the work I do at Status.
322 Commits 1 Branch 0 Tags 17 MiB
HTML 99.8%
Go 0.2%
Go to file
Samuel Hawksby-Robinson 4796d08457 Updated 2024-06-04 2024-06-05 10:14:30 +01:00
analysis/wallet/Router Added suggested restructure for filterRoutes 2024-05-15 15:45:06 +01:00
archive Archived 2024-05 2024-06-03 09:19:03 +01:00
attachments Updated 2024-05-29 2024-05-29 20:45:04 +01:00
priorities Updated priorities 2022-01-05 13:34:36 +00:00
tags Updated 2024-05-13 2024-05-13 21:42:30 +01:00
README.md Updated 2024-06-04 2024-06-05 10:14:30 +01:00

README.md

2024-06-04

Pulls

  • Removing torrent from mobile build #5257 - commits
    • Implemented build OS conditional build instructions
    • Added more complex build conditions to exclude OSes
    • 😱 Debugging why OS conditional builds are not working 😱

Reviews

  • fix missing value of keyuid for old mobile user #5203 approved, feedback
    • Related to this PR there seems to be some discrepancy between what Code Climate judges as having test coverage and what IntelliJ IDEA reports.
    • From the case of this PR it seems that Code Climate is less accurate and reports that some statements are not covered when they are.

Schedule

2024-06-03

Pulls

  • Removing torrent from mobile build #5257 - commits, scoping
    • Removed TorrentManager from handleImportedMessages
    • Removed TorrentManager from checkIfIMemberOfCommunity
    • Moved archive related funcs into ArchiveManager
      • To be honest once I started this work I quickly realised how pointless it is as archiving functionality and torrent seeding functionality are really entwined. So I'm keeping the code I've done, but it is a bit pointless without spending a lot of time untangling torrenting and archiving. I'm just going to make an interface for all the functions that are used publicly from TorrentManager. I think that this will be the fast way to move on from this issue. I don't like this work anymore, there is a lot of work to do elsewhere and torrent is a rabbit hole filled with canned worms.
    • Created TorrentContract and ArchiveContract interfaces
    • Created nil structs for Mobile use (or close to nil as possible)
    • Mapped all 2nd level TorrentManager usage

Schedule

  • 11:30 – 12:00 : Melanie <> Sam
  • 13:00 – 13:45 : bi-weekly status-go call
    • https://meet.google.com/gbq-tyqe-vju
    • Stand-ups
    • Belal was introduced to the group (Hey Belal)
    • Discussion of how to ensure compatibility between V1 and V2 key derivation and generation
    • Action points / Key Decisions
      • Activating Code Climate diff test coverage as REQUIRED
      • Agreement to activate audio transcription to ensure we have low effort, yet (reasonably) accurate notes for our calls