status-im
/
samyoul-notes
mirror of https://github.com/status-im/samyoul-notes.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Updated 2020-12-16

This commit is contained in:
Samuel Hawksby-Robinson 2020-12-17 10:54:40 +00:00
parent f73cb10114
commit f4ad8cf1f8
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
README.md Normal file
View File

@ -0,0 +1,27 @@
# 2020-12-16
## Pulls
- [x] [#2051 - Profile Images](https://github.com/status-im/status-go/pull/2051) - `commits`
- Related to debugging
- Issue finally resolved by Cammellos
- [tracking of the messages would deadlock](https://github.com/status-im/status-go/blob/50b17308bde0008daf4c8365782575d4f22b1515/protocol/messenger.go#L306)
- [Making `EnvelopesMonitor.Add()` deadlock](https://github.com/status-im/status-go/blob/50b17308bde0008daf4c8365782575d4f22b1515/protocol/transport/waku/envelopes.go#L108)
- [Because `EnvelopesMonitor.handleEventEnvelopeSent()` couldn't unlock](https://github.com/status-im/status-go/blob/50b17308bde0008daf4c8365782575d4f22b1515/protocol/transport/waku/envelopes.go#L165)
- [Fix was to remove mutex lock from `Messenger.processSentMessages()`](https://github.com/status-im/status-go/blob/50b17308bde0008daf4c8365782575d4f22b1515/protocol/messenger.go#L306)
## Issues
- [x] [#11347 - Profile edit picture UI](https://github.com/status-im/status-react/pull/11347)
- [App Freezing when user sends message after changing profile image](https://github.com/status-im/status-react/pull/11347#issuecomment-746252933)
- Debugging
## Schedule
- [x] 14:00 GMT - Samuel & Andrea 1-to-1
- https://meet.google.com/rhy-trwc-ybb
- **Notes :**
- *Profile Images*
- [App Freezing when user sends message after changing profile image](https://github.com/status-im/status-react/pull/11347#issuecomment-746252933)
- *`status-go` notifications improvement*
- Adding `Notifications` field to `MessageResponse` struct and parsing in the `PublisherSignalHandler`