From 125523e1939247a1fd5d766800ae4f8ba70533d3 Mon Sep 17 00:00:00 2001 From: Samuel Hawksby-Robinson Date: Thu, 4 Jun 2020 00:07:34 +0100 Subject: [PATCH 1/2] Updated 2020-06-03 --- README.md | 4 +++- priorities/README.md | 30 +++++++++++++++--------------- 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index d12139f..a70fc32 100644 --- a/README.md +++ b/README.md @@ -6,10 +6,12 @@ - [Theoretical min and max base58 encoded compressed key lengths](https://github.com/status-im/status-go/issues/1937#issuecomment-638286734) - [x] [vacp2p/specs#137 - Remove / deprecate Batch Ack packet type](https://github.com/vacp2p/specs/issues/137) - `created` - [x] [vacp2p/specs#138 - Remove MessageResponse version](https://github.com/vacp2p/specs/issues/138) - `created` +- [x] [vacp2p/specs#139 - Remove confirmations-enabled from status-options](https://github.com/vacp2p/specs/issues/139) - `created` +- [x] [vacp2p/specs#140 - Change name of status-options light-node to is-light-node](https://github.com/vacp2p/specs/issues/140) - `created` ## Pulls -- [x] [status-im/specs#132 - Remove personal pronouns](https://github.com/status-im/specs/pull/132/) - `commits` +- [x] [status-im/specs#132 - Remove personal pronouns](https://github.com/status-im/specs/pull/132/) - `commits`, `merged` - [x] [#1984 - Added basic history of the protocol package](https://github.com/status-im/status-go/pull/1984) - `commits`, `submitted` ## Reviews diff --git a/priorities/README.md b/priorities/README.md index 4ae273a..044ab97 100644 --- a/priorities/README.md +++ b/priorities/README.md @@ -2,20 +2,12 @@ ## Personal -1) Create VAC Waku spec improvement issue(s) for: - - **Discussed:** - - [here for discussion](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664) - - **Improvements:** - - [~~Remove MessageResponse version~~](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664/3?u=samuel) - - [~~Remove Batch Ack packet type~~](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664/10?u=samuel) - - [Remove `confimations-enabled` from `status-options`](https://github.com/vacp2p/specs/pull/128#discussion_r427771425) - - Change name of `status-options` `light-node` to `is-light-node` 1) [#1834 - Show pending transactions](https://github.com/status-im/status-go/issues/1834) - - **Todos:** - - [ ] Write specs - - [ ] Implement - - **Impacts:** - - [status-react#3997 - Display pending requests in transactions history](https://github.com/status-im/status-react/issues/3997) + - **Todos:** + - [ ] Write specs + - [ ] Implement + - **Impacts:** + - [status-react#3997 - Display pending requests in transactions history](https://github.com/status-im/status-react/issues/3997) - [status-react#9976 - Show pending transactions](https://github.com/status-im/status-react/issues/9976) 1) [#7118 - SNT and emoji reactions**](https://github.com/status-im/status-react/issues/7118) - **Notes:** @@ -50,10 +42,18 @@ ## Resolved +- [x] Create VAC Waku spec improvement issue(s) for: + - **Discussed:** + - [here for discussion](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664) + - **Improvements:** + - [~~Remove MessageResponse version~~](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664/3?u=samuel) + - [~~Remove Batch Ack packet type~~](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664/10?u=samuel) + - [~~Remove `confimations-enabled` from `status-options`.~~](https://github.com/vacp2p/specs/pull/128#discussion_r427771425) + - ~~Change name of `status-options` `light-node` to `is-light-node`.~~ - [x] ~~Add to the `status-go/protocol` package README notes about how it was originally a whole repo with managed dependencies.~~ - - **PR :** [#1984 - Added basic history of the protocol package](https://github.com/status-im/status-go/pull/1984) + - **PR :** [#1984 - Added basic history of the protocol package](https://github.com/status-im/status-go/pull/1984) - [x] [~~status-im/specs#61 - Replace forked Whisper usage with Waku/0 in specs~~](https://github.com/status-im/specs/issues/61) - - **PR :** [#114 - Update/waku replace](https://github.com/status-im/specs/pull/114) + - **PR :** [#114 - Update/waku replace](https://github.com/status-im/specs/pull/114) - [x] [~~I’ll open a PR making an explicit reference that Envelope is specified by ABNF. Resolving Proposal 4.~~](https://discuss.status.im/t/wherefore-art-thou-mailserver-treatise-on-waku-terminology/1664/8?u=samuel) - [x] ~~Discuss post on waku mailserver name,~~ [~~change to `history node`, `persistence node`, `echo node` . Some thing more descriptive.~~](https://github.com/status-im/status-go/pull/1949#discussion_r419615374) - [x] ~~Discuss post on~~ [~~Database package location refactor~~](https://github.com/status-im/status-go/issues/1945) From b8b942f557522bca9d326fd82830d157da075e63 Mon Sep 17 00:00:00 2001 From: Samuel Hawksby-Robinson Date: Thu, 4 Jun 2020 00:11:52 +0100 Subject: [PATCH 2/2] Format tweak --- priorities/README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/priorities/README.md b/priorities/README.md index 044ab97..f057db3 100644 --- a/priorities/README.md +++ b/priorities/README.md @@ -3,11 +3,11 @@ ## Personal 1) [#1834 - Show pending transactions](https://github.com/status-im/status-go/issues/1834) - - **Todos:** - - [ ] Write specs - - [ ] Implement - - **Impacts:** - - [status-react#3997 - Display pending requests in transactions history](https://github.com/status-im/status-react/issues/3997) + - **Todos:** + - [ ] Write specs + - [ ] Implement + - **Impacts:** + - [status-react#3997 - Display pending requests in transactions history](https://github.com/status-im/status-react/issues/3997) - [status-react#9976 - Show pending transactions](https://github.com/status-im/status-react/issues/9976) 1) [#7118 - SNT and emoji reactions**](https://github.com/status-im/status-react/issues/7118) - **Notes:**