From 13fc9bae142c9a5384f14e66f5f062f0509fa437 Mon Sep 17 00:00:00 2001 From: Samuel Hawksby-Robinson Date: Wed, 29 May 2024 20:38:47 +0100 Subject: [PATCH] Updated 2024-05-29 --- README.md | 51 +++++++++++++++++++ .../2024-05/2024-05-29_02:48:00_nightly.log | 41 +++++++++++++++ 2 files changed, 92 insertions(+) create mode 100644 attachments/2024-05/2024-05-29_02:48:00_nightly.log diff --git a/README.md b/README.md index 26e6d89..8fcd0dc 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,54 @@ +# 2024-05-29 + +## Documents + +- Implementing User Stories + - https://www.notion.so/About-implementing-user-stories-fc6bc6b81e54461c85cd1b793cae4e22 + - I was given the privilege of previewing and reviewing this stable draft of Status' unified approach to User Stories. + +## Issues + +- [Remove torrent dependencies at build time for mobile #5146](https://github.com/status-im/status-go/issues/5146) + - Begun working on this issue. + +## Pulls + +- [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) - `commits` + - Initial migration of all torrent dependent code + - Code moved into new `TorrentManager`. This is BROKEN! The code is not ready to use so don't use it, lots more work to do. Biggest problem is that the torrent management in `Manager` is very tightly coupled to sending encrypting etc. All of that needs to be prised apart + - Ensured move of all torrent funcs and structs + - I also ensured that the order of functions matches the original code, to make comparison easier during review. + +## Schedule + +Note details of this below call were shared in the Snow Blowers' chat and in the general `status-go` Discord / Status channel. + +- 12:00 – 13:00 : ❄🔥 Snow Blowers (status-go flaky tests) Sync Call + - https://meet.google.com/cvh-crfd-uji + - Igor presented his intent to make diff test coverage at 50% per PR REQUIRED. + - Attendees: + - Igor (facilitator) + - Patryk + - Myself + - Summary + - Discussed the latest nightly flaky results: + - https://ci.status.im/job/status-go/job/tests-nightly/235/Reports/ + - https://ci.status.im/job/status-go/job/tests-nightly/235/ + - We agreed to target all of the `TestMessengerCommunitiesTokenPermissionsSuite` flakes + - [See the log file for more details](./attachments/2024-05/2024-05-29_02:48:00_nightly.log) + - We agreed to activate REQUIRED and considered a number of points that would need to be addressed. + - Generated files should be ignored + - Test coverage of 50% should be reasonable and not burdensome while effective at enforcing necessary code quality. + - We have a mechanism to override the requirement in EXTREME cases + - QA should be given visibility of this work + - [Make codeclimate diff coverage test reports Required #5254](https://github.com/status-im/status-go/issues/5254) + - [fix missing value of keyuid for old mobile user #5203](https://github.com/status-im/status-go/pull/5203) A case where the tests are present and seem to be robust but Codeclimate reports that the test coverage is only 36% (this case is notable because it seems unfair, may need investigation) + - [refactor_: ExtractTokenCriteria -> extractContractAddressesByChain #5226](https://github.com/status-im/status-go/pull/5226) A case where code changes are made but have no Codeclimate test coverage report + - [Direct settings updates (API) #5237](https://github.com/status-im/status-go/pull/5237) A case with 0% coverage + - [Router Filter Modularisation and Test suite #5177](https://github.com/status-im/status-go/pull/5177) A case with 100% coverage 😉 + +--- + # 2024-05-28 ## Issues diff --git a/attachments/2024-05/2024-05-29_02:48:00_nightly.log b/attachments/2024-05/2024-05-29_02:48:00_nightly.log new file mode 100644 index 0000000..1eee39e --- /dev/null +++ b/attachments/2024-05/2024-05-29_02:48:00_nightly.log @@ -0,0 +1,41 @@ +--- +Failing tests stats +--- +TestRendezvousDiscovery: 85.0% (17 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite: 80.0% (16 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestReevaluateMemberTokenMasterRoleInClosedCommunity: 35.0% (7 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestJoinCommunityAsAdminWithMemberAndAdminPermission: 30.0% (6 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestReevaluateMemberAdminRoleInOpenCommunity: 25.0% (5 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestViewChannelPermissions/viewers_are_allowed_to_post_reactions: 25.0% (5 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestViewChannelPermissions: 25.0% (5 of 20 failed) +TestCreateWallet: 20.0% (4 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestEditTokenPermission: 20.0% (4 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestReevaluateMemberTokenMasterRoleInOpenCommunity: 20.0% (4 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestJoinCommunityAsMemberWithMemberAndAdminPermission: 15.0% (3 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestImportDecryptedArchiveMessages: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestContactCode: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestReceivePushNotification: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestReceivePushNotificationCommunityRequest: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestReceivePushNotificationFromContactOnly: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestReceivePushNotificationMention: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestReceivePushNotificationPairedDevices: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite/TestReceivePushNotificationRetries: 15.0% (3 of 20 failed) +TestMessengerPushNotificationSuite: 15.0% (3 of 20 failed) +TestMessengerCommunitiesTokenPermissionsSuite/TestReevaluateMemberAdminRoleInClosedCommunity: 10.0% (2 of 20 failed) +Test_removeBalanceHistoryOnEventAccountRemoved: 5.0% (1 of 20 failed) +TestCircuitBreaker_ExecuteMultipleFallbacksFailButLastSuccessStress: 5.0% (1 of 20 failed) +TestMessengerRawMessageResendTestSuite/TestMessageSent: 5.0% (1 of 20 failed) +TestMessengerRawMessageResendTestSuite: 5.0% (1 of 20 failed) +TestMessengerCommunitiesSignersSuite/TestSyncTokenGatedCommunity/community_with_token_ownership: 5.0% (1 of 20 failed) +TestMessengerCommunitiesSignersSuite/TestSyncTokenGatedCommunity: 5.0% (1 of 20 failed) +TestMessengerCommunitiesSignersSuite: 5.0% (1 of 20 failed) +TestMessengerCommunitiesSuite/TestPostToCommunityChat: 5.0% (1 of 20 failed) +TestMessengerCommunitiesSuite: 5.0% (1 of 20 failed) +TestMessengerDeleteMessageForMeSuite/TestDeleteMessageForMe: 5.0% (1 of 20 failed) +TestMessengerDeleteMessageForMeSuite: 5.0% (1 of 20 failed) +TestMessengerProfileDisplayNameHandlerSuite/TestDisplayNameSync: 5.0% (1 of 20 failed) +TestMessengerProfileDisplayNameHandlerSuite: 5.0% (1 of 20 failed) +TestMessengerSendImagesAlbumSuite/TestAlbumImageEditText: 5.0% (1 of 20 failed) +TestMessengerSendImagesAlbumSuite: 5.0% (1 of 20 failed) +TestMessengerStoreNodeRequestSuite/TestRequestProfileInfo: 5.0% (1 of 20 failed) +TestMessengerStoreNodeRequestSuite: 5.0% (1 of 20 failed) \ No newline at end of file