Fernando 3e5d4f6646
Feature #406: Transaction Cancellation (#451)
* Add `cancel transactions` state to the store

* Populate store with `cancelTransactions` separated from `transactions`

- also fixed some related typing errors/warnings

* Avoid flow typing errors

* WiP - Merge Tx with its cancellation

* Prevent notification of pending transaction

* Mark transaction as cancelled

* Fix check errors

* Code cleanup

* Use `cancel` flags for confirm/execute of a cancelling tx modal

* Fix `Cancel Tx` button row display conditions

* Fix transaction row condition for cancelled tx

* Fix execute icon display conditions

* Fix condition to display `Confirm Tx` buttons for cancel tx

* Fix conditions for Execute icon

* Add test for `getTxTableData`

* Fix `updateAddressBookEntry` to make tests run

* (Feature) Transaction cancellation: implement design (#465)

* (fix) button icons positions

* (add) new buttons layout

* (fix) executor block style

* (remove) unused file

* (fix) transaction timeline styles

* (fix) overflowing left contents

* Show buttons only in the confirmation thread

* Green line on top of Cancel flow only when tx is executed

* Avoid checking `INCOMING_TX_TYPE` for a cancelTx

* Clean up code conditions

* Rename `cancelTransactions` to `cancellationTransactions`

* Start functions with a verb. `get` in this case.

Co-authored-by: Fernando <fernando.greco@gmail.com>

* Change notification message for cancelling txs

- Added `TX_CANCELLATION_EXECUTED_MSG`
- Also did some flow typing error fixes

* missing file for cancelling tx message

* Always display Reject flow

- display buttons independently (reject buttons in reject flow, confirmation buttons in confirmation flow)

* Reject a Tx when threshold is reached

* Use `safeGasPrice` instead of `gasPrice` to prevent sending `null`s to web3

* Revert "Use `safeGasPrice` instead of `gasPrice` to prevent sending `null`s to web3"

This reverts commit db4cd728

* Revert "Use `safeGasPrice` instead of `gasPrice` to prevent sending `null`s to web3"

This reverts commit db4cd728

Also sets '0' as a default value if `gasPrice` is falsy

* Do not use current `threshold` for closed/executed transactions

* Add closing square bracket

* Verify if txNonce is invalid, zero is a falsy value but a valid nonce

* Display Execute Reject for those tx that met the threshold but weren't able to be executed

* Show pending txs messages for non executed rejections

* wrap `getTimelineCircle` into useMemo

* Remove unnecessary comments

* Verify tx nonce by using `Number.isInteger`

* Parse tx nonce before verifying it

Co-authored-by: Gabriel Rodríguez Alsina <gabitoesmiapodo@users.noreply.github.com>
2020-02-04 17:54:59 +04:00
2019-12-18 12:31:58 +01:00
2019-11-21 16:59:36 -03:00
2019-09-20 16:04:35 +04:00
2019-05-29 18:11:44 +04:00
2019-08-15 18:50:15 +04:00
2018-03-12 11:26:53 +01:00
2019-12-16 16:07:46 +04:00

Gnosis Team Safe

The most secure way to manage your crypto funds collectively

Getting Started

These instructions will get you a copy of the project up and running on your local machine for development and testing purposes. See deployment for notes on how to deploy the project on a live system.

Prerequisites

What things you need to install the software and how to install them

yarn add truffle // recommended usage of -g flag
yarn add ganache-cli // recommended usage of -g flag
yarn add flow-type // recommended usage of -g flag

We use yarn in our infrastacture, so we decided to go with yarn in the README

Installing and running

A step by step series of examples that tell you have to get a development env running

Install dependencies for the project:

yarn install

For using the Rinkeby services:

yarn start

If you prefer using Mainnet ones:

yarn start-mainnet

Building

For Rinkeby:

yarn build

For Mainnet:

yarn build-mainnet

Running the tests

  1. Run transaction-history-service
git clone https://github.com/gnosis/safe-transaction-service.git
cd safe-transaction-service
git checkout develop
docker-compose build
# it comes enabled by default in docker-compose
sudo service postgresql stop
docker-compose up -d

Check that the service is running at https://localhost:8000

  1. Migrate Safe Contracts:
git clone https://github.com/gnosis/safe-contracts.git
cd safe-contracts
yarn
npx truffle migrate
  1. Migrate Token Contracts for the tests: Inside safe-react directory
npx truffle migrate
  1. Run the tests:
yarn test

Break down into end to end tests

Explain what these tests test and why

Give an example

And coding style tests

Explain what these tests test and why

Give an example

Deployment

Add additional notes about how to deploy this on a live system

Built With

Contributing

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Versioning

We use SemVer for versioning. For the versions available, see the tags on this repository.

Authors

See the full list of contributors who participated in this project.

License

This project is licensed under the MIT License - see the LICENSE.md file for details

Acknowledgments

  • Thanks for Gnosis Team for providing the Safe contracts.
Description
Gnosis Safe – The most trusted platform to store digital assets on Ethereum
https://gnosis-safe.io
Readme
Languages
TypeScript 97.9%
JavaScript 1%
CSS 0.8%
Shell 0.2%