Commit Graph

442 Commits

Author SHA1 Message Date
Agustín Longoni 63cd88d845
Gas calculation info UI fixes (#1861)
* upgrade SRC

* add styles to GasInfo container

* reject modal

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-02-05 18:58:08 +01:00
Daniel Sanchez 1ac338e12c Merge branch 'development' into hotfix/v2.19.2 2021-02-04 12:51:29 +01:00
Daniel Sanchez f0f17e6083 Set v2.19.2 2021-02-04 10:05:06 +01:00
Daniel Sanchez 038b51e398
Bump dependencies (#1850)
* Upgrade dependencies without breaking changes
2021-02-03 14:15:44 +01:00
Daniel Sanchez 7921a8d9f3 Set v2.19.1 2021-02-03 00:08:03 +01:00
Daniel Sanchez 92d0f7fc4b Set v2.19.1 2021-02-02 22:16:38 +01:00
Daniel Sanchez 2bd73c3443 Set v2.19.0 2021-02-01 12:32:08 +01:00
nicolas 2ea67b5137
Set transaction parameters manually - Advanced options (#1760)
* Makes getGasEstimationTxResponse exportable

* Add check for failing txs on approveTxModal

* Adds styles for reviewTx

* Adds useTxSuccessCheck hook

* Remove hook

* Adds checkIfTxWillFail function

* Uses checkIfTxWillFailAsync on reviewTx modal

* Improves approveTx modal

* Add check for failing transaction in contract interaction modal

* Add check for reviewCollectible

* Fix check on sendFunds reviewTx

* Adds styling for contractInteraction modal

* Fix gas calculation for native token transfers

* Remove logs

* Rename estimateDataGasCosts to parseRequiredTxGasResponse
Adds getPreValidatedSignatures
Refactor estimateTxGasCosts
Refactor checkIfExecTxWillFail

* Refactor checkIfExecTxWill usage

* Refactor checkIfTxWillFailAsync in ReviewTx

* Use getPreValidatedSignatures in createTransaction()

* Refactor estimateTxGasCosts
Rename estimateSafeTxGas to estimateExecTransactionGas

* Refactor ReviewTx: extract useEffects to hooks

* Remove unnecessary gas transfer amount

* Refactor estimateTxGasCosts: extract checkIfTxIsExecution and estimateTxGas

* Fix tx amount
Remove console log

* Moves useCheckIfTransactionWillFail to logic/hooks folder

* Replaces useEffect usage with useCheckIfTransactionWillFail hook
Also fix how some modals fetch the safeAddress

* Improves modal's wording

* Remove comment

* Fix error parsing the cancel transaction error message from GETH nodes

* Remove useCheckIfTransactionWillFail
Adds useEstimateTransactionGas
Renames estimateTxGas to estimateTransactionGas
Removes estimateTxGasCosts
Removes checkIfExecTxWillFail

* Replace useCheckIfTransactionWillFail from modals with useEstimateTransactionGas

* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas

* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas

* Extract isExecution calculation to useEstimateTransactionGas

* Creates TransactionFailText

* Uses TransactionFailText in the review modals

* Remove unnecessary styles

* Fix imports

* Remove css

* Fix missing style

* Remove duplicated function

* Fix modal height

* Fix wrong selector usage

* Fix missing null check on cancel tx confirmations

* Add guard for CLOSE_SNACKBAR action when tx was already dismissed

* Improves useEstimateTransactionGas in review custom tx and contract interaction review

* Fix hook dependency

* Add active screen types in send modal

* SafeInfo: replace AddressInfo by EthHashInfo

* Fix review replace/remove/add owner modals styling

* AdvancedOptions without funcionality

* change button text

* fix margins and texts

* fix close button margin

* rename ReviewTx by ReviewSendFundsTx

* safe params: partial implementation

* make use of useTransactionParameters hook

* Refactor response of useEstimateTransactionGas

* Remove safeAddress as param to the useEstimateTransactionGas

* Improves how threshold is obtained in useEstimateTransactionGas.tsx

* Rename gasCostHumanReadable to gasCostFormatted

* Add operation to useEstimateTransactionGas

* Refactor ConfirmTransactionModal to use useEstimateTransactionGas

* Refactor proccessTransaction to use getPreValidatedSignatures method

* Fix default export of ApproveTxModal

* Rename estimateExecTransactionGas to estimateGasForTransactionCreation
Remove estimateTransactionGas from gas.ts

* form, accordion, validations

* Make estimateGasForTransactionCreation throw error instead of 0 gas

* Adds estimateGasForTransactionExecution and estimateGasForTransactionApproval to gas.ts

* Move estimateTransactionGas to useEstimateTransactionGas
Refactors useEstimateTransactionGas to return isCreation and isOffChainSignature

* Add in contractInteraction

* review custom TX

* review collectible

* Type and refactor generateSignaturesFromTxConfirmations
Moves getPreValidatedSignatures to safeTxSigner.ts

* Uses confirmations to estimateGasForTransactionExecution

* Adds TransactionFeesText component
Uses TransactionFeesText on ApproveTxModal

* Update text

* Update text

* Remove unnecessary condition

* Pass more parameters to estimateGasForTransactionExecution

* Removes unnecessary parameter in getNewTxNonce

* Moves checkIfOffChainSignatureIsPossible to safeTxSigner.ts

* rename AdvancedOptions and add parameters in add owner

* replace owner - remove owner

* Fix check for null confirmations

* Uses checkIfOffChainSignatureIsPossible on createTransaction.ts

* Policies

* Move TransactionFailText inside TransactionFees component

* spending limit

* fix textfields gap and margins

* fix margins, text size and textfields disposition

* Remove unnecessary awaits

* Update Accordion comp

* Pass safeTxGas to useEstimateTransactionGas.tsx
Improves how we use default params

* Fix gas iteration on estimateGasForTransactionExecution

* Fix estimateGasForTransactionExecution calculation

* Fix generateSignaturesFromTxConfirmations calculation

* Remove unnecessary Promise and await

* Fix estimateGasForTransactionExecution for preApproving owner case

* Improve logging

* Remove log

* Fix typo

* merge fixes

* Uses operation in useEstimateTransactionGas

* Uses operation in useEstimateTransactionGas

* add txParameters in ApproveTx

* useEstimateTransactionGas add gasPriceFormatted

* reviewSendFundsTx gasFormatted

* add gasLimit to useEstimateTransactionGas

* Files movement - EditParameters refactor

* tx parameters in creation

* set correct gasPrice

* createTx from contractInteraction

* Fix gas estimation for transaction creation

* disable button while calculating gas

* Add owner - reactor and creation options

* Add owner: remove unused code

* Threshold settings

* fix modal ui bug (tx)

* fix modal ui bug (settings)

* fix modal ui bug (Settings: Policies )

* fix ui bug modal (Spending Limit)

* (Fix) - Calculates gas for SpendingLimit transactions (#1773)

* Bug: Use link tag instead of javascript navigation in apps list (#1770)

* Use list instead of programmable navigation

* add declaration for styled-components theme

* (Fix) - Calculates gas for SpendingLimit transactions (#1773)

* Calculates gas for spendingLimit transactions

* Adds TransactionFees component inside UpdateSafeModal

* Fix send collectible gas calculation

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* speding limits

* Remove default exports for spendingLimits

* Fix warning in TxParametersDetail

* Extracts calculateSpendingLimitsTxData logic and add types

* Remove txParameters from setSpendingLimitMultiSendTx/spendingLimitMultiSendTx
Adds log for transaction creation success

* Refactor handleSubmit, now uses calculateSpendingLimitsTxData to calculate the spendingLimit transaction data before submitting
Also calculateSpendingLimitsTxData is used to estimate the amount of gas that the transaction will cost

* disable parameters when needed

* fix parametersStatus condition

* Some fixes

* more fixes

* send directly when tx nonce == safeNonce

* fix tests

* parameters in replace owner and remove owner

* Fix gas estimation issues for Metamask

* FIx Edit transaction parameters src route

* Remove default exports RemoveModuleModal

* Adds advanced parameters in RemoveModuleModal

* Fix css styling of UpdateSafeModal

* Adds EditableTxParameters within UpdateSafeModal

* Fix warning in <Accordion> for compact parameter

* Add advanced settings for RemoveLimitModal.tsx

* Fix txNonce usage in RemoveModuleModal.tsx

* Remove logs

* Fix txNonce param in RemoveLimitModal.tsx

* Remove TODOS for refactoring default case of getParametersStatus in EditableTxParameters

* Add advanced parameters to Safe apps modal

* Force gasPrice and safeTxGas 0 for cancelling transaction

* Invert validation of safeTxGas > ethGasLimit, safeTxGas should be < than ethGasLimit

* Add missing validation for approveTxModal submit button

* Fix checkIfTxIsApproveAndExecution  method
Add tests

* Remove duplication of gas value for calculateGasOf

* Fix gas estimation for execution & approval

* Adds EXTRA_NODE_GAS for the gasLimit calculation

* Revert duplicate of web3.eth.estimateGas

* Revert fix of execution & approval

* Adds closeEditModalCallback in EditableTxParameters

* Accept manual gas price in useEstimateTransactionGas.tsx

* Use manualPrice in sendFunds gas estimation

* Add safeTxGas estimation to Editable TX Parameters

* Set safeTx gasPrice to 0 on tx creation

* Refactor useTransactionParameters with initialValues support

* Refactor EditableTxParameters.tsx, fixs changing gasLimit or gasPrice

* Fix safeTxGas

* Add naming to minimum gas required for a transaction

* Remove log

* Fix nonce calculation for cancel transaction

* Update gas estimation to be more precise and avoid reverts

* Check that only the creator of the transaction or the executor could modify the advanced parameters

* Add validation to submit buttons on modals when the gas estimation is loading

* Fix advanced parameters display in change threshold

* Fix wrong commit

Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2021-01-29 21:21:42 +01:00
Daniel Sanchez 012b41a3f7
Feature - Add .crypto domain resolution (#1764)
* (Feature) - Support for .crypto resolution

* Fix EthereumAddress validator error msg

* Extract unstoppable domains logic to an util

* Add singleton to UnstoppableDomains instance

* Shorten address or domain validation error message

Co-authored-by: sudoryan <rleinbox@gmail.com>
2021-01-29 13:07:47 +01:00
Daniel Sanchez 93f5e8134e Set v2.18.1 2021-01-22 09:04:21 +01:00
Daniel Sanchez c0441e97fa Merge branch 'master' into release/v2.17.1 2021-01-19 16:14:55 +01:00
Daniel Sanchez d6d820ca3b Update packed files for desktop app 2021-01-19 09:40:30 +01:00
Daniel Sanchez 0e1efc6f8f Set v2.18.0 2021-01-19 09:13:57 +01:00
Daniel Sanchez 4aa5955b08 Set v2.17.1 2021-01-18 12:07:34 +01:00
Daniel Sanchez 5bcad40c16 Fix electron app image
Update and fix ledger connection for desktop app
2021-01-15 12:04:43 +01:00
Daniel Sanchez 618888ed07
Upgrade dependencies (#1767)
* Deduplicate dependencies

* Upgrade @truffle/contract to latest v4.3.0

* Upgrade dependencies with minor changes

* Upgrade electron-builder configuration

* Upgrade typescript to latest version

* Upgrade safe-apps-sdk to latest version
Remove autoprefixer dependency
2021-01-12 22:33:22 +01:00
Agustín Longoni 31be5b1993
Feature/#1499 add mobile start (#1750)
* add modal, img and card

* add overlay and clean css

* fix breakpoint to 992px (screenMd)

* add mobileView  library

* add link to download app button

* close button styles

* fix close button on hover

* Remove polished rgba for material-ui fade

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-12 20:26:38 +01:00
dependabot[bot] 09b470187f
Bump axios from 0.21.0 to 0.21.1 (#1754)
Bumps [axios](https://github.com/axios/axios) from 0.21.0 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.21.0...v0.21.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-12 14:01:34 +01:00
Daniel Sanchez afa8903eb2 Set v2.17.0 2020-12-14 13:58:05 +01:00
Daniel Sanchez e34b9e74ed Use latest safe-react-components version 2020-12-14 13:53:51 +01:00
Agustín Longoni 1bb3ebce63
Welcome Screen (#1655)
* add cards and styles on texts

* add styles and content

* align card content

* fix text about Safe Multisig

* add new components from SRC

* update SRC

* changes to welcome page

* fix margins

* update SRC

* fix icon size

* update SRC hash

* Dot: replace number by check when wallet is connected

* fix card  width

* add url to help to connect wallet.

* remove underline on button as a link (Load Safe).

* Fix buttons

* disable connect wallet button when there is a connected wallet

* fix padding in New Transaction button

Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-11 22:47:07 +01:00
Daniel Sanchez f782c35e31
Clean dependencies warnings (#1716)
* Add resolution for babel version

Update @rescrips/cli to be compatible with react-scripts 4

* Upgrade packages to avoid install warnings
2020-12-11 20:42:13 +01:00
nicolas c9a06ec1c2
Handle console erros and warnings (#1709)
* Remove Warning: React.createFactory() is deprecated

* make TS recognize Window definition by adding an empty export

* Silent MM warning  ethereum.autoRefreshOnNetworkChange

* remove warning when requesting data from contract with null address.
2020-12-11 19:38:16 +01:00
Mikhail Mikheev 94175a6970
Feature #1593: Support promise-based api of Safe Apps SDK (#1594)
* use multiple versions of safe apps sdk

* use multiple versions of safe apps sdk

* Type fixes

* wip error for multiple versions

* fix multiple sdk versions

* app communicator wip

* communicator wip

* getEnvInfo handler

* update sdk

* app communicator wip

* sdk dep bump

* promisified getSafeInfo

* sendTransactions handler wip

* don't send a response if a handler doesnt return anything

* add handler for transaction sending

* wip rpc call handler

* rpc handler

* rpc handler fix

* V2 Communicator

* remove tsbuildinfo

* fix communicator

* fix error handling for rpc requests

* rpc call fixes

* Update sdk

* Adapting app to use formatters wip

* use messafe formatter from sdk

* Sdk update

* update safe apps sdk version, remove ethBalance from response for safe apps sdk v1

* bump sdk to beta version

* update yarn.lock

* update yarn.lock

* update yarn.lock

* use beta version of the sdk

* enhance validation check

* update dependecies

* Update to python3 dependencies

* Revert "Update to python3 dependencies"

This reverts commit 1332940c77cb649b53ec3e1adfdca10b88e24a87.

* fix transaction params type import

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-11 12:31:55 +04:00
nicolas 2fe1fb2794
Remove safe address tracking for GA (#1683)
* reactGA bump

* remove address from GA

* remove unneeded option

* Disable travis cache

* Set travis to use latest linux build image

* Update to use python3 dependencies

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-09 20:45:06 +01:00
Daniel Sanchez 258790dcca
Backmerge hotfix v2.16.2 (#1702) 2020-12-04 19:28:46 -03:00
Daniel Sanchez 9a9bb3c775
Upgrade dependencies (#1691)
* Upgrade dependencies without breaking changes

* Upgrade react-scripts to v4

* Use import instead of require in icons

* Update styles dependencies

* Remove react-app-rewired as is deprecated and not needed anymore

* Update prettier and testing-library/react dependencies

* Upgrade @ledger for desktop app

* Fix types in fetchSafeTokens test

* Use rescripts to remove ESLint plugin from react-scripts webpack

* Disable travis cache

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-12-04 18:38:49 +01:00
Daniel Sanchez a7cf0ffbf2 Rollback bnc-onboard dependency 2020-11-30 09:49:51 +01:00
Daniel Sanchez 4e6ce1bef0 Set v2.16.0 2020-11-27 12:23:48 +01:00
nicolas ba680f7158
SafeApps new layout (#1600)
* speed-up load time  for safe-apps

* show loading status until all the apps are loaded

* Add App route

* Add cards for each safe-app

* move logic to AppFrame

* add basic skeleton styles

* css fixes

* fix image sizes

* add transition animation to skeleton

* remove duplicated code

* Modals

* refactor skeleton

* refactor layout using flexbox

* make content clickable in cards

* cards container as css-grid

* remove fixed width for cards

* replace auto by 1fr

* remove margin for cards

* add card component and remove some css

* rename buttons

* add margin to app list

* refactor useAppList

* fix disclaimer always flashing

* fix pointer cursor for Add app icon

* add styled component keyframe

* update safe-react-components

* fix margin and card height, icon size

* fix margin in iconImg and app name

* fix margins on apps container (breadcrumb area)

* remove style comment

* fix margin on HelpCenter
/ remove overflow in sidebar

* Improve featuresEnabled for sidebar and apps page.

Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-26 18:40:29 +01:00
Fernando fc1250d528
(Feature) Spending Limit (#1637)
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-25 15:59:17 -03:00
Daniel Sanchez 9ef6d36ba1
Merge branch 'development' into hotfix/v2.15.1 2020-11-24 09:09:48 +01:00
Daniel Sanchez 3e6bf5b9d4 Set v2.15.1 2020-11-23 10:08:54 +01:00
Daniel Sanchez 9fdf4e298f
Bump dependencies without breaking changes (#1632) 2020-11-20 09:26:08 +01:00
Agustin Pane 3f6a8ee3f8
(Feature) - EWC/Volta ENS support on web3 patch (#1596)
* Adds patch-package and postinstall

* Creates a patch to add EWC and Volta in web3-eth and web3-eth-ens

* Adds support for ewc in isValidEnsName

* Update web3 ewc patch

* Enables ens lookup for ewc and volta

* Fix eslint

* Update patch
Fix patch-package script in package.json

Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-18 14:42:00 -03:00
Daniel Sanchez fb3ad8c0df Merge branch 'master' into release/v2.14.1 2020-11-17 17:56:56 +01:00
Daniel Sanchez 456d28c37d Change hw-transport-node-hid for hw-transport-node-hid-singleton 2020-11-17 15:37:59 +01:00
Daniel Sanchez 0fe29f11c8 Set v2.15.0 2020-11-16 12:52:39 +01:00
Daniel Sanchez 9d7fec573d Merge branch 'master' into release/v2.15.0 2020-11-16 12:52:21 +01:00
Daniel Sanchez 3bab94e70d Rollback node-sass to latest v4 version 2020-11-13 15:08:32 +01:00
Daniel Sanchez 710a2a99ed Upgrade @truffle/contract to a version that uses web3@1.2.9
Fix scrypt issue building in windows
2020-11-13 13:32:14 +01:00
Daniel Sanchez 26231ef54b Update node-gyp and node-sass to latest version
This is intended to avoid memory leak in windows machines
2020-11-13 12:45:12 +01:00
Daniel Sanchez 3c795462b7
Rollback web3 to v1.2.11 to avoid issues with walletconnect (#1599) 2020-11-12 20:20:54 +01:00
Daniel Sanchez 08d24facb7 Set v2.14.1 2020-11-12 12:07:34 +01:00
Daniel Sanchez 0c67c48648
Upgrade dependencies (#1572)
* Upgrade web3 to v1.3.0

* Remove polished direct dependency

* Upgrade types dependencies

* Upgrade ledger and electron related dependencies

* Update gnosis-safe-components to latest version

* Upgrade sentry dependencies to latest version

* Upgrade truffle-contract and axios

* Upgrade electron dependencies

* Use fade instead rgba with hex value

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-11-06 17:01:40 +01:00
Daniel Sanchez 387ebe68fb
Updates bnc-notify version and adds support for GridPlus Lattice [internal] (#1569)
* Adds support for GridPlus Lattice and bumps `bnc-onboard` version.
For more information on the GridPlus Lattice, see https://gridplus.io/lattice

* Disable Lattice wallet from incompatible chains

Co-authored-by: Alex Miller <asmiller1989@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-11-05 16:02:24 +01:00
nicolas df42b36194
Add Sentry config and ErrorBoundary Component (#1528)
* Add Sentry config and ErrorBoundary Component

* Update travis file to upload sentry sourcemaps

* Add design implementation for ErrorBoundary

* Add Sentry DSN configuration for all networks

* Push sourcemaps to sentry only on staging/production build

* move isProdction to constants file

* change Button for Link

* fix redirect when safeAddress is provided but not a subpath for it.

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-10-30 20:55:40 +01:00
Daniel Sanchez 26dd60a12f Set v2.14.0 2020-10-30 20:23:21 +01:00
Daniel Sanchez 02ba83cef2
Bump dependencies (#1529)
* Upgrade Typescript to v4.0.3

* Upgrade dependencies with minor changes

* Cleanup yarn.lock file

* Upgrade types dependencies

* Fix inconsistency with @typescript/eslint caused by react-scripts

* Fix eslint issues

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-10-28 12:48:31 +01:00
Mikhail Mikheev 1c53167a9a
Feature #1480: Handle rpc calls from apps SDK (#1519)
* sdk version update

* point sdk to a newer commit

* Update iframe message handler

* ConfirmTransactionModal tweaks to support params

* handle sendTransactionsWithParams, display safeTxGas in app tx modal

* new sdk version

* yarn lock update

* install libudev in travis

* update sdk version

* Estimating safeTxGas for Safe Apps Txs WIP

* safetxgas estimation warning wip

* gas estimation in confirm transaction modal

* yarn lock update

* update sdk version

* add handler for rpc calls

* use send method

* update sdk version

* dep bump

* wip

* update sdk

* remove unused interface and console.log

* remove async, tweak check for send func

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-10-26 13:53:01 +04:00