Commit Graph

282 Commits

Author SHA1 Message Date
nicosampler 44a5a9c190 update package.json 2020-08-06 08:55:14 -03:00
nicosampler 18dd6b7e97 Merge branch 'development' into issue-1144 2020-08-06 08:22:19 -03:00
Mikhail Mikheev b6bb5ffde1
Tech Debt: Safe Apps Refactor (#1110)
* apps refactoring wip

* apps refactoring wip

* type fixes

* add useLegalConsent hook in apps

* useAppList hook wip

* dep nump

* useAppList hook wip

* fix selecting first app

* Remove console.log

* dep bump

* update persisting app logic

* update saveToStorage type

* fix crash on apps tab

* reuse selectedApp variable in hook

* remove initialAppSelected
2020-08-06 11:33:58 +04:00
nicosampler 7f3a99b7f1 Merge remote-tracking branch 'origin/development' into issue-1144 2020-08-03 13:36:36 -03:00
Daniel Sanchez f374315a5a
Avoid constant creation of new web3 object (#1171)
* Avoid constant creation of new web3 object

* rollback web3 version, small type fixes in ConnectButton

* Use web3 instance in getProviderInfo

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-03 11:29:17 +02:00
Mikhail Mikheev 86cbd94b0c
Tech debt: Add types for contracts (#1118)
* typechain wip

* add types for multisend

* type definitions improvements

* type safe contract in estimateTxGasCosts

* contract type definitions wip

* SafeInstance truffle -> web3 migration

* fix calls for version

* transactions/send enhancements

* fix safe recor owner type

* Stepper type definitions wip

* dep bump

* stepper types wip

* refactoring stepper component to fix bug in load safe form

* stepper types wip, addressbook reducer types wip

* finally make it work

* Fix ownerlist component hook in load safe

* dep bump

* dep bump

* rollback types/history

* add types for gas calc

* debugging...

* fix using RO web3 for sending txs

* update package.json generate-types command

* add ts-ignore for stepperpage

* db

* dep bump

* as unknown as AbiItem -> as AbiItem[]

* use optional chaining for isExecution in gas esimations

* abiITem -> AbiItem[]

* fix safeVersion utils tests

* fix imports, put upgradeSafe test close to the actual code

* add comment about ts-ignore usage

* downgrade web3 version
2020-08-01 02:26:10 +04:00
nicosampler df8e3f49df review fixes 2020-07-31 15:21:17 -03:00
nicosampler 5f1f5f5387 update yarn.lock 2020-07-30 12:09:49 -03:00
nicolas 251da319a5
Fix: debounce fetch apps (#1021)
* Fix: debounce fetch apps

* refactor: fix AddAppForm name and add missing types

* add `use-lodash-debounce` hook to test debounce functionality

I'm planning to remove this dependency, as it requires to also install `lodash.debounce`. I prefer to implement it ad-hoc.

* refactor AddAppForm to use the observable pattern

* memoize `getAppInfoFromUrl` to prevent requesting the same information over and over

* prevent requesting data if url is not valid

* remove logging

* prevent validating form before visiting the fields

* refactor AddAppForm

reorganize code

* fix: change `any` to `unknown`

* fix: `uitls.ts` types and imports

* refactor: rename `isSubmitDisabled` to `onSubmitButtonStatusChange` prop

* refactor: rename `agreement` to `agreementAccepted`

also, moved `initialValues` to a constant `INITIAL_VALUES` outside the component

* refactor: reimplement `useDebounce` hook in-app

* refactor: extract app manifest verification to a helper function

also fixed types

* fix: prevent accessing `contentWindow` if `iframe` is `null`

* fix: `getAppInfoFromOrigin` return type

also, removed the expected type for the `getAppInfoFromOrigin` calls as it is inferred

Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-30 18:28:30 +04:00
Daniel Sanchez 89c17180de
Trim spaces from AddressInput (#1142)
* Remove spaces

* Change naming convention to make clear that only edge whitespaces are removed

Fix function documentation in string util

* Add trim spaces from address input in AddToken and AddAsset

* Use validator type

* Trim spaces on Safe App links

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-29 17:28:43 +04:00
Mikhail Mikheev f62bbffdd3
Tech Debt: Validator Type definitions (#1108)
* type validators

* safeSelector types

* history 5.0.0 breaking changes adaptation

* replace simpleMemoize with memoize from lodash because of typing issues

* add type definitions for history and react-router-dom

* type fixes

* yarn lock update

* fix router state

* more type improvements

* validator tests wip

* add tests for validators, remove duplicated validators

* add error messages to tests

* fix minValue error message for inclusive param

* Replace jsx.element with react.reactelement

* Fix uniqueAddress validator argument type

* remove comment in AddCustomToken validator

* use absolute import for saferecord in safe paage container
2020-07-27 14:31:13 +04:00
Germán Martínez 253639d009
Safe apps can request the Safe info (#1138)
* Request Safe info from Safe apps

* Update dependencies

* Update yarn.lock file

* remove usecallback

* Rename initialization messageId from safe-apps-sdk

* Fix openOnFocus on AddressBookInput

* Fix yarn.lock file

* Rollback @material-ui/lab to avoid type errors

* dep bump

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-24 17:56:24 +04:00
Mikhail Mikheev cea91ca007 update yarn.lock 2020-07-22 20:58:10 +04:00
nicosampler c1c5488d53 Fix: [SafeApps] add app input 2020-07-22 12:54:14 -03:00
fernandomg 028913d9bf bump `safe-react-components` version 2020-07-17 18:39:46 -03:00
fernandomg 0adaaf5c77 update `yarn.lock` 2020-07-13 13:43:30 -03:00
Agustin Pane 948bb21378 Merge branch 'development' of https://github.com/gnosis/safe-react into coveralls
# Conflicts:
#	yarn.lock
2020-07-08 10:30:37 -03:00
Agustin Pane 8fb5cf5e63 Adds web3-core types 2020-07-08 10:07:38 -03:00
Agustin Pane 3e982b741f Merge branch 'master' of https://github.com/gnosis/safe-react into coveralls
# Conflicts:
#	yarn.lock
2020-07-02 09:06:28 -03:00
Agustin Pane 98ec85d454 Merge branch 'development' of https://github.com/gnosis/safe-react into coveralls 2020-07-01 08:50:14 -03:00
nicolas d57ad72588
2.4.0 (#1079)
* Fix: Sapp confirmTXs modal width.

* explicitly type classNames

* typo

* Bump onboardjs version (#1049)

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* add Aave app (#1075)

* bump package.json version (#1077)

* mock commit

* yarn.lock regenration

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-06-30 12:57:21 +04:00
Mati Dastugue 222ace288c
Bump onboardjs version (#1049)
Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-29 16:33:56 +04:00
Agustin Pane 8625684b2a Merge branch 'master' of https://github.com/gnosis/safe-react into coveralls
# Conflicts:
#	yarn.lock
2020-06-25 10:52:31 -03:00
Mikhail Mikheev f39b0903ca
2.3.1 bugfix
* fallback to tx.recipient in case no if statement worked in getTxData

* update pkg.json
2020-06-25 16:18:53 +04:00
fernandomg 6fff362664 update yarn.lock 2020-06-24 10:24:25 -03:00
Mikhail Mikheev 75a72f32a7 turn on rule for explicit return type 2020-06-19 14:12:03 +04:00
nicolas 813619c123
hide sapp iframe until it loads completely (#1020)
* hide sapp iframe until it loads completely

* review changes

* remove code

* moving type

* adding styled-components types

* fix TS error

* refactor iframe loading
2020-06-18 14:03:12 +04:00
Fernando 0296a670e7
(Fix) [Contract Interaction] Support array-like arguments (#1009)
* Add `ArrayTypeInput` to support array type values

- also updated types for ContractInteraction/utils

* Update placeholder message

* Support fixed size arrays

- refactored how Field's key is generated due to conflicts with final-form library and `[]` in the name
- also simplified validation for array-like fields, as it messed with arguments of type `T[][2][][3]`
2020-06-18 13:53:49 +04:00
Agustin Pane 6d1a349d87
(Fix) - Identicons fix (#1004)
* Replaces old blockies dependency with ethereum-blockies-base64

* Add types

* Refactor as functional component

* Simplify identicon logic

* Simplify identicon styling logic

* Simplify identicon styling logic
2020-06-11 12:13:14 -03:00
nicolas ea1662bc6f
Safe apps url config (#1001)
* safe-react-apps  url from config and add request app

* Adding types

* safe-react-components bump

* extracting types

* add return type

Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-09 11:34:43 -03:00
Mikhail Mikheev 9abd83d824 dep bump 2020-06-09 14:47:58 +04:00
Mikhail Mikheev fc8fe5ddc6 typescript version bump 2020-06-09 14:23:14 +04:00
Mati Dastugue 84c525673a Update electron-settings 2020-06-07 22:23:05 -03:00
Mati Dastugue 0af59a7f78 Merge branch 'development' of github.com:gnosis/safe-react into feature/updateDialog 2020-06-07 21:57:46 -03:00
Fernando cefb33b593
(Fix) [Contract Interaction] Parameter validation (#974) 2020-06-06 10:32:25 -03:00
Mikhail Mikheev 5a7ced92ad
Merge pull request #897 from gnosis/536-notifications-status-labels-sync
Feature: Hide transactions with no confirmations, labels/notifications sync
2020-06-05 14:20:04 +04:00
Agustin Pane e5c6d8040d
(Fix) Null balances (#971)
* Fixs balances will null value

* Fixs collectibles not loading

* Uses useLocation hooks

* Add types

* fix types for useLocation

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-04 17:54:39 -03:00
Agustin Pane 63193d2429
(Fix) [Contract Interaction] boolean fields (#976)
* Replaces checkbox component with safe apps components

* Refactor input params to use checkbox component for boolean types

* Remove "anys"
Fix boolean values display on review tx

* Remove any

* Fix ts issues

* Exports boolean fn to util function

* Extract input component rendering to another component

* Fixs imports
Add types

* Remove old checkbox component

* Add types

* Add types

* fix `data` string not being updated after modifying a reviewed tx

* fixes required for typescript 3.9.3 upgrade

* bump typescript version

* add travis_wait for build command

* add cache for yarn

* travis wait fix

* remove travis_wait

* Revert "fix `data` string not being updated after modifying a reviewed tx"

This reverts commit 49356054cd93726b058073d3cd2e7a0244fd5914.

* Revert "Revert "fix `data` string not being updated after modifying a reviewed tx""

This reverts commit f2572e68dc59c01d8e4b1eccf975faf4006cd7a7.

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-04 10:56:55 -03:00
Mati Dastugue c5fad7cdd8 Add dialog and skip version 2020-06-03 14:37:50 -03:00
fernandomg e6ea715aca update `yarn.lock` 2020-06-03 10:38:38 -03:00
Mati Dastugue 31555d675e Update electron build 2020-05-29 22:48:11 -03:00
Mati Dastugue 1382c8e7a2 Update electron scripts 2020-05-29 15:30:38 -03:00
Mati Dastugue 7b0eb4cf7d Merge branch 'development' of github.com:gnosis/safe-react into fix/ledger 2020-05-29 12:22:41 -03:00
Mati Dastugue a519e6f3ad Fix yarn deps 2020-05-28 13:54:10 -03:00
nicolas 4065d5a007
Allow to load Safe Apps with ENS names (#911)
* Remove ethereum-ens in favour of web3.eth.ens

* Allow load Apps from ENS names

* remove comment

* review changes

* replace REACT_APP_IPFS_NODE by REACT_APP_IPFS_GATEWAY

* review fixes

* TS Errors

* fix paths

* Fix validtor

* Apps: Move App form to a separate file

* re-build

* review changes

* fix iframeEl type

* remove validation

* fix type

* update web3 version

* remove type in getContentFromENS

Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-05-28 12:50:08 -03:00
nicolas 1ae63f6784
Clean up dependencies (#944)
* Clean up dependencies

* Fix css mixing not being called
2020-05-22 13:48:27 +04:00
Mikhail Mikheev d9e62adc26
Bug: fix build directory for deployment, remove unused code (#937)
* fix build dir, remove unused code

* fix public path & remove unused code
2020-05-21 08:42:11 -03:00
nicolas 982d79c0d0
Migrating to Typescript and bringing back react-scripts (#933)
* remove flow from src

* remove unused files

* remove rules from eslint

* replace absolute paths

* add tsconfig

* update package.json

* remove babel-polyfill

* eslint fix

* remove jsconfig.json

* replace .scss by .module.scss

* Revert "replace absolute paths"

This reverts commit e430c71263a1a4c190d50e72271bba7ea6356bc4.

* replace ~/ by src/

* js fixes

* scss fixes

* fix unused vars

* adding eslint

* adding back config folder

* fix eslint and prettier

* force build

* fix baseUrl

* rename js/jsx to ts/tsx

* some rules

* rename files with jsx syntax to tsx

* fix app build

* Revert "fix baseUrl"

This reverts commit 523f29c7b61e14dd6be0ffc3cd199ff399157467.

* some fixes

* replace ts to tsx

* some TS fixes

* more tsc changes

* more tsc fixes

* more fixes

* more ts fixes

* more fixes

* last fix

* fixes

* prettier fix

* some fixes

* fix safe information aligment

* add yarn.lock

* fix blockies and build memory space

* include blockies in tsconfig

* fix blockies

* fix blockies import

* fix Identicon component

* fix build command

* Fix ref type in Identicon

* add libusb-1.0-0-dev to travis

* build command fix [2]

* build command fix [3]

* fix margin layout

* Update  yarn lock

* remove @ts-ignore

* hide Critial dependency

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
2020-05-20 16:15:21 -03:00
Mikhail Mikheev 6377c80e4f
Feature #739: Deployment screen improvements (#908)
* Dep bump

* add deps to useEffect hook

* Revert "Dep bump"

This reverts commit f22795296cd7989ecda594ffef4478c2f5d92911.

* fix / redirect

* Fix currency fetch 400 error

* extract tab labels to components

* fix currency dropdown not showing, rename DropdownCurrency component to CurrencyDropdown

* Fix loader component type

* move steps to a separate file

* make confirmation banner green

* track safe creation in analytics

* add back button

* remove width style from backbutton

* remove width style from backbutton (prev was just commented)

* remove components-v2 and use safe-react-components

* fix duplicated import

* bring back addressinfo component because it was not included in safe-react-components

* Fix broken import (CurrencyDropdown component was renamed)

* add CustomIconText component to fix transaction tab crash

* bring back ListLayoutComponent
2020-05-19 15:55:35 +04:00
nicolas 77e4987919
Inform the user if a Safe-App initiate a malformed TX (#895)
* @gnosis.pm/safe-react-components from NPM

* Infor is TX is malformed

* review fixes

* improve names

* review fixes

* trigger build
2020-05-14 10:50:04 -03:00