* Fix: debounce fetch apps
* refactor: fix AddAppForm name and add missing types
* add `use-lodash-debounce` hook to test debounce functionality
I'm planning to remove this dependency, as it requires to also install `lodash.debounce`. I prefer to implement it ad-hoc.
* refactor AddAppForm to use the observable pattern
* memoize `getAppInfoFromUrl` to prevent requesting the same information over and over
* prevent requesting data if url is not valid
* remove logging
* prevent validating form before visiting the fields
* refactor AddAppForm
reorganize code
* fix: change `any` to `unknown`
* fix: `uitls.ts` types and imports
* refactor: rename `isSubmitDisabled` to `onSubmitButtonStatusChange` prop
* refactor: rename `agreement` to `agreementAccepted`
also, moved `initialValues` to a constant `INITIAL_VALUES` outside the component
* refactor: reimplement `useDebounce` hook in-app
* refactor: extract app manifest verification to a helper function
also fixed types
* fix: prevent accessing `contentWindow` if `iframe` is `null`
* fix: `getAppInfoFromOrigin` return type
also, removed the expected type for the `getAppInfoFromOrigin` calls as it is inferred
Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* Remove spaces
* Change naming convention to make clear that only edge whitespaces are removed
Fix function documentation in string util
* Add trim spaces from address input in AddToken and AddAsset
* Use validator type
* Trim spaces on Safe App links
Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* type validators
* safeSelector types
* history 5.0.0 breaking changes adaptation
* replace simpleMemoize with memoize from lodash because of typing issues
* add type definitions for history and react-router-dom
* type fixes
* yarn lock update
* fix router state
* more type improvements
* validator tests wip
* add tests for validators, remove duplicated validators
* add error messages to tests
* fix minValue error message for inclusive param
* Replace jsx.element with react.reactelement
* Fix uniqueAddress validator argument type
* remove comment in AddCustomToken validator
* use absolute import for saferecord in safe paage container
* Add `ArrayTypeInput` to support array type values
- also updated types for ContractInteraction/utils
* Update placeholder message
* Support fixed size arrays
- refactored how Field's key is generated due to conflicts with final-form library and `[]` in the name
- also simplified validation for array-like fields, as it messed with arguments of type `T[][2][][3]`
* Dep bump
* add deps to useEffect hook
* Revert "Dep bump"
This reverts commit f22795296cd7989ecda594ffef4478c2f5d92911.
* fix / redirect
* Fix currency fetch 400 error
* extract tab labels to components
* fix currency dropdown not showing, rename DropdownCurrency component to CurrencyDropdown
* Fix loader component type
* move steps to a separate file
* make confirmation banner green
* track safe creation in analytics
* add back button
* remove width style from backbutton
* remove width style from backbutton (prev was just commented)
* remove components-v2 and use safe-react-components
* fix duplicated import
* bring back addressinfo component because it was not included in safe-react-components
* Fix broken import (CurrencyDropdown component was renamed)
* add CustomIconText component to fix transaction tab crash
* bring back ListLayoutComponent
* v2.0.0 (#806)
* Bug: Invalid V in signature with eth_sign (#728)
* Fix invalid V with metamask/ledger
* DONT FORGET TO REVERT BEFORE MERGING: test deployment
* DONT FORGET TO REVERT BEFORE MERGING 2: test deployment
* Revert "DONT FORGET TO REVERT BEFORE MERGING 2: test deployment"
This reverts commit 8331f2a78f7fc8f53eb893899f16edd8238c68ff.
* Revert "DONT FORGET TO REVERT BEFORE MERGING: test deployment"
This reverts commit 03b81e31820ce4fe078a7131c2f0caa2af4870ac.
* BUG: Only injected providers are cached as last used provider (#733)
* cache every used provider, not only injected one
* package json update
* (Fix) Adapt app to back-end changes (#736)
* refactor: Set success status to `201` (CREATED)
* refactor: return `null` when there's no latestTx
* (Fix) Transaction not automatically executed (#716)
* feature: action/reducer to UPDATE_SAFE_NONCE
* refactor: when processing txs returned from backend, extract latest tx nonce value and store it in the safe's state
* chore: update `yarn.lock`
* refactor: `UPDATE_SAFE_THRESHOLD` and `UPDATE_SAFE_NONCE` discarded in favor of `UPDATE_SAFE`
* refactor: use `SAFE_REDUCER_ID` constant
* refactor: remove `updateSafeNonce` file
* (Fix) Change the order of the upgrade methods lookup (#740)
* fix: change the order of the upgrade methods lookup
The `isUpgradeTransaction` method was looking for the methods in an wrong order (#599).
The proper order was set in #610, but `isUpgradeTransaction` wasn't updated.
* fix: contract upgrade version lookup
* Feature: Use eth_sign for hardware wallets connected via onboard.js (#742)
* Use eth_sign for hardware wallets
* install onboard.js with fix from forked repo
* rebuild yarn.lock to fix cached onboard
* update bnc-onboard
* update package json (#743)
* (Fix) Properly decode threshold value in tx details (#749)
* fix: Display new threshold value when changing its value
There was a typo for the `changeThreshold` action
fixes#746
* refactor: use a constant for safe methods names
* fix: check for `decimals` method in transferredTokens (#748)
Previously we were looking for `decimals` hash in the contract `code`.
There are some contracts like USDC who happen to be behind a FiatTokenProxy, making it upgradable.
By directly calling the `decimals()` method, we interact with the contract and can be sure that the `decimals()` method is present.
fixes#678
* Bug #747: Don't use getLastTxNonce to fetch safe nonce (#750)
* don't use getLastTxNonce to fetch safe nonce
* fetch safe nonce in checkAndUpdateSafe
* checkAndUpdateSafe refactor
* remove nonce update logic from UPDATE_SAFE reducer
* handle the case when localSafe returns undefined
* handle the case when localSafe returns undefined in buildTransactionFrom
* bump package json version to 1.9.4
* Issue-595: Apps config from Manifest (#715)
* getting apps info from its manifest
* Consume app info from manifest in Apps list, Transactions and Toast
* fixes
* navigate to TX Tab with an app makes a TX
* (Fix) If backend returns `null` for addresses the Transaction ca… (#718)
This tends to solve any possible issue that there may be in the tx execution for the `gasToken` and `refundReceiver` nullish values.
fixes#573
* #751 fix - Replaces decimals from backend with decimals from blockchain (#755)
* Replaces decimals from backend with decimals from blockchain
* Removes fetching again token info from blockchain
Fixs decimals cast, now we force to move from bignumber to number
For data already wrong stored as string we remove it to force fetching again the decimals
* Fixs missing symbol
* Add description comment
* Added Unilogin provider + support for legacy paths (#719)
* Added unilogin provier + support for legacy path
* Bump onboardjs version
* fallback to displaying custom tx when we fail to fetch token info (#767)
* Create release.yml
Created script for building desktop app
* Feature #322: Set safeTxGas for newly created transactions (#752)
* Set safeTxGas for newly created transactions
* extending estimation for nested calls WIP
* messing up things to implement safeTxGas estimation
* simplifying base gas calculations
* remove eslint disable
* messing things up to make things work
* bring estimateData back
* pass payload to requiredTxGas
* pass esimateData to estimateDataGasCosts
* remove console log
* use batch requests to estimate safeTxGas
* use const for txGasEstimation
* check the response in request simultion
* sidebar fix
* remove for loop
* Manage Apps (#765)
* getting apps info from its manifest
* Consume app info from manifest in Apps list, Transactions and Toast
* fixes
* navigate to TX Tab with an app makes a TX
* ManageApps partial implementation
* update safe-react-components
* changes
* apps validator
* fix providedBy
* TextField in addApp
* fix checkbox error message
* validation
* adding app
* Manage Apps
* fix modal width
* update package.json
* update netlify url
* fix modal widh
* Set layout to Non-owners allowed error
* some fixes
* Apply suggestions from code review
Co-Authored-By: lukasschor <lukas.schor@gnosis.pm>
* review changes
* fix condition
* Legal Disclaimer
* Better error message
* update yarn.lock
* Error message
* review fixes
* upgrade safe-react-components
* show for all environments
* Disclaimer changes
* review changes
* fix re-render
* visual changes
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
* fix scroll and fix margin layout
* Add region to travis CI develop (#787)
Enable region for s3 provider to allow upload development environment to different S3 regions
* Feature/travis ci s3 region (#789)
* Add region to travis CI develop
Enable region for s3 provider to allow upload development environment to different S3 regions
* Enable region for staging s3 providers
* fix error on Wrapper
* Add gnosis wc bridge to onboard.js wallets options array (#790)
* Rename incoming-transactions url to incoming-transfers
* Feature #587 - App performance improvement (#738)
* Refactor Balances to functional component
Removes Balances props in Layout.jsx
* Replaces selectors that were using safeParamAddressSelector with safeParamAddressFromStateSelector to avoid the bug of non-loaded safe when called
Also exports extendedTransactionsSelector to let the components use it
* Refactors Transactions.jsx, replaces transactions.tsx with txsTable.jsx
Removes all unused props from transactions.jsx
Makes all childs of txsTable.jsx fetch the props they need instead of sharing all of them even if they are not used
* Adds new selectors: safeNameSelector, safeNeedsUpdateSelector, safeCurrentVersionSelector
* Removes unused props from layout to settings.jsx
Removed props from the settings.jsx childs, now they fetch the values they need directly from the store
* Removes unused redux connect
* Adds safeEthBalanceSelector
* Removes all the props from layout to settings
* Refactor root and layout, extracts checkForUpdate and componentDidMount to components
Extracts header and tabs from Layout.jsx
* Makes routes.jsx use selectors instead of connect to unify the code
* Loads tabs components using react suspense
* Fixs warning when trying to update root component within loadStore.jsx
Replaces safe with safeAddress selector in layout.jsx to reduce the unnecessary rendering
Fixs setState in container.jsx
* Fixs checkForUpdates fetchTokenBalances
Adds FetchTokens.jsx in balances
Adds safeFeaturesEnabledSelector
* Fixs load addressbook action
* Replaces safe with owners in manage owners
* Improves buildSafe promises calls
Improves the loadStorage calls
* Fixs error "Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined"
* Extracts LoadStore from outside the router component to avoid re-loading the store
Adds react lazy for Coins and Collectible tabs
* Reduce the polling rate for fetching transactions
* Removes unused actions.js
Removes unused selector props
* Fixes owners column selector usage
* Fixes processTransaction usage
* Optimize how the transaction list within the transactions tab are loaded
* Fix lint error
* Fix edit addressbook entry
* Fixs show send coins modal
* feature: batchRequest for incoming transactions
* Fixs race condition on loadStore
Fixs check for updates address null validation
* Adds ensureOnceAsync for getGnosisSafeInstanceAt
Adds batch request for safe params
* Removes unnecessary checkAndUpdateSafe from checkForUpdates, now the safe gets updated when a transaction arrives
* Fixs ensureOnce/memoization
* refactor: make a generic generateBatchRequest method
Create a generic method to easily build web3 batch requests
* refactor: use `generateBatchRequest` in `getTokensBalances`
* Removes .toJS in edit entry
* Removes web3 from sendTransactions
Removes pascal case FetchTokens
* Replaces /layout import
* Replaces CheckForUpdates component with useCheckForUpdates hook
* Makes FetchTokens a hook
* Removes getSafeParamsBatch, now the safes gets the data using the generic generateBatchRequests
* Replaces INITIAL_STATUS with INITIAL_STATE
* Replaces regex
Adds spaces before return
* Adds wrapInSuspense
* Runs prettier
* Makes checkAndUpdateSafe use generateBatchRequests
* Makes checkAndUpdateSafe use generateBatchRequests
* Fixs check for updates with null address
* Fixs transaction details getNameFromAddressBook
* Fixes zIndex between cookies banner and transaction details
* fix: cast returned values to number
Original code was expecting a BN instance, now it's a plain string.
* Fix replace owner name
* Fix race condition with adbk load
* Fixes replaces owner
* Fixs apps
* Moved hooks into own folder
* Moved LoadStore to routes.js
Refactors LoadStore as Hook
Move LoadStore to hooks folder
* Moves useLoadStore to safes/index
* Revert loadStore place change
* Fixes bug with fetchEtherBalance that causes updateSafe to be called
* remove useLoadStore, add useAnalytics hook
* remove React.memo from SafeView
* Reverts removing useLoadStore in order to maintain the consistency of the code
* rewrite useLoadStore in a more hook-y way, rename it to useLoadSafe
* Removes unnecessary setSafeLoaded
* Removes unnecessary safeLoaded
* fix: Coins values and balances
The app was retrieving ERC20 tokens information from 3 different endpoints.
- One from `balance/` to have the list updated
- another from `balance/usd` to have the values in USD
- the last one from the blockchain, to update the balances
This was all simplified to `balance/usd`.
Also, added a `currencyRate` to be updated when the currency is modified.
The value calculation happens on a component level, so when the `balanceUsd` value is modified, the value is properly reflected on the screen.
Refactored `activateTokensByBalance` to `fetchSafeTokens`, as this was doing quite more than just _activating_ and also added the `currencyList` calculation in it, so everything is updated when `balance/usd` endpoint is requested.
* fix: Balance screen
Collectibles weren't loading when clicking on the link
Also, refactored setState usage, to properly update current state
* fix: featuresEnabled undefined
* fix: add/activate newly received tokens
* fix: NaN Values in Coins for a newly loaded Safe
Was failing to set a default value for the `currencyRate`
* fix: Settings fails to load if `owners` is not loaded into store
Added a `Loader` until the required Safe's data is loaded into store.
* fix: prefetch txs data
When building the Txs list, we requested data for every tx what was translated into several RPC calls.
Now by _batchRequesting_ all the information on beforehand, Safe's loading is a bit faster.
* fix: prevent requesting safe, when there's no safe available in the store
* enhancement: fetch tokens when loading safe
By doing this, when loading a safe in the balance screen we will have tokens immediately loaded into the coins list
* fix: load collectibles when switch to collectibles screen
Collectibles weren't loaded when clicking menu link for a newly loaded safe.
Now every switch to the collectible's screen will trigger a fetch for collectibles.
* fix: fetch only if safe is ready
Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* Fix (#777)
* fix: batchRequest params order
* fix: execute decodeParams for all sendTokenTxs
* fix: proper amount display for tx in TxTable
* Uses formatAmount
* Removes unused code
Fixs params props safe address form
* Fixs composeValidators
Adds composeValidators for apps section
* Makes composeValidatorsApps a wrapper
* Moves composeValidatorsApps to managesApps.js
* Desktop app (#745)
* Set up electron app
* Update dependencies
* Update package.json
* Added https support
* Add support for Ledger
* Updated certs
* Added auto updates messages
* Update auto-updater method
* Update package.json
* Added build resources
* Update preload
* Update Ledger method on mac
* Update build
* Merge with develop
* Added support for Portis
* Fix electron error and updater
* Update auto updater
* Fix dependencies
* Merge with develop
* Change auto update functionality
* Edit package.json and added github actions
* Updated github actions
* Fixed Torus + Update github actions
* Updated release.yml
* Try only ubuntu
* Update package.json
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* Updated safe-contracts
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* Updated deploy branch
* Updated script
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: David Albela Pérez <3659067+davidalbela@users.noreply.github.com>
Co-authored-by: Uxio Fuentefria <uxio@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
* Update CI Desktop script
* Update CI script for windows
* Development v2 fixes (#822)
* Bug: Invalid V in signature with eth_sign (#728)
* Fix invalid V with metamask/ledger
* DONT FORGET TO REVERT BEFORE MERGING: test deployment
* DONT FORGET TO REVERT BEFORE MERGING 2: test deployment
* Revert "DONT FORGET TO REVERT BEFORE MERGING 2: test deployment"
This reverts commit 8331f2a78f7fc8f53eb893899f16edd8238c68ff.
* Revert "DONT FORGET TO REVERT BEFORE MERGING: test deployment"
This reverts commit 03b81e31820ce4fe078a7131c2f0caa2af4870ac.
* BUG: Only injected providers are cached as last used provider (#733)
* cache every used provider, not only injected one
* package json update
* (Fix) Adapt app to back-end changes (#736)
* refactor: Set success status to `201` (CREATED)
* refactor: return `null` when there's no latestTx
* (Fix) Transaction not automatically executed (#716)
* feature: action/reducer to UPDATE_SAFE_NONCE
* refactor: when processing txs returned from backend, extract latest tx nonce value and store it in the safe's state
* chore: update `yarn.lock`
* refactor: `UPDATE_SAFE_THRESHOLD` and `UPDATE_SAFE_NONCE` discarded in favor of `UPDATE_SAFE`
* refactor: use `SAFE_REDUCER_ID` constant
* refactor: remove `updateSafeNonce` file
* (Fix) Change the order of the upgrade methods lookup (#740)
* fix: change the order of the upgrade methods lookup
The `isUpgradeTransaction` method was looking for the methods in an wrong order (#599).
The proper order was set in #610, but `isUpgradeTransaction` wasn't updated.
* fix: contract upgrade version lookup
* Feature: Use eth_sign for hardware wallets connected via onboard.js (#742)
* Use eth_sign for hardware wallets
* install onboard.js with fix from forked repo
* rebuild yarn.lock to fix cached onboard
* update bnc-onboard
* update package json (#743)
* (Fix) Properly decode threshold value in tx details (#749)
* fix: Display new threshold value when changing its value
There was a typo for the `changeThreshold` action
fixes#746
* refactor: use a constant for safe methods names
* fix: check for `decimals` method in transferredTokens (#748)
Previously we were looking for `decimals` hash in the contract `code`.
There are some contracts like USDC who happen to be behind a FiatTokenProxy, making it upgradable.
By directly calling the `decimals()` method, we interact with the contract and can be sure that the `decimals()` method is present.
fixes#678
* Bug #747: Don't use getLastTxNonce to fetch safe nonce (#750)
* don't use getLastTxNonce to fetch safe nonce
* fetch safe nonce in checkAndUpdateSafe
* checkAndUpdateSafe refactor
* remove nonce update logic from UPDATE_SAFE reducer
* handle the case when localSafe returns undefined
* handle the case when localSafe returns undefined in buildTransactionFrom
* bump package json version to 1.9.4
* Issue-595: Apps config from Manifest (#715)
* getting apps info from its manifest
* Consume app info from manifest in Apps list, Transactions and Toast
* fixes
* navigate to TX Tab with an app makes a TX
* (Fix) If backend returns `null` for addresses the Transaction ca… (#718)
This tends to solve any possible issue that there may be in the tx execution for the `gasToken` and `refundReceiver` nullish values.
fixes#573
* #751 fix - Replaces decimals from backend with decimals from blockchain (#755)
* Replaces decimals from backend with decimals from blockchain
* Removes fetching again token info from blockchain
Fixs decimals cast, now we force to move from bignumber to number
For data already wrong stored as string we remove it to force fetching again the decimals
* Fixs missing symbol
* Add description comment
* Added Unilogin provider + support for legacy paths (#719)
* Added unilogin provier + support for legacy path
* Bump onboardjs version
* fallback to displaying custom tx when we fail to fetch token info (#767)
* Create release.yml
Created script for building desktop app
* Feature #322: Set safeTxGas for newly created transactions (#752)
* Set safeTxGas for newly created transactions
* extending estimation for nested calls WIP
* messing up things to implement safeTxGas estimation
* simplifying base gas calculations
* remove eslint disable
* messing things up to make things work
* bring estimateData back
* pass payload to requiredTxGas
* pass esimateData to estimateDataGasCosts
* remove console log
* use batch requests to estimate safeTxGas
* use const for txGasEstimation
* check the response in request simultion
* sidebar fix
* remove for loop
* Manage Apps (#765)
* getting apps info from its manifest
* Consume app info from manifest in Apps list, Transactions and Toast
* fixes
* navigate to TX Tab with an app makes a TX
* ManageApps partial implementation
* update safe-react-components
* changes
* apps validator
* fix providedBy
* TextField in addApp
* fix checkbox error message
* validation
* adding app
* Manage Apps
* fix modal width
* update package.json
* update netlify url
* fix modal widh
* Set layout to Non-owners allowed error
* some fixes
* Apply suggestions from code review
Co-Authored-By: lukasschor <lukas.schor@gnosis.pm>
* review changes
* fix condition
* Legal Disclaimer
* Better error message
* update yarn.lock
* Error message
* review fixes
* upgrade safe-react-components
* show for all environments
* Disclaimer changes
* review changes
* fix re-render
* visual changes
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
* fix scroll and fix margin layout
* Add region to travis CI develop (#787)
Enable region for s3 provider to allow upload development environment to different S3 regions
* Feature/travis ci s3 region (#789)
* Add region to travis CI develop
Enable region for s3 provider to allow upload development environment to different S3 regions
* Enable region for staging s3 providers
* fix error on Wrapper
* Add gnosis wc bridge to onboard.js wallets options array (#790)
* Rename incoming-transactions url to incoming-transfers
* Feature #587 - App performance improvement (#738)
* Refactor Balances to functional component
Removes Balances props in Layout.jsx
* Replaces selectors that were using safeParamAddressSelector with safeParamAddressFromStateSelector to avoid the bug of non-loaded safe when called
Also exports extendedTransactionsSelector to let the components use it
* Refactors Transactions.jsx, replaces transactions.tsx with txsTable.jsx
Removes all unused props from transactions.jsx
Makes all childs of txsTable.jsx fetch the props they need instead of sharing all of them even if they are not used
* Adds new selectors: safeNameSelector, safeNeedsUpdateSelector, safeCurrentVersionSelector
* Removes unused props from layout to settings.jsx
Removed props from the settings.jsx childs, now they fetch the values they need directly from the store
* Removes unused redux connect
* Adds safeEthBalanceSelector
* Removes all the props from layout to settings
* Refactor root and layout, extracts checkForUpdate and componentDidMount to components
Extracts header and tabs from Layout.jsx
* Makes routes.jsx use selectors instead of connect to unify the code
* Loads tabs components using react suspense
* Fixs warning when trying to update root component within loadStore.jsx
Replaces safe with safeAddress selector in layout.jsx to reduce the unnecessary rendering
Fixs setState in container.jsx
* Fixs checkForUpdates fetchTokenBalances
Adds FetchTokens.jsx in balances
Adds safeFeaturesEnabledSelector
* Fixs load addressbook action
* Replaces safe with owners in manage owners
* Improves buildSafe promises calls
Improves the loadStorage calls
* Fixs error "Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined"
* Extracts LoadStore from outside the router component to avoid re-loading the store
Adds react lazy for Coins and Collectible tabs
* Reduce the polling rate for fetching transactions
* Removes unused actions.js
Removes unused selector props
* Fixes owners column selector usage
* Fixes processTransaction usage
* Optimize how the transaction list within the transactions tab are loaded
* Fix lint error
* Fix edit addressbook entry
* Fixs show send coins modal
* feature: batchRequest for incoming transactions
* Fixs race condition on loadStore
Fixs check for updates address null validation
* Adds ensureOnceAsync for getGnosisSafeInstanceAt
Adds batch request for safe params
* Removes unnecessary checkAndUpdateSafe from checkForUpdates, now the safe gets updated when a transaction arrives
* Fixs ensureOnce/memoization
* refactor: make a generic generateBatchRequest method
Create a generic method to easily build web3 batch requests
* refactor: use `generateBatchRequest` in `getTokensBalances`
* Removes .toJS in edit entry
* Removes web3 from sendTransactions
Removes pascal case FetchTokens
* Replaces /layout import
* Replaces CheckForUpdates component with useCheckForUpdates hook
* Makes FetchTokens a hook
* Removes getSafeParamsBatch, now the safes gets the data using the generic generateBatchRequests
* Replaces INITIAL_STATUS with INITIAL_STATE
* Replaces regex
Adds spaces before return
* Adds wrapInSuspense
* Runs prettier
* Makes checkAndUpdateSafe use generateBatchRequests
* Makes checkAndUpdateSafe use generateBatchRequests
* Fixs check for updates with null address
* Fixs transaction details getNameFromAddressBook
* Fixes zIndex between cookies banner and transaction details
* fix: cast returned values to number
Original code was expecting a BN instance, now it's a plain string.
* Fix replace owner name
* Fix race condition with adbk load
* Fixes replaces owner
* Fixs apps
* Moved hooks into own folder
* Moved LoadStore to routes.js
Refactors LoadStore as Hook
Move LoadStore to hooks folder
* Moves useLoadStore to safes/index
* Revert loadStore place change
* Fixes bug with fetchEtherBalance that causes updateSafe to be called
* remove useLoadStore, add useAnalytics hook
* remove React.memo from SafeView
* Reverts removing useLoadStore in order to maintain the consistency of the code
* rewrite useLoadStore in a more hook-y way, rename it to useLoadSafe
* Removes unnecessary setSafeLoaded
* Removes unnecessary safeLoaded
* fix: Coins values and balances
The app was retrieving ERC20 tokens information from 3 different endpoints.
- One from `balance/` to have the list updated
- another from `balance/usd` to have the values in USD
- the last one from the blockchain, to update the balances
This was all simplified to `balance/usd`.
Also, added a `currencyRate` to be updated when the currency is modified.
The value calculation happens on a component level, so when the `balanceUsd` value is modified, the value is properly reflected on the screen.
Refactored `activateTokensByBalance` to `fetchSafeTokens`, as this was doing quite more than just _activating_ and also added the `currencyList` calculation in it, so everything is updated when `balance/usd` endpoint is requested.
* fix: Balance screen
Collectibles weren't loading when clicking on the link
Also, refactored setState usage, to properly update current state
* fix: featuresEnabled undefined
* fix: add/activate newly received tokens
* fix: NaN Values in Coins for a newly loaded Safe
Was failing to set a default value for the `currencyRate`
* fix: Settings fails to load if `owners` is not loaded into store
Added a `Loader` until the required Safe's data is loaded into store.
* fix: prefetch txs data
When building the Txs list, we requested data for every tx what was translated into several RPC calls.
Now by _batchRequesting_ all the information on beforehand, Safe's loading is a bit faster.
* fix: prevent requesting safe, when there's no safe available in the store
* enhancement: fetch tokens when loading safe
By doing this, when loading a safe in the balance screen we will have tokens immediately loaded into the coins list
* fix: load collectibles when switch to collectibles screen
Collectibles weren't loaded when clicking menu link for a newly loaded safe.
Now every switch to the collectible's screen will trigger a fetch for collectibles.
* fix: fetch only if safe is ready
Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* Fix (#777)
* fix: batchRequest params order
* fix: execute decodeParams for all sendTokenTxs
* fix: proper amount display for tx in TxTable
* Uses formatAmount
* Removes unused code
Fixs params props safe address form
* Fixs composeValidators
Adds composeValidators for apps section
* Makes composeValidatorsApps a wrapper
* Moves composeValidatorsApps to managesApps.js
* Desktop app (#745)
* Set up electron app
* Update dependencies
* Update package.json
* Added https support
* Add support for Ledger
* Updated certs
* Added auto updates messages
* Update auto-updater method
* Update package.json
* Added build resources
* Update preload
* Update Ledger method on mac
* Update build
* Merge with develop
* Added support for Portis
* Fix electron error and updater
* Update auto updater
* Fix dependencies
* Merge with develop
* Change auto update functionality
* Edit package.json and added github actions
* Updated github actions
* Fixed Torus + Update github actions
* Updated release.yml
* Try only ubuntu
* Update package.json
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* Updated safe-contracts
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* Updated deploy branch
* Updated script
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
* Update yarn script + SAFE_APPS env variable
* Converts custom token address to checksum version (#793)
* SafeTxGas calculation: Add check for openethereum/parity revert messages (#788)
* add check for openethereum/parity revert messages
* fix isEstimationSuccessful check
* fix estimation check if revert msg is from openethereum
* Issue 796 (#807)
* consume gnosis componentes from npm
* set safe-apps url from environment variable
* fix apps padding and border radius
* Apps updates
* update disclaimer
* fix Loader in TXList
* Fix invalid origin
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
* (Feature) Tx Table amount notations (#812)
* Fix master conflicts (#819)
* v2.0.0 (#806)
* Bug: Invalid V in signature with eth_sign (#728)
* Fix invalid V with metamask/ledger
* DONT FORGET TO REVERT BEFORE MERGING: test deployment
* DONT FORGET TO REVERT BEFORE MERGING 2: test deployment
* Revert "DONT FORGET TO REVERT BEFORE MERGING 2: test deployment"
This reverts commit 8331f2a78f7fc8f53eb893899f16edd8238c68ff.
* Revert "DONT FORGET TO REVERT BEFORE MERGING: test deployment"
This reverts commit 03b81e31820ce4fe078a7131c2f0caa2af4870ac.
* BUG: Only injected providers are cached as last used provider (#733)
* cache every used provider, not only injected one
* package json update
* (Fix) Adapt app to back-end changes (#736)
* refactor: Set success status to `201` (CREATED)
* refactor: return `null` when there's no latestTx
* (Fix) Transaction not automatically executed (#716)
* feature: action/reducer to UPDATE_SAFE_NONCE
* refactor: when processing txs returned from backend, extract latest tx nonce value and store it in the safe's state
* chore: update `yarn.lock`
* refactor: `UPDATE_SAFE_THRESHOLD` and `UPDATE_SAFE_NONCE` discarded in favor of `UPDATE_SAFE`
* refactor: use `SAFE_REDUCER_ID` constant
* refactor: remove `updateSafeNonce` file
* (Fix) Change the order of the upgrade methods lookup (#740)
* fix: change the order of the upgrade methods lookup
The `isUpgradeTransaction` method was looking for the methods in an wrong order (#599).
The proper order was set in #610, but `isUpgradeTransaction` wasn't updated.
* fix: contract upgrade version lookup
* Feature: Use eth_sign for hardware wallets connected via onboard.js (#742)
* Use eth_sign for hardware wallets
* install onboard.js with fix from forked repo
* rebuild yarn.lock to fix cached onboard
* update bnc-onboard
* update package json (#743)
* (Fix) Properly decode threshold value in tx details (#749)
* fix: Display new threshold value when changing its value
There was a typo for the `changeThreshold` action
fixes#746
* refactor: use a constant for safe methods names
* fix: check for `decimals` method in transferredTokens (#748)
Previously we were looking for `decimals` hash in the contract `code`.
There are some contracts like USDC who happen to be behind a FiatTokenProxy, making it upgradable.
By directly calling the `decimals()` method, we interact with the contract and can be sure that the `decimals()` method is present.
fixes#678
* Bug #747: Don't use getLastTxNonce to fetch safe nonce (#750)
* don't use getLastTxNonce to fetch safe nonce
* fetch safe nonce in checkAndUpdateSafe
* checkAndUpdateSafe refactor
* remove nonce update logic from UPDATE_SAFE reducer
* handle the case when localSafe returns undefined
* handle the case when localSafe returns undefined in buildTransactionFrom
* bump package json version to 1.9.4
* Issue-595: Apps config from Manifest (#715)
* getting apps info from its manifest
* Consume app info from manifest in Apps list, Transactions and Toast
* fixes
* navigate to TX Tab with an app makes a TX
* (Fix) If backend returns `null` for addresses the Transaction ca… (#718)
This tends to solve any possible issue that there may be in the tx execution for the `gasToken` and `refundReceiver` nullish values.
fixes#573
* #751 fix - Replaces decimals from backend with decimals from blockchain (#755)
* Replaces decimals from backend with decimals from blockchain
* Removes fetching again token info from blockchain
Fixs decimals cast, now we force to move from bignumber to number
For data already wrong stored as string we remove it to force fetching again the decimals
* Fixs missing symbol
* Add description comment
* Added Unilogin provider + support for legacy paths (#719)
* Added unilogin provier + support for legacy path
* Bump onboardjs version
* fallback to displaying custom tx when we fail to fetch token info (#767)
* Create release.yml
Created script for building desktop app
* Feature #322: Set safeTxGas for newly created transactions (#752)
* Set safeTxGas for newly created transactions
* extending estimation for nested calls WIP
* messing up things to implement safeTxGas estimation
* simplifying base gas calculations
* remove eslint disable
* messing things up to make things work
* bring estimateData back
* pass payload to requiredTxGas
* pass esimateData to estimateDataGasCosts
* remove console log
* use batch requests to estimate safeTxGas
* use const for txGasEstimation
* check the response in request simultion
* sidebar fix
* remove for loop
* Manage Apps (#765)
* getting apps info from its manifest
* Consume app info from manifest in Apps list, Transactions and Toast
* fixes
* navigate to TX Tab with an app makes a TX
* ManageApps partial implementation
* update safe-react-components
* changes
* apps validator
* fix providedBy
* TextField in addApp
* fix checkbox error message
* validation
* adding app
* Manage Apps
* fix modal width
* update package.json
* update netlify url
* fix modal widh
* Set layout to Non-owners allowed error
* some fixes
* Apply suggestions from code review
Co-Authored-By: lukasschor <lukas.schor@gnosis.pm>
* review changes
* fix condition
* Legal Disclaimer
* Better error message
* update yarn.lock
* Error message
* review fixes
* upgrade safe-react-components
* show for all environments
* Disclaimer changes
* review changes
* fix re-render
* visual changes
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
* fix scroll and fix margin layout
* Add region to travis CI develop (#787)
Enable region for s3 provider to allow upload development environment to different S3 regions
* Feature/travis ci s3 region (#789)
* Add region to travis CI develop
Enable region for s3 provider to allow upload development environment to different S3 regions
* Enable region for staging s3 providers
* fix error on Wrapper
* Add gnosis wc bridge to onboard.js wallets options array (#790)
* Rename incoming-transactions url to incoming-transfers
* Feature #587 - App performance improvement (#738)
* Refactor Balances to functional component
Removes Balances props in Layout.jsx
* Replaces selectors that were using safeParamAddressSelector with safeParamAddressFromStateSelector to avoid the bug of non-loaded safe when called
Also exports extendedTransactionsSelector to let the components use it
* Refactors Transactions.jsx, replaces transactions.tsx with txsTable.jsx
Removes all unused props from transactions.jsx
Makes all childs of txsTable.jsx fetch the props they need instead of sharing all of them even if they are not used
* Adds new selectors: safeNameSelector, safeNeedsUpdateSelector, safeCurrentVersionSelector
* Removes unused props from layout to settings.jsx
Removed props from the settings.jsx childs, now they fetch the values they need directly from the store
* Removes unused redux connect
* Adds safeEthBalanceSelector
* Removes all the props from layout to settings
* Refactor root and layout, extracts checkForUpdate and componentDidMount to components
Extracts header and tabs from Layout.jsx
* Makes routes.jsx use selectors instead of connect to unify the code
* Loads tabs components using react suspense
* Fixs warning when trying to update root component within loadStore.jsx
Replaces safe with safeAddress selector in layout.jsx to reduce the unnecessary rendering
Fixs setState in container.jsx
* Fixs checkForUpdates fetchTokenBalances
Adds FetchTokens.jsx in balances
Adds safeFeaturesEnabledSelector
* Fixs load addressbook action
* Replaces safe with owners in manage owners
* Improves buildSafe promises calls
Improves the loadStorage calls
* Fixs error "Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined"
* Extracts LoadStore from outside the router component to avoid re-loading the store
Adds react lazy for Coins and Collectible tabs
* Reduce the polling rate for fetching transactions
* Removes unused actions.js
Removes unused selector props
* Fixes owners column selector usage
* Fixes processTransaction usage
* Optimize how the transaction list within the transactions tab are loaded
* Fix lint error
* Fix edit addressbook entry
* Fixs show send coins modal
* feature: batchRequest for incoming transactions
* Fixs race condition on loadStore
Fixs check for updates address null validation
* Adds ensureOnceAsync for getGnosisSafeInstanceAt
Adds batch request for safe params
* Removes unnecessary checkAndUpdateSafe from checkForUpdates, now the safe gets updated when a transaction arrives
* Fixs ensureOnce/memoization
* refactor: make a generic generateBatchRequest method
Create a generic method to easily build web3 batch requests
* refactor: use `generateBatchRequest` in `getTokensBalances`
* Removes .toJS in edit entry
* Removes web3 from sendTransactions
Removes pascal case FetchTokens
* Replaces /layout import
* Replaces CheckForUpdates component with useCheckForUpdates hook
* Makes FetchTokens a hook
* Removes getSafeParamsBatch, now the safes gets the data using the generic generateBatchRequests
* Replaces INITIAL_STATUS with INITIAL_STATE
* Replaces regex
Adds spaces before return
* Adds wrapInSuspense
* Runs prettier
* Makes checkAndUpdateSafe use generateBatchRequests
* Makes checkAndUpdateSafe use generateBatchRequests
* Fixs check for updates with null address
* Fixs transaction details getNameFromAddressBook
* Fixes zIndex between cookies banner and transaction details
* fix: cast returned values to number
Original code was expecting a BN instance, now it's a plain string.
* Fix replace owner name
* Fix race condition with adbk load
* Fixes replaces owner
* Fixs apps
* Moved hooks into own folder
* Moved LoadStore to routes.js
Refactors LoadStore as Hook
Move LoadStore to hooks folder
* Moves useLoadStore to safes/index
* Revert loadStore place change
* Fixes bug with fetchEtherBalance that causes updateSafe to be called
* remove useLoadStore, add useAnalytics hook
* remove React.memo from SafeView
* Reverts removing useLoadStore in order to maintain the consistency of the code
* rewrite useLoadStore in a more hook-y way, rename it to useLoadSafe
* Removes unnecessary setSafeLoaded
* Removes unnecessary safeLoaded
* fix: Coins values and balances
The app was retrieving ERC20 tokens information from 3 different endpoints.
- One from `balance/` to have the list updated
- another from `balance/usd` to have the values in USD
- the last one from the blockchain, to update the balances
This was all simplified to `balance/usd`.
Also, added a `currencyRate` to be updated when the currency is modified.
The value calculation happens on a component level, so when the `balanceUsd` value is modified, the value is properly reflected on the screen.
Refactored `activateTokensByBalance` to `fetchSafeTokens`, as this was doing quite more than just _activating_ and also added the `currencyList` calculation in it, so everything is updated when `balance/usd` endpoint is requested.
* fix: Balance screen
Collectibles weren't loading when clicking on the link
Also, refactored setState usage, to properly update current state
* fix: featuresEnabled undefined
* fix: add/activate newly received tokens
* fix: NaN Values in Coins for a newly loaded Safe
Was failing to set a default value for the `currencyRate`
* fix: Settings fails to load if `owners` is not loaded into store
Added a `Loader` until the required Safe's data is loaded into store.
* fix: prefetch txs data
When building the Txs list, we requested data for every tx what was translated into several RPC calls.
Now by _batchRequesting_ all the information on beforehand, Safe's loading is a bit faster.
* fix: prevent requesting safe, when there's no safe available in the store
* enhancement: fetch tokens when loading safe
By doing this, when loading a safe in the balance screen we will have tokens immediately loaded into the coins list
* fix: load collectibles when switch to collectibles screen
Collectibles weren't loaded when clicking menu link for a newly loaded safe.
Now every switch to the collectible's screen will trigger a fetch for collectibles.
* fix: fetch only if safe is ready
Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* Fix (#777)
* fix: batchRequest params order
* fix: execute decodeParams for all sendTokenTxs
* fix: proper amount display for tx in TxTable
* Uses formatAmount
* Removes unused code
Fixs params props safe address form
* Fixs composeValidators
Adds composeValidators for apps section
* Makes composeValidatorsApps a wrapper
* Moves composeValidatorsApps to managesApps.js
* Desktop app (#745)
* Set up electron app
* Update dependencies
* Update package.json
* Added https support
* Add support for Ledger
* Updated certs
* Added auto updates messages
* Update auto-updater method
* Update package.json
* Added build resources
* Update preload
* Update Ledger method on mac
* Update build
* Merge with develop
* Added support for Portis
* Fix electron error and updater
* Update auto updater
* Fix dependencies
* Merge with develop
* Change auto update functionality
* Edit package.json and added github actions
* Updated github actions
* Fixed Torus + Update github actions
* Updated release.yml
* Try only ubuntu
* Update package.json
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* Updated safe-contracts
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* v1.9.6
* Updated deploy branch
* Updated script
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: David Albela Pérez <3659067+davidalbela@users.noreply.github.com>
Co-authored-by: Uxio Fuentefria <uxio@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
* Update CI Desktop script
* Update CI script for windows
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: David Albela Pérez <3659067+davidalbela@users.noreply.github.com>
Co-authored-by: Uxio Fuentefria <uxio@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: David Albela Pérez <3659067+davidalbela@users.noreply.github.com>
Co-authored-by: Uxio Fuentefria <uxio@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
* Fix apps loader
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: David Albela Pérez <3659067+davidalbela@users.noreply.github.com>
Co-authored-by: Uxio Fuentefria <uxio@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@mercadolibre.com>
nicosampler
nicolas
Daniel Sanchez
Mikhail Mikheev
Germán Martínez
fernandomg
Agustin Pane
Mati Dastugue
Mati Dastugue
Mati Dastugue