Commit Graph

3234 Commits

Author SHA1 Message Date
nicolas 2ea67b5137
Set transaction parameters manually - Advanced options (#1760)
* Makes getGasEstimationTxResponse exportable

* Add check for failing txs on approveTxModal

* Adds styles for reviewTx

* Adds useTxSuccessCheck hook

* Remove hook

* Adds checkIfTxWillFail function

* Uses checkIfTxWillFailAsync on reviewTx modal

* Improves approveTx modal

* Add check for failing transaction in contract interaction modal

* Add check for reviewCollectible

* Fix check on sendFunds reviewTx

* Adds styling for contractInteraction modal

* Fix gas calculation for native token transfers

* Remove logs

* Rename estimateDataGasCosts to parseRequiredTxGasResponse
Adds getPreValidatedSignatures
Refactor estimateTxGasCosts
Refactor checkIfExecTxWillFail

* Refactor checkIfExecTxWill usage

* Refactor checkIfTxWillFailAsync in ReviewTx

* Use getPreValidatedSignatures in createTransaction()

* Refactor estimateTxGasCosts
Rename estimateSafeTxGas to estimateExecTransactionGas

* Refactor ReviewTx: extract useEffects to hooks

* Remove unnecessary gas transfer amount

* Refactor estimateTxGasCosts: extract checkIfTxIsExecution and estimateTxGas

* Fix tx amount
Remove console log

* Moves useCheckIfTransactionWillFail to logic/hooks folder

* Replaces useEffect usage with useCheckIfTransactionWillFail hook
Also fix how some modals fetch the safeAddress

* Improves modal's wording

* Remove comment

* Fix error parsing the cancel transaction error message from GETH nodes

* Remove useCheckIfTransactionWillFail
Adds useEstimateTransactionGas
Renames estimateTxGas to estimateTransactionGas
Removes estimateTxGasCosts
Removes checkIfExecTxWillFail

* Replace useCheckIfTransactionWillFail from modals with useEstimateTransactionGas

* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas

* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas

* Extract isExecution calculation to useEstimateTransactionGas

* Creates TransactionFailText

* Uses TransactionFailText in the review modals

* Remove unnecessary styles

* Fix imports

* Remove css

* Fix missing style

* Remove duplicated function

* Fix modal height

* Fix wrong selector usage

* Fix missing null check on cancel tx confirmations

* Add guard for CLOSE_SNACKBAR action when tx was already dismissed

* Improves useEstimateTransactionGas in review custom tx and contract interaction review

* Fix hook dependency

* Add active screen types in send modal

* SafeInfo: replace AddressInfo by EthHashInfo

* Fix review replace/remove/add owner modals styling

* AdvancedOptions without funcionality

* change button text

* fix margins and texts

* fix close button margin

* rename ReviewTx by ReviewSendFundsTx

* safe params: partial implementation

* make use of useTransactionParameters hook

* Refactor response of useEstimateTransactionGas

* Remove safeAddress as param to the useEstimateTransactionGas

* Improves how threshold is obtained in useEstimateTransactionGas.tsx

* Rename gasCostHumanReadable to gasCostFormatted

* Add operation to useEstimateTransactionGas

* Refactor ConfirmTransactionModal to use useEstimateTransactionGas

* Refactor proccessTransaction to use getPreValidatedSignatures method

* Fix default export of ApproveTxModal

* Rename estimateExecTransactionGas to estimateGasForTransactionCreation
Remove estimateTransactionGas from gas.ts

* form, accordion, validations

* Make estimateGasForTransactionCreation throw error instead of 0 gas

* Adds estimateGasForTransactionExecution and estimateGasForTransactionApproval to gas.ts

* Move estimateTransactionGas to useEstimateTransactionGas
Refactors useEstimateTransactionGas to return isCreation and isOffChainSignature

* Add in contractInteraction

* review custom TX

* review collectible

* Type and refactor generateSignaturesFromTxConfirmations
Moves getPreValidatedSignatures to safeTxSigner.ts

* Uses confirmations to estimateGasForTransactionExecution

* Adds TransactionFeesText component
Uses TransactionFeesText on ApproveTxModal

* Update text

* Update text

* Remove unnecessary condition

* Pass more parameters to estimateGasForTransactionExecution

* Removes unnecessary parameter in getNewTxNonce

* Moves checkIfOffChainSignatureIsPossible to safeTxSigner.ts

* rename AdvancedOptions and add parameters in add owner

* replace owner - remove owner

* Fix check for null confirmations

* Uses checkIfOffChainSignatureIsPossible on createTransaction.ts

* Policies

* Move TransactionFailText inside TransactionFees component

* spending limit

* fix textfields gap and margins

* fix margins, text size and textfields disposition

* Remove unnecessary awaits

* Update Accordion comp

* Pass safeTxGas to useEstimateTransactionGas.tsx
Improves how we use default params

* Fix gas iteration on estimateGasForTransactionExecution

* Fix estimateGasForTransactionExecution calculation

* Fix generateSignaturesFromTxConfirmations calculation

* Remove unnecessary Promise and await

* Fix estimateGasForTransactionExecution for preApproving owner case

* Improve logging

* Remove log

* Fix typo

* merge fixes

* Uses operation in useEstimateTransactionGas

* Uses operation in useEstimateTransactionGas

* add txParameters in ApproveTx

* useEstimateTransactionGas add gasPriceFormatted

* reviewSendFundsTx gasFormatted

* add gasLimit to useEstimateTransactionGas

* Files movement - EditParameters refactor

* tx parameters in creation

* set correct gasPrice

* createTx from contractInteraction

* Fix gas estimation for transaction creation

* disable button while calculating gas

* Add owner - reactor and creation options

* Add owner: remove unused code

* Threshold settings

* fix modal ui bug (tx)

* fix modal ui bug (settings)

* fix modal ui bug (Settings: Policies )

* fix ui bug modal (Spending Limit)

* (Fix) - Calculates gas for SpendingLimit transactions (#1773)

* Bug: Use link tag instead of javascript navigation in apps list (#1770)

* Use list instead of programmable navigation

* add declaration for styled-components theme

* (Fix) - Calculates gas for SpendingLimit transactions (#1773)

* Calculates gas for spendingLimit transactions

* Adds TransactionFees component inside UpdateSafeModal

* Fix send collectible gas calculation

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* speding limits

* Remove default exports for spendingLimits

* Fix warning in TxParametersDetail

* Extracts calculateSpendingLimitsTxData logic and add types

* Remove txParameters from setSpendingLimitMultiSendTx/spendingLimitMultiSendTx
Adds log for transaction creation success

* Refactor handleSubmit, now uses calculateSpendingLimitsTxData to calculate the spendingLimit transaction data before submitting
Also calculateSpendingLimitsTxData is used to estimate the amount of gas that the transaction will cost

* disable parameters when needed

* fix parametersStatus condition

* Some fixes

* more fixes

* send directly when tx nonce == safeNonce

* fix tests

* parameters in replace owner and remove owner

* Fix gas estimation issues for Metamask

* FIx Edit transaction parameters src route

* Remove default exports RemoveModuleModal

* Adds advanced parameters in RemoveModuleModal

* Fix css styling of UpdateSafeModal

* Adds EditableTxParameters within UpdateSafeModal

* Fix warning in <Accordion> for compact parameter

* Add advanced settings for RemoveLimitModal.tsx

* Fix txNonce usage in RemoveModuleModal.tsx

* Remove logs

* Fix txNonce param in RemoveLimitModal.tsx

* Remove TODOS for refactoring default case of getParametersStatus in EditableTxParameters

* Add advanced parameters to Safe apps modal

* Force gasPrice and safeTxGas 0 for cancelling transaction

* Invert validation of safeTxGas > ethGasLimit, safeTxGas should be < than ethGasLimit

* Add missing validation for approveTxModal submit button

* Fix checkIfTxIsApproveAndExecution  method
Add tests

* Remove duplication of gas value for calculateGasOf

* Fix gas estimation for execution & approval

* Adds EXTRA_NODE_GAS for the gasLimit calculation

* Revert duplicate of web3.eth.estimateGas

* Revert fix of execution & approval

* Adds closeEditModalCallback in EditableTxParameters

* Accept manual gas price in useEstimateTransactionGas.tsx

* Use manualPrice in sendFunds gas estimation

* Add safeTxGas estimation to Editable TX Parameters

* Set safeTx gasPrice to 0 on tx creation

* Refactor useTransactionParameters with initialValues support

* Refactor EditableTxParameters.tsx, fixs changing gasLimit or gasPrice

* Fix safeTxGas

* Add naming to minimum gas required for a transaction

* Remove log

* Fix nonce calculation for cancel transaction

* Update gas estimation to be more precise and avoid reverts

* Check that only the creator of the transaction or the executor could modify the advanced parameters

* Add validation to submit buttons on modals when the gas estimation is loading

* Fix advanced parameters display in change threshold

* Fix wrong commit

Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2021-01-29 21:21:42 +01:00
Mikhail Mikheev 3415b73ef0
Update WalletConnect app url (#1822)
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-29 17:24:00 +01:00
Daniel Sanchez 012b41a3f7
Feature - Add .crypto domain resolution (#1764)
* (Feature) - Support for .crypto resolution

* Fix EthereumAddress validator error msg

* Extract unstoppable domains logic to an util

* Add singleton to UnstoppableDomains instance

* Shorten address or domain validation error message

Co-authored-by: sudoryan <rleinbox@gmail.com>
2021-01-29 13:07:47 +01:00
Daniel Sanchez 6b4b156daf
Update balancer exchange app (#1823) 2021-01-28 15:22:48 +01:00
Agustin Pane 758fc3c0c0
(Fix) Estimate gas for wallet connect (#1806)
* Guard for empty result

* Type TextField

* Fix warning of InputAdornment in SendFunds modal

* Re-enable gas estimation for wallet connect

* Replace web3.call on parseRequiredTxGasResponse with axios post to infura

* Adds estimateGasWithInfura and estimateGasWithWeb3Provider for changing the estimation method if we are in a non-infura-supported network

* Revert calculateMinimumGasForTransaction change to leave the change for the already-open pr

* Renames estimateGasWithInfura with estimateGasWithRPCCall
Replaces web3 with web3ReadOnly in estimateGasWithRPCCall

Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-28 09:12:02 +01:00
Agustin Pane 3d43db039b
(Fix) Contract interaction tuples (#1787)
* Adds isTupleParameter validation to the extractMethodArgs

* Improves tuples parsing

* Show examples for txs inputs

* Remove MethodsInputExamples

Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
2021-01-27 23:44:02 +01:00
Daniel Sanchez e3adb24825
Update balancer pool management app with new keys (#1819) 2021-01-27 20:19:32 +01:00
Daniel Sanchez 621401bc82
Add dHedge safe app (#1821)
* Add dHedge safe app

* Disable volta build for all PRs and leave only for release branch and master
2021-01-27 19:15:17 +01:00
Mikhail Mikheev d6343a9bb1
Feature: Single tx safe apps interactions should not use multisend (#1792)
* Don't use multisend if txs.length = 1

* calc txData inside useMemo

* fix sending txs from apps, use correct operation/recipient

Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-27 17:35:14 +01:00
Daniel Sanchez 57f7acd26e
Update IDLE Safe app (#1813) 2021-01-27 16:30:39 +01:00
Daniel Sanchez fef88b0bb9
Update 1 Inch app to v1.2.3 (#1816) 2021-01-27 15:30:29 +01:00
Agustin Pane a020e8e0dc
(Fix) - Gas estimation for transaction creation (#1772)
* Fix gas estimation for transaction creation

* Adds missing logs

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-26 18:06:39 -03:00
Agustin Pane 19be231d53
(Fix) - #1804 Tx gas estimation fail for threshold >= 3 (#1808)
* Fix checkIfTxIsExecution method implementation

* Add tests for checkIfTxIsExecution/checkIfTxIsCreation/checkIfTxIsApproveAndExecution/

* Minimice number of ifs with same result

Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-26 19:29:28 +01:00
Mati Dastugue c7c9facfcc Merge branch 'development' of github.com:gnosis/safe-react into development 2021-01-26 13:21:56 -03:00
Daniel Sanchez 5e5736827f
Merge pull request #1807 from gnosis/hotfix/refund-displayed-as-rejection
Mergeback hotfix v2.18.1 to development
2021-01-25 16:43:58 +01:00
Daniel Sanchez 3748245a79
Merge branch 'development' into hotfix/refund-displayed-as-rejection 2021-01-22 19:49:50 +01:00
Daniel Sanchez 173054a1b6
Merge pull request #1805 from gnosis/hotix/refund-displayed-as-rejection-desktop-app
Add commit for desktop app v2.17.2
2021-01-22 19:47:38 +01:00
Daniel Sanchez a84577cebb Merge branch 'master' into hotix/refund-displayed-as-rejection-desktop-app 2021-01-22 12:57:28 +01:00
Daniel Sanchez 5bfc4bb15b
Merge pull request #1803 from gnosis/hotfix/refund-displayed-as-rejection
(Hotfix) Refund displayed as transaction rejection
2021-01-22 10:00:08 +01:00
Daniel Sanchez 93f5e8134e Set v2.18.1 2021-01-22 09:04:21 +01:00
Daniel Sanchez f47bc7f175 Set v2.17.2 2021-01-22 09:03:01 +01:00
Agustin Pane a604da1b6c Fix prettier 2021-01-22 08:59:06 +01:00
Agustin Pane b6577f8e6f Updates isCancelTransaction logic and tests 2021-01-22 08:59:06 +01:00
Agustin Pane 67af60ef71 Adds isEmptyAddress method 2021-01-22 08:59:06 +01:00
Agustin Pane 75f1f8829f Fix prettier 2021-01-21 17:46:32 -03:00
Agustin Pane c0d86c42ae Updates isCancelTransaction logic and tests 2021-01-21 15:26:44 -03:00
Agustin Pane 8b1809d8eb Adds isEmptyAddress method 2021-01-21 15:26:25 -03:00
Daniel Sanchez 87470956fc
Merge pull request #1796 from gnosis/release/v2.18.0
Backmerge release v2.18.0 to development
2021-01-19 21:52:30 +01:00
Daniel Sanchez d36e447120
Merge branch 'development' into release/v2.18.0 2021-01-19 19:10:44 +01:00
francovenica 46274b00ec
fix ids (#1755)
add data-testid for sidebar

add id for recipient field

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2021-01-19 15:08:51 -03:00
Daniel Sanchez dfc650dd06
Merge branch 'development' into release/v2.18.0 2021-01-19 19:04:28 +01:00
Daniel Sanchez 38c5bdf757
Merge pull request #1794 from gnosis/release/v2.17.1
Release v2.17.1
2021-01-19 19:02:22 +01:00
Daniel Sanchez c0441e97fa Merge branch 'master' into release/v2.17.1 2021-01-19 16:14:55 +01:00
Daniel Sanchez e65849691e Update client signature 2021-01-19 13:17:15 +01:00
Daniel Sanchez 42d438fb53
Merge pull request #1771 from gnosis/release/v2.18.0
Release v2.18.0
2021-01-19 10:06:36 +01:00
Daniel Sanchez d6d820ca3b Update packed files for desktop app 2021-01-19 09:40:30 +01:00
Daniel Sanchez 0e1efc6f8f Set v2.18.0 2021-01-19 09:13:57 +01:00
Agustin Pane f79f37709f
(Feature) Disable gas estimation for WalletConnect (#1790)
* Make calculateGasOf receive object param

* Disable estimation of gas feature for walletConnect

* Add FIXME to walletConnect estimation check

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-18 15:43:05 -03:00
Agustin Pane 0d0acacd04
Adds TransactionFees modal to confirm safe app tx modal (#1789) 2021-01-18 15:25:28 -03:00
Agustin Pane ce43a97bee
(Fix) - #1783 Trezor gas estimation fail (#1788)
* Improves the way we parse the error message on getDataFromNodeErrorMessage for supporting trezor response

* Fix trezor execution not working properly

* Add parameter to processTransaction in ApproveTxModal

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2021-01-18 18:04:04 +01:00
Daniel Sanchez 4aa5955b08 Set v2.17.1 2021-01-18 12:07:34 +01:00
Daniel Sanchez 4a10ed045f Build desktop app using latest ubuntu runner 2021-01-18 11:14:29 +01:00
Daniel Sanchez 54ed65ca4e Disable devtools 2021-01-18 10:20:04 +01:00
Daniel Sanchez 6daaf0cb6d Enable dev tools to test electron build 2021-01-16 00:13:17 +01:00
Daniel Sanchez 2264b1cb7e Remove unused blocknative keys
Remove unused build file
2021-01-16 00:12:36 +01:00
Daniel Sanchez b7f1036a60 Disable yarn cache for electron build 2021-01-15 22:47:07 +01:00
Daniel Sanchez 6cc780c994 Upgrade build action to use node 14 2021-01-15 20:17:13 +01:00
Agustín Longoni 0fb1824f49 Fix asset value column alignment (#1778) 2021-01-15 20:12:14 +01:00
Agustín Longoni 188dc80912
Fix asset value column alignment (#1778) 2021-01-15 20:06:05 +01:00
Daniel Sanchez cdbe4dfc57 Cleanup erc20 amount calcs 2021-01-15 17:33:35 +01:00