2325 Commits

Author SHA1 Message Date
Mati Dastugue
8946ebcf32 Merge branch 'development' of github.com:gnosis/safe-react into fix/modal-close 2020-12-18 10:36:02 -03:00
Mati Dastugue
62232e6dc2 Prevent modal from closing on its own 2020-12-18 10:34:57 -03:00
Daniel Sanchez
f143721c06
Fix typo in ADD_OR_UPDATE_SAFE reducer (#1735) 2020-12-16 18:32:13 -03:00
Agustin Pane
7c19205e01
(Feature) - Expanded decoded data collapses automatically (#1731)
* Adds shouldSafeBeUpdated to avoid updating unnecessary the safe

* Fix css typing

* Moves equalArrays to utils function
Improves how updateSafe is dispatched within checkAndUpdateSafe to avoid unnecessary re renders

* Revert some default cases fixes

* Adds equalArrays tests

* Add test to arrays.test.ts

* Improves shouldSafeStoreBeUpdated order and renames it

* Adds shouldSafeStoreBeUpdated.test.ts

* Uses shouldSafeStoreBeUpdated within safe reducer

* Replaces equalArrays with isEqual from lodash

* Simplify shouldSafeStoreBeUpdated using isEqual from lodash

* Remove lodash to compare Immutable objects correctly

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-15 22:23:12 +01:00
Mati Dastugue
0814eb528e Merge branch 'development' of github.com:gnosis/safe-react into development 2020-12-14 14:53:54 -03:00
Mati Dastugue
71375f9d64 Fix wrong status on txs 2020-12-14 14:53:34 -03:00
Daniel Sanchez
cca6854320 Update tx-builder and Aave app hashes 2020-12-14 16:06:36 +01:00
nicolas
89c7482344
Show ETH value input for payable methods (fix for solidity v0.6x) (#1717) 2020-12-14 11:01:03 +01:00
Agustin Pane
0f592111e9
(Feature) Safe owners not loaded (#1710)
* Makes getGasEstimationTxResponse exportable

* Removes the race condition between useLoadSafe and useSafeScheduledUpdates

* Reword safeLoaded

* Improve check for setIsSafeLoaded
2020-12-12 14:39:50 +01:00
Agustín Longoni
1bb3ebce63
Welcome Screen (#1655)
* add cards and styles on texts

* add styles and content

* align card content

* fix text about Safe Multisig

* add new components from SRC

* update SRC

* changes to welcome page

* fix margins

* update SRC

* fix icon size

* update SRC hash

* Dot: replace number by check when wallet is connected

* fix card  width

* add url to help to connect wallet.

* remove underline on button as a link (Load Safe).

* Fix buttons

* disable connect wallet button when there is a connected wallet

* fix padding in New Transaction button

Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-11 22:47:07 +01:00
nicolas
c9a06ec1c2
Handle console erros and warnings (#1709)
* Remove Warning: React.createFactory() is deprecated

* make TS recognize Window definition by adding an empty export

* Silent MM warning  ethereum.autoRefreshOnNetworkChange

* remove warning when requesting data from contract with null address.
2020-12-11 19:38:16 +01:00
Mikhail Mikheev
94175a6970
Feature #1593: Support promise-based api of Safe Apps SDK (#1594)
* use multiple versions of safe apps sdk

* use multiple versions of safe apps sdk

* Type fixes

* wip error for multiple versions

* fix multiple sdk versions

* app communicator wip

* communicator wip

* getEnvInfo handler

* update sdk

* app communicator wip

* sdk dep bump

* promisified getSafeInfo

* sendTransactions handler wip

* don't send a response if a handler doesnt return anything

* add handler for transaction sending

* wip rpc call handler

* rpc handler

* rpc handler fix

* V2 Communicator

* remove tsbuildinfo

* fix communicator

* fix error handling for rpc requests

* rpc call fixes

* Update sdk

* Adapting app to use formatters wip

* use messafe formatter from sdk

* Sdk update

* update safe apps sdk version, remove ethBalance from response for safe apps sdk v1

* bump sdk to beta version

* update yarn.lock

* update yarn.lock

* update yarn.lock

* use beta version of the sdk

* enhance validation check

* update dependecies

* Update to python3 dependencies

* Revert "Update to python3 dependencies"

This reverts commit 1332940c77cb649b53ec3e1adfdca10b88e24a87.

* fix transaction params type import

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-11 12:31:55 +04:00
Fernando
71f1ea7ad1
(Fix) Duplicated address validation (#1699)
* use createStyles/makeStyles

* simplify `addressBookQueryParamsSelector`

* avoid using `createSelector`

as memoization in this scenario is not working as expected and list is not refreshed

* refactor `uniqueAddress` curried function and strategy to validate

- `selectedEntry` being `null` made the code harder to follow

* fix `uniqueAddress` validator tests

* use arrow function
2020-12-10 16:07:38 +01:00
Fernando
4079ff9abe
add missing parameters to TransferDescription (#1686) 2020-12-10 00:25:20 +01:00
nicolas
2fe1fb2794
Remove safe address tracking for GA (#1683)
* reactGA bump

* remove address from GA

* remove unneeded option

* Disable travis cache

* Set travis to use latest linux build image

* Update to use python3 dependencies

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-09 20:45:06 +01:00
Agustin Pane
9175552488
(Feature) - #1656 Tx is sent to backend even if not signed (#1672)
* Fix black notification

* Fix executing tx even if the user rejected it

* Fix hidden metamask error code

* Fix proccessTransaction notifications and metamask sign reject handling
2020-12-09 18:02:09 +01:00
Fernando
f161875902
(Fix) Duplicated Owner Addresses on Safe Creation (#1666)
* add form level validation for OwnersForm

- also fixed `calculateValuesAfterRemoving` function that removed an owner's row by clicking on the trash icon

* add tests for `calculateValuesAfterRemoving` function

* reformat with prettier
2020-12-09 12:55:55 +01:00
Daniel Sanchez
258790dcca
Backmerge hotfix v2.16.2 (#1702) 2020-12-04 19:28:46 -03:00
Daniel Sanchez
9a9bb3c775
Upgrade dependencies (#1691)
* Upgrade dependencies without breaking changes

* Upgrade react-scripts to v4

* Use import instead of require in icons

* Update styles dependencies

* Remove react-app-rewired as is deprecated and not needed anymore

* Update prettier and testing-library/react dependencies

* Upgrade @ledger for desktop app

* Fix types in fetchSafeTokens test

* Use rescripts to remove ESLint plugin from react-scripts webpack

* Disable travis cache

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-12-04 18:38:49 +01:00
Agustin Pane
c0a8d24828
(Fix) - Shows a timeout message on app timeout (#1654)
* Shows a timeout message on api timeout

* Improves loading text

* Improves clear timeout

* Fix typo

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-12-03 08:56:34 -03:00
Daniel Sanchez
265f43e72e Disable Ledger and Trezor in Volta network 2020-11-30 19:47:08 +01:00
Daniel Sanchez
d5abbd7aae Update WalletConnect app to show correct logo 2020-11-30 19:28:10 +01:00
Fernando
76ef99fa96
(Fix) Native Coin transfer not shown (#1670)
* allow to display native coin transfers in the expanded view

* fix issue with fragment being passed to material-ui menu
2020-11-30 17:10:42 +01:00
Daniel Sanchez
8d73ebd177 Lower sentry sample rate to avoid threshold overflow 2020-11-30 15:15:27 +01:00
nicosampler
5f15090df5 update safe-apps legend 2020-11-27 11:04:55 -03:00
Daniel Sanchez
7273da91fe Add Sablier, WalletConnect and TX-Builder latest versions 2020-11-27 12:22:59 +01:00
nicolas
ba680f7158
SafeApps new layout (#1600)
* speed-up load time  for safe-apps

* show loading status until all the apps are loaded

* Add App route

* Add cards for each safe-app

* move logic to AppFrame

* add basic skeleton styles

* css fixes

* fix image sizes

* add transition animation to skeleton

* remove duplicated code

* Modals

* refactor skeleton

* refactor layout using flexbox

* make content clickable in cards

* cards container as css-grid

* remove fixed width for cards

* replace auto by 1fr

* remove margin for cards

* add card component and remove some css

* rename buttons

* add margin to app list

* refactor useAppList

* fix disclaimer always flashing

* fix pointer cursor for Add app icon

* add styled component keyframe

* update safe-react-components

* fix margin and card height, icon size

* fix margin in iconImg and app name

* fix margins on apps container (breadcrumb area)

* remove style comment

* fix margin on HelpCenter
/ remove overflow in sidebar

* Improve featuresEnabled for sidebar and apps page.

Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-26 18:40:29 +01:00
nicolas
0ecd70fdbc
Support Circles Safes in frontend on xDai (#1636)
* fix web3 issue

* update settings

* get masterCopy Address from backend

* fix prettier errors

* Fix Circles typo

* Change Circles detect logic

* Use sameAddress to compare mastercopy addresses

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-26 18:00:19 +01:00
Mati Dastugue
e3a8b9fe2a
Remove dappId from OnboardJS connection (#1627)
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-11-26 12:31:56 -03:00
Fernando
fc1250d528
(Feature) Spending Limit (#1637)
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-25 15:59:17 -03:00
Fernando
dca9f19fd0
(Fix) remove module feature (#1646) 2020-11-25 15:35:09 -03:00
Agustin Pane
6ed1e2ea18
(Fix) Geth nodes gas estimation errors (#1635)
* Replaces getNonGETHErrorDataResult with getDataFromNodeErrorMessage
Updates the extraction of data from the error message to include new GETH nodes version

* Add tests for new GETH nodes
2020-11-20 17:56:29 +01:00
Agustin Pane
592999da3f
Uses addressbook names in the review remove owner (#1631) 2020-11-19 16:40:49 +01:00
Agustin Pane
e482d3259b
(Fix) - #1605 QR Input address fix (#1612)
* Add types

* Fix missing address in input field

* Fix reopening file upload modal once closed

* Error first callback onFileUploadHandlerClose

* Adds error text for qrs that can't be read
Fixes popping up again for wrong qr codes

* Fix opening modal

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-11-19 12:22:48 -03:00
Agustin Pane
486bb4b203
(Feature) - Replaces createProxy with createProxyWithNonce method no safe creation (#1630)
* Replaces createProxy with createProxyWithNonce method no safe creation

* Updates estimationGas method

* Moves safeCreationSalt as a parameter

* Fix default export

Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
2020-11-19 09:19:31 -03:00
Agustin Pane
8876469166
(Fix) - Adds operation call check on isTokenTransfer (#1613)
* Adds operation call check on isTokenTransfer

* Add comment in unclear if

Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-18 15:11:20 -03:00
Agustin Pane
3f6a8ee3f8
(Feature) - EWC/Volta ENS support on web3 patch (#1596)
* Adds patch-package and postinstall

* Creates a patch to add EWC and Volta in web3-eth and web3-eth-ens

* Adds support for ewc in isValidEnsName

* Update web3 ewc patch

* Enables ens lookup for ewc and volta

* Fix eslint

* Update patch
Fix patch-package script in package.json

Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-18 14:42:00 -03:00
Daniel Sanchez
37877d7fba
Merge branch 'development' into release/v2.15.0 2020-11-18 15:51:24 +01:00
Agustin Pane
0913f2539f
Update legal text (#1624) 2020-11-18 11:23:09 -03:00
nicolas
1d3d61d812
Merge branch 'development' into release/v2.15.0 2020-11-18 10:08:53 -03:00
nicolas
996d339982
Layout refactor (#1604)
* refactor layout using flexfox

* comments

* fix sidebar css

* remove overflow y

Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
2020-11-17 15:47:17 -03:00
Agustin Pane
38751958bb
(Fix) - #1154 Add more owners on safe creation (#1583)
* Add types in getAddressValidator
Remove unused props

* Absolute import

* Adds safeOwnersAddressesSelector

* Fix uniqueAddress function

* Replaces getAddressesListFromAddressBook with addressBookAddressesListSelector

* Remove comment

* Types

* Fix tests

* Improves safeOwnersAddressesSelector

* Remove memoize from uniqueAddress

* Improves uniqueAddress validation

* Improves uniqueAddress function to check checksum values
Add tests

* Removes toArray from safeOwnersAddressesSelector
Allows uniqueAddress to use both string[] and List<string>

* Renames safeOwnersAddressesSelector to safeOwnersAddressesListSelector

* Update src/components/forms/validator.ts

Improves uniqueAddress

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* Fix tests

* Fix uniqueAddress

* Fix types extensions

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-11-17 09:34:01 -03:00
Agustin Pane
9f1dc37bbb
(Fix) #1587 - Ens mislabeled as eth (#1601)
* Fix fetch symbol for incoming txs

* Fix getting symbol promise from erc721

* Adda ens contract addresses for different networks
2020-11-16 11:20:07 -03:00
Daniel Sanchez
033de25cf5 Set production Sablier and WalletConnect IPFS hash 2020-11-16 12:45:35 +01:00
Fernando
da1e39c2ef
(Fix) Remove the provider when the site is disconnected (#1585) 2020-11-12 11:40:28 -03:00
Fernando
914333dc54
(Fix) Support CryptoKitties NFTs (#1574)
* create `logic/collectibles/utils` file and move all the
 NFT-related helper functions into it

`generateERC721TransferTxData` will decide whether the method
 to transfer an NFT will be `transfer` or `safeTransferFrom`,
 based on preset conditions where CryptoKitties tokens is taken
 as an exception.

Also, `transfer` was used instead of `transferFrom`
 because `transferFrom` is not implemented in the
 rinkeby version, and was the method used as a
 fallback before.

- moved `SAFE_TRANSFER_FROM_WITHOUT_DATA_HASH` const
- moved `isSendERC721Transaction` function
- moved `getERC721Symbol` function
- moved `isERC721Contract` function
- created `getTransferMethodByContractAddress` along with `CK_ADDRESS` const
- created `generateERC721TransferTxData` function
- refactored `ReviewCollectible` component to use `generateERC721TransferTxData`
- updated tests

* remove `ENS_ADDRESS` constant as it's not used

* add unmock of collectibles/utils

* add tests for `getTransferMethodByContractAddress`
2020-11-11 18:31:54 -03:00
Agustin Pane
294ba47142
(Feature) - #1244 send tx again (#1582)
* Types

* Adds tokenAddress to getTxData for tokenTransfer transactions

* Adds sendModalOpenHandler to EllipsisTransactionDetails

* Adds getRawTxAmount util

* Add isTokenTransfer fix for ether in getTxData

* Uses sendFund modal for retry outgoing transfer transactions

* Adds ether address in getTxData result for outgoig transfers

* Uses nativeCoin

* Remove fragmnet

* Fix decimals for native coin

* Fix decimals usage in tx transfer amount

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-11-11 14:20:10 -03:00
Mati Dastugue
19e6df725a
Add tracking info to Google analytics (#1584)
Add extra information to Google Analytics (#1510 )
2020-11-11 15:44:14 +01:00
Agustin Pane
ca732001bf
(Fix) - #1561 Outgoing instead of custom tx for sending collectibles (#1567)
* Refactor getTxData

* Add SAFE_TRANSFER_FROM in SAFE_METHODS_NAMES

* Adds check on isSendERC721Transaction for erc721 send

* Adds TOKEN_TRANSFER_METHODS_NAMES types

* Replace type SAFE_TRANSFER_FROM

* Fix import

* Adds nftAssetsListAddressSelector

* Remove txCode and knownTokens from isSendERC721Transaction
Now it directly checks agains the list of nftAssets on the store

* Refactor ENS_TOKEN_CONTRACT usage check

* Add TODO

* Add return for ENS symbol

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-11-10 17:09:41 -03:00
Fernando
325864cffb
(Fix) Prevent ENS check when not supported (#1570) 2020-11-10 16:16:44 -03:00