2369 Commits

Author SHA1 Message Date
Mikhail Mikheev
168dcc9f6d Fix offchain signing 2020-08-12 15:04:12 +04:00
Mikhail Mikheev
70a1c523d4 add overflow hidden to iframe container in safe apps 2020-08-12 15:04:12 +04:00
Mati Dastugue
4666272cdd Merge with dev 2020-08-11 13:35:53 -03:00
Daniel Sanchez
425a38b2d9
Merge branch 'development' into issue-1144 2020-08-11 17:26:10 +02:00
nicosampler
c42ce0f261 Add Balancer Pool and Exchange Apps. 2020-08-11 12:09:27 -03:00
Mikhail Mikheev
41059c1e8e fix crash when opening a mocked transaction 2020-08-11 14:59:28 +04:00
Mikhail Mikheev
94de33aa5d Fix offchain signing 2020-08-11 13:12:24 +04:00
Mikhail Mikheev
a84c8765c0 add overflow hidden to iframe container in safe apps 2020-08-10 14:25:53 +04:00
Daniel Sanchez
91d3aa8592
Bug/safe crash when accessing from link (#1209)
* use updateSafeAction for adding modules

* Fix address parameter naming issue

Add comment to ADD_SAFE_MODULE behaviour

* fetchSafe batch everything to updateSafe

* remove addSafeModules action

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-07 18:49:29 +04:00
nicosampler
c6b0d6a783 remove forced error 2020-08-07 09:12:07 -03:00
nicosampler
fcb601fd79 force an error 2020-08-07 09:11:35 -03:00
nicosampler
8462759e13 Merge branch 'development' into issue-1144 2020-08-07 09:01:06 -03:00
Agustin Pane
64e4b6b45a
(Feature) - 1068 Don't show unknown when unknown (#1212)
* Components types

* Remove UNKNOWN in OwnerAddressTableCell

* Remove UNKNOWN in OwnerComponent

* Move imports

* Fix import

* Fix types

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-07 15:26:26 +04:00
nicosampler
e39e9bbc31 tsc fixes 2020-08-07 08:21:54 -03:00
nicosampler
b119f3e88f Merge branch 'development' into issue-1144 2020-08-06 19:28:03 -03:00
nicolas
22d12a37fa
Fix broken unit tests (#1216)
* Fix broken unittests

* fix TS errors

* remove unused mock

* remove getTransactinoServiceMock function

* fix types in tests

* fix safe reducer types

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-07 00:58:05 +04:00
Fernando
f8b9851020
(Feature) Add "Action" details in transaction list (#1134)
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-06 12:18:46 -03:00
nicosampler
18dd6b7e97 Merge branch 'development' into issue-1144 2020-08-06 08:22:19 -03:00
Mikhail Mikheev
b6bb5ffde1
Tech Debt: Safe Apps Refactor (#1110)
* apps refactoring wip

* apps refactoring wip

* type fixes

* add useLegalConsent hook in apps

* useAppList hook wip

* dep nump

* useAppList hook wip

* fix selecting first app

* Remove console.log

* dep bump

* update persisting app logic

* update saveToStorage type

* fix crash on apps tab

* reuse selectedApp variable in hook

* remove initialAppSelected
2020-08-06 11:33:58 +04:00
Mati Dastugue
a0baca4d1f Add styles for full output 2020-08-05 18:35:33 -03:00
Fernando
a0ed0a1f31
(Feature) Decode multiSend tx details (#1106)
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-04 15:32:09 -03:00
nicosampler
a21de8be18 Replace AddressInfo by EthHashInfo 2020-08-04 15:29:29 -03:00
Mikhail Mikheev
ece2bc6a8c
Fix safe loading (#1203) 2020-08-04 19:53:30 +04:00
nicosampler
7f3a99b7f1 Merge remote-tracking branch 'origin/development' into issue-1144 2020-08-03 13:36:36 -03:00
nicosampler
24fe633e1a Styles 2020-08-03 13:31:43 -03:00
nicosampler
bc5c30ec85 fix makeTransaction 2020-08-03 13:02:48 -03:00
nicosampler
7373c4afac ExpandedTx 2020-08-03 13:01:47 -03:00
nicosampler
877cf5ea4b ExpandedTx - creation 2020-08-03 12:38:02 -03:00
nicosampler
1bd028b97a SafeList types 2020-08-03 12:35:40 -03:00
nicosampler
7b2d7fd35d remove unused classes 2020-08-03 11:03:39 -03:00
Daniel Sanchez
f374315a5a
Avoid constant creation of new web3 object (#1171)
* Avoid constant creation of new web3 object

* rollback web3 version, small type fixes in ConnectButton

* Use web3 instance in getProviderInfo

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-03 11:29:17 +02:00
Mikhail Mikheev
86cbd94b0c
Tech debt: Add types for contracts (#1118)
* typechain wip

* add types for multisend

* type definitions improvements

* type safe contract in estimateTxGasCosts

* contract type definitions wip

* SafeInstance truffle -> web3 migration

* fix calls for version

* transactions/send enhancements

* fix safe recor owner type

* Stepper type definitions wip

* dep bump

* stepper types wip

* refactoring stepper component to fix bug in load safe form

* stepper types wip, addressbook reducer types wip

* finally make it work

* Fix ownerlist component hook in load safe

* dep bump

* dep bump

* rollback types/history

* add types for gas calc

* debugging...

* fix using RO web3 for sending txs

* update package.json generate-types command

* add ts-ignore for stepperpage

* db

* dep bump

* as unknown as AbiItem -> as AbiItem[]

* use optional chaining for isExecution in gas esimations

* abiITem -> AbiItem[]

* fix safeVersion utils tests

* fix imports, put upgradeSafe test close to the actual code

* add comment about ts-ignore usage

* downgrade web3 version
2020-08-01 02:26:10 +04:00
Mikhail Mikheev
24dffd53da
Set inclusive false for minValue validator in sendfunds form (#1193) 2020-08-01 01:15:56 +04:00
nicosampler
df8e3f49df review fixes 2020-07-31 15:21:17 -03:00
nicolas
81c14133ac
Update MultiSend contract address. (#1186)
* Update Multisend Address

* Update Apps loaders not centered

* remove empty spaces

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-31 14:27:22 +04:00
nicosampler
e31ef44d76 run prettier for files faining in CI 2020-07-30 15:32:03 -03:00
nicosampler
b84db710e8 Merge branch 'development' into issue-1144 2020-07-30 12:08:00 -03:00
nicolas
251da319a5
Fix: debounce fetch apps (#1021)
* Fix: debounce fetch apps

* refactor: fix AddAppForm name and add missing types

* add `use-lodash-debounce` hook to test debounce functionality

I'm planning to remove this dependency, as it requires to also install `lodash.debounce`. I prefer to implement it ad-hoc.

* refactor AddAppForm to use the observable pattern

* memoize `getAppInfoFromUrl` to prevent requesting the same information over and over

* prevent requesting data if url is not valid

* remove logging

* prevent validating form before visiting the fields

* refactor AddAppForm

reorganize code

* fix: change `any` to `unknown`

* fix: `uitls.ts` types and imports

* refactor: rename `isSubmitDisabled` to `onSubmitButtonStatusChange` prop

* refactor: rename `agreement` to `agreementAccepted`

also, moved `initialValues` to a constant `INITIAL_VALUES` outside the component

* refactor: reimplement `useDebounce` hook in-app

* refactor: extract app manifest verification to a helper function

also fixed types

* fix: prevent accessing `contentWindow` if `iframe` is `null`

* fix: `getAppInfoFromOrigin` return type

also, removed the expected type for the `getAppInfoFromOrigin` calls as it is inferred

Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-30 18:28:30 +04:00
nicosampler
5cc29d518d Add network 2020-07-29 16:33:04 -03:00
nicosampler
a295747cb6 Wallet details 2020-07-29 16:16:29 -03:00
nicosampler
184c1cb08e Transaction List 2020-07-29 15:28:14 -03:00
nicosampler
8bc7d3efcc Connected wallet 2020-07-29 14:40:51 -03:00
Daniel Sanchez
89c17180de
Trim spaces from AddressInput (#1142)
* Remove spaces

* Change naming convention to make clear that only edge whitespaces are removed

Fix function documentation in string util

* Add trim spaces from address input in AddToken and AddAsset

* Use validator type

* Trim spaces on Safe App links

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-29 17:28:43 +04:00
nicosampler
3a04b077b2 Safes list 2020-07-28 19:23:42 -03:00
nicosampler
617863fb54 fix TS error 2020-07-28 19:09:29 -03:00
Agustin Pane
bbfa7d8166
(Feature) Balances enhancements (#1122)
* Fix ts error
Add type return on fetchCurrencyValues

* Add skeleton for loading balance value

* Fix texts in uppercase

* Adds ETH Icon in currencyValues dropdown

* Adds getExchangeRatesUrlFallback
Adds support for ETH as currency

* Alphabetically sort currencies

* Add types

* Type formatAmount

* Adds formatAmountInUsFormat util function

* Add types
Uses formatAmountInUsFormat for BALANCE_TABLE_BALANCE_ID

* Updates max and min fraction digits on formatAmountInUsFormat
Add tests

* Updates max and min fraction digits on formatAmountInUsFormat
Add tests

* Add types

* Fix currencyValues types

* Adds safeFiatBalancesTotalSelector

* Adds total balance to safe header

* Fix types

* Adds currentCurrency on header

* Adds types to getTokenPriceInCurrency

* Fix balance currency rate conversion

* Add guards for modules

* Add guards for modules

* Uses console error for api

* Remove anys

* Redefine CurrencyRateValue types into CurrencyRateValueRecord

* Redefine test texts

* Use absolute imports

* Add types to dispatch

* Add guard for no balance value

* Fix ESLINT warning

* Add types

* Fix no balance case

* Use optional chaining

* Absolute paths

* Adds return types
Uses BigNumber in safeFiatBalancesTotalSelector

* Remove number as type for formatAmountInUsFormat

* Uses createStyles to remove any types

* Improve total balances display

* Fix balances value column

* formatAmountInUsFormat feedback

* Force boolean evaluation

* Fix totalBalance heading styles

* Add types

* Add types to fetchTokenCurrenciesBalances endpoint

* Replaces coinbase dependency by backend for ETH price in USD

* Absolute paths

* Replaces RecordOf<TokenProps> with Token

* Feedback

* Trigger buid

* Types

* Fix tests order

* Renames numberFormat to usNumberFormatter

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-28 19:29:26 +04:00
Mati Dastugue
8a6b219781
Fix - Owners list error (#1127)
* Add validation for addressBooj

* Fix types

* Update default value

* Update src/logic/addressBook/utils/index.ts

Co-authored-by: Fernando <fernando.greco@gmail.com>

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-07-28 15:25:26 +04:00
Mati Dastugue
91a85ae9ea
Fix Wrong Wallet Network Label (#1163)
* Fix network label

* rename component

* use interfaceNetwork as a default parameter

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail <mmvsha73@gmail.com>
2020-07-28 11:54:19 +04:00
Mikhail Mikheev
f62bbffdd3
Tech Debt: Validator Type definitions (#1108)
* type validators

* safeSelector types

* history 5.0.0 breaking changes adaptation

* replace simpleMemoize with memoize from lodash because of typing issues

* add type definitions for history and react-router-dom

* type fixes

* yarn lock update

* fix router state

* more type improvements

* validator tests wip

* add tests for validators, remove duplicated validators

* add error messages to tests

* fix minValue error message for inclusive param

* Replace jsx.element with react.reactelement

* Fix uniqueAddress validator argument type

* remove comment in AddCustomToken validator

* use absolute import for saferecord in safe paage container
2020-07-27 14:31:13 +04:00
Agustín Longoni
93448b550a
fix modal position at top (#1160)
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-07-27 13:55:53 +04:00