* Makes getGasEstimationTxResponse exportable
* Add check for failing txs on approveTxModal
* Adds styles for reviewTx
* Adds useTxSuccessCheck hook
* Remove hook
* Adds checkIfTxWillFail function
* Uses checkIfTxWillFailAsync on reviewTx modal
* Improves approveTx modal
* Add check for failing transaction in contract interaction modal
* Add check for reviewCollectible
* Fix check on sendFunds reviewTx
* Adds styling for contractInteraction modal
* Fix gas calculation for native token transfers
* Remove logs
* Rename estimateDataGasCosts to parseRequiredTxGasResponse
Adds getPreValidatedSignatures
Refactor estimateTxGasCosts
Refactor checkIfExecTxWillFail
* Refactor checkIfExecTxWill usage
* Refactor checkIfTxWillFailAsync in ReviewTx
* Use getPreValidatedSignatures in createTransaction()
* Refactor estimateTxGasCosts
Rename estimateSafeTxGas to estimateExecTransactionGas
* Refactor ReviewTx: extract useEffects to hooks
* Remove unnecessary gas transfer amount
* Refactor estimateTxGasCosts: extract checkIfTxIsExecution and estimateTxGas
* Fix tx amount
Remove console log
* Moves useCheckIfTransactionWillFail to logic/hooks folder
* Replaces useEffect usage with useCheckIfTransactionWillFail hook
Also fix how some modals fetch the safeAddress
* Improves modal's wording
* Remove comment
* Fix error parsing the cancel transaction error message from GETH nodes
* Remove useCheckIfTransactionWillFail
Adds useEstimateTransactionGas
Renames estimateTxGas to estimateTransactionGas
Removes estimateTxGasCosts
Removes checkIfExecTxWillFail
* Replace useCheckIfTransactionWillFail from modals with useEstimateTransactionGas
* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas
* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas
* Extract isExecution calculation to useEstimateTransactionGas
* Creates TransactionFailText
* Uses TransactionFailText in the review modals
* Remove unnecessary styles
* Fix imports
* Remove css
* Fix missing style
* Remove duplicated function
* Fix modal height
* Fix wrong selector usage
* Fix missing null check on cancel tx confirmations
* Add guard for CLOSE_SNACKBAR action when tx was already dismissed
* Improves useEstimateTransactionGas in review custom tx and contract interaction review
* Fix hook dependency
* Add active screen types in send modal
* SafeInfo: replace AddressInfo by EthHashInfo
* Fix review replace/remove/add owner modals styling
* AdvancedOptions without funcionality
* change button text
* fix margins and texts
* fix close button margin
* rename ReviewTx by ReviewSendFundsTx
* safe params: partial implementation
* make use of useTransactionParameters hook
* Refactor response of useEstimateTransactionGas
* Remove safeAddress as param to the useEstimateTransactionGas
* Improves how threshold is obtained in useEstimateTransactionGas.tsx
* Rename gasCostHumanReadable to gasCostFormatted
* Add operation to useEstimateTransactionGas
* Refactor ConfirmTransactionModal to use useEstimateTransactionGas
* Refactor proccessTransaction to use getPreValidatedSignatures method
* Fix default export of ApproveTxModal
* Rename estimateExecTransactionGas to estimateGasForTransactionCreation
Remove estimateTransactionGas from gas.ts
* form, accordion, validations
* Make estimateGasForTransactionCreation throw error instead of 0 gas
* Adds estimateGasForTransactionExecution and estimateGasForTransactionApproval to gas.ts
* Move estimateTransactionGas to useEstimateTransactionGas
Refactors useEstimateTransactionGas to return isCreation and isOffChainSignature
* Add in contractInteraction
* review custom TX
* review collectible
* Type and refactor generateSignaturesFromTxConfirmations
Moves getPreValidatedSignatures to safeTxSigner.ts
* Uses confirmations to estimateGasForTransactionExecution
* Adds TransactionFeesText component
Uses TransactionFeesText on ApproveTxModal
* Update text
* Update text
* Remove unnecessary condition
* Pass more parameters to estimateGasForTransactionExecution
* Removes unnecessary parameter in getNewTxNonce
* Moves checkIfOffChainSignatureIsPossible to safeTxSigner.ts
* rename AdvancedOptions and add parameters in add owner
* replace owner - remove owner
* Fix check for null confirmations
* Uses checkIfOffChainSignatureIsPossible on createTransaction.ts
* Policies
* Move TransactionFailText inside TransactionFees component
* spending limit
* fix textfields gap and margins
* fix margins, text size and textfields disposition
* Remove unnecessary awaits
* Update Accordion comp
* Pass safeTxGas to useEstimateTransactionGas.tsx
Improves how we use default params
* Fix gas iteration on estimateGasForTransactionExecution
* Fix estimateGasForTransactionExecution calculation
* Fix generateSignaturesFromTxConfirmations calculation
* Remove unnecessary Promise and await
* Fix estimateGasForTransactionExecution for preApproving owner case
* Improve logging
* Remove log
* Fix typo
* merge fixes
* Uses operation in useEstimateTransactionGas
* Uses operation in useEstimateTransactionGas
* add txParameters in ApproveTx
* useEstimateTransactionGas add gasPriceFormatted
* reviewSendFundsTx gasFormatted
* add gasLimit to useEstimateTransactionGas
* Files movement - EditParameters refactor
* tx parameters in creation
* set correct gasPrice
* createTx from contractInteraction
* Fix gas estimation for transaction creation
* disable button while calculating gas
* Add owner - reactor and creation options
* Add owner: remove unused code
* Threshold settings
* fix modal ui bug (tx)
* fix modal ui bug (settings)
* fix modal ui bug (Settings: Policies )
* fix ui bug modal (Spending Limit)
* (Fix) - Calculates gas for SpendingLimit transactions (#1773)
* Bug: Use link tag instead of javascript navigation in apps list (#1770)
* Use list instead of programmable navigation
* add declaration for styled-components theme
* (Fix) - Calculates gas for SpendingLimit transactions (#1773)
* Calculates gas for spendingLimit transactions
* Adds TransactionFees component inside UpdateSafeModal
* Fix send collectible gas calculation
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* speding limits
* Remove default exports for spendingLimits
* Fix warning in TxParametersDetail
* Extracts calculateSpendingLimitsTxData logic and add types
* Remove txParameters from setSpendingLimitMultiSendTx/spendingLimitMultiSendTx
Adds log for transaction creation success
* Refactor handleSubmit, now uses calculateSpendingLimitsTxData to calculate the spendingLimit transaction data before submitting
Also calculateSpendingLimitsTxData is used to estimate the amount of gas that the transaction will cost
* disable parameters when needed
* fix parametersStatus condition
* Some fixes
* more fixes
* send directly when tx nonce == safeNonce
* fix tests
* parameters in replace owner and remove owner
* Fix gas estimation issues for Metamask
* FIx Edit transaction parameters src route
* Remove default exports RemoveModuleModal
* Adds advanced parameters in RemoveModuleModal
* Fix css styling of UpdateSafeModal
* Adds EditableTxParameters within UpdateSafeModal
* Fix warning in <Accordion> for compact parameter
* Add advanced settings for RemoveLimitModal.tsx
* Fix txNonce usage in RemoveModuleModal.tsx
* Remove logs
* Fix txNonce param in RemoveLimitModal.tsx
* Remove TODOS for refactoring default case of getParametersStatus in EditableTxParameters
* Add advanced parameters to Safe apps modal
* Force gasPrice and safeTxGas 0 for cancelling transaction
* Invert validation of safeTxGas > ethGasLimit, safeTxGas should be < than ethGasLimit
* Add missing validation for approveTxModal submit button
* Fix checkIfTxIsApproveAndExecution method
Add tests
* Remove duplication of gas value for calculateGasOf
* Fix gas estimation for execution & approval
* Adds EXTRA_NODE_GAS for the gasLimit calculation
* Revert duplicate of web3.eth.estimateGas
* Revert fix of execution & approval
* Adds closeEditModalCallback in EditableTxParameters
* Accept manual gas price in useEstimateTransactionGas.tsx
* Use manualPrice in sendFunds gas estimation
* Add safeTxGas estimation to Editable TX Parameters
* Set safeTx gasPrice to 0 on tx creation
* Refactor useTransactionParameters with initialValues support
* Refactor EditableTxParameters.tsx, fixs changing gasLimit or gasPrice
* Fix safeTxGas
* Add naming to minimum gas required for a transaction
* Remove log
* Fix nonce calculation for cancel transaction
* Update gas estimation to be more precise and avoid reverts
* Check that only the creator of the transaction or the executor could modify the advanced parameters
* Add validation to submit buttons on modals when the gas estimation is loading
* Fix advanced parameters display in change threshold
* Fix wrong commit
Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* Guard for empty result
* Type TextField
* Fix warning of InputAdornment in SendFunds modal
* Re-enable gas estimation for wallet connect
* Replace web3.call on parseRequiredTxGasResponse with axios post to infura
* Adds estimateGasWithInfura and estimateGasWithWeb3Provider for changing the estimation method if we are in a non-infura-supported network
* Revert calculateMinimumGasForTransaction change to leave the change for the already-open pr
* Renames estimateGasWithInfura with estimateGasWithRPCCall
Replaces web3 with web3ReadOnly in estimateGasWithRPCCall
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Fix checkIfTxIsExecution method implementation
* Add tests for checkIfTxIsExecution/checkIfTxIsCreation/checkIfTxIsApproveAndExecution/
* Minimice number of ifs with same result
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Make calculateGasOf receive object param
* Disable estimation of gas feature for walletConnect
* Add FIXME to walletConnect estimation check
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Improves the way we parse the error message on getDataFromNodeErrorMessage for supporting trezor response
* Fix trezor execution not working properly
* Add parameter to processTransaction in ApproveTxModal
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Bug: Use link tag instead of javascript navigation in apps list (#1770)
* Use list instead of programmable navigation
* add declaration for styled-components theme
* (Fix) - Calculates gas for SpendingLimit transactions (#1773)
* Calculates gas for spendingLimit transactions
* Adds TransactionFees component inside UpdateSafeModal
* Fix send collectible gas calculation
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
* Makes getGasEstimationTxResponse exportable
* Add check for failing txs on approveTxModal
* Adds styles for reviewTx
* Adds useTxSuccessCheck hook
* Adds checkIfTxWillFail function
* Uses checkIfTxWillFailAsync on reviewTx modal
* Improves approveTx modal
* Add check for failing transaction in contract interaction modal
* Add check for reviewCollectible
* Fix check on sendFunds reviewTx
* Adds styling for contractInteraction modal
* Fix gas calculation for native token transfers
* Rename estimateDataGasCosts to parseRequiredTxGasResponse
Adds getPreValidatedSignatures
Refactor estimateTxGasCosts
Refactor checkIfExecTxWillFail
* Refactor checkIfExecTxWill usage
* Refactor checkIfTxWillFailAsync in ReviewTx
* Use getPreValidatedSignatures in createTransaction()
* Refactor estimateTxGasCosts
Rename estimateSafeTxGas to estimateExecTransactionGas
* Refactor ReviewTx: extract useEffects to hooks
* Remove unnecessary gas transfer amount
* Refactor estimateTxGasCosts: extract checkIfTxIsExecution and estimateTxGas
* Fix tx amount
Remove console log
* Moves useCheckIfTransactionWillFail to logic/hooks folder
* Replaces useEffect usage with useCheckIfTransactionWillFail hook
Also fix how some modals fetch the safeAddress
* Improves modal's wording
* Fix error parsing the cancel transaction error message from GETH nodes
* Remove useCheckIfTransactionWillFail
Adds useEstimateTransactionGas
Renames estimateTxGas to estimateTransactionGas
Removes estimateTxGasCosts
Removes checkIfExecTxWillFail
* Replace useCheckIfTransactionWillFail from modals with useEstimateTransactionGas
* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas
* Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas
* Extract isExecution calculation to useEstimateTransactionGas
* Creates TransactionFailText
* Uses TransactionFailText in the review modals
* Fix wrong selector usage
* Fix missing null check on cancel tx confirmations
* Add guard for CLOSE_SNACKBAR action when tx was already dismissed
* Improves useEstimateTransactionGas in review custom tx and contract interaction review
* Fix review replace/remove/add owner modals styling
* Refactor response of useEstimateTransactionGas
* Remove safeAddress as param to the useEstimateTransactionGas
* Improves how threshold is obtained in useEstimateTransactionGas.tsx
* Rename gasCostHumanReadable to gasCostFormatted
* Add operation to useEstimateTransactionGas
* Refactor ConfirmTransactionModal to use useEstimateTransactionGas
* Refactor proccessTransaction to use getPreValidatedSignatures method
* Fix default export of ApproveTxModal
* Rename estimateExecTransactionGas to estimateGasForTransactionCreation
Remove estimateTransactionGas from gas.ts
* Make estimateGasForTransactionCreation throw error instead of 0 gas
* Adds estimateGasForTransactionExecution and estimateGasForTransactionApproval to gas.ts
* Move estimateTransactionGas to useEstimateTransactionGas
Refactors useEstimateTransactionGas to return isCreation and isOffChainSignature
* Type and refactor generateSignaturesFromTxConfirmations
Moves getPreValidatedSignatures to safeTxSigner.ts
* Uses confirmations to estimateGasForTransactionExecution
* Adds TransactionFeesText component
Uses TransactionFeesText on ApproveTxModal
* Pass more parameters to estimateGasForTransactionExecution
* Removes unnecessary parameter in getNewTxNonce
* Moves checkIfOffChainSignatureIsPossible to safeTxSigner.ts
* Fix check for null confirmations
* Uses checkIfOffChainSignatureIsPossible on createTransaction.ts
* Move TransactionFailText inside TransactionFees component
* Pass safeTxGas to useEstimateTransactionGas.tsx
Improves how we use default params
* Fix gas iteration on estimateGasForTransactionExecution
* Fix estimateGasForTransactionExecution calculation
* Fix generateSignaturesFromTxConfirmations calculation
* Remove unnecessary Promise and await
* Fix estimateGasForTransactionExecution for preApproving owner case
* Improve logging
* Uses operation in useEstimateTransactionGas
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
* Deduplicate dependencies
* Upgrade @truffle/contract to latest v4.3.0
* Upgrade dependencies with minor changes
* Upgrade electron-builder configuration
* Upgrade typescript to latest version
* Upgrade safe-apps-sdk to latest version
Remove autoprefixer dependency
* Avoid displaying notification for non updated owner
* Remove old selector usage on welcome page
* Remove provider props on WelcomeLayout
Fix removing safe behaviour
* Fix missing undefined property check on cancelThresholdReached
* Removes the default safe when removing the safe marked as default
* Remove index
* Change react import
* Fix relative path for relocate url
* Adds removeLocalSafe action
Uses removeLocalSafe on onRemoveSafeHandler also removes default safe
* Refactor SafeListSidebar uses redux-hooks approach
* Disabled save button when the owner name input is pristine
* Adds shouldSafeBeUpdated to avoid updating unnecessary the safe
* Fix css typing
* Moves equalArrays to utils function
Improves how updateSafe is dispatched within checkAndUpdateSafe to avoid unnecessary re renders
* Revert some default cases fixes
* Adds equalArrays tests
* Add test to arrays.test.ts
* Improves shouldSafeStoreBeUpdated order and renames it
* Adds shouldSafeStoreBeUpdated.test.ts
* Uses shouldSafeStoreBeUpdated within safe reducer
* Replaces equalArrays with isEqual from lodash
* Simplify shouldSafeStoreBeUpdated using isEqual from lodash
* Remove lodash to compare Immutable objects correctly
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Makes getGasEstimationTxResponse exportable
* Removes the race condition between useLoadSafe and useSafeScheduledUpdates
* Reword safeLoaded
* Improve check for setIsSafeLoaded
* Remove Warning: React.createFactory() is deprecated
* make TS recognize Window definition by adding an empty export
* Silent MM warning ethereum.autoRefreshOnNetworkChange
* remove warning when requesting data from contract with null address.
* use createStyles/makeStyles
* simplify `addressBookQueryParamsSelector`
* avoid using `createSelector`
as memoization in this scenario is not working as expected and list is not refreshed
* refactor `uniqueAddress` curried function and strategy to validate
- `selectedEntry` being `null` made the code harder to follow
* fix `uniqueAddress` validator tests
* use arrow function
* Fix black notification
* Fix executing tx even if the user rejected it
* Fix hidden metamask error code
* Fix proccessTransaction notifications and metamask sign reject handling
* Upgrade dependencies without breaking changes
* Upgrade react-scripts to v4
* Use import instead of require in icons
* Update styles dependencies
* Remove react-app-rewired as is deprecated and not needed anymore
* Update prettier and testing-library/react dependencies
* Upgrade @ledger for desktop app
* Fix types in fetchSafeTokens test
* Use rescripts to remove ESLint plugin from react-scripts webpack
* Disable travis cache
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
* Replaces getNonGETHErrorDataResult with getDataFromNodeErrorMessage
Updates the extraction of data from the error message to include new GETH nodes version
* Add tests for new GETH nodes
* Adds operation call check on isTokenTransfer
* Add comment in unclear if
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Adds patch-package and postinstall
* Creates a patch to add EWC and Volta in web3-eth and web3-eth-ens
* Adds support for ewc in isValidEnsName
* Update web3 ewc patch
* Enables ens lookup for ewc and volta
* Fix eslint
* Update patch
Fix patch-package script in package.json
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* create `logic/collectibles/utils` file and move all the
NFT-related helper functions into it
`generateERC721TransferTxData` will decide whether the method
to transfer an NFT will be `transfer` or `safeTransferFrom`,
based on preset conditions where CryptoKitties tokens is taken
as an exception.
Also, `transfer` was used instead of `transferFrom`
because `transferFrom` is not implemented in the
rinkeby version, and was the method used as a
fallback before.
- moved `SAFE_TRANSFER_FROM_WITHOUT_DATA_HASH` const
- moved `isSendERC721Transaction` function
- moved `getERC721Symbol` function
- moved `isERC721Contract` function
- created `getTransferMethodByContractAddress` along with `CK_ADDRESS` const
- created `generateERC721TransferTxData` function
- refactored `ReviewCollectible` component to use `generateERC721TransferTxData`
- updated tests
* remove `ENS_ADDRESS` constant as it's not used
* add unmock of collectibles/utils
* add tests for `getTransferMethodByContractAddress`
* Refactor getTxData
* Add SAFE_TRANSFER_FROM in SAFE_METHODS_NAMES
* Adds check on isSendERC721Transaction for erc721 send
* Adds TOKEN_TRANSFER_METHODS_NAMES types
* Replace type SAFE_TRANSFER_FROM
* Fix import
* Adds nftAssetsListAddressSelector
* Remove txCode and knownTokens from isSendERC721Transaction
Now it directly checks agains the list of nftAssets on the store
* Refactor ENS_TOKEN_CONTRACT usage check
* Add TODO
* Add return for ENS symbol
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Fernando <fernando.greco@gmail.com>
* Adds support for GridPlus Lattice and bumps `bnc-onboard` version.
For more information on the GridPlus Lattice, see https://gridplus.io/lattice
* Disable Lattice wallet from incompatible chains
Co-authored-by: Alex Miller <asmiller1989@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
* Remove unnecesary await
* Implement gas calculation for NON-GETH nodes
* Add tests
* Refactor estimateSafeTxGas: now getGasEstimationTxResponse calculates gas or throws errors based on the current node
* Refactor getOpenEthereumErrorDataResult to make it works with Nethermind
Updates tests
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
* Add config for EWC and Volta
* Join tests in same file
* change price oracle in volta
* add travis config for volta and ewc
* Update travis to build xDai only in master or version release
* Add PR environment by network
* simplify some constants assignments
* Add PUBLIC_URL overwrite for PRs
* Change PULL_REQUEST condition test
* Use absolute path for PUBLIC_URL
* Fix missing https://
* Adapt EWC/Volta config to use new gasPriceOracle format
* disable openZeppeling in volta and EWC
* Deploy EWC to staging
* Fix Portis, Fortmatic and Blocknative key refactor
* Set EWC deployment to release/2.14.0
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
