Commit Graph

302 Commits

Author SHA1 Message Date
Daniel Sanchez eab0e73ac6
Bump dependencies (#1478)
* Upgrade dependencies without breaking changes

* Update electron and gnosis dependencies with minor changes

* Upgrade dependencies with minor changes and remove unnecessary electron dependency

* Upgrade truffle-contract to latest @truffle/contract
2020-10-15 17:01:12 +02:00
dependabot[bot] 032b93c603
Bump electron from 9.3.0 to 9.3.1
Bumps [electron](https://github.com/electron/electron) from 9.3.0 to 9.3.1.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md)
- [Commits](https://github.com/electron/electron/compare/v9.3.0...v9.3.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-06 18:15:48 +00:00
Daniel Sanchez 171b6d9ddc
Update travis script to execute tests (#1382)
* Update travis script to execute tests

* Update ReviewInformation components to remove type error

* Fix tests and import types without .d

* Upgrade dependencies with minor changes
2020-09-24 16:04:35 +02:00
Mati Dastugue dc632be4e2
Not able to connect with Opera Touch (#1378)
* Bump new onboard.js version

* Fix opera touch
2020-09-21 10:41:22 +02:00
Mikhail Mikheev 8a6633db92
Apps/Feature #37: add onUserReject event handler (#1354)
* add onUserReject event handler

* fix invoking possibly undefined func

* update sdk version

* yarn lock update

* fix network passing
2020-09-15 20:21:03 +04:00
Daniel Sanchez 8efafc1aaa
1265 Restore strict null checks (#1336)
* dep bump, enable strictNullChecks ts compiler option

* remove unused imports

* nullchecks errors wip

* fix clipboard func type errors

* fix send funds validation

* Update style load in ThresholdSettings

* Fix isValidAddress default state for SendCollectible

* fix OwnersColumn return type

* fix extractUsefulMethods typing

* Bug: incoming transactions do not load if it fails to fetch gas for a transaction (#1321)

* check if gas returned values are valid when loading token info for incoming tx

* Fix generateBatchRequests

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
(cherry picked from commit 372d27f5a6)

* Revert "Revert "Tech debt 1265: Enable strictNullChecks TS compiler option (#1301)" (#1335)"

This reverts commit 43bc4984b8.

* Fix safe clean load

Fix transaction nonce get

* Fix issue adding owners again after reloading the page

* Add viewedSafes correctly to current session

* Add typing and reduce dependency with immutable

* Rename SerializedSessionState to CurrentSessionState

* Remove immutable from currentSession

* Use Dispatch type defined using ThunkDispatch

* Remove if as parameter should always be defined

* Fix test typo issues

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-09-15 09:50:51 +02:00
Daniel Sanchez 141b6464ae
Add manual trigger to desktop app build (#1356)
* Set desktop app build on workflow_dispatch

* Update workflow_dispatch

* Add yarn cache to build desktop app

Upgrade electron to latest compatible version

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-09-14 23:06:10 +04:00
Daniel Sanchez 43bc4984b8
Revert "Tech debt 1265: Enable strictNullChecks TS compiler option (#1301)" (#1335)
This reverts commit bfed9679f7.
2020-09-09 17:35:27 +02:00
Mikhail Mikheev bfed9679f7
Tech debt 1265: Enable strictNullChecks TS compiler option (#1301)
* dep bump, enable strictNullChecks ts compiler option

* working on errors wip

* remove unused imports

* nullchecks errors wip

* fixing errors

* fixing errors

* fixing errors

* fix clipboard func type errors

* error fixes

* error fixes

* error fixes

* error fixes

* error fixes

* error fixes

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* error fixing

* Finally made it

* eslint fixes

* eslint fixes 2

* fix send funds validation

* Update style load in ThresholdSettings

* Fix isValidAddress default state for SendCollectible

* fix OwnersColumn return type

* fix extractUsefulMethods typing

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-09-04 16:03:09 +04:00
Mati Dastugue c5bafa6569
Bump new onboard.js version (#1307)
* Bump new onboard.js version

* bump new version

* Clean unnecessary dependencies from yarn.lock file

* Bump dependencies without breaking changes

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-09-01 19:02:25 +04:00
nicosampler e0151a42d9 update safe-react-components version 2020-08-27 14:12:02 -03:00
nicolas 03cb4aba96
New layout (#1201)
* Adding storybook

* new layout components

* add preview body

* add styles

* extract walletInfo to a separated component

* remove unused component

* New Layout componentes refactor

* Return type in Root

* change story name

* adding back OpenHoc

* sort import

* fix margins

* split layout

* Move Layout related components to /components/SidebarLayout

* Adding new layout for real

* Some changes and refactor

* Move Modals from safe to sidebar

* move safeAddress logic from safe to sidebar

* move safe container from components

* List refactor

* sidebar navigation

* selected item

* list selected example

* add styles

* add text component to new tx button

* Sidebar without walletInfo

* fix footer and body margins

* add logo Safe Multisig

* update safe-react-components

* List colors and List Icon

* fix subItem

* update safe-react-components

* fix logo margin, add notConnected icon and badge Read Only

* fix merge problems

* add sidebar styles and icon notConnected

* fix readOnly

* fix QR tooltip info

* add Help Center link and fix margins

* Remove 'No safe loaded' text

* review changes

* fix import

* fix Help center margin

* add styles to address

* replace empty div with FlexSpacer component

* rename Sidebar by SafeListSidebar

* fix load and create safe position (top-left)

* Add comment to FlexSpacer

* fix Title margin Safe Creation Progress

* fix Read Only line-height

* review fixes

* review fixes

* rename component

* fix Help Center styles

* return type in DefaultBadge

* Fix types for list component (still wip)

* move sidebarList to a hook

* fix safe route container

* fix src version

* fix list typescript issue

* rename sidebarlayout to applayout

* sidebar fixes wip

* sidebar fixes wip

* remove unused function

* lift sidebar items state up

* fix broken imports

* remove unused files

Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-27 18:53:28 +04:00
Daniel Sanchez d5513013f5 Merge remote-tracking branch 'origin/development' into v2.10.2-backmerge 2020-08-26 11:34:22 +02:00
Mikhail Mikheev 66c5ae7f8e
Safe apps: return safe tx hash (#1245)
* apps refactoring wip

* apps refactoring wip

* type fixes

* add useLegalConsent hook in apps

* useAppList hook wip

* dep nump

* useAppList hook wip

* fix selecting first app

* Remove console.log

* dep bump

* update persisting app logic

* update saveToStorage type

* fix crash on apps tab

* add appframe comp

* add handleIframeLoad func

* reuse selectedApp variable in hook

* remove initialAppSelected

* yarn regenration

* useIframeCommunicator wip

* add types for apps component

* dep bump

* fix history types

* yarn regenration

* extract useIframeMessenger hook

* fix safe-react-components version

* useIframeMessageHandler wip

* fix types

* send safe info on handshake

* fix naming/types for url utils

* remove operations

* update safe-apps-sdk

* wip

* update safe-apps-sdk

* requestId wip

* cta snackbar usage fixes

* notifications refactor wip

* notifications refactor: use dispatch

* tsc fixes

* extract confirm transaction modal

* Extract confirmation modal to a separate component

* dep bump

* ConfirmTransactionModal component

* Return safeTxHash after user confirmed transaction

* fix address validator, close modal when user confirms the tx

* close modal after confirmation

* update imports

* update imports [2]

* update imports [3]

* update imports [4]

* remove console.log in createTransaction

* update safe-apps-sdk

* yarn.lock

* EditOwnerModal types
2020-08-26 13:05:34 +04:00
nicolas 4dc28942c0
Allow to remove a Safe-app added manually (#1260)
* partial imp

* Delete safe apps added manually

* Fix and review changes

* remove unnecesary exports

* Fix deleteApp and sort in modal list
2020-08-25 17:19:01 -03:00
Daniel Sanchez af0f303fe0
Fix windows directory issue on yarn install (#1275)
* Update yarn.lock file to match integrity

* Restore network-concurrency flag
2020-08-25 20:06:37 +02:00
Daniel Sanchez 5a8b3e248b Fix desktop app build (#1254)
* Change generate-types routes

* Use cross-env in generate-types script

* Update desktop build to Node 12

* Rollback to Node 10

* Remove cross-env

* Disable yarncache steps

* Enable yarn cache clear

* Cleanup yarn.lock file

* Restore yarn install step

* Set release action when merge to master
2020-08-25 13:35:28 +02:00
Daniel Sanchez 8a13d333d2
Fix desktop app build (#1254)
* Change generate-types routes

* Use cross-env in generate-types script

* Update desktop build to Node 12

* Rollback to Node 10

* Remove cross-env

* Disable yarncache steps

* Enable yarn cache clear

* Cleanup yarn.lock file

* Restore yarn install step

* Set release action when merge to master
2020-08-20 00:52:36 +04:00
Mikhail Mikheev 7a4773511c
Safe apps: Extract Iframe messenger to a hook (#1219)
* add useLegalConsent hook in apps

* useAppList hook wip

* fix selecting first app

* update persisting app logic

* update saveToStorage type

* fix crash on apps tab

* add appframe comp

* add handleIframeLoad func

* reuse selectedApp variable in hook

* remove initialAppSelected

* add types for apps component

* fix history types

* extract useIframeMessenger hook

* fix safe-react-components version

* useIframeMessageHandler

* update safe-apps-sdk

* Fix alignment between app list and app iframe

* send safe info on handshake

* fix naming/types for url utils

* fix types and code cleanup

* remove operations

* dep bump

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
2020-08-13 13:37:34 +02:00
Mati Dastugue aeaf3c4ee6 Remove styles hook and change styles change 2020-08-12 12:07:45 -03:00
nicosampler 44a5a9c190 update package.json 2020-08-06 08:55:14 -03:00
nicosampler 18dd6b7e97 Merge branch 'development' into issue-1144 2020-08-06 08:22:19 -03:00
Mikhail Mikheev b6bb5ffde1
Tech Debt: Safe Apps Refactor (#1110)
* apps refactoring wip

* apps refactoring wip

* type fixes

* add useLegalConsent hook in apps

* useAppList hook wip

* dep nump

* useAppList hook wip

* fix selecting first app

* Remove console.log

* dep bump

* update persisting app logic

* update saveToStorage type

* fix crash on apps tab

* reuse selectedApp variable in hook

* remove initialAppSelected
2020-08-06 11:33:58 +04:00
nicosampler 7f3a99b7f1 Merge remote-tracking branch 'origin/development' into issue-1144 2020-08-03 13:36:36 -03:00
Daniel Sanchez f374315a5a
Avoid constant creation of new web3 object (#1171)
* Avoid constant creation of new web3 object

* rollback web3 version, small type fixes in ConnectButton

* Use web3 instance in getProviderInfo

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-03 11:29:17 +02:00
Mikhail Mikheev 86cbd94b0c
Tech debt: Add types for contracts (#1118)
* typechain wip

* add types for multisend

* type definitions improvements

* type safe contract in estimateTxGasCosts

* contract type definitions wip

* SafeInstance truffle -> web3 migration

* fix calls for version

* transactions/send enhancements

* fix safe recor owner type

* Stepper type definitions wip

* dep bump

* stepper types wip

* refactoring stepper component to fix bug in load safe form

* stepper types wip, addressbook reducer types wip

* finally make it work

* Fix ownerlist component hook in load safe

* dep bump

* dep bump

* rollback types/history

* add types for gas calc

* debugging...

* fix using RO web3 for sending txs

* update package.json generate-types command

* add ts-ignore for stepperpage

* db

* dep bump

* as unknown as AbiItem -> as AbiItem[]

* use optional chaining for isExecution in gas esimations

* abiITem -> AbiItem[]

* fix safeVersion utils tests

* fix imports, put upgradeSafe test close to the actual code

* add comment about ts-ignore usage

* downgrade web3 version
2020-08-01 02:26:10 +04:00
nicosampler df8e3f49df review fixes 2020-07-31 15:21:17 -03:00
nicosampler 5f1f5f5387 update yarn.lock 2020-07-30 12:09:49 -03:00
nicolas 251da319a5
Fix: debounce fetch apps (#1021)
* Fix: debounce fetch apps

* refactor: fix AddAppForm name and add missing types

* add `use-lodash-debounce` hook to test debounce functionality

I'm planning to remove this dependency, as it requires to also install `lodash.debounce`. I prefer to implement it ad-hoc.

* refactor AddAppForm to use the observable pattern

* memoize `getAppInfoFromUrl` to prevent requesting the same information over and over

* prevent requesting data if url is not valid

* remove logging

* prevent validating form before visiting the fields

* refactor AddAppForm

reorganize code

* fix: change `any` to `unknown`

* fix: `uitls.ts` types and imports

* refactor: rename `isSubmitDisabled` to `onSubmitButtonStatusChange` prop

* refactor: rename `agreement` to `agreementAccepted`

also, moved `initialValues` to a constant `INITIAL_VALUES` outside the component

* refactor: reimplement `useDebounce` hook in-app

* refactor: extract app manifest verification to a helper function

also fixed types

* fix: prevent accessing `contentWindow` if `iframe` is `null`

* fix: `getAppInfoFromOrigin` return type

also, removed the expected type for the `getAppInfoFromOrigin` calls as it is inferred

Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-30 18:28:30 +04:00
Daniel Sanchez 89c17180de
Trim spaces from AddressInput (#1142)
* Remove spaces

* Change naming convention to make clear that only edge whitespaces are removed

Fix function documentation in string util

* Add trim spaces from address input in AddToken and AddAsset

* Use validator type

* Trim spaces on Safe App links

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-29 17:28:43 +04:00
Mikhail Mikheev f62bbffdd3
Tech Debt: Validator Type definitions (#1108)
* type validators

* safeSelector types

* history 5.0.0 breaking changes adaptation

* replace simpleMemoize with memoize from lodash because of typing issues

* add type definitions for history and react-router-dom

* type fixes

* yarn lock update

* fix router state

* more type improvements

* validator tests wip

* add tests for validators, remove duplicated validators

* add error messages to tests

* fix minValue error message for inclusive param

* Replace jsx.element with react.reactelement

* Fix uniqueAddress validator argument type

* remove comment in AddCustomToken validator

* use absolute import for saferecord in safe paage container
2020-07-27 14:31:13 +04:00
Germán Martínez 253639d009
Safe apps can request the Safe info (#1138)
* Request Safe info from Safe apps

* Update dependencies

* Update yarn.lock file

* remove usecallback

* Rename initialization messageId from safe-apps-sdk

* Fix openOnFocus on AddressBookInput

* Fix yarn.lock file

* Rollback @material-ui/lab to avoid type errors

* dep bump

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-24 17:56:24 +04:00
Mikhail Mikheev cea91ca007 update yarn.lock 2020-07-22 20:58:10 +04:00
nicosampler c1c5488d53 Fix: [SafeApps] add app input 2020-07-22 12:54:14 -03:00
fernandomg 028913d9bf bump `safe-react-components` version 2020-07-17 18:39:46 -03:00
fernandomg 0adaaf5c77 update `yarn.lock` 2020-07-13 13:43:30 -03:00
Agustin Pane 948bb21378 Merge branch 'development' of https://github.com/gnosis/safe-react into coveralls
# Conflicts:
#	yarn.lock
2020-07-08 10:30:37 -03:00
Agustin Pane 8fb5cf5e63 Adds web3-core types 2020-07-08 10:07:38 -03:00
Agustin Pane 3e982b741f Merge branch 'master' of https://github.com/gnosis/safe-react into coveralls
# Conflicts:
#	yarn.lock
2020-07-02 09:06:28 -03:00
Agustin Pane 98ec85d454 Merge branch 'development' of https://github.com/gnosis/safe-react into coveralls 2020-07-01 08:50:14 -03:00
nicolas d57ad72588
2.4.0 (#1079)
* Fix: Sapp confirmTXs modal width.

* explicitly type classNames

* typo

* Bump onboardjs version (#1049)

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* add Aave app (#1075)

* bump package.json version (#1077)

* mock commit

* yarn.lock regenration

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-06-30 12:57:21 +04:00
Mati Dastugue 222ace288c
Bump onboardjs version (#1049)
Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-29 16:33:56 +04:00
Agustin Pane 8625684b2a Merge branch 'master' of https://github.com/gnosis/safe-react into coveralls
# Conflicts:
#	yarn.lock
2020-06-25 10:52:31 -03:00
Mikhail Mikheev f39b0903ca
2.3.1 bugfix
* fallback to tx.recipient in case no if statement worked in getTxData

* update pkg.json
2020-06-25 16:18:53 +04:00
fernandomg 6fff362664 update yarn.lock 2020-06-24 10:24:25 -03:00
Mikhail Mikheev 75a72f32a7 turn on rule for explicit return type 2020-06-19 14:12:03 +04:00
nicolas 813619c123
hide sapp iframe until it loads completely (#1020)
* hide sapp iframe until it loads completely

* review changes

* remove code

* moving type

* adding styled-components types

* fix TS error

* refactor iframe loading
2020-06-18 14:03:12 +04:00
Fernando 0296a670e7
(Fix) [Contract Interaction] Support array-like arguments (#1009)
* Add `ArrayTypeInput` to support array type values

- also updated types for ContractInteraction/utils

* Update placeholder message

* Support fixed size arrays

- refactored how Field's key is generated due to conflicts with final-form library and `[]` in the name
- also simplified validation for array-like fields, as it messed with arguments of type `T[][2][][3]`
2020-06-18 13:53:49 +04:00
Agustin Pane 6d1a349d87
(Fix) - Identicons fix (#1004)
* Replaces old blockies dependency with ethereum-blockies-base64

* Add types

* Refactor as functional component

* Simplify identicon logic

* Simplify identicon styling logic

* Simplify identicon styling logic
2020-06-11 12:13:14 -03:00
nicolas ea1662bc6f
Safe apps url config (#1001)
* safe-react-apps  url from config and add request app

* Adding types

* safe-react-components bump

* extracting types

* add return type

Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-09 11:34:43 -03:00