From 2bd73c3443560f2e0619d3183279b0e7b9ae76df Mon Sep 17 00:00:00 2001 From: Daniel Sanchez Date: Mon, 1 Feb 2021 12:32:08 +0100 Subject: [PATCH 1/6] Set v2.19.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index eb592303..3e6b3123 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "safe-react", - "version": "2.18.1", + "version": "2.19.0", "description": "Allowing crypto users manage funds in a safer way", "website": "https://github.com/gnosis/safe-react#readme", "bugs": { From 4bf1a74b330597beb56cb124e41885a58b6ec62f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Longoni?= Date: Mon, 1 Feb 2021 16:02:14 -0300 Subject: [PATCH 2/6] fix 'Advanced options' presentation in modal --- .../components/Settings/ManageOwners/AddOwnerModal/index.tsx | 1 - .../components/Settings/ManageOwners/RemoveOwnerModal/index.tsx | 1 - .../components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx | 1 - 3 files changed, 3 deletions(-) diff --git a/src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx b/src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx index c3121921..37a3427c 100644 --- a/src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx +++ b/src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx @@ -21,7 +21,6 @@ import ThresholdForm from './screens/ThresholdForm' const styles = createStyles({ biggerModalWindow: { width: '775px', - minHeight: '500px', height: 'auto', }, }) diff --git a/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/index.tsx b/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/index.tsx index 575046d3..6a5e8f86 100644 --- a/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/index.tsx +++ b/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/index.tsx @@ -18,7 +18,6 @@ import { TxParameters } from 'src/routes/safe/container/hooks/useTransactionPara const styles = createStyles({ biggerModalWindow: { width: '775px', - minHeight: '500px', height: 'auto', }, }) diff --git a/src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx b/src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx index 6e0e9600..a1d6c7db 100644 --- a/src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx +++ b/src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx @@ -21,7 +21,6 @@ import { TxParameters } from 'src/routes/safe/container/hooks/useTransactionPara const styles = createStyles({ biggerModalWindow: { width: '775px', - minHeight: '500px', height: 'auto', }, }) From 42821c11d253401080535082d6df021be00a82b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Longoni?= Date: Mon, 1 Feb 2021 19:20:15 -0300 Subject: [PATCH 3/6] Avoids changing the transaction fee message while loading the estimation --- src/components/TransactionsFees/index.tsx | 3 +++ .../RemoveOwnerModal/screens/Review/index.tsx | 22 ++++++++++--------- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/components/TransactionsFees/index.tsx b/src/components/TransactionsFees/index.tsx index c5e54f19..09187210 100644 --- a/src/components/TransactionsFees/index.tsx +++ b/src/components/TransactionsFees/index.tsx @@ -21,6 +21,9 @@ export const TransactionFees = ({ txEstimationExecutionStatus, }: TransactionFailTextProps): React.ReactElement | null => { let transactionAction + if (txEstimationExecutionStatus === EstimationStatus.LOADING) { + return null + } if (isCreation) { transactionAction = 'create' } else if (isExecution) { diff --git a/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/Review/index.tsx b/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/Review/index.tsx index ece059c9..36ec7e79 100644 --- a/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/Review/index.tsx +++ b/src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/Review/index.tsx @@ -216,16 +216,18 @@ export const ReviewRemoveOwnerModal = ({ isTransactionExecution={isExecution} /> - - - - + {txEstimationExecutionStatus === EstimationStatus.LOADING ? null : ( + + + + + )}