From c25946ab8f12296043add7995d7e7481fc40a2e4 Mon Sep 17 00:00:00 2001 From: Daniel Sanchez Date: Fri, 26 Mar 2021 16:23:52 +0100 Subject: [PATCH] Remove validator to check that safeTxGas is lower than gasLimit (#2089) --- .../helpers/EditTxParametersForm/index.tsx | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/routes/safe/components/Transactions/helpers/EditTxParametersForm/index.tsx b/src/routes/safe/components/Transactions/helpers/EditTxParametersForm/index.tsx index a497eb2b..2d21fcab 100644 --- a/src/routes/safe/components/Transactions/helpers/EditTxParametersForm/index.tsx +++ b/src/routes/safe/components/Transactions/helpers/EditTxParametersForm/index.tsx @@ -1,4 +1,4 @@ -import React from 'react' +import React, { ReactElement } from 'react' import IconButton from '@material-ui/core/IconButton' import Close from '@material-ui/icons/Close' import { makeStyles } from '@material-ui/core/styles' @@ -13,10 +13,9 @@ import Row from 'src/components/layout/Row' import { styles } from './style' import GnoForm from 'src/components/forms/GnoForm' import { TxParameters } from 'src/routes/safe/container/hooks/useTransactionParameters' -import { composeValidators, minValue } from 'src/components/forms/validator' +import { minValue } from 'src/components/forms/validator' import { ParametersStatus, areSafeParamsEnabled, areEthereumParamsVisible, ethereumTxParametersTitle } from '../utils' -import { getNetworkInfo } from 'src/config' const StyledDivider = styled(Divider)` margin: 16px 0; @@ -59,8 +58,6 @@ const StyledTextMt = styled(Text)` const useStyles = makeStyles(styles) -const { label } = getNetworkInfo() - interface Props { txParameters: TxParameters onClose: (txParameters?: TxParameters) => void @@ -79,15 +76,7 @@ const formValidation = (values) => { const safeNonceValidation = minValue(0, true)(safeNonce) - const safeTxGasValidation = composeValidators(minValue(0, true), (value: string) => { - if (!value) { - return - } - - if (Number(value) > Number(ethGasLimit)) { - return `Bigger than ${label} gas limit.` - } - })(safeTxGas) + const safeTxGasValidation = minValue(0, true)(safeTxGas) return { ethGasLimit: ethGasLimitValidation, @@ -103,7 +92,7 @@ export const EditTxParametersForm = ({ txParameters, parametersStatus = 'ENABLED', isExecution, -}: Props): React.ReactElement => { +}: Props): ReactElement => { const classes = useStyles() const { safeNonce, safeTxGas, ethNonce, ethGasLimit, ethGasPrice } = txParameters