From 50995c3f0ccbc78eb4c0459275ef837cdeac8e8e Mon Sep 17 00:00:00 2001 From: Mati Dastugue Date: Thu, 20 Aug 2020 16:15:38 -0300 Subject: [PATCH] Etherscan link broken (#1255) * Add default type * update deps * Rename variables * Update link * hardcode link type * remove optional type prop for etherscanlink Co-authored-by: Mikhail Mikheev --- src/components/EtherscanLink/index.tsx | 2 +- .../TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx | 1 - .../Transactions/TxsTable/ExpandedTx/TxDescription/Value.tsx | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/components/EtherscanLink/index.tsx b/src/components/EtherscanLink/index.tsx index b2a476ff..fe33a953 100644 --- a/src/components/EtherscanLink/index.tsx +++ b/src/components/EtherscanLink/index.tsx @@ -17,7 +17,7 @@ interface EtherscanLinkProps { className?: string cut?: number knownAddress?: boolean - type?: 'tx' | 'address' + type: 'tx' | 'address' value: string } diff --git a/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx b/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx index 24b93cc8..1076b335 100644 --- a/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx +++ b/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx @@ -59,7 +59,6 @@ const TxInfoDetails = ({ data }: { data: DataDecoded }): React.ReactElement => ( {param.name}({param.type}): - ))} diff --git a/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/Value.tsx b/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/Value.tsx index 172515d8..9cfc3839 100644 --- a/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/Value.tsx +++ b/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/Value.tsx @@ -47,13 +47,13 @@ const EtherscanLink = ({ method, type, value }: RenderValueProps): React.ReactEl return ( {(value as string[]).map((value, index) => ( - + ))} ) } - return + return } const GenericValue = ({ method, type, value }: RenderValueProps): React.ReactElement => {