diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..4340026f --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,38 @@ + + + + +**What**: + + + +**Why**: + + + +**How**: + + + +**How to test it**: + + + +**Checklist**: + + + + + +- [ ] Tests added/updated +- [ ] Ready to be merged + + + diff --git a/package.json b/package.json index b2bb7467..4b050a55 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "safe-react", - "version": "3.5.2", + "version": "3.6.0", "description": "Allowing crypto users manage funds in a safer way", "website": "https://github.com/gnosis/safe-react#readme", "bugs": { diff --git a/readme.md b/readme.md index 460b31bd..fab1323f 100644 --- a/readme.md +++ b/readme.md @@ -4,7 +4,7 @@ The most trusted platform to store digital assets on Ethereum. More info at [gno This repository contains the code for the frontend code hosted at [https://gnosis-safe.io/app/] -Besides Ethereum Mainnet, the following networks are supported: +Besides the Ethereum Mainnet, the following networks are supported: - [Rinkeby Testnet](https://rinkeby.gnosis-safe.io/app/) - [xDai](https://xdai.gnosis-safe.io/app/) @@ -21,7 +21,7 @@ These instructions will get you a copy of the project up and running on your loc ### Prerequisites -What things you need to install globally: +What you need to install globally: ``` yarn global add truffle ganache-cli @@ -31,19 +31,17 @@ We use [yarn](https://yarnpkg.com) in our infrastacture, so we decided to go wit ### Installing and running -A step by step series of examples that tell you have to get a development env running - Install dependencies for the project: ``` yarn install ``` -For using the Rinkeby services: +To use the Rinkeby services: ``` yarn start ``` -If you prefer using Mainnet ones: +If you prefer using the Mainnet ones: ``` yarn start-mainnet ``` @@ -141,7 +139,6 @@ We prepare a new release every sprint. Sprints are two weeks long. * [React](https://reactjs.org/) - A JS library for building user interfaces * [Material UI 4.X](https://material-ui.com/) - React components that implement Google's Material Design * [redux, immutable, reselect, final-form](https://redux.js.org/) - React ecosystem libraries -* [Flow](https://flow.org/) - Static Type Checker ## Contributing diff --git a/src/components/Modal/index.tsx b/src/components/Modal/index.tsx index cebf2b75..5a6dcc33 100644 --- a/src/components/Modal/index.tsx +++ b/src/components/Modal/index.tsx @@ -47,9 +47,6 @@ const ModalStyled = styled(ModalMUI)` &.smaller-modal-window { height: auto; - max-height: 90vh; - overflow: hidden; - overflow-y: auto; } &.modal { diff --git a/src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/style.ts b/src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/style.ts index 1c273cca..f1498d01 100644 --- a/src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/style.ts +++ b/src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/style.ts @@ -27,9 +27,6 @@ export const styles = createStyles({ formContainer: { padding: `${md} ${lg}`, wordBreak: 'break-word', - maxHeight: '50vh', - overflow: 'hidden', - overflowY: 'auto', }, value: { marginLeft: sm, @@ -51,7 +48,7 @@ export const styles = createStyles({ lineHeight: '1.43', }, buttonRow: { - padding: '25px', + height: '84px', justifyContent: 'center', '& > button': { fontFamily: 'Averta', diff --git a/src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx b/src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx index 9faccdfa..ce32578b 100644 --- a/src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx +++ b/src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx @@ -42,6 +42,7 @@ const { nativeCoin } = getNetworkInfo() export type ReviewTxProp = { recipientAddress: string + recipientName?: string amount: string txRecipient: string token: string @@ -218,6 +219,7 @@ const ReviewSendFundsTx = ({ onClose, onPrev, tx }: ReviewTxProps): React.ReactE { - const submitValues = values + const submitValues = { ...values } // If the input wasn't modified, there was no mutation of the recipientAddress if (!values.recipientAddress) { submitValues.recipientAddress = selectedEntry?.address } + submitValues.recipientName = selectedEntry?.name onReview({ ...submitValues, tokenSpendingLimit }) } diff --git a/yarn.lock b/yarn.lock index a54416e0..7553e323 100644 --- a/yarn.lock +++ b/yarn.lock @@ -11409,9 +11409,9 @@ hoopy@^0.1.4: integrity sha512-HRcs+2mr52W0K+x8RzcLzuPPmVIKMSv97RGHy0Ea9y/mpcaK+xTrjICA04KAHi4GRzxliNqNJEFYWHghy3rSfQ== hosted-git-info@^2.1.4: - version "2.8.8" - resolved "https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.8.8.tgz#7539bd4bc1e0e0a895815a2e0262420b12858488" - integrity sha512-f/wzC2QaWBs7t9IYqB4T3sR1xviIViXJRJTWBlx2Gf3g0Xi5vI7Yy4koXQ1c9OYDGHN9sBy1DQ2AB8fqZBWhUg== + version "2.8.9" + resolved "https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.8.9.tgz#dffc0bf9a21c02209090f2aa69429e1414daf3f9" + integrity sha512-mxIDAb9Lsm6DoOJ7xH+5+X4y1LU/4Hi50L9C5sIswK3JzULS4bwk1FvjdBgvYR4bzT4tuUQiC15FE2f5HbLvYw== hosted-git-info@^3.0.6, hosted-git-info@^3.0.8: version "3.0.8"