status-im/realm-js
2
0
Fork 0
mirror of https://github.com/status-im/realm-js.git synced 2025-02-25 12:45:32 +00:00
Code Issues Projects Releases Wiki Activity

Avoid copying List unnecessarily.

Browse Source
This commit is contained in:
Mark Rowe 2016-05-31 15:27:48 -07:00
parent ba6e83191b
commit efdf0e01a9
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/js_list.hpp
View File

@ -41,7 +41,7 @@ struct ListClass : ClassDefinition<T, realm::List, CollectionClass<T>> {
using Value = js::Value<T>; using Value = js::Value<T>;
using ReturnValue = js::ReturnValue<T>; using ReturnValue = js::ReturnValue<T>;
static ObjectType create_instance(ContextType, realm::List &); static ObjectType create_instance(ContextType, realm::List);
// properties // properties
static void get_length(ContextType, ObjectType, ReturnValue &); static void get_length(ContextType, ObjectType, ReturnValue &);
@ -81,8 +81,8 @@ struct ListClass : ClassDefinition<T, realm::List, CollectionClass<T>> {
}; };
template<typename T> template<typename T>
typename T::Object ListClass<T>::create_instance(ContextType ctx, realm::List &list) { typename T::Object ListClass<T>::create_instance(ContextType ctx, realm::List list) {
return create_object<T, ListClass<T>>(ctx, new realm::List(list)); return create_object<T, ListClass<T>>(ctx, new realm::List(std::move(list)));
} }
template<typename T> template<typename T>

2
src/js_object_accessor.hpp
View File

@ -135,7 +135,7 @@ struct NativeAccessor {
return Object::validated_get_object(ctx, Value::validated_to_object(ctx, value), (uint32_t)index); return Object::validated_get_object(ctx, Value::validated_to_object(ctx, value), (uint32_t)index);
} }
static ValueType from_list(ContextType ctx, realm::List list) { static ValueType from_list(ContextType ctx, realm::List list) {
return ListClass<T>::create_instance(ctx, list); return ListClass<T>::create_instance(ctx, std::move(list));
} }
static Mixed to_mixed(ContextType ctx, ValueType &val) { static Mixed to_mixed(ContextType ctx, ValueType &val) {