status-im/realm-js
2
0
Fork 0
mirror of https://github.com/status-im/realm-js.git synced 2025-01-26 22:39:05 +00:00
Code Issues Projects Releases Wiki Activity

Eliminate some copies when reading strings from node

Browse Source
This commit is contained in:
Thomas Goyne 2018-06-20 14:42:52 -07:00
parent 55fe200446
commit ed8b5d835d
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/node/node_string.hpp
View File

@ -30,16 +30,35 @@ class String<node::Types> {
public:
String(const char* s) : m_str(s) {}
String(const std::string &s) : m_str(s) {}
String(const v8::Local<v8::String> &s) : m_str(*Nan::Utf8String(s)) {}
String(const v8::Local<v8::String> &s);
String(v8::Local<v8::String> &&s) : String(s) {}
operator std::string() const {
operator std::string() const& {
return m_str;
}
operator std::string() && {
return std::move(m_str);
}
operator v8::Local<v8::String>() const {
return Nan::New(m_str).ToLocalChecked();
}
};
inline String<node::Types>::String(const v8::Local<v8::String> &s) {
if (s.IsEmpty() || s->Length() == 0) {
return;
}
if (s->IsOneByte()) {
m_str.resize(s->Length());
}
else {
// Length is in UCS-2 code units, which can take up to 3 bytes each to encode
m_str.resize(3 * s->Length());
}
const int flags = v8::String::NO_NULL_TERMINATION | v8::String::REPLACE_INVALID_UTF8;
auto length = s->WriteUtf8(&m_str[0], m_str.size(), 0, flags);
m_str.resize(length);
}
} // js
} // realm