diff --git a/react-native/android/app/src/main/jni/Android.mk b/react-native/android/app/src/main/jni/Android.mk index 39c71df7..6ee9b8dd 100644 --- a/react-native/android/app/src/main/jni/Android.mk +++ b/react-native/android/app/src/main/jni/Android.mk @@ -37,9 +37,9 @@ LOCAL_C_INCLUDES += src/object-store LOCAL_C_INCLUDES += src/object-store/parser LOCAL_C_INCLUDES += vendor LOCAL_C_INCLUDES += vendor/PEGTL -LOCAL_C_INCLUDES += ../../../../../../../react-native/ReactAndroid/src/main/jni/react -LOCAL_C_INCLUDES += ../../../../../../../react-native/ReactAndroid/src/main/jni/first-party -LOCAL_C_INCLUDES += ../../../../../../../react-native/ReactAndroid/src/main/jni/first-party/fb/include +LOCAL_C_INCLUDES += react-native/ReactAndroid/src/main/jni/react +LOCAL_C_INCLUDES += react-native/ReactAndroid/src/main/jni/first-party +LOCAL_C_INCLUDES += react-native/ReactAndroid/src/main/jni/first-party/fb/include LOCAL_C_INCLUDES += $(JAVA_HOME)/include LOCAL_C_INCLUDES += $(JAVA_HOME)/include/darwin LOCAL_C_INCLUDES += core/include diff --git a/react-native/android/app/src/main/jni/react-native b/react-native/android/app/src/main/jni/react-native new file mode 120000 index 00000000..77b89eab --- /dev/null +++ b/react-native/android/app/src/main/jni/react-native @@ -0,0 +1 @@ +../../../../../../../../react-native \ No newline at end of file diff --git a/src/js_object.cpp b/src/js_object.cpp index 92f87fd4..d527df7f 100644 --- a/src/js_object.cpp +++ b/src/js_object.cpp @@ -63,7 +63,7 @@ JSObjectRef RJSObjectCreate(JSContextRef ctx, Object object) { return jsObject; } -extern JSObjectRef RJSDictForPropertyArray(JSContextRef ctx, ObjectSchema &object_schema, JSObjectRef array); +extern JSObjectRef RJSDictForPropertyArray(JSContextRef ctx, const ObjectSchema &object_schema, JSObjectRef array); namespace realm { diff --git a/src/js_realm.hpp b/src/js_realm.hpp index 30ebe657..fa2b4fdd 100644 --- a/src/js_realm.hpp +++ b/src/js_realm.hpp @@ -20,9 +20,3 @@ void RJSSetDefaultPath(std::string path); std::map &RJSDefaults(realm::Realm *realm); std::map &RJSPrototypes(realm::Realm *realm); - -template -std::unique_ptr make_unique(Args&&... args) -{ - return std::unique_ptr(new T(std::forward(args)...)); -} \ No newline at end of file diff --git a/src/object-store/impl/transact_log_handler.cpp b/src/object-store/impl/transact_log_handler.cpp index bd678668..ac74b515 100644 --- a/src/object-store/impl/transact_log_handler.cpp +++ b/src/object-store/impl/transact_log_handler.cpp @@ -306,8 +306,6 @@ public: bool set_link(size_t col, size_t row, size_t, size_t) { return mark_dirty(row, col); } bool set_null(size_t col, size_t row) { return mark_dirty(row, col); } bool nullify_link(size_t col, size_t row, size_t) { return mark_dirty(row, col); } - bool set_int_unique(size_t col, size_t row, int_fast64_t) { return mark_dirty(row, col); } - bool set_string_unique(size_t col, size_t row, StringData) { return mark_dirty(row, col); } // Doesn't change any data bool optimize_table() { return true; } diff --git a/src/object-store/parser/parser.cpp b/src/object-store/parser/parser.cpp index 7d425ee5..2753fbd8 100644 --- a/src/object-store/parser/parser.cpp +++ b/src/object-store/parser/parser.cpp @@ -227,7 +227,7 @@ template<> struct action< or_op > template<> struct action< rule > { \ static void apply( const input & in, ParserState & state ) { \ DEBUG_PRINT_TOKEN(in.string()); \ - state.add_expression(Expression{type, in.string()}); }}; + state.add_expression(Expression(type, in.string())); }}; EXPRESSION_ACTION(dq_string_content, Expression::Type::String) EXPRESSION_ACTION(sq_string_content, Expression::Type::String) diff --git a/src/object-store/parser/parser.hpp b/src/object-store/parser/parser.hpp index 681847f0..92f7ebea 100644 --- a/src/object-store/parser/parser.hpp +++ b/src/object-store/parser/parser.hpp @@ -30,6 +30,7 @@ struct Expression { enum class Type { None, Number, String, KeyPath, Argument, True, False } type = Type::None; std::string s; + Expression(Type t = Type::None, std::string s = "") : type(t), s(s) {} }; struct Predicate diff --git a/src/object-store/parser/query_builder.hpp b/src/object-store/parser/query_builder.hpp index eac61312..f6738b47 100644 --- a/src/object-store/parser/query_builder.hpp +++ b/src/object-store/parser/query_builder.hpp @@ -67,13 +67,11 @@ class ArgumentConverter : public Arguments std::vector m_arguments; ContextType m_ctx; - ValueType &argument_at(size_t index) { - if (index >= m_arguments.size()) { - throw std::out_of_range((std::string)"Argument index " + to_string(index) + " out of range 0.." + to_string(m_arguments.size()-1)); - } - return m_arguments[index]; - } - }; + ValueType &argument_at(size_t index) { + if (index >= m_arguments.size()) { + throw std::out_of_range((std::string)"Argument index " + to_string(index) + " out of range 0.." + to_string(m_arguments.size()-1)); + } + return m_arguments[index]; } }; }