From d0715cc8e4edc4e9726f7b2eef0dedb20f0fcb8d Mon Sep 17 00:00:00 2001 From: Ari Lazier Date: Fri, 8 Jan 2016 11:37:05 -0800 Subject: [PATCH] pr fixes --- parser/parser.cpp | 2 +- parser/parser.hpp | 4 ++-- parser/query_builder.cpp | 2 +- parser/test.cpp | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/parser/parser.cpp b/parser/parser.cpp index 7d425ee5..2fbcbfbd 100644 --- a/parser/parser.cpp +++ b/parser/parser.cpp @@ -334,7 +334,7 @@ Predicate parse(const std::string &query) return std::move(out_predicate); } -void analyzeGrammar() +void analyze_grammar() { analyze(); } diff --git a/parser/parser.hpp b/parser/parser.hpp index 681847f0..39834dde 100644 --- a/parser/parser.hpp +++ b/parser/parser.hpp @@ -78,8 +78,8 @@ struct Predicate Predicate parse(const std::string &query); -void analyzeGrammar(); -bool testGrammar(); +void analyze_grammar(); +bool test_grammar(); } } diff --git a/parser/query_builder.cpp b/parser/query_builder.cpp index e3834ee1..af0c3d62 100644 --- a/parser/query_builder.cpp +++ b/parser/query_builder.cpp @@ -371,7 +371,7 @@ auto value_of_type_for_query(TableGetter&& tables, Value&& value, Arguments &arg { const bool isColumn = std::is_same::type>::value; using helper = std::conditional_t, ValueGetter>; - return helper::convert(std::forward(tables), std::forward(value), args); + return helper::convert(tables, value, args); } template diff --git a/parser/test.cpp b/parser/test.cpp index ce290474..f834c505 100644 --- a/parser/test.cpp +++ b/parser/test.cpp @@ -134,7 +134,7 @@ static std::vector invalid_queries = { namespace realm { namespace parser { -bool testGrammar() +bool test_grammar() { bool success = true; for (auto &query : valid_queries) {