status-im/realm-js
2
0
Fork 0
mirror of https://github.com/status-im/realm-js.git synced 2025-01-11 14:54:33 +00:00
Code Issues Projects Releases Wiki Activity

Don't refresh tokens for sessions that have been closed (#2119)

Browse Source 
* Don't refresh tokens for sessions that have been closed

* Changelog entry
This commit is contained in:
Nikola Irinchev 2018-11-19 12:05:59 +01:00 committed by GitHub
parent 6f36efb81e
commit c173d3cca7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
CHANGELOG.md
View File

@ -1,20 +1,3 @@
x.x.x Release notes (yyyy-MM-dd)
=============================================================
### Enhancements
* None.
### Fixed
* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
* None.
### Compatibility
* Realm Object Server: 3.11.0 or later.
* APIs are backwards compatible with all previous release of realm in the 2.x.y series.
* File format: Generates Realms with format v9 (Reads and upgrades all previous formats)
### Internal
* None.
x.x.x Release notes (yyyy-MM-dd) x.x.x Release notes (yyyy-MM-dd)
============================================================= =============================================================
### Enhancements ### Enhancements
@ -22,6 +5,7 @@ x.x.x Release notes (yyyy-MM-dd)
### Fixed ### Fixed
* Tokens are refreshed ahead of time. If the lifetime of the token is lower than the threshold for refreshing it will cause the client to continously refresh, spamming the server with refresh requests. A lower bound of 10 seconds has been introduced. ([#2115](https://github.com/realm/realm-js/issues/2115), since v1.0.2) * Tokens are refreshed ahead of time. If the lifetime of the token is lower than the threshold for refreshing it will cause the client to continously refresh, spamming the server with refresh requests. A lower bound of 10 seconds has been introduced. ([#2115](https://github.com/realm/realm-js/issues/2115), since v1.0.2)
* Prevent automatic token refreshes for Realms that have been closed. Previously, these could have resulted in obscure `Unhandled session token refresh error` messages in the logs that were benign. ([#2119](https://github.com/realm/realm-js/pull/2119))
### Compatibility ### Compatibility
* Realm Object Server: 3.11.0 or later. * Realm Object Server: 3.11.0 or later.

10
lib/user-methods.js
View File

@ -135,7 +135,6 @@ function print_error() {
function validateRefresh(user, localRealmPath, response, json) { function validateRefresh(user, localRealmPath, response, json) {
let session = user._sessionForOnDiskPath(localRealmPath); let session = user._sessionForOnDiskPath(localRealmPath);
if (!session) { if (!session) {
print_error(`Unhandled session token refresh error: could not look up session for user ${user.identity} at path ${localRealmPath}`);
return; return;
} }
@ -198,6 +197,13 @@ function refreshAdminToken(user, localRealmPath, realmUrl) {
} }
function refreshAccessToken(user, localRealmPath, realmUrl) { function refreshAccessToken(user, localRealmPath, realmUrl) {
if (!user._sessionForOnDiskPath(localRealmPath)) {
// We're trying to refresh the token for a session that's closed. This could happen, for example,
// when the server is not reachable and we periodically try to refresh the token, but the user has
// already closed the Realm file.
return;
}
if (!user.server) { if (!user.server) {
throw new Error("Server for user must be specified"); throw new Error("Server for user must be specified");
} }
@ -259,7 +265,7 @@ function refreshAccessToken(user, localRealmPath, realmUrl) {
}) })
.catch((e) => { .catch((e) => {
print_error(e); print_error(e);
// in case something lower in the HTTP stack breaks, try again in 10 seconds // in case something lower in the HTTP stack breaks, try again in `retryInterval` seconds
setTimeout(() => refreshAccessToken(user, localRealmPath, realmUrl), retryInterval); setTimeout(() => refreshAccessToken(user, localRealmPath, realmUrl), retryInterval);
}) })
} }