Merge pull request #953 from realm/blagoev/remove-obsolete-nosync-targets

remove obsolete test nosync targets

.vscode/launch.json

@@ -24,27 +24,6 @@
             "args": [
                 "spec/unit_tests.js"
             ]
-        },
-        {
-            "type": "node",
-            "request": "launch",
-            "name": "Debug Node Sync Unit Tests (rebuild)",
-            "preLaunchTask": "rebuild-node-tests",
-            "cwd": "${workspaceRoot}/tests",
-            "program": "${workspaceRoot}/tests/node_modules/jasmine/bin/jasmine.js",
-            "args": [
-                "spec/sync_tests.js"
-            ]
-        },
-        {
-            "type": "node",
-            "request": "launch",
-            "name": "Debug Node Sync Unit Tests",
-            "cwd": "${workspaceRoot}/tests",
-            "program": "${workspaceRoot}/tests/node_modules/jasmine/bin/jasmine.js",
-            "args": [
-                "spec/sync_tests.js"
-            ]
         }
     ]
 }

Jenkinsfile

@@ -210,7 +210,7 @@ def doWindowsBuild() {
         bat 'npm install --build-from-source'
         dir('tests') {
           bat 'npm install'
-          bat 'npm run test-nosync'
+          bat 'npm run test'
           junit 'junitresults-*.xml'
         }
       } finally {

README.md

@@ -93,9 +93,16 @@ test.sh options
  * react-tests - runs all React Native tests on iOS Simulator
  * react-tests-android runs all React Native Android tests on Android emulator
  * node - runs all tests for node
- * node-nosync - runs all tests for node without sync support
  * test-runners - checks supported tests runners are working correctly
 
+On Windows some of these targets are available as npm commands.
+```
+npm run eslint
+npm run node-tests
+npm run test-runners
+```
+
+## Debugging the tests
 
 You can attach a debugger to react-native tests by passing "Debug" to the tests.sh script. A Chrome browser will open and connect to the react native application. Use the built-in Chrome Debugger to debug the code.
 
@@ -103,6 +110,10 @@ You can attach a debugger to react-native tests by passing "Debug" to the tests.
 ./tests.sh react-tests Debug
 ```
 
+Using Visual Studio Code
+
+You can debug node tests using Visual Studio Code. Just use one of the launch configurations.
+
 ## Code of Conduct
 
 This project adheres to the Contributor Covenant [code of conduct](https://realm.io/conduct/).

package.json

@@ -57,9 +57,7 @@
     "jsdoc:clean": "rimraf ./docs/output",
     "jsdoc": "npm install && npm run jsdoc:clean && jsdoc -c docs/conf.json",
     "prenode-tests": "npm install --build-from-source && cd tests && npm install",
-    "node-tests": "cd tests && npm run test-nosync && cd ..",
-    "prenode-tests-nosync": "npm install --build-from-source && cd tests && npm install",
-    "node-tests-nosync": "cd tests && npm run test-nosync && cd ..",
+    "node-tests": "cd tests && npm run test && cd ..",
     "test-runner:ava": "cd tests/test-runners/ava && npm install && npm test",
     "test-runner:mocha": "cd tests/test-runners/mocha && npm install && npm test",
     "test-runner:jest": "cd tests/test-runners/jest && npm install && npm test",

scripts/test.sh

@@ -341,7 +341,7 @@ case "$TARGET" in
     npm_tests_cmd="npm run test"
     npm install --build-from-source --realm_enable_sync
   else
-    npm_tests_cmd="npm run test-nosync"
+    npm_tests_cmd="npm run test"
     npm install --build-from-source
   fi
 
@@ -355,18 +355,6 @@ case "$TARGET" in
   popd
   stop_server
   ;;
-"node-nosync")
-  npm install --build-from-source
-
-  # Change to a temp directory.
-  cd "$(mktemp -q -d -t realm.node.XXXXXX)"
-  test_temp_dir=$PWD # set it to be cleaned at exit
-
-  pushd "$SRCROOT/tests"
-  npm install
-  npm run test-nosync
-  popd
-  ;;
 "test-runners")
   # Create a fake realm module that points to the source root so that test-runner tests can require('realm')
   npm install --build-from-source

tests/package.json

@@ -13,8 +13,7 @@
     "url-parse": "^1.1.7"
   },
   "scripts": {
-    "test": "jasmine spec/unit_tests.js spec/sync_tests.js",
-    "test-nosync": "jasmine spec/unit_tests.js",
+    "test": "jasmine spec/unit_tests.js",
     "test-sync-integration": "jasmine spec/sync_integration_tests.js"
   }
 }