status-im
/
realm-js
mirror of https://github.com/status-im/realm-js.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #1146 from realm/ni/open-async 

Don’t invoke openAsync callback twice
This commit is contained in:
blagoev 2017-07-27 13:26:57 +03:00 committed by GitHub
parent 68df00154f bbe62c361b
commit c090cd9700
2 changed files with 25 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
CHANGELOG.md
View File

@ -1,3 +1,12 @@
vNext (TBD)
=============================================================
### Breaking changes
* `Realm.openAsync` will no longer open the realm if an error has occured. Previously this resulted in the callback being invoked twice - once with an error and a second time - with the synchronously opened Realm.
### Enhancements
### Bug fixes
1.10.0 Release notes (2017-7-12) 1.10.0 Release notes (2017-7-12)
============================================================= =============================================================
### Breaking changes ### Breaking changes

30
lib/extensions.js
View File

@ -48,13 +48,14 @@ module.exports = function(realmConstructor) {
if (error) { if (error) {
reject(error); reject(error);
} }
else {
try { try {
let syncedRealm = new this(config); let syncedRealm = new this(config);
//FIXME: RN hangs here. Remove when node's makeCallback alternative is implemented //FIXME: RN hangs here. Remove when node's makeCallback alternative is implemented
setTimeout(() => { resolve(syncedRealm); }, 1); setTimeout(() => { resolve(syncedRealm); }, 1);
} catch (e) { } catch (e) {
reject(e); reject(e);
}
} }
}); });
}); });
@ -65,13 +66,14 @@ module.exports = function(realmConstructor) {
if (error) { if (error) {
callback(error); callback(error);
} }
else {
try { try {
let syncedRealm = new this(config); let syncedRealm = new this(config);
//FIXME: RN hangs here. Remove when node's makeCallback alternative is implemented //FIXME: RN hangs here. Remove when node's makeCallback alternative is implemented
setTimeout(() => { callback(null, syncedRealm); }, 1); setTimeout(() => { callback(null, syncedRealm); }, 1);
} catch (e) { } catch (e) {
callback(e); callback(e);
}
} }
}); });
}, },