pr feedback

package.json

@@ -41,6 +41,7 @@
   "scripts": {
     "get-version": "echo $npm_package_version",
     "set-version": "scripts/set-version.sh",
+    "get-core-version": "scripts/download-core.sh --version",
     "jsdoc": "rm -rf docs/output && jsdoc -c docs/conf.json",
     "lint": "eslint",
     "test": "scripts/test.sh",

react-native/android/build.gradle

@@ -28,7 +28,7 @@ import org.apache.tools.ant.filters.ReplaceTokens
 // We then copy both the downloaded code and our custom makefiles and headers into third-party-ndk.
 // After that we build native code from src/main/jni with module path pointing at third-party-ndk.
 
-ext.coreVersion = "$System.env.REALM_CORE_VERSION"
+ext.coreVersion = "npm --silent run get-core-version".execute().text.trim()
 def currentVersion = "npm --silent run get-version".execute().text.trim()
 def downloadsDir = new File("$projectDir/downloads")
 def jscDownloadDir = new File("$projectDir/src/main/jni/jsc")

scripts/prepublish.sh

@@ -2,8 +2,8 @@
 
 set -e
 set -o pipefail
-export REALM_CORE_VERSION=`bash ./scripts/download-core.sh --version`
-echo "Core Version:$REALM_CORE_VERSION" 
+export REALM_CORE_VERSION=$(./scripts/download-core.sh --version)
+echo "Core Version: $REALM_CORE_VERSION" 
 cd "$(dirname "$0")/.."
 
 if [ -n "$REALM_BUILD_ANDROID" ]; then

tests/js/realm-tests.js

@@ -301,6 +301,8 @@ module.exports = BaseTest.extend({
         // primary key
         IndexedTypes.primaryKey = 'boolCol';
         IndexedTypes.properties = { boolCol: {type: 'bool', indexed: true} }
+
+	// Test this doesn't throw
         new Realm({schema: [IndexedTypes], path: '5'});
     },