pr feedback

This commit is contained in:
Ari Lazier 2016-03-21 11:46:34 -07:00
parent 693df136d5
commit b9475ad772
4 changed files with 6 additions and 3 deletions

View File

@ -41,6 +41,7 @@
"scripts": { "scripts": {
"get-version": "echo $npm_package_version", "get-version": "echo $npm_package_version",
"set-version": "scripts/set-version.sh", "set-version": "scripts/set-version.sh",
"get-core-version": "scripts/download-core.sh --version",
"jsdoc": "rm -rf docs/output && jsdoc -c docs/conf.json", "jsdoc": "rm -rf docs/output && jsdoc -c docs/conf.json",
"lint": "eslint", "lint": "eslint",
"test": "scripts/test.sh", "test": "scripts/test.sh",

View File

@ -28,7 +28,7 @@ import org.apache.tools.ant.filters.ReplaceTokens
// We then copy both the downloaded code and our custom makefiles and headers into third-party-ndk. // We then copy both the downloaded code and our custom makefiles and headers into third-party-ndk.
// After that we build native code from src/main/jni with module path pointing at third-party-ndk. // After that we build native code from src/main/jni with module path pointing at third-party-ndk.
ext.coreVersion = "$System.env.REALM_CORE_VERSION" ext.coreVersion = "npm --silent run get-core-version".execute().text.trim()
def currentVersion = "npm --silent run get-version".execute().text.trim() def currentVersion = "npm --silent run get-version".execute().text.trim()
def downloadsDir = new File("$projectDir/downloads") def downloadsDir = new File("$projectDir/downloads")
def jscDownloadDir = new File("$projectDir/src/main/jni/jsc") def jscDownloadDir = new File("$projectDir/src/main/jni/jsc")

View File

@ -2,8 +2,8 @@
set -e set -e
set -o pipefail set -o pipefail
export REALM_CORE_VERSION=`bash ./scripts/download-core.sh --version` export REALM_CORE_VERSION=$(./scripts/download-core.sh --version)
echo "Core Version:$REALM_CORE_VERSION" echo "Core Version: $REALM_CORE_VERSION"
cd "$(dirname "$0")/.." cd "$(dirname "$0")/.."
if [ -n "$REALM_BUILD_ANDROID" ]; then if [ -n "$REALM_BUILD_ANDROID" ]; then

View File

@ -301,6 +301,8 @@ module.exports = BaseTest.extend({
// primary key // primary key
IndexedTypes.primaryKey = 'boolCol'; IndexedTypes.primaryKey = 'boolCol';
IndexedTypes.properties = { boolCol: {type: 'bool', indexed: true} } IndexedTypes.properties = { boolCol: {type: 'bool', indexed: true} }
// Test this doesn't throw
new Realm({schema: [IndexedTypes], path: '5'}); new Realm({schema: [IndexedTypes], path: '5'});
}, },