status-im/realm-js
2
0
Fork 0
mirror of https://github.com/status-im/realm-js.git synced 2025-01-12 07:14:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix dangling pointers to a reallocated vector when there are multiple source versions for handover

Browse Source
This commit is contained in:
Thomas Goyne 2016-03-21 14:20:20 -07:00
parent ef632804ef
commit a0b16305c9
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/impl/realm_coordinator.cpp
View File

@ -331,8 +331,6 @@ void RealmCoordinator::run_async_notifiers()
change_info.resize(1);
}
else {
change_info.resize(2);
// Sort newly added notifiers by their source version so that we can pull them
// all forward to the latest version in a single pass over the transaction log
std::sort(new_notifiers.begin(), new_notifiers.end(),
@ -340,6 +338,18 @@ void RealmCoordinator::run_async_notifiers()
version = m_advancer_sg->get_version_of_current_transaction();
REALM_ASSERT(version == new_notifiers.front()->version());
// Preallocate the required amount of space in the vector so that we can
// safely give out pointers to within the vector
{
size_t count = 2;
for (auto it = new_notifiers.begin(), next = it + 1; next != new_notifiers.end(); ++it, ++next) {
if ((*it)->version() != (*next)->version())
++count;
}
change_info.reserve(count);
change_info.resize(2);
}
TransactionChangeInfo* info = &change_info.back();
// Advance each of the new notifiers to the latest version, attaching them