status-im
/
realm-js
mirror of https://github.com/status-im/realm-js.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

pr feedback

This commit is contained in:
Ari Lazier 2016-05-27 15:50:33 -07:00
parent 9012549c5d
commit 9fe636b614
5 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/object-store/src/object_accessor.hpp
View File

@ -207,7 +207,7 @@ namespace realm {
auto string_value = Accessor::to_string(ctx, value); auto string_value = Accessor::to_string(ctx, value);
m_row.set_string(column, string_value); m_row.set_string(column, string_value);
break; break;
} }
case PropertyType::Data: case PropertyType::Data:
m_row.set_binary(column, BinaryData(Accessor::to_binary(ctx, value))); m_row.set_binary(column, BinaryData(Accessor::to_binary(ctx, value)));
break; break;

5
src/object-store/src/parser/query_builder.cpp
View File

@ -501,10 +501,9 @@ void do_add_null_comparison_to_query(Query &query, const Schema &schema, const O
do_add_null_comparison_to_query<Link>(query, cmp.op, expr, args); do_add_null_comparison_to_query<Link>(query, cmp.op, expr, args);
break; break;
case realm::PropertyType::Array: case realm::PropertyType::Array:
throw std::runtime_error((std::string)"Comparing Lists to 'null' is not supported"); throw std::runtime_error("Comparing Lists to 'null' is not supported");
break;
default: { default: {
throw std::runtime_error((std::string)"Object type " + string_for_property_type(type) + " not supported"); throw std::runtime_error(std::string("Object type ") + string_for_property_type(type) + " not supported");
} }
} }
} }

2
src/object-store/src/shared_realm.cpp
View File

@ -68,7 +68,7 @@ Realm::Realm(Config config)
} }
} }
void Realm::open_with_config(Config& config, void Realm::open_with_config(const Config& config,
std::unique_ptr<Replication>& history, std::unique_ptr<Replication>& history,
std::unique_ptr<SharedGroup>& shared_group, std::unique_ptr<SharedGroup>& shared_group,
std::unique_ptr<Group>& read_only_group, std::unique_ptr<Group>& read_only_group,

2
src/object-store/src/shared_realm.hpp
View File

@ -158,7 +158,7 @@ namespace realm {
static _impl::RealmCoordinator& get_coordinator(Realm& realm) { return *realm.m_coordinator; } static _impl::RealmCoordinator& get_coordinator(Realm& realm) { return *realm.m_coordinator; }
}; };
static void open_with_config(Config& config, static void open_with_config(const Config& config,
std::unique_ptr<Replication>& history, std::unique_ptr<Replication>& history,
std::unique_ptr<SharedGroup>& shared_group, std::unique_ptr<SharedGroup>& shared_group,
std::unique_ptr<Group>& read_only_group, std::unique_ptr<Group>& read_only_group,