status-im/realm-js
2
0
Fork 0
mirror of https://github.com/status-im/realm-js.git synced 2025-01-11 14:54:33 +00:00
Code Issues Projects Releases Wiki Activity

Fix another crash involving protected values

Browse Source
This commit is contained in:
Scott Kyle 2016-04-19 03:58:23 -07:00
parent 275334fa7e
commit 8e5afeccc9
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/js_realm.hpp
View File

@ -63,7 +63,10 @@ class RealmDelegate : public BindingContext {
RealmDelegate(std::weak_ptr<Realm> realm, GlobalContextType ctx) : m_context(ctx), m_realm(realm) {} RealmDelegate(std::weak_ptr<Realm> realm, GlobalContextType ctx) : m_context(ctx), m_realm(realm) {}
~RealmDelegate() { ~RealmDelegate() {
remove_all_notifications(); // All protected values need to be unprotected while the context is retained.
m_defaults.clear();
m_constructors.clear();
m_notifications.clear();
} }
void add_notification(FunctionType notification) { void add_notification(FunctionType notification) {

2
src/jsc/jsc_protected.hpp
View File

@ -32,7 +32,7 @@ class Protected<JSGlobalContextRef> {
Protected(Protected<JSGlobalContextRef> &&other) : m_context(other.m_context) { Protected(Protected<JSGlobalContextRef> &&other) : m_context(other.m_context) {
other.m_context = nullptr; other.m_context = nullptr;
} }
Protected(JSGlobalContextRef ctx) : m_context(ctx) { explicit Protected(JSGlobalContextRef ctx) : m_context(ctx) {
JSGlobalContextRetain(m_context); JSGlobalContextRetain(m_context);
} }
~Protected() { ~Protected() {