status-im
/
realm-js
mirror of https://github.com/status-im/realm-js.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Checking the content-type of authentication responses (#1556) 

* Checking the content-type of authentication responses
* Adding a changelog entry
* Fixing changelog typos and line endings
This commit is contained in:
Kræn Hansen 2017-12-07 10:36:24 +01:00 committed by Kenneth Geisshirt
parent 32f55105ec
commit 70004b9304
3 changed files with 46 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
CHANGELOG.md
View File

@ -1,9 +1,23 @@
x.y.z Release notes
=============================================================
### Breaking changes
* None
### Enhancements
* None
### Bug fixes
* When authentication fails due to a misbehaving server, a proper error is thrown.
### Internal
* None
2.0.12 Release notes (2017-12-1)
=============================================================
### Breaking changes
* None.
### Enchancements
### Enhancements
* None
### Bug fixes
@ -18,7 +32,7 @@
### Breaking changes
* None.
### Enchancements
### Enhancements
* None
### Bug fixes
@ -33,7 +47,7 @@
### Breaking changes
* None.
### Enchancements
### Enhancements
* None
### Bug fixes
@ -47,7 +61,7 @@
### Breaking changes
* None.
### Enchancements
### Enhancements
* None
### Bug fixes
@ -61,7 +75,7 @@
### Breaking changes
* None.
### Enchancements
### Enhancements
* [Object Server] Improving performance of processing large changesets.
### Bug fixes
@ -76,7 +90,7 @@
### Breaking changes
* None
### Enchancements
### Enhancements
* None
### Bug fixes
@ -91,7 +105,7 @@
### Breaking changes
* None.
### Enchancements
### Enhancements
* Improved notification performance for objects with no object or list properties.
### Bug fixes
@ -107,7 +121,7 @@
### Breaking changes
* None.
### Enchancements
### Enhancements
* None.
### Bug fixes

10
lib/user-methods.js
View File

@ -154,7 +154,15 @@ function _authenticate(userConstructor, server, json, callback) {
const promise = performFetch(url, options)
.then((response) => {
if (response.status !== 200) {
const contentType = response.headers.get('Content-Type');
if (contentType.indexOf('application/json') === -1) {
return response.text().then((body) => {
throw new AuthError({
title: `Could not authenticate: Realm Object Server didn't respond with valid JSON`,
body,
});
});
} else if (!response.ok) {
return response.json().then((body) => Promise.reject(new AuthError(body)));
} else {
return response.json().then(function (body) {

15
tests/js/user-tests.js
View File

@ -160,6 +160,20 @@ module.exports = {
.catch((e) => assertIsError(e));
},
testLoginTowardsMisbehavingServer() {
const username = uuid();
// Try authenticating towards a server thats clearly not ROS
return Realm.Sync.User.register('https://github.com/realm/realm-js', username, 'user')
.catch((e) => {
assertIsError(e);
TestCase.assertEqual(
e.message,
"Could not authenticate: Realm Object Server didn't respond with valid JSON"
);
});
},
testAll() {
const all = Realm.Sync.User.all;
TestCase.assertArrayLength(Object.keys(all), 0);
@ -324,4 +338,3 @@ module.exports = {
}, */
};