Update some out-of-date comments
This commit is contained in:
parent
aa67216574
commit
4e18a99dfd
|
@ -183,6 +183,9 @@ void AsyncQuery::prepare_handover()
|
||||||
m_initial_run_complete = true;
|
m_initial_run_complete = true;
|
||||||
m_handed_over_table_version = m_tv.outside_version();
|
m_handed_over_table_version = m_tv.outside_version();
|
||||||
m_tv_handover = m_sg->export_for_handover(m_tv, MutableSourcePayload::Move);
|
m_tv_handover = m_sg->export_for_handover(m_tv, MutableSourcePayload::Move);
|
||||||
|
|
||||||
|
// detach the TableView as we won't need it again and keeping it around
|
||||||
|
// makes advance_read() much more expensive
|
||||||
m_tv = TableView();
|
m_tv = TableView();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -72,15 +72,12 @@ private:
|
||||||
const SortOrder m_sort;
|
const SortOrder m_sort;
|
||||||
const std::thread::id m_thread_id = std::this_thread::get_id();
|
const std::thread::id m_thread_id = std::this_thread::get_id();
|
||||||
|
|
||||||
// The source Query, in handover from iff m_sg is null
|
// The source Query, in handover form iff m_sg is null
|
||||||
// Only used until the first time the query is actually run, after which
|
|
||||||
// both will be null
|
|
||||||
std::unique_ptr<SharedGroup::Handover<Query>> m_query_handover;
|
std::unique_ptr<SharedGroup::Handover<Query>> m_query_handover;
|
||||||
std::unique_ptr<Query> m_query;
|
std::unique_ptr<Query> m_query;
|
||||||
|
|
||||||
// The TableView resulting from running the query. Will be detached if the
|
// The TableView resulting from running the query. Will be detached unless
|
||||||
// Query has not yet been run, in which case m_query or m_query_handover will
|
// the query was (re)run since the last time the handover object was created
|
||||||
// be non-null
|
|
||||||
TableView m_tv;
|
TableView m_tv;
|
||||||
std::unique_ptr<SharedGroup::Handover<TableView>> m_tv_handover;
|
std::unique_ptr<SharedGroup::Handover<TableView>> m_tv_handover;
|
||||||
SharedGroup::VersionID m_sg_version;
|
SharedGroup::VersionID m_sg_version;
|
||||||
|
@ -93,7 +90,7 @@ private:
|
||||||
};
|
};
|
||||||
|
|
||||||
// Currently registered callbacks and a mutex which must always be held
|
// Currently registered callbacks and a mutex which must always be held
|
||||||
// while doing anything with them
|
// while doing anything with them or m_callback_index
|
||||||
std::mutex m_callback_mutex;
|
std::mutex m_callback_mutex;
|
||||||
std::vector<Callback> m_callbacks;
|
std::vector<Callback> m_callbacks;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue