mirror of
https://github.com/status-im/realm-js.git
synced 2025-01-11 23:04:29 +00:00
more pr feedback
This commit is contained in:
parent
e316b54eff
commit
3e74cd98d5
@ -102,7 +102,7 @@ std::shared_ptr<Realm> RealmCoordinator::get_realm(Realm::Config config)
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
auto realm = std::make_shared<Realm>(std::move(config));
|
auto realm = std::make_shared<Realm>(std::move(config));
|
||||||
realm->init(shared_from_this());
|
realm->init(shared_from_this());
|
||||||
|
|
||||||
|
@ -157,7 +157,7 @@ namespace realm {
|
|||||||
private:
|
private:
|
||||||
std::vector<ObjectSchemaValidationException> m_validation_errors;
|
std::vector<ObjectSchemaValidationException> m_validation_errors;
|
||||||
};
|
};
|
||||||
|
|
||||||
class SchemaMismatchException : public ObjectStoreException {
|
class SchemaMismatchException : public ObjectStoreException {
|
||||||
public:
|
public:
|
||||||
SchemaMismatchException(std::vector<ObjectSchemaValidationException> const& errors);
|
SchemaMismatchException(std::vector<ObjectSchemaValidationException> const& errors);
|
||||||
|
@ -463,10 +463,10 @@ void Realm::close()
|
|||||||
m_coordinator = nullptr;
|
m_coordinator = nullptr;
|
||||||
}
|
}
|
||||||
|
|
||||||
int Realm::file_format_upgraded_from_version() const
|
util::Optional<int> Realm::file_format_upgraded_from_version() const
|
||||||
{
|
{
|
||||||
if (upgrade_initial_version != upgrade_final_version) {
|
if (upgrade_initial_version != upgrade_final_version) {
|
||||||
return upgrade_initial_version;
|
return upgrade_initial_version;
|
||||||
}
|
}
|
||||||
return 0;
|
return util::Optional<int>();
|
||||||
}
|
}
|
||||||
|
@ -133,7 +133,7 @@ namespace realm {
|
|||||||
void close();
|
void close();
|
||||||
|
|
||||||
// returns the file format version upgraded from, or 0 if not upgraded
|
// returns the file format version upgraded from, or 0 if not upgraded
|
||||||
int file_format_upgraded_from_version() const;
|
util::Optional<int> file_format_upgraded_from_version() const;
|
||||||
|
|
||||||
~Realm();
|
~Realm();
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user