status-im
/
realm-js
mirror of https://github.com/status-im/realm-js.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enable object Ids on RN Android (#1481) 

* Using C function instead of C++ function since Android NDK r10e doesn't support std::stoull().
* Update CHANGELOG.md
This commit is contained in:
Kenneth Geisshirt 2017-11-10 10:05:06 +01:00 committed by GitHub
parent d567cd2dd9
commit 0ca292c133
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -4,10 +4,11 @@ X.Y.Z Release notes
* None. * None.
### Enchancements ### Enchancements
* Improve notification performance for objects with no object or list properties. * Improved notification performance for objects with no object or list properties.
### Bug fixes ### Bug fixes
* Fix a race condition where closing and immediately reopening a synchronized * Fixed a compilation error related to object IDs for React Native on Android (#1480).
* Fixed a race condition where closing and immediately reopening a synchronized
Realm opened using an admin token user would fail. Realm opened using an admin token user would fail.
### Internal ### Internal

3
src/js_realm.hpp
View File

@ -1013,8 +1013,7 @@ inline sync::ObjectID object_id_from_string(std::string const& string)
!std::all_of(low_string.begin(), low_string.end(), isxdigit)) { !std::all_of(low_string.begin(), low_string.end(), isxdigit)) {
throw std::invalid_argument("Invalid object ID."); throw std::invalid_argument("Invalid object ID.");
} }
return sync::ObjectID(strtoull(high_string.c_str(), nullptr, 16), strtoull(low_string.c_str(), nullptr, 16));
return sync::ObjectID(std::stoull(high_string, nullptr, 16), std::stoull(low_string, nullptr, 16));
} }
} // unnamed namespace } // unnamed namespace