From 0c9d70905a1fd3ad0a014fdc2b854c9b4e00d2b6 Mon Sep 17 00:00:00 2001 From: Scott Kyle Date: Wed, 17 Feb 2016 13:46:00 -0800 Subject: [PATCH] Adjust Mixpanel properties --- react-native/RealmAnalytics.mm | 9 +++++++-- .../src/main/java/io/realm/react/RealmAnalytics.java | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/react-native/RealmAnalytics.mm b/react-native/RealmAnalytics.mm index 99b2e6f9..f2688498 100644 --- a/react-native/RealmAnalytics.mm +++ b/react-native/RealmAnalytics.mm @@ -4,7 +4,7 @@ #import "RealmAnalytics.h" -#if TARGET_IPHONE_SIMULATOR +#if TARGET_IPHONE_SIMULATOR || TARGET_OS_MAC #import #import #import @@ -145,10 +145,15 @@ static NSDictionary *RLMAnalyticsPayload() { @"Anonymized Bundle ID": hashedBundleID ?: kUnknownString, // Which version of Realm is being used - @"Binding": @"react-native", + @"Binding": @"js", @"Language": @"js", + @"Framework": @"react-native", @"Realm Version": [[@(RealmReactVersionString) componentsSeparatedByString:@"-"] lastObject] ?: kUnknownString, +#if TARGET_OS_MAC + @"Target OS Type": @"osx", +#else @"Target OS Type": @"ios", +#endif // Current OS version the app is targetting @"Target OS Version": [[NSProcessInfo processInfo] operatingSystemVersionString], // Minimum OS version the app is targetting diff --git a/react-native/android/src/main/java/io/realm/react/RealmAnalytics.java b/react-native/android/src/main/java/io/realm/react/RealmAnalytics.java index 7f49bbb1..acf13c71 100644 --- a/react-native/android/src/main/java/io/realm/react/RealmAnalytics.java +++ b/react-native/android/src/main/java/io/realm/react/RealmAnalytics.java @@ -60,8 +60,9 @@ public class RealmAnalytics { + " \"distinct_id\": \"%USER_ID%\",\n" + " \"Anonymized MAC Address\": \"%USER_ID%\",\n" + " \"Anonymized Bundle ID\": \"%APP_ID%\",\n" - + " \"Binding\": \"react-native\",\n" + + " \"Binding\": \"js\",\n" + " \"Language\": \"js\",\n" + + " \"Framework\": \"react-native\"," + " \"Realm Version\": \"%REALM_VERSION%\",\n" + " \"Host OS Type\": \"%OS_TYPE%\",\n" + " \"Host OS Version\": \"%OS_VERSION%\",\n"