Commit Graph

1275 Commits

Author SHA1 Message Date
Juho Teperi 182007c74a foo 2020-02-05 23:30:51 +02:00
Juho Teperi 785f884e23 Fix lein-codox 2020-02-05 23:27:52 +02:00
Juho Teperi ff4c9a6031 Remove dom functions from core ns 2020-02-05 23:15:05 +02:00
Juho Teperi 106e5d86ca Deprecate component-path in core ns 2020-02-05 23:13:57 +02:00
Juho Teperi ad3b6af57e Bump version number 2020-02-05 23:13:46 +02:00
Juho Teperi 2027a2d888 Expected value first in tests, use direct comparsion instead of re-find 2020-02-05 23:04:56 +02:00
Juho Teperi 2b5c464f35 Remove some local defs from test ns 2020-02-05 23:01:27 +02:00
Juho Teperi c2bf3c0407 Remove found-in test checker, use = for better errors 2020-02-05 22:53:42 +02:00
Juho Teperi f5bfa6160e Update circleci image 2020-02-05 22:49:31 +02:00
Juho Teperi 1ff560a13b Update deps 2020-02-05 22:49:08 +02:00
Juho Teperi ecbbc60d95 Add Kondo config and lint code 2020-02-05 22:48:54 +02:00
Juho Teperi 9173f453b5 Remove deprecated interop macros 2020-02-05 22:48:37 +02:00
Juho Teperi 178aaee030 Update React 2020-02-05 22:47:42 +02:00
Juho Teperi 293bffafd2 Update documentation links 2020-02-03 10:11:12 +02:00
Juho Teperi 307d10e543 Release 0.9.1 to fix the package 2020-01-15 11:54:13 +02:00
Juho Teperi 40e1ca306b Test cursor assertion only if assertions are enabled 2020-01-15 10:57:36 +02:00
Juho Teperi afd4d89808 Update CHANGELOG.md 2020-01-15 10:32:22 +02:00
Juho Teperi 341f1ef1d5 Release 0.9.0 2020-01-15 10:30:32 +02:00
Juho Teperi d70ac1e351 Add cursor assert test 2020-01-15 10:30:23 +02:00
Juho Teperi 9a7372d8ec Fix missing parenthesis 2020-01-15 09:40:01 +02:00
Juho Teperi ced4a18aaa
Merge pull request #472 from dazld/patch-1
Include path in assert error for cursors
2020-01-15 09:38:35 +02:00
Mike Thompson 31c765b317
Merge pull request #473 from dosbol/patch-1
Fix indentation
2020-01-05 10:32:29 +11:00
Dosbol 2eea6f92d6
Fix indentation 2020-01-04 19:57:05 +06:00
Dan Peddle 02b5170bd2 include path in assert error
Including path helps track down which particular cursor is misbehaving.
2020-01-03 11:44:38 +01:00
Juho Teperi c5b93b909d
Merge pull request #471 from dosbol/patch-1
Typo component-did-mount -> component-did-update
2020-01-02 10:13:18 +02:00
Dosbol 7595c74beb
Typo component-did-mount -> component-did-update 2020-01-02 13:27:45 +06:00
Juho Teperi b7b32bb4d6
Merge pull request #470 from danielcompton/patch-1
Reformat code examples for using an entity
2019-12-28 12:20:14 +02:00
Daniel Compton 956f4dc1dc
Reformat code examples for using an entity 2019-12-28 09:43:50 +13:00
Juho Teperi 6615b535c4 Remove old comment 2019-12-17 23:46:15 +02:00
Juho Teperi ae0c64fe9f Release 0.9.0-rc4 2019-12-17 03:02:49 +02:00
Juho Teperi 8f9045311c Extern fix for npm prod build 2019-12-17 02:58:38 +02:00
Juho Teperi 2c5bfb553f Update cljs and shadow-cljs 2019-12-17 02:39:44 +02:00
Juho Teperi 5e4146ae4f
Merge pull request #468 from reagent-project/constructor-mount-order
Use component constructor to keep track of mount order
2019-12-17 02:34:45 +02:00
Juho Teperi 6cb6561ba6 Use component constructor to keep track of mount order
Previous change (35ff5d33dd) started using ComponentDidMount to keep
track of component mount order. This affected the order in which this
was called, previously ComponentWillMount was called the first for
parent components and then for children. ComponentDidMount was called
first for children etc. To work around this, the mount order was
reversed when updating components after ratom updates.

Problem with this is, that when only some components are rerendered,
they get new numbers, but their parents don't:

(given components c, b, a)

**0.8.1**

c 1 > b 2 > a 3

a rerendered
c 1 > b 2 > a 4

b rerendered
c 1 > b 5 > a 6

**35ff5d33dd**

c 3 > b 2 > a 1

a rerendered
c 3 > b 2 > a 4 (BROKEN)

b rerendered
c 3 > b 6 > a 5 (BROKEN)

Best way to fix this is to revert back to old way, where parents get the
smaller number, this was re-rendering children doesn't change the order.
To implement this the mount-order can be stored in component
constructor, which seems to work similarly to ComponentWillMount.

> The constructor for a React component is called before it is mounted.

> UNSAFE_componentWillMount()... Generally, we recommend using the constructor() instead for initializing state.
2019-12-17 02:30:25 +02:00
Juho Teperi 07bfa901ac Add static contextType test 2019-12-17 02:21:05 +02:00
Juho Teperi 4c5dd6fd7b
Merge pull request #467 from plexus/class-context-type
Add support for Class.contextType
2019-12-17 02:18:51 +02:00
Arne Brasseur e6b1e9794c Add support for Class.contextType
We already support the static contextTypes and childContextTypes from the legacy
context API. React has now added contextType to the new Context API to make it
easier to consume the context value.

https://reactjs.org/docs/context.html#classcontexttype
https://reactjs.org/blog/2018/10/23/react-v-16-6.html
2019-12-12 17:58:59 +01:00
Juho Teperi 665b7964da
Update README.md 2019-11-24 16:24:45 +02:00
Juho Teperi afd9a739ce
Update README.md 2019-11-24 16:24:21 +02:00
Juho Teperi e22025ef47 Update CHANGELOG.md 2019-11-19 22:01:20 +02:00
Juho Teperi c4d9c1f5a2 Update CHANGELOG.md 2019-11-19 22:01:03 +02:00
Juho Teperi d48f020147 Update changelog 2019-11-19 21:59:49 +02:00
Juho Teperi e85e2bb056 Add shadow-cljs dev setup 2019-11-19 21:57:21 +02:00
Juho Teperi 8de886d8b1
Merge pull request #461 from reagent-project/infer-externs
Fix #460: Add type hints for extern inference
2019-11-19 21:23:30 +02:00
Juho Teperi 13a5cba2a5 Update package lock 2019-10-25 10:28:52 +03:00
Juho Teperi a9cace4e14 Tag all objects with infer warnings 2019-10-25 10:28:52 +03:00
Juho Teperi d663f3b53e Add shadow-cljs test configuration 2019-10-25 10:28:52 +03:00
Juho Teperi 7a974ecccd Fix #460: Add type hints for extern inference 2019-10-25 08:55:22 +03:00
Juho Teperi 7eb42190d6
Merge pull request #458 from iyedb/patch-1
Fix some sentences and change wording
2019-10-20 10:08:09 +03:00
Iyed Bennour b9ce0ac92f
Fix some sentences and change wording 2019-10-19 17:39:28 +02:00