status-im
/
reagent
mirror of https://github.com/status-im/reagent.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Compare all maps passed to components the same way

This commit is contained in:
Dan Holmsand 2014-02-17 12:42:08 +01:00
parent 4c48271d26
commit b6c20ac863
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
demo/reagentdemo/intro.cljs
View File

@ -231,15 +231,15 @@
[:code "atom"] ", the arguments passed to the component or
component state."]
[:p "All of these are checked for changes with a simple "
[:p "All of these are checked for changes with "
[:code "identical?"] " which is basically only a pointer
comparison, so the overhead is very low (even if the entries of
the first argument, if it is a map, are compared separately, and "
[:code ":style"] " attributes are handled specially). Even the
built-in React components are handled the same way."]
comparison, so the overhead is very low. Maps passed as arguments
to components are compared the same way: they are considered equal
if all their entries are identical. This also applies to built-in
React components like " [:code ":div"] ", " [:code ":p"] ", etc."]
[:p "All this means that you (hopefully) simply won’t have to care
about performance most of the time. Just define your UI however you like
[:p "All this means that you simply won’t have to care about
performance most of the time. Just define your UI however you like
– it will be fast enough."]
[:p "There are a couple of situations that you might have to care

2
src/reagent/impl/util.cljs
View File

@ -131,7 +131,7 @@
(let [v' (v2 k)]
(if (or (identical? v v')
(identical-ish? v v')
(and (== 1 k)
(and (map? v)
(shallow-equal-maps v v')))
res
(reduced false))))