status-im
/
reagent
mirror of https://github.com/status-im/reagent.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #360 from reagent-project/browser-npm-prod-fix 

Use latest Closure for React fix
This commit is contained in:
Juho Teperi 2018-04-04 19:12:30 +03:00 committed by GitHub
parent d8b41f8208 35a04a6125
commit a805717b9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/0.8-upgrade.md
View File

@ -18,6 +18,8 @@ Using Chrome React Developer Tools with this setup will break Reagent.
2. Closure optimization currently breaks certain statically created objects which are 2. Closure optimization currently breaks certain statically created objects which are
accessed dynamically in `ReactDOM/server`: https://github.com/facebook/react/issues/12368 accessed dynamically in `ReactDOM/server`: https://github.com/facebook/react/issues/12368
Fixed by using `[com.google.javascript/closure-compiler-unshaded "v20180319"]` ([fix commit](https://github.com/google/closure-compiler/commit/c13cf48b98477e44409dba6359246bffa95b1c7b)), will be
the default in next ClojureScript release.
## Browser - Cljsjs ## Browser - Cljsjs

1
project.clj
View File

@ -26,6 +26,7 @@
:profiles {:dev {:dependencies [[figwheel "0.5.15"] :profiles {:dev {:dependencies [[figwheel "0.5.15"]
[doo "0.1.10"] [doo "0.1.10"]
[com.google.javascript/closure-compiler-unshaded "v20180319"]
[cljsjs/prop-types "15.6.0-0"]] [cljsjs/prop-types "15.6.0-0"]]
:source-paths ["demo" "examples/todomvc/src" "examples/simple/src" "examples/geometry/src"] :source-paths ["demo" "examples/todomvc/src" "examples/simple/src" "examples/geometry/src"]
:resource-paths ["site" "target/cljsbuild/client" "target/cljsbuild/client-npm"]}} :resource-paths ["site" "target/cljsbuild/client" "target/cljsbuild/client-npm"]}}

5
test-environments/browser-npm-prod/test.sh
View File

@ -1,10 +1,7 @@
#!/bin/bash #!/bin/bash
echo "Failure expected: https://github.com/facebook/react/issues/12368"
echo
set -ex set -ex
lein do clean, doo chrome-headless prod-test-npm once || true lein do clean, doo chrome-headless prod-test-npm once
test -f target/cljsbuild/prod-test-npm/main.js test -f target/cljsbuild/prod-test-npm/main.js
node_modules/.bin/gzip-size target/cljsbuild/prod-test-npm/main.js node_modules/.bin/gzip-size target/cljsbuild/prod-test-npm/main.js