420c07ef6f
Summary: We're seeing sporadic "CGContext...: invalid context 0x..." error messages during snapshot runs of our product build. This also seems to happen sometimes when building RN, see for instance: https://www.google.nl/search?q=site%3Atravis-ci.org%2Ffacebook%2Freact-native%20CGContextSaveGState%20invalid%20context Our guess is that at some point, the CGContextRef is autoreleased. We tried retaining the ref first, but eventually settled for pushing/popping the context as it never fails in our tests (retaining still causes seemingly unrelated failures). We're not sure if we can provide a testplan for this change, as the FBSnapshotTestController is not tested separately. Closes https://github.com/facebook/react-native/pull/8098 Differential Revision: D3431043 fbshipit-source-id: 61b9a7a849a020f6b8671d63781eed9418d409dc |
||
|---|---|---|
| .. | ||
| FBSnapshotTestCase | ||
| RCTTest.xcodeproj | ||
| RCTSnapshotManager.h | ||
| RCTSnapshotManager.m | ||
| RCTTestModule.h | ||
| RCTTestModule.m | ||
| RCTTestRunner.h | ||
| RCTTestRunner.m | ||
| SnapshotViewIOS.android.js | ||
| SnapshotViewIOS.ios.js | ||