status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/ReactAndroid
History
Valentin Shergin 35393524a9 Fixed <TextInput>.onContentSizeChange on Android 
Summary:
Previously <TextInput>'s onContentSizeChange event fires very rearly, usually just once after initial layout. This diff fixed that.
I also considered to a bunch of another things to get the native notification, but I found that overriding `onTextChanged` is the most reliable, easy and effitient way to implement this.

I tried/considered:
 * onLayout (does not fire)
 * OnPreDrawListener (fires to often)
 * OnGlobalLayoutListener (does not fire)
 * OnLayoutChangeListener (does not fire)
 * isLayoutRequested (too hacky)

(I also fixed the <AutoExpandingTextInput> demo to illustrate the fix.)

And just heads up, we will remove `contentSize` info from `onChange` event very soon.

GH issue: https://github.com/facebook/react-native/issues/11692

Reviewed By: achen1

Differential Revision: D5132589

fbshipit-source-id: e7edbd8dc5ae891a6f4a87b51d9450b8c6ce4a1e
 		2017-05-25 19:31:31 -07:00
..
libs Apply auto-formatter for BUCK files in fbandroid. 2017-02-27 14:04:56 -08:00
src Fixed <TextInput>.onContentSizeChange on Android 2017-05-25 19:31:31 -07:00
.npmignore
…
DEFS Fix ReactNative build break 2017-03-14 13:16:11 -07:00
DevExperience.md
…
README.md Add scripts for running tests locally 2016-05-04 08:58:18 -07:00
build.gradle Update okhttp3 2017-05-18 08:16:02 -07:00
gradle.properties fixed mockito version 2016-10-04 10:43:35 -07:00
release.gradle Circle CI releases now work with Java 8 2016-10-28 07:58:52 -07:00

README.md

Building React Native for Android

See the docs on the website.

Running tests

When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.