status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/local-cli
History
jrodiger f891985bd8 Update runAndroid.js to fix startServerInNewWindow() (Windows) 
Summary:
**Motivation**
Resolves issue: #12367. The issue is that the packager does not launch automatically on Windows when running `react-native run-android` like it does on OSX. The proposed change fixes this issue, and causes the packager to be launched automatically on Windows 10. Also note the updated code uses the syntax described in the [Node.js documentation](https://nodejs.org/api/all.html#child_process_spawning_bat_and_cmd_files_on_windows) on spawning .bat files on Windows.

**Test plan**
Manually tested on Windows 10.

Running just `react-native run-android` now results in the packager launching, without needing to run `react-native start` in a new command prompt window.

**Screenshot:**
![packager](https://cloud.githubusercontent.com/assets/17132071/23641540/8d82bb7c-02c2-11e7-9c47-d1c9b582bd65.png)
Closes https://github.com/facebook/react-native/pull/12755

Differential Revision: D4767321

fbshipit-source-id: a14f369ba99939aa44d0ee3403e1d262e2657e6e
 		2017-03-23 18:20:10 -07:00
..
__mocks__ Fix lint in local-cli 2016-11-14 11:13:42 -08:00
bundle packager: fix buildBundle() options 2017-03-14 11:04:51 -07:00
core Fix symlink resolving for examples in the repo 2017-03-05 17:34:41 -08:00
dependencies Introduce HasteImpl 2017-02-27 14:04:58 -08:00
eject Eject CLI command to re-create native folders 2017-02-03 12:58:46 -08:00
generator CLI: Add support for templates fetched from npm 2017-02-27 14:04:57 -08:00
init CLI: Add support for project templates 2017-02-06 12:31:25 -08:00
install Use Yarn for Install/Uninstall CLI if available 2017-02-02 05:13:33 -08:00
library Fix lint in local-cli 2016-11-21 10:28:34 -08:00
link Use appropriate capitalization of Xcode 2017-02-27 22:47:14 -08:00
logAndroid Use native Promise in local-cli 2016-11-21 10:28:34 -08:00
logIOS Use native Promise in local-cli 2016-11-21 10:28:34 -08:00
runAndroid Update runAndroid.js to fix startServerInNewWindow() (Windows) 2017-03-23 18:20:10 -07:00
runIOS more accurate product-name regex 2017-03-18 13:16:08 -07:00
server Improve dark mode for debugger 2017-03-23 04:38:57 -07:00
templates Deploy v0.42.0 2017-03-23 16:46:23 -07:00
upgrade New upgrading process, relying on Git 2016-11-28 08:28:35 -08:00
util Use Yarn for Install/Uninstall CLI if available 2017-02-02 05:13:33 -08:00
.eslintrc Support copy to clipboard on Windows 2017-01-19 16:28:39 -08:00
cli.js packager: centralize babelRegisterOnly callsites 2017-01-06 06:13:54 -08:00
cliEntry.js Merge `rnpm config` with the `cli config`, step 1 2017-01-09 07:58:33 -08:00
commands.js Eject CLI command to re-create native folders 2017-02-03 12:58:46 -08:00
setup_env.bat Fix comments on .bat file 2015-10-28 21:36:07 -04:00
setup_env.sh Change ulimit to 2048 for non root Mac users 2016-02-06 11:45:37 -08:00
wrong-react-native.js Fix usage of react-native cli inside package.json scripts 2016-04-26 15:42:35 -07:00